New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 22 days ago
Closed: Dec 7
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 10102
issue 10101



Sign in to add a comment
link

Issue 9972: Surface additional network events in RTCEventLog

Reported by zstein@google.com, Nov 7 Project Member

Issue description

This is part of a project to make debugging ICE issues easier.

For the existing STUN ping events, add transactionID and timestamp.
Also expose DTLS connection state and writable state changes.
 

Comment 1 by zstein@webrtc.org, Nov 7

Project Member
Owner: zstein@webrtc.org
Status: Started (was: Unconfirmed)

Comment 2 by anatolid@webrtc.org, Nov 19

Project Member
[bulk-edit: ignore if N/A]

This bug has no component but has an owner. Can the owner please assign the right component?

Comment 3 by zstein@webrtc.org, Nov 19

Project Member
Components: Stats Network>ICE

Comment 4 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/c64078fdc01fa05cc693753ef53b930354729296

commit c64078fdc01fa05cc693753ef53b930354729296
Author: Zach Stein <zstein@webrtc.org>
Date: Wed Nov 28 19:49:29 2018

Log DTLS state changes to RtcEventLog

Bug:  webrtc:9972 
Change-Id: Icb2cdda87c1c42607ed06653e053699532f25e84
Reviewed-on: https://webrtc-review.googlesource.com/c/111023
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25832}
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/BUILD.gn
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.h
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/encoder/rtc_event_log_encoder_unittest.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/events/rtc_event.h
[add] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/events/rtc_event_dtls_transport_state.cc
[add] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/events/rtc_event_dtls_transport_state.h
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/rtc_event_log2.proto
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/rtc_event_log_parser_new.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/rtc_event_log_parser_new.h
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/rtc_event_log_unittest.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/logging/rtc_event_log/rtc_event_log_unittest_helper.h
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/p2p/BUILD.gn
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/p2p/base/dtlstransport.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/p2p/base/dtlstransport.h
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/p2p/base/dtlstransport_unittest.cc
[modify] https://crrev.com/c64078fdc01fa05cc693753ef53b930354729296/pc/jseptransportcontroller.cc

Comment 5 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/c308bdfa451ee2ceac7096b6777fcbf756f4091a

commit c308bdfa451ee2ceac7096b6777fcbf756f4091a
Author: Zach Stein <zstein@webrtc.org>
Date: Thu Nov 29 22:52:35 2018

Add transaction id to CandidatePairEvents.

The transaction id is a randomly generated number used to link stun
requests and responses (https://tools.ietf.org/html/rfc5389#section-6).
Logging this will help us debug ICE network issues.

Bug:  webrtc:9972 
Change-Id: I93167cb119aad99156e8727b6e4eeeff5198f924
Reviewed-on: https://webrtc-review.googlesource.com/c/109720
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25848}
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/logging/rtc_event_log/events/rtc_event_ice_candidate_pair.cc
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/logging/rtc_event_log/events/rtc_event_ice_candidate_pair.h
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/logging/rtc_event_log/icelogger.cc
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/logging/rtc_event_log/icelogger.h
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/p2p/base/port.cc
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/p2p/base/port.h
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/p2p/base/stun.cc
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/p2p/base/stun.h
[modify] https://crrev.com/c308bdfa451ee2ceac7096b6777fcbf756f4091a/p2p/base/stunrequest.h

Comment 6 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/286ee0123e02ec364acf70357d8192468e10a7eb

commit 286ee0123e02ec364acf70357d8192468e10a7eb
Author: Erik Språng <sprang@webrtc.org>
Date: Fri Nov 30 09:28:25 2018

Revert "Add transaction id to CandidatePairEvents."

This reverts commit c308bdfa451ee2ceac7096b6777fcbf756f4091a.

Reason for revert: The msan bot has been consistently failing since this commit. See eg https://ci.chromium.org/p/webrtc/builders/luci.webrtc.ci/Linux%20MSan/16989

Original change's description:
> Add transaction id to CandidatePairEvents.
> 
> The transaction id is a randomly generated number used to link stun
> requests and responses (https://tools.ietf.org/html/rfc5389#section-6).
> Logging this will help us debug ICE network issues.
> 
> Bug:  webrtc:9972 
> Change-Id: I93167cb119aad99156e8727b6e4eeeff5198f924
> Reviewed-on: https://webrtc-review.googlesource.com/c/109720
> Commit-Queue: Zach Stein <zstein@webrtc.org>
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> Reviewed-by: Elad Alon <eladalon@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#25848}

TBR=eladalon@webrtc.org,terelius@webrtc.org,zstein@webrtc.org,qingsi@webrtc.org,jeroendb@webrtc.org

Change-Id: Ib3b0a845f2300f4fcba2061650e17522735f08b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  webrtc:9972 
Reviewed-on: https://webrtc-review.googlesource.com/c/112581
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25852}
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/logging/rtc_event_log/events/rtc_event_ice_candidate_pair.cc
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/logging/rtc_event_log/events/rtc_event_ice_candidate_pair.h
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/logging/rtc_event_log/icelogger.cc
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/logging/rtc_event_log/icelogger.h
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/p2p/base/port.cc
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/p2p/base/port.h
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/p2p/base/stun.cc
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/p2p/base/stun.h
[modify] https://crrev.com/286ee0123e02ec364acf70357d8192468e10a7eb/p2p/base/stunrequest.h

Comment 7 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/92c4289ada94f663530822f8cc5668cb63c1f011

commit 92c4289ada94f663530822f8cc5668cb63c1f011
Author: Zach Stein <zstein@webrtc.org>
Date: Fri Nov 30 21:10:51 2018

Reland "Add transaction id to CandidatePairEvents."

This is a reland of c308bdfa451ee2ceac7096b6777fcbf756f4091a

Original change's description:
> Add transaction id to CandidatePairEvents.
>
> The transaction id is a randomly generated number used to link stun
> requests and responses (https://tools.ietf.org/html/rfc5389#section-6).
> Logging this will help us debug ICE network issues.
>
> Bug:  webrtc:9972 
> Change-Id: I93167cb119aad99156e8727b6e4eeeff5198f924
> Reviewed-on: https://webrtc-review.googlesource.com/c/109720
> Commit-Queue: Zach Stein <zstein@webrtc.org>
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> Reviewed-by: Elad Alon <eladalon@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#25848}

TBR=terelius@webrtc.org,qingsi@webrtc.org

Bug:  webrtc:9972 
Change-Id: I32b55befddfcb8dc98babd0b64e756eaeb9fab09
Reviewed-on: https://webrtc-review.googlesource.com/c/112661
Reviewed-by: Zach Stein <zstein@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25862}
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/logging/rtc_event_log/events/rtc_event_ice_candidate_pair.cc
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/logging/rtc_event_log/events/rtc_event_ice_candidate_pair.h
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/logging/rtc_event_log/icelogger.cc
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/logging/rtc_event_log/icelogger.h
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/p2p/base/port.cc
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/p2p/base/port.h
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/p2p/base/stun.cc
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/p2p/base/stun.h
[modify] https://crrev.com/92c4289ada94f663530822f8cc5668cb63c1f011/p2p/base/stunrequest.h

Comment 8 by bugdroid1@chromium.org, Dec 1

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/846dfdfd01c76cc47245f799a6e871cefc871932

commit 846dfdfd01c76cc47245f799a6e871cefc871932
Author: Zach Stein <zstein@webrtc.org>
Date: Sat Dec 01 01:00:28 2018

Log DTLS writable changes to RtcEventLog

Bug:  webrtc:9972 
Change-Id: I8d29dcbc200bd0aad7f4c2600459c4d344c61bbb
Reviewed-on: https://webrtc-review.googlesource.com/c/111453
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Zach Stein <zstein@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25866}
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/BUILD.gn
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.h
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/encoder/rtc_event_log_encoder_unittest.cc
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/events/rtc_event.h
[add] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/events/rtc_event_dtls_writable_state.cc
[add] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/events/rtc_event_dtls_writable_state.h
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/rtc_event_log2.proto
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/rtc_event_log_parser_new.cc
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/rtc_event_log_parser_new.h
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/rtc_event_log_unittest.cc
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/logging/rtc_event_log/rtc_event_log_unittest_helper.h
[modify] https://crrev.com/846dfdfd01c76cc47245f799a6e871cefc871932/p2p/base/dtlstransport.cc

Comment 9 by bugdroid1@chromium.org, Dec 1

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b3033c448ffd0d4266dfec636bfc5471baf1e848

commit b3033c448ffd0d4266dfec636bfc5471baf1e848
Author: Zach Stein <zstein@webrtc.org>
Date: Sat Dec 01 01:15:29 2018

Add transaction id to candidate pair event log parser and encoder.

Covered by these tests:
RandomSeeds/RtcEventLogEncoderTest.RtcEventIceCandidatePair/*
RtcEventLogTest/RtcEventLogSession.*

Bug:  webrtc:9972 
Change-Id: I05473176357804e7ad0dedb51a659ab9481a4e4a
Reviewed-on: https://webrtc-review.googlesource.com/c/110103
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25867}
[modify] https://crrev.com/b3033c448ffd0d4266dfec636bfc5471baf1e848/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc
[modify] https://crrev.com/b3033c448ffd0d4266dfec636bfc5471baf1e848/logging/rtc_event_log/rtc_event_log2.proto
[modify] https://crrev.com/b3033c448ffd0d4266dfec636bfc5471baf1e848/logging/rtc_event_log/rtc_event_log_parser_new.cc
[modify] https://crrev.com/b3033c448ffd0d4266dfec636bfc5471baf1e848/logging/rtc_event_log/rtc_event_log_parser_new.h
[modify] https://crrev.com/b3033c448ffd0d4266dfec636bfc5471baf1e848/logging/rtc_event_log/rtc_event_log_unittest_helper.cc

Comment 10 by terelius@webrtc.org, Dec 3

Project Member
Zack, could you please fix the memcpy issue in ReduceTransactionId; it looks like the result is byte order dependent. The tests pass because the log is always written and read on the same computer, but afaik, this isn't how you intend to use it.

Comment 11 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/fafae11bfc4c7d1f8f02e708b0187fb48f7b8810

commit fafae11bfc4c7d1f8f02e708b0187fb48f7b8810
Author: Bjorn Terelius <terelius@webrtc.org>
Date: Thu Dec 06 09:59:45 2018

Allow parsing RTC event logs without a transaction ID.

Bug:  webrtc:9972 
Change-Id: I01d60671d249adbd55f25c8f49f205b18787cbf4
Reviewed-on: https://webrtc-review.googlesource.com/c/113304
Reviewed-by: Zach Stein <zstein@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25914}
[modify] https://crrev.com/fafae11bfc4c7d1f8f02e708b0187fb48f7b8810/logging/rtc_event_log/rtc_event_log_parser_new.cc

Comment 12 by zstein@webrtc.org, Dec 6

Project Member
Blocking: 10101

Comment 13 by zstein@webrtc.org, Dec 6

Project Member
Blocking: 10102

Comment 14 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ff71a49b3008c96898324ffe1a6850e1eaceb62f

commit ff71a49b3008c96898324ffe1a6850e1eaceb62f
Author: Zach Stein <zstein@webrtc.org>
Date: Fri Dec 07 20:30:03 2018

Reduce transaction ids independent of host byte order.

Bug:  webrtc:9972 
Change-Id: I91df2f2c4854bec6d581c3beb9f57235a1ce47b1
Reviewed-on: https://webrtc-review.googlesource.com/c/112926
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Zach Stein <zstein@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25939}
[modify] https://crrev.com/ff71a49b3008c96898324ffe1a6850e1eaceb62f/p2p/base/stun.cc
[modify] https://crrev.com/ff71a49b3008c96898324ffe1a6850e1eaceb62f/p2p/base/stun_unittest.cc

Comment 15 by zstein@webrtc.org, Dec 7

Project Member
Status: Fixed (was: Started)

Comment 16 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9e2e6e704b28832c8a50e8f30e308e74713a9395

commit 9e2e6e704b28832c8a50e8f30e308e74713a9395
Author: Zach Stein <zstein@webrtc.org>
Date: Thu Dec 13 20:40:36 2018

Set LoggedIceCandidatePairEvent.transaction_id to default value if missing.

Bug:  webrtc:9972 
Change-Id: I559ccb6799b494a9013523d3960a725ea7fd448e
Reviewed-on: https://webrtc-review.googlesource.com/c/114240
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Zach Stein <zstein@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26006}
[modify] https://crrev.com/9e2e6e704b28832c8a50e8f30e308e74713a9395/logging/rtc_event_log/rtc_event_log_parser_new.cc

Sign in to add a comment