New issue
Advanced search Search tips

Issue 9582 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
NextAction: ----
OS: ----
Pri: ----
Type: Feature



Sign in to add a comment

Add picture_id to generic RTP packetizer format.

Project Member Reported by sakal@webrtc.org, Aug 1

Issue description

Feature description (please include a link to the functional spec):
picture_id is important to many WebRTC components. It currently exists only for VP8 and VP9. To improve kVideoCodecGeneric performance, we should add picture_id to the generic packetization format.

To keep backwards compatibility, we should use one of the bits in the existing one byte header and use it to signal an "extended" header. Alternatively, a field trial could be used to enable the feature.

Eng owner: sakal/philipel



 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/f8d81d33ed1354e7a9d267253cb9ca0bf4349658

commit f8d81d33ed1354e7a9d267253cb9ca0bf4349658
Author: philipel <philipel@webrtc.org>
Date: Thu Aug 02 09:12:31 2018

Add members for the codec agnostic descriptor to RTPVideoHeader.

TBR=danilchap@webrtc.org

Bug: webrtc:9361,  webrtc:9582 
Change-Id: I0303fc89bafab59e68ec81979e0e4372e79a4f51
Reviewed-on: https://webrtc-review.googlesource.com/91866
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24170}
[modify] https://crrev.com/f8d81d33ed1354e7a9d267253cb9ca0bf4349658/DEPS
[modify] https://crrev.com/f8d81d33ed1354e7a9d267253cb9ca0bf4349658/modules/rtp_rtcp/BUILD.gn
[modify] https://crrev.com/f8d81d33ed1354e7a9d267253cb9ca0bf4349658/modules/rtp_rtcp/source/rtp_video_header.cc
[modify] https://crrev.com/f8d81d33ed1354e7a9d267253cb9ca0bf4349658/modules/rtp_rtcp/source/rtp_video_header.h

Project Member

Comment 2 by ssilkin@webrtc.org, Aug 6

Cc: ssilkin@webrtc.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/426a80ce0899f98aa85c91ee96c3a48811b11af0

commit 426a80ce0899f98aa85c91ee96c3a48811b11af0
Author: Sami Kalliomäki <sakal@webrtc.org>
Date: Thu Aug 09 14:05:39 2018

Add extended header containing frame ID to the generic packetizer.

Also changes default value of frame ID in RTPVideoHeader to
kNoPictureId. Special care should be take so that picture ID will not
be set in RTPVideoHeader unless the client on the end supports
deserializing extended generic header.

Bug:  webrtc:9582 
Change-Id: Ib096373ed187f31e51d481193a2bda56de68f167
Reviewed-on: https://webrtc-review.googlesource.com/92084
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24250}
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/rtp_format.cc
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/rtp_format_video_generic.cc
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/rtp_format_video_generic.h
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/rtp_format_video_generic_unittest.cc
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/source/rtp_video_header.h
[modify] https://crrev.com/426a80ce0899f98aa85c91ee96c3a48811b11af0/modules/rtp_rtcp/test/testAPI/test_api_video.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9882495ecaed593e034b5788c2480317cfbd8ebc

commit 9882495ecaed593e034b5788c2480317cfbd8ebc
Author: Sami Kalliomäki <sakal@webrtc.org>
Date: Wed Aug 29 09:23:14 2018

Use generic video header frame ID as picture ID.

Bug:  webrtc:9582 
Change-Id: I7b68a66205f704cba3afe1f461cce2c993016056
Reviewed-on: https://webrtc-review.googlesource.com/96501
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24479}
[modify] https://crrev.com/9882495ecaed593e034b5788c2480317cfbd8ebc/modules/video_coding/frame_object.cc
[modify] https://crrev.com/9882495ecaed593e034b5788c2480317cfbd8ebc/modules/video_coding/frame_object.h
[modify] https://crrev.com/9882495ecaed593e034b5788c2480317cfbd8ebc/modules/video_coding/rtp_frame_reference_finder.cc

Project Member

Comment 5 by sakal@webrtc.org, Sep 6

Status: Fixed (was: Assigned)

Sign in to add a comment