New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 12 users

Issue metadata

Status: WontFix
OOO until 7/22
Closed: Dec 2017
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Show other hotlists

Hotlists containing this issue:

Sign in to add a comment

ProcessRecordedData passes uninitialized data to Media Process

Project Member Reported by, Sep 27 2012

Issue description

What steps will reproduce the problem?
1. Run voice engine tests under valgrind: tools/valgrind-webrtc/ -t out/Debug/voe_auto_test ++automated ++gtest_filter="-MixingTest.*"

What is the expected output? What do you see instead?
You will get a valgrind warning where the code must be mismanaging some buffer or length variable. 

Please use labels and text to provide additional information.
20:46:20 [ERROR] Command:   
Use of uninitialised value of size 8
  __dubsin (/build/buildd/eglibc-2.15/math/../sysdeps/ieee754/dbl-64/dosincos.c:80)
  __sin_sse2 (/build/buildd/eglibc-2.15/math/../sysdeps/ieee754/dbl-64/s_sin.c:744)
  FakeMediaProcess::Process(int, webrtc::ProcessingTypes, short*, int, int, bool) (/out/Debug/../../src/voice_engine/test/auto_test/fakes/fake_media_process.h:26)
  webrtc::voe::Channel::PrepareEncodeAndSend(int) (/out/Debug/../../src/voice_engine/
  webrtc::voe::TransmitMixer::DemuxAndMix() (/out/Debug/../../src/voice_engine/
  webrtc::VoEBaseImpl::RecordedDataIsAvailable(void const*, unsigned int, unsigned char, unsigned char, unsigned int, unsigned int, int, unsigned int, unsigned int&) (/out/Debug/../../src/voice_engine/
  webrtc::AudioDeviceBuffer::DeliverRecordedData() (/out/Debug/../../src/modules/audio_device/
  webrtc::AudioDeviceLinuxPulse::ProcessRecordedData(signed char*, unsigned int, unsigned int) (/out/Debug/../../src/modules/audio_device/linux/
  webrtc::AudioDeviceLinuxPulse::ReadRecordedData(void const*, unsigned long) (/out/Debug/../../src/modules/audio_device/linux/
  webrtc::AudioDeviceLinuxPulse::RecThreadProcess() (/out/Debug/../../src/modules/audio_device/linux/
  webrtc::AudioDeviceLinuxPulse::RecThreadFunc(void*) (/out/Debug/../../src/modules/audio_device/linux/
  webrtc::ThreadPosix::Run() (/out/Debug/../../src/system_wrappers/source/
  StartThread (/out/Debug/../../src/system_wrappers/source/
Suppression (error hash=#9B6FC089AA881538#):
  For more info on using suppressions see

Project Member

Comment 1 by, Sep 27 2012

I forgot to mention that you will need to comment out all bug_898_* suppressions in /trunk/tools/valgrind-webrtc/memcheck/suppressions.txt to properly "reproduce" these warnings, at least after my voice engine valgrind patch goes in (which will be probably next week).

There are actually a whole bunch of errors that involve FakeMediaProcess. Could it so easy that FakeMediaProcess mishandles memory? Or is the voice engine actually passing uninitialized data? I've suppressed all the errors I could find.
Project Member

Comment 2 by, Oct 17 2012

Status: Available
Project Member

Comment 3 by, Nov 8 2012

The following revision refers to this bug:

r2898 | | 2012-10-10T15:41:03.292675Z

Changed paths:

Suppressed all voe_auto_test standard suite bugs and introduced a flag for excluding timing-dependent tests.

Also Suppressed FakeMediaProcess errors ( bug 898 ) and took out a test and suppressed general errors ( bug 332 ). Lastly, fixed memory leak in misc test.

BUG= 898 ,  332 
TEST=Ran voe_auto_test with repeat=10 through the whole standard suite, under valgrind. Ran without valgrind. Tested that the extended and standard tests still start and are reachable from the menu.

Review URL:

Comment 4 by, Oct 15 2014

Labels: Area-Mic
Project Member

Comment 5 by, Jan 7 2015

Labels: -Area-Mic Area-GetUserMedia-Mic
Project Member

Comment 6 by, Jan 7 2015

Labels: -Area-GetUserMedia-Mic Mic
Project Member

Comment 7 by, Apr 20 2015

Project Member

Comment 8 by, Dec 1 2016

Project Member

Comment 9 by, Dec 1 2016

Project Member

Comment 10 by, Dec 11 2016

Components: Audio
Project Member

Comment 11 by, Jan 3 2017

Status: Assigned (was: Available)
Fredrik, we don't plan to run voe_auto_test anymore, right? Do you think this still is a valid issue?
Project Member

Comment 12 by, Jan 23 2017

Labels: -Pri-2 Pri-3
Project Member

Comment 13 by, Jan 30 2017

This test still runs on some bots. Leave assigned to me.
129 KB Download
Project Member

Comment 15 by, Dec 4 2017

Status: WontFix (was: Assigned)
voe_auto_test has been removed.

Sign in to add a comment