New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 8219 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: iOS , Android
Pri: 3
Type: Feature



Sign in to add a comment

Add full stack tests with HW codecs

Project Member Reported by brandtr@webrtc.org, Sep 8 2017

Issue description

We should track the performance of HW codecs in our full stack tests.

Since we currently only have Android perf bots, we should add MediaCodec support first.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa

commit 2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa
Author: brandtr <brandtr@webrtc.org>
Date: Fri Sep 22 07:46:25 2017

Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: MediaCodec and libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219

Review-Url: https://codereview.webrtc.org/3005253002
Cr-Commit-Position: refs/heads/master@{#19923}

[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/BUILD.gn
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/call/call_perf_tests.cc
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/modules/video_coding/BUILD.gn
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/test/call_test.cc
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/test/call_test.h
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/BUILD.gn
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/DEPS
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/full_stack_tests.cc
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/screenshare_loopback.cc
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/video_loopback.cc
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/video_quality_test.cc
[modify] https://crrev.com/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa/video/video_quality_test.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2c30120fac1e1cbdab89e459ac6256d198bf291d

commit 2c30120fac1e1cbdab89e459ac6256d198bf291d
Author: brandtr <brandtr@webrtc.org>
Date: Fri Sep 22 11:30:08 2017

Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ )

Reason for revert:
Breaks KitKat/Lollipop perf bots.

Original issue's description:
> Add full stack tests for MediaCodec encoder.
>
> * Add audio_ prefix to CallTest::{en,de}coder_factory_.
> * Let VideoQualityTest only instantiate encoders using encoder factories.
> * Add HW encoder factories to VideoQualityTest.
> * Add full stack tests:
>   - sqcif7 at  30 kbps: MediaCodec and libvpx.
>   - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.
>
> BUG=webrtc:8219
>
> Review-Url: https://codereview.webrtc.org/3005253002
> Cr-Commit-Position: refs/heads/master@{#19923}
> Committed: https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa

TBR=sprang@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8219

Review-Url: https://codereview.webrtc.org/3016593002
Cr-Commit-Position: refs/heads/master@{#19926}

[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/BUILD.gn
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/call/call_perf_tests.cc
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/modules/video_coding/BUILD.gn
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/test/call_test.cc
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/test/call_test.h
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/BUILD.gn
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/DEPS
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/full_stack_tests.cc
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/screenshare_loopback.cc
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/video_loopback.cc
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/video_quality_test.cc
[modify] https://crrev.com/2c30120fac1e1cbdab89e459ac6256d198bf291d/video/video_quality_test.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2666cf7eba4bdd697d59d0451a8f74a05d4d207e

commit 2666cf7eba4bdd697d59d0451a8f74a05d4d207e
Author: Rasmus Brandt <brandtr@webrtc.org>
Date: Fri Sep 29 12:54:17 2017

Reland of Add full stack tests for MediaCodec encoder (moved from Rietveld).

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219
TBR=asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org,sprang@webrtc.org

Change-Id: I464409ac0d5276defa78c1bf66034c6cca717d74
Reviewed-on: https://webrtc-review.googlesource.com/4740
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20041}
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/BUILD.gn
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/call/call_perf_tests.cc
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/modules/video_coding/BUILD.gn
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/test/call_test.cc
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/test/call_test.h
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/BUILD.gn
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/DEPS
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/full_stack_tests.cc
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/screenshare_loopback.cc
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/video_loopback.cc
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/video_quality_test.cc
[modify] https://crrev.com/2666cf7eba4bdd697d59d0451a8f74a05d4d207e/video/video_quality_test.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/310273459dcdaeb0596031286c94113bafaaa88c

commit 310273459dcdaeb0596031286c94113bafaaa88c
Author: Rasmus Brandt <brandtr@webrtc.org>
Date: Fri Sep 29 13:48:29 2017

Revert "Reland of Add full stack tests for MediaCodec encoder (moved from Rietveld)."

This reverts commit 2666cf7eba4bdd697d59d0451a8f74a05d4d207e.

Reason for revert: On Lollipop Nexus 4, the 240p tests fail too.

Original change's description:
> Reland of Add full stack tests for MediaCodec encoder (moved from Rietveld).
> 
> * Add audio_ prefix to CallTest::{en,de}coder_factory_.
> * Let VideoQualityTest only instantiate encoders using encoder factories.
> * Add HW encoder factories to VideoQualityTest.
> * Add full stack tests:
>   - sqcif7 at  30 kbps: libvpx.
>   - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.
> 
> BUG=webrtc:8219
> TBR=asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org,sprang@webrtc.org
> 
> Change-Id: I464409ac0d5276defa78c1bf66034c6cca717d74
> Reviewed-on: https://webrtc-review.googlesource.com/4740
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20041}

TBR=kjellander@webrtc.org,brandtr@webrtc.org,asapersson@webrtc.org,sprang@webrtc.org,stefan@webrtc.org

Change-Id: If558b7fb86740658e50a6897d1eeeb72103a54ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8219
Reviewed-on: https://webrtc-review.googlesource.com/4900
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20044}
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/BUILD.gn
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/call/call_perf_tests.cc
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/modules/video_coding/BUILD.gn
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/test/call_test.cc
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/test/call_test.h
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/BUILD.gn
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/DEPS
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/full_stack_tests.cc
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/screenshare_loopback.cc
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/video_loopback.cc
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/video_quality_test.cc
[modify] https://crrev.com/310273459dcdaeb0596031286c94113bafaaa88c/video/video_quality_test.h

Project Member

Comment 5 by brandtr@webrtc.org, Oct 16 2017

Labels: -Pri-2 Pri-3
Project Member

Comment 6 by brandtr@webrtc.org, Apr 30 2018

Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment