New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 8
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Other

Blocked on:
issue 8852

Blocking:
issue 6333
issue 7504



Sign in to add a comment
link

Issue 6353: Obsolete cricket::VideoCapturer

Reported by nisse@webrtc.org, Sep 14 2016 Project Member

Issue description

Capturers should no longer need to inherit cricket::VideoCapturer, instead they should implement VideoSourceInterface or VideoTrackSourceInterface.

To get there, we may need some new more lightweight helper classes to handle videoadaptation.

After all custom capturers are migrated, cricket::VideoCapturer can be deleted.
 

Comment 1 by magjed@webrtc.org, Sep 14 2016

Project Member
Blocking: 6333

Comment 3 by anatolid@webrtc.org, Oct 27 2016

Project Member
Components: Video

Comment 4 by pbos@webrtc.org, Dec 15 2016

Project Member
Cc: pbos@webrtc.org

Comment 5 by nisse@webrtc.org, Feb 6 2018

Project Member
Blocking: 7504
Cc: magjed@webrtc.org kthelgason@webrtc.org
What's left to be able to finally delete cricket::VideoCapturer?

It seems it is used in the objc code, RTCAVFoundationVideoSource uses an AVFoundationVideoCapturer. This is marked as deprecated, replaced by RTCCameraVideoCapturer and RTCVideoCapturer, which as far as I see doesn't depend on cricket::VideoCapturer. So here itäs iónly a matter of deleting the old code?

I's also used by WebRtcVideoCapturer (in media/engine), which wraps the VideoCaptureModule and appears used in example code via WebRtcVideoDeviceCapturerFactory, including in

  examples/peerconnection/client/conductor.cc
  examples/unityplugin/simple_peer_connection.cc

For this, we'd need to write some VideoTrackSource implementation(s) interfacing with the platform specific VideoCaptureModule code. Preferably with as few layers in between as possible.

I'm looking at this now because the PeerConnection dependency in cricket::VideoCapturer makes the api depend on lots of things in media/base, including circular dependencies. I considered trying to move just videocapturer.h to api/deprecated/, but it would bring with it, among aother things, videoadapter.h, which I don't think we want in the api.

Comment 6 by kthelgason@webrtc.org, Feb 6 2018

Project Member
I'm working on getting rid of RTCAVFoundationVideoSource and AVFoundationVideoCapturer from upstream projects now, so they will hopefully be gone soon.

This is the first time i hear about examples/unityplugin. Do we care about maintaining that? 

As for videoadapter.h, I don't see a problem with making it part of the API. If clients want to implement their own video source it may be beneficial for them to be able to use the video adapter, no?

Comment 7 by nisse@webrtc.org, Feb 6 2018

Project Member
Good to hear that AVFoundationVideoCapturer is being eliminated.

I don't know any background on why we maintain the unity plugin. It seems it was added less than a year ago, in cl https://codereview.webrtc.org/2823783002.

But I think all our client code, e.g., peerconnection_client, use WebRtcVideoCapturer in one way or the other. So if we transition that to something else, hopefully no big deal to do the same to the unityplugin.

Comment 8 by kthelgason@webrtc.org, Feb 6 2018

Project Member
Sounds reasonable. Are you going to take on the VideoTrackSource <-> VideoCapturemodule interface and handle the transition of the example projects?

Comment 9 by nisse@webrtc.org, Feb 6 2018

Project Member
I'd like to, but I doubt I will get the time for it soon. I wonder if the factory thing means we have to do them all at once, or if it could work to start with converting, e.g., only the linux capturer.

Comment 10 by kthelgason@webrtc.org, Feb 6 2018

Project Member
Blockedon: 8852

Comment 11 by pbos@chromium.org, Feb 6 2018

I can't directly +cc because I don't have my 2fa for @webrtc.org on me, but you should +cc niklas.enbom@webrtc.org and gyzhou@chromium.org for #6 if you're considering removing it, and not remove it from under their feet. Having a working unity example might be important for VR usecases.

Comment 12 by nisse@webrtc.org, Feb 7 2018

Project Member
I'll get in touch with Niklas and team if I consider removing the unity plugin. Which I don't do at the moment.

Comment 13 by bugdroid1@chromium.org, Feb 8 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/6f7bc08457fd89868c3bd14335905d4b195065e7

commit 6f7bc08457fd89868c3bd14335905d4b195065e7
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Feb 08 09:55:28 2018

Rewrite FakeVideoTrackSource to not use VideoCapturer.

Bug:  webrtc:6353 
Change-Id: I992048868eebca1889e697950003b537b344bb53
Reviewed-on: https://webrtc-review.googlesource.com/49163
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21955}
[modify] https://crrev.com/6f7bc08457fd89868c3bd14335905d4b195065e7/pc/test/fakevideotracksource.h

Comment 14 by bugdroid1@chromium.org, Feb 13 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a6cc0f94bfa00c2817150c3f8ed79368208080de

commit a6cc0f94bfa00c2817150c3f8ed79368208080de
Author: Niels Möller <nisse@webrtc.org>
Date: Tue Feb 13 10:24:01 2018

Refactor FakeVideoCapturer.

Extract the code to produce a stream of frames to its own class,
FakeFrameSource. Use in VideoAdapter unittests, to make the code simpler
and not depend on the deprecated cricket::VideoCapturer.

Bug:  webrtc:6353 
Change-Id: Ib5c34c6a0bd7f4338650459873ddc94b12d0c569
Reviewed-on: https://webrtc-review.googlesource.com/49740
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21995}
[modify] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/BUILD.gn
[add] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/base/fakeframesource.cc
[add] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/base/fakeframesource.h
[modify] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/base/fakevideocapturer.cc
[modify] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/base/fakevideocapturer.h
[modify] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/base/videoengine_unittest.h
[modify] https://crrev.com/a6cc0f94bfa00c2817150c3f8ed79368208080de/media/engine/webrtcvideoengine_unittest.cc

Comment 16 by bugdroid1@chromium.org, May 11 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3cbdb78878bfd4551b7419eefffe7a02e67323a2

commit 3cbdb78878bfd4551b7419eefffe7a02e67323a2
Author: Niels Möller <nisse@webrtc.org>
Date: Fri May 11 08:14:10 2018

Add method FakePeriodicVideoSource::Stop()

Fixes potential race at test shutdown, introduced in cl
https://webrtc-review.googlesource.com/49220.

Bug:  webrtc:6353 
Change-Id: Ifaf9e736681b87073a489d75bf1375aa95ee92bb
Reviewed-on: https://webrtc-review.googlesource.com/75124
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23200}
[modify] https://crrev.com/3cbdb78878bfd4551b7419eefffe7a02e67323a2/ortc/ortcfactory_integrationtest.cc
[modify] https://crrev.com/3cbdb78878bfd4551b7419eefffe7a02e67323a2/pc/test/fakeperiodicvideosource.h

Comment 18 by bugdroid1@chromium.org, May 17 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8e7a62beb2d5a3bf17afa63ce6359069ae741cc1

commit 8e7a62beb2d5a3bf17afa63ce6359069ae741cc1
Author: Niels Möller <nisse@webrtc.org>
Date: Thu May 17 07:23:01 2018

Delete unused include of fakevideocapturer.h.

Bug:  webrtc:6353 
Change-Id: I007320e821e44bbd93776ff76d76e550a7f94602
Reviewed-on: https://webrtc-review.googlesource.com/76922
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23268}
[modify] https://crrev.com/8e7a62beb2d5a3bf17afa63ce6359069ae741cc1/pc/channelmanager_unittest.cc

Comment 19 by bugdroid1@chromium.org, May 21 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/0f405825c77bb20513e96f2b4ff4f9d6b2b6e22e

commit 0f405825c77bb20513e96f2b4ff4f9d6b2b6e22e
Author: Niels Möller <nisse@webrtc.org>
Date: Mon May 21 10:27:55 2018

New class FakePeriodicVideoTrackSource, simplifying shutdown logic.

Previous code had a FakePeriodicVideoSource and a
VideoTrackSource, where the latter is reference counted and
outlives the former. That results in potential races when
RemoveSink is called on the VideoTrackSource after the
FakePeriodicVideoSource is destroyed, with a complicated sequence
to do correct shutdown.

The new class, FakePeriodicVideoTrackSource, owns a
FakePeriodicVideoSource, and they get the same lifetime.

Bug:  webrtc:6353 
Change-Id: Ic33b393e00a31fa28893dce2018948d3f90e0a9e
Reviewed-on: https://webrtc-review.googlesource.com/76961
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23320}
[modify] https://crrev.com/0f405825c77bb20513e96f2b4ff4f9d6b2b6e22e/ortc/ortcfactory_integrationtest.cc
[modify] https://crrev.com/0f405825c77bb20513e96f2b4ff4f9d6b2b6e22e/pc/BUILD.gn
[modify] https://crrev.com/0f405825c77bb20513e96f2b4ff4f9d6b2b6e22e/pc/peerconnection_integrationtest.cc
[add] https://crrev.com/0f405825c77bb20513e96f2b4ff4f9d6b2b6e22e/pc/test/fakeperiodicvideotracksource.h

Comment 20 by anatolid@chromium.org, May 29 2018

Project Member
Is this finished?

Comment 21 by nisse@webrtc.org, May 29 2018

Project Member
Not finished. Subclasses of cricket::VideoCapturer are still in use in example programs and tests (not entirely sure what the situation is downstream).

Comment 22 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a1cc73f2f9a50c8a905f2a513a15d2c9082099b0

commit a1cc73f2f9a50c8a905f2a513a15d2c9082099b0
Author: Niels Möller <nisse@webrtc.org>
Date: Wed May 30 08:21:30 2018

Delete class FakePeriodicVideoCapturer.

Only use replaced with FakePeriodicVideoTrackSource.

Bug:  webrtc:6353 
Change-Id: Iee38b98a5242a292a848738bde05de18d96de7f4
Reviewed-on: https://webrtc-review.googlesource.com/79441
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23441}
[modify] https://crrev.com/a1cc73f2f9a50c8a905f2a513a15d2c9082099b0/pc/BUILD.gn
[delete] https://crrev.com/7ba9e92fa0dfb16579f4f6ecd746397bdfdd174d/pc/test/fakeperiodicvideocapturer.h
[modify] https://crrev.com/a1cc73f2f9a50c8a905f2a513a15d2c9082099b0/pc/test/peerconnectiontestwrapper.cc

Comment 23 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e8ae5df1030f4108b04fa373cd24cbc6de0c3ef1

commit e8ae5df1030f4108b04fa373cd24cbc6de0c3ef1
Author: Niels Möller <nisse@webrtc.org>
Date: Wed May 30 09:17:17 2018

Convert PeerConnectionWrapper from FakeVideoCapturer to FakeVideoTrackSource.

Bug:  webrtc:6353 
Change-Id: I735317815820888f1e9042b6b18ac77e4c938193
Reviewed-on: https://webrtc-review.googlesource.com/79482
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23443}
[modify] https://crrev.com/e8ae5df1030f4108b04fa373cd24cbc6de0c3ef1/pc/peerconnectionwrapper.cc
[modify] https://crrev.com/e8ae5df1030f4108b04fa373cd24cbc6de0c3ef1/pc/peerconnectionwrapper.h

Comment 24 by bugdroid1@chromium.org, Jul 30 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/731a2c2dc60b8a4ab7d16fd8ea532a53383b1e3b

commit 731a2c2dc60b8a4ab7d16fd8ea532a53383b1e3b
Author: Niels Möller <nisse@webrtc.org>
Date: Mon Jul 30 14:41:23 2018

Convert webrtcvideoengine CVO tests away from cricket::VideoCapturer.

Bug:  webrtc:6353 
Change-Id: I1f4f705cda4fdf88465395898e2588b2a19eebf3
Reviewed-on: https://webrtc-review.googlesource.com/83324
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24142}
[modify] https://crrev.com/731a2c2dc60b8a4ab7d16fd8ea532a53383b1e3b/media/engine/webrtcvideoengine_unittest.cc

Comment 25 by anatolid@chromium.org, Sep 4

Project Member
Is this finished?

Comment 26 by nisse@webrtc.org, Sep 4

Project Member
Not yet finished, we still have

1. PeerConnectionFactoryInterface::CreateVideoSource( std::unique_ptr<cricket::VideoCapturer> capturer)

2. Use in tests,

3. Use in examples/, via WebRtcVideoDeviceCapturerFactory

Comment 27 by nisse@webrtc.org, Nov 20

Project Member
Cc: perkj@webrtc.org
In Chromium, cameras were converted from cricket::VideoCapturer to VideoSourceInterface long ago. But it seems cricket::VideoCapturer is still used for non-camera (remote?) video streams, by the classes MediaStreamVideoWebRtcSink and WebRtcVideoCapturerAdapter.

Per, do you have some advice on how to refactor that?

Comment 29 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32bbd8e61c3256c23f5f16826b8c7ae8d1dc233

commit f32bbd8e61c3256c23f5f16826b8c7ae8d1dc233
Author: Niels Möller <nisse@chromium.org>
Date: Fri Dec 14 09:26:55 2018

Delete remnants of ContentHint handling in WebRtcVideoCapturerAdapter

The |content_hint_| member is unused since
https://chromium-review.googlesource.com/c/chromium/src/+/1146564/.

Deletes wiring in MediaStreamVideoWebRtcSink, as a preparation for
replacing WebRtcVideoCapturerAdapter (a subclass of
cricket::VideoCapturer) with an implementation of
webrtc::VideoTrackSourceInterface.

Bug: 864529,  webrtc:6353 
Change-Id: I48972c63a6c69ceb859fb11fcad98d6faefac524
Reviewed-on: https://chromium-review.googlesource.com/c/1375720
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616620}
[modify] https://crrev.com/f32bbd8e61c3256c23f5f16826b8c7ae8d1dc233/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/f32bbd8e61c3256c23f5f16826b8c7ae8d1dc233/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
[modify] https://crrev.com/f32bbd8e61c3256c23f5f16826b8c7ae8d1dc233/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
[modify] https://crrev.com/f32bbd8e61c3256c23f5f16826b8c7ae8d1dc233/content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc

Comment 30 by nisse@webrtc.org, Dec 14

Project Member
Deletion on chromium under review. In webrtc, remaining usage is in examples/, for peerconnection_client and unityplugin.

It looks like examples could use test::VcmCapturer instead, except that class supports only one sink. To fix, make it inherit AdaptedVideoTrackSource instead of TestVideoCapturer.

Comment 31 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b

commit bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b
Author: Niels Möller <nisse@chromium.org>
Date: Mon Dec 17 09:43:14 2018

Delete class WebRtcVideoCapturerAdapter.

Move functionality into MediaStreamVideoWebRtcSink::WebRtcVideoSource,
inheriting the convenience base class rtc::AdaptedVideoTrackSource.

Bug:  webrtc:6353 
Change-Id: Ia0eb3bc9addd888eab58981e84378e4cb9da8b5a
Reviewed-on: https://chromium-review.googlesource.com/c/1373757
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617069}
[modify] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/BUILD.gn
[modify] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/media_stream_video_webrtc_sink.h
[modify] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc
[modify] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[delete] https://crrev.com/459a99beff59024365a1df84bf390f213255605b/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
[delete] https://crrev.com/459a99beff59024365a1df84bf390f213255605b/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
[add] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/webrtc_video_track_source.cc
[add] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/webrtc_video_track_source.h
[rename] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/renderer/media/webrtc/webrtc_video_track_source_unittest.cc
[modify] https://crrev.com/bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b/content/test/BUILD.gn

Comment 32 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06fc2611088af69fc82bc9c61312641a33a1c433

commit 06fc2611088af69fc82bc9c61312641a33a1c433
Author: Luna Lu <loonybear@chromium.org>
Date: Mon Dec 17 16:50:36 2018

Revert "Delete class WebRtcVideoCapturerAdapter."

This reverts commit bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b.

Reason for revert: Suspect causing failure of WebRtcGetUserMediaBrowserTest.ApplyConstraintsNonDevice on Windows-10 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan

Original change's description:
> Delete class WebRtcVideoCapturerAdapter.
> 
> Move functionality into MediaStreamVideoWebRtcSink::WebRtcVideoSource,
> inheriting the convenience base class rtc::AdaptedVideoTrackSource.
> 
> Bug:  webrtc:6353 
> Change-Id: Ia0eb3bc9addd888eab58981e84378e4cb9da8b5a
> Reviewed-on: https://chromium-review.googlesource.com/c/1373757
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Niels Möller <nisse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617069}

TBR=sergeyu@chromium.org,nisse@chromium.org,orphis@webrtc.org

Change-Id: I56d551ef31772f3615179a736b39399e761e7ef7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  webrtc:6353 
Reviewed-on: https://chromium-review.googlesource.com/c/1379402
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617142}
[modify] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/BUILD.gn
[modify] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/media_stream_video_webrtc_sink.h
[modify] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc
[modify] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[add] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
[add] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
[rename] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc
[delete] https://crrev.com/643f6a9407ea25988a523a2cd349bc16d83d29b2/content/renderer/media/webrtc/webrtc_video_track_source.cc
[delete] https://crrev.com/643f6a9407ea25988a523a2cd349bc16d83d29b2/content/renderer/media/webrtc/webrtc_video_track_source.h
[modify] https://crrev.com/06fc2611088af69fc82bc9c61312641a33a1c433/content/test/BUILD.gn

Comment 33 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8eeccbe6a67105b3334f48eb47b463d75d06a255

commit 8eeccbe6a67105b3334f48eb47b463d75d06a255
Author: Niels Möller <nisse@webrtc.org>
Date: Tue Dec 18 09:29:52 2018

Delete Start and Stop methods from TestVideoCapturer.

Preparation for replacing use of TestVideoCapturer as an interface,
instead using VideoSourceInterface.

Methods kept as non-virtual on the subclass FrameGeneratorCapturer,
but it's changed to be started on creation.

Bug:  webrtc:6353 
Change-Id: Iae1c9a0ee55d730d4992204f62227ef2f057d58e
Reviewed-on: https://webrtc-review.googlesource.com/c/114425
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26037}
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/call/bitrate_estimator_tests.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/pc/test/framegeneratorcapturervideotracksource.h
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/call_test.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/call_test.h
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/frame_generator_capturer.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/frame_generator_capturer.h
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/scenario/scenario.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/scenario/video_stream.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/test_video_capturer.h
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/vcm_capturer.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/test/vcm_capturer.h
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/video/end_to_end_tests/multi_codec_receive_tests.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/video/end_to_end_tests/rtp_rtcp_tests.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/video/picture_id_tests.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/video/video_quality_test.cc
[modify] https://crrev.com/8eeccbe6a67105b3334f48eb47b463d75d06a255/video/video_quality_test.h

Comment 34 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5

commit ab88bc830db02b22a8b4ce3c8d08fee55fd026b5
Author: Niels Möller <nisse@chromium.org>
Date: Tue Dec 18 13:13:10 2018

Reland "Delete class WebRtcVideoCapturerAdapter."

This is a reland of bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b

Original change's description:
> Delete class WebRtcVideoCapturerAdapter.
>
> Move functionality into MediaStreamVideoWebRtcSink::WebRtcVideoSource,
> inheriting the convenience base class rtc::AdaptedVideoTrackSource.
>
> Bug:  webrtc:6353 
> Change-Id: Ia0eb3bc9addd888eab58981e84378e4cb9da8b5a
> Reviewed-on: https://chromium-review.googlesource.com/c/1373757
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Niels Möller <nisse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617069}

Tbr: sergeyu@chromium.org
Bug:  webrtc:6353 
Change-Id: I828b0ac4842b36dd543ff574cad5eb47be6a4d48
Reviewed-on: https://chromium-review.googlesource.com/c/1382231
Commit-Queue: Niels Möller <nisse@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617464}
[modify] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/BUILD.gn
[modify] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/media_stream_video_webrtc_sink.h
[modify] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc
[modify] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[delete] https://crrev.com/12c83c1d10ca587a50c1be1b3aa710a6969079e7/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
[delete] https://crrev.com/12c83c1d10ca587a50c1be1b3aa710a6969079e7/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
[add] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/webrtc_video_track_source.cc
[add] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/webrtc_video_track_source.h
[rename] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/renderer/media/webrtc/webrtc_video_track_source_unittest.cc
[modify] https://crrev.com/ab88bc830db02b22a8b4ce3c8d08fee55fd026b5/content/test/BUILD.gn

Comment 35 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb

commit 1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb
Author: Niels Möller <nisse@webrtc.org>
Date: Tue Dec 18 15:43:55 2018

Use VideoSourceInterface for owning test video sources

CallTest, VideoQualityTest and VideoAnalyzer used test::TestVideoCapturer
as an interface for video sources. Change to use VideoSourceInterface instead,
since that's all they need.

This is a preparation for making test::VcmCapturer usable as a
VideoTrackSource, and replace use of cricket::VideoCapturer in example code.

Bug:  webrtc:6353 
Change-Id: I445f5f6f9b7342230b89f53a5722df9c9e92834f
Reviewed-on: https://webrtc-review.googlesource.com/c/114881
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26047}
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/api/video/video_source_interface.h
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/test/call_test.cc
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/test/call_test.h
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/video/BUILD.gn
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/video/video_analyzer.cc
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/video/video_analyzer.h
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/video/video_quality_test.cc
[modify] https://crrev.com/1c931c4f005146cbb8174e8a16b2f7e1ff6e57eb/video/video_quality_test.h

Comment 36 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3793bb447ae5d502bd4f763d688c65eb47c05ede

commit 3793bb447ae5d502bd4f763d688c65eb47c05ede
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Dec 20 14:04:16 2018

Refactor TestVideoCapturer to support multiple sinks.

To be able to reuse VideoBroadcaster, that class needs to be
officially threadsafe. It already had the needed locks, but thread
checkers have to be deleted to allow calls to AddOrUpdateSink on
multiple threads (worker thread + encoder thread).

Bug:  webrtc:6353 , webrtc:10147
Change-Id: I16128ac205c566f09402b6f22587a340d9a983c1
Reviewed-on: https://webrtc-review.googlesource.com/c/115201
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26073}
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/media/base/videobroadcaster.cc
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/media/base/videobroadcaster.h
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/media/base/videosourcebase.cc
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/media/base/videosourcebase.h
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/test/frame_generator_capturer.cc
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/test/frame_generator_capturer.h
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/test/test_video_capturer.cc
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/test/test_video_capturer.h
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/test/vcm_capturer.cc
[modify] https://crrev.com/3793bb447ae5d502bd4f763d688c65eb47c05ede/test/vcm_capturer.h

Comment 37 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/0a59535ce732138add46bbd96803a1f170715786

commit 0a59535ce732138add46bbd96803a1f170715786
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Jan 03 10:06:17 2019

Update unityplugin to use VcmCapturer.

Replaces use of WebRtcVideoDeviceCapturerFactory.

Bug:  webrtc:6353 
Change-Id: I3c1626af46cb56817190739a39842c4c5a51560d
Reviewed-on: https://webrtc-review.googlesource.com/c/115960
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26117}
[modify] https://crrev.com/0a59535ce732138add46bbd96803a1f170715786/examples/BUILD.gn
[modify] https://crrev.com/0a59535ce732138add46bbd96803a1f170715786/examples/unityplugin/simple_peer_connection.cc
[modify] https://crrev.com/0a59535ce732138add46bbd96803a1f170715786/examples/unityplugin/simple_peer_connection.h

Comment 38 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b76be9a39f3ff2335fae91802048f8c6d4a4225a

commit b76be9a39f3ff2335fae91802048f8c6d4a4225a
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Jan 03 10:52:29 2019

Convert peerconnection_client to use VcmCapturer

Eliminates the last use of WebRtcVideoDeviceCapturerFactory.

Bug:  webrtc:6353 
Change-Id: I72f8a1a968143037c04777e4fb443fff3801f763
Reviewed-on: https://webrtc-review.googlesource.com/c/115340
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26118}
[modify] https://crrev.com/b76be9a39f3ff2335fae91802048f8c6d4a4225a/examples/BUILD.gn
[modify] https://crrev.com/b76be9a39f3ff2335fae91802048f8c6d4a4225a/examples/peerconnection/client/conductor.cc
[modify] https://crrev.com/b76be9a39f3ff2335fae91802048f8c6d4a4225a/examples/peerconnection/client/conductor.h

Comment 39 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/fd87da7a4b548e8b446b57795fcff7d4c2659662

commit fd87da7a4b548e8b446b57795fcff7d4c2659662
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Jan 03 15:15:48 2019

Delete WebRtcVideoCapturer and related classes.

Bug:  webrtc:6353 
Change-Id: Iee2d0d10bcfcb85aec81b426167d9e6a9485187f
Reviewed-on: https://webrtc-review.googlesource.com/c/115341
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26125}
[modify] https://crrev.com/fd87da7a4b548e8b446b57795fcff7d4c2659662/PRESUBMIT.py
[modify] https://crrev.com/fd87da7a4b548e8b446b57795fcff7d4c2659662/media/BUILD.gn
[modify] https://crrev.com/fd87da7a4b548e8b446b57795fcff7d4c2659662/media/base/testutils.cc
[modify] https://crrev.com/fd87da7a4b548e8b446b57795fcff7d4c2659662/media/base/testutils.h
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/base/videocapturerfactory.h
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/fakewebrtcdeviceinfo.h
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/fakewebrtcvcmfactory.h
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/fakewebrtcvideocapturemodule.h
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/webrtcvideocapturer.cc
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/webrtcvideocapturer.h
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/webrtcvideocapturer_unittest.cc
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/webrtcvideocapturerfactory.cc
[delete] https://crrev.com/1dfc4d50656cdb779ce026073a4ed8dce2ad128e/media/engine/webrtcvideocapturerfactory.h

Comment 40 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d0f0f68953afc311cf0ca83e56437b931dd7afa8

commit d0f0f68953afc311cf0ca83e56437b931dd7afa8
Author: Niels Möller <nisse@webrtc.org>
Date: Mon Jan 14 12:34:51 2019

Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 1.

Replaced with a combination of cricket::FakeFrameSource and
webrtc::test::FrameForwarder. This cl converts the first three
affected tests, the rest will follow.

Bug:  webrtc:6353 
Change-Id: I556f6b58f4ca81234ffae3dc6e1319f9c60a76ae
Reviewed-on: https://webrtc-review.googlesource.com/c/117260
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26239}
[modify] https://crrev.com/d0f0f68953afc311cf0ca83e56437b931dd7afa8/media/engine/webrtc_video_engine_unittest.cc

Comment 41 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/45ccd8488ea45f9aea8fda08b1d58f0fa7447442

commit 45ccd8488ea45f9aea8fda08b1d58f0fa7447442
Author: Niels Möller <nisse@webrtc.org>
Date: Tue Jan 15 10:22:13 2019

Don't set the screenshare flag on FakeVideoCapturerWithTaskQueue

A capturer with this flag was set in
WebRtcVideoChannelTest.PreviousAdaptationDoesNotApplyToScreenshare.
But the flag is used only by the VideoCapturerTrackSource class, which
isn't used in this test.

Bug:  webrtc:6353 
Change-Id: I58058c882c5a65b5cfa9921e302c422c8ccb20a9
Reviewed-on: https://webrtc-review.googlesource.com/c/117561
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26256}
[modify] https://crrev.com/45ccd8488ea45f9aea8fda08b1d58f0fa7447442/media/engine/webrtc_video_engine_unittest.cc

Comment 42 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/dcc70297cdd7f71a7a4e81b9e3169475fbefbbb9

commit dcc70297cdd7f71a7a4e81b9e3169475fbefbbb9
Author: Niels Möller <nisse@webrtc.org>
Date: Wed Jan 16 13:02:49 2019

Simplify WebRtcVideoChannelTest.PreviousAdaptationDoesNotApplyToScreenshare

Test wiring to DegradationPreference passed to
VideoSendStream::SetSource, but not the adaptation implemented in the
test class FakeVideoCapturer.

Bug:  webrtc:6353 
Change-Id: Iec2ae89283fb856822ea2829db17eaa02337b467
Reviewed-on: https://webrtc-review.googlesource.com/c/117641
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26278}
[modify] https://crrev.com/dcc70297cdd7f71a7a4e81b9e3169475fbefbbb9/media/engine/webrtc_video_engine_unittest.cc

Comment 43 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1ba3ddd3c62638ae140aa02d754deb9279361c71

commit 1ba3ddd3c62638ae140aa02d754deb9279361c71
Author: Yves Gerey <yvesg@webrtc.org>
Date: Thu Jan 17 11:28:43 2019

Remove obsolete video_capture_module dependency.

Since WebRtcVideoCapturer and related classes were deleted [1],
this dependency isn't needed anymore.

[1] https://webrtc.googlesource.com/src/+/fd87da7a4b548e8b446b57795fcff7d4c2659662

Bug:  webrtc:6353 
Change-Id: I9f2df2d11d1bf471c941f6d7769b35f70f5ffd27
Reviewed-on: https://webrtc-review.googlesource.com/c/117960
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26291}
[modify] https://crrev.com/1ba3ddd3c62638ae140aa02d754deb9279361c71/media/BUILD.gn

Comment 44 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/fb7a6a7f8dc8f7f549203dc95bc1789183b88c01

commit fb7a6a7f8dc8f7f549203dc95bc1789183b88c01
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Jan 17 14:23:52 2019

Delete test WebRtcVideoChannelTest.AdaptsOnOveruseAndChangeResolution

It only tests the videoadaptation in the test class FakeVideoCapturer.

Bug:  webrtc:6353 
Change-Id: I4766eebc5cfa7412fde9fd6e5173f1b2381a5d87
Reviewed-on: https://webrtc-review.googlesource.com/c/118042
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26297}
[modify] https://crrev.com/fb7a6a7f8dc8f7f549203dc95bc1789183b88c01/media/engine/webrtc_video_engine_unittest.cc

Comment 45 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3eaf9f169cd04dcd15ecda60add655da249f9b36

commit 3eaf9f169cd04dcd15ecda60add655da249f9b36
Author: Niels Möller <nisse@webrtc.org>
Date: Fri Jan 18 12:57:11 2019

Refactor PeerConnectionFactoryTest to not use FakeVideoCapturer.

Extend FakeVideoTrackSource to have a VideoBroadcaster.

Bug:  webrtc:6353 
Change-Id: I3c8e68b4ec9a1910f0450b5cc698056c0f3089d2
Reviewed-on: https://webrtc-review.googlesource.com/c/118080
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26320}
[modify] https://crrev.com/3eaf9f169cd04dcd15ecda60add655da249f9b36/pc/peer_connection_factory_unittest.cc
[modify] https://crrev.com/3eaf9f169cd04dcd15ecda60add655da249f9b36/pc/test/fake_video_track_source.h

Comment 46 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/215ba609dea3c8e5c1b0e4c669aeb8984d55b088

commit 215ba609dea3c8e5c1b0e4c669aeb8984d55b088
Author: Niels Möller <nisse@webrtc.org>
Date: Fri Jan 18 13:55:19 2019

Refactor PeerConnectionInterfaceTest to not depend on cricket::VideoCapturer

Bug:  webrtc:6353 
Change-Id: Ib18f7cec8a8a742d76f4a43410fa927e43336a8a
Reviewed-on: https://webrtc-review.googlesource.com/c/118100
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26323}
[modify] https://crrev.com/215ba609dea3c8e5c1b0e4c669aeb8984d55b088/pc/peer_connection_interface_unittest.cc

Comment 47 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/dd6633beaa437cdb34ef56a42a7d74d82e701f54

commit dd6633beaa437cdb34ef56a42a7d74d82e701f54
Author: Niels Möller <nisse@webrtc.org>
Date: Mon Jan 21 07:33:35 2019

Refactor VideoTrackTest to not depend on cricket::VideoCapturer

Bug:  webrtc:6353 
Change-Id: Ie0c9d22e1339aa7ff1e02fe26ca796a299410cf1
Reviewed-on: https://webrtc-review.googlesource.com/c/118420
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26330}
[modify] https://crrev.com/dd6633beaa437cdb34ef56a42a7d74d82e701f54/pc/video_track_unittest.cc

Comment 48 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/aa8b94c170d6002c9e3f0290e9ab683e4163723c

commit aa8b94c170d6002c9e3f0290e9ab683e4163723c
Author: Niels Möller <nisse@webrtc.org>
Date: Mon Jan 21 07:34:41 2019

Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2.

Update remaining tests of WebRtcVideoEngine.

Bug:  webrtc:6353 
Change-Id: I63f86a6c3cd45e1c95345746ac4ecc018d2f29c6
Reviewed-on: https://webrtc-review.googlesource.com/c/117560
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26331}
[modify] https://crrev.com/aa8b94c170d6002c9e3f0290e9ab683e4163723c/media/engine/webrtc_video_engine_unittest.cc

Comment 49 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a882fb3ee433e464433d593f72c4f5fa439f1adf

commit a882fb3ee433e464433d593f72c4f5fa439f1adf
Author: Niels Moller <nisse@webrtc.org>
Date: Mon Jan 21 08:44:47 2019

Revert "Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2."

This reverts commit aa8b94c170d6002c9e3f0290e9ab683e4163723c.

Reason for revert: Timestamp-related breakage in downstream tests. 
Will try to reland together with fix in cl https://webrtc-review.googlesource.com/c/src/+/118680

Original change's description:
> Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2.
> 
> Update remaining tests of WebRtcVideoEngine.
> 
> Bug:  webrtc:6353 
> Change-Id: I63f86a6c3cd45e1c95345746ac4ecc018d2f29c6
> Reviewed-on: https://webrtc-review.googlesource.com/c/117560
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26331}

TBR=nisse@webrtc.org,sprang@webrtc.org

Change-Id: I901fe7416390aa36716b4124c8bbc6b751c26cee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  webrtc:6353 
Reviewed-on: https://webrtc-review.googlesource.com/c/118681
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26332}
[modify] https://crrev.com/a882fb3ee433e464433d593f72c4f5fa439f1adf/media/engine/webrtc_video_engine_unittest.cc

Comment 50 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/805a27e134507d54d0bc80e52a312b1b21312572

commit 805a27e134507d54d0bc80e52a312b1b21312572
Author: Niels Möller <nisse@webrtc.org>
Date: Mon Jan 21 12:48:35 2019

Reland "Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2."

This is a reland of aa8b94c170d6002c9e3f0290e9ab683e4163723c

Original change's description:
> Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2.
> 
> Update remaining tests of WebRtcVideoEngine.
> 
> Bug:  webrtc:6353 
> Change-Id: I63f86a6c3cd45e1c95345746ac4ecc018d2f29c6
> Reviewed-on: https://webrtc-review.googlesource.com/c/117560
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26331}

Bug:  webrtc:6353 
Change-Id: I052bea3be776140c0f301cc4383337c0aa62f4f5
Reviewed-on: https://webrtc-review.googlesource.com/c/118700
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26338}
[modify] https://crrev.com/805a27e134507d54d0bc80e52a312b1b21312572/media/base/fake_frame_source.cc
[modify] https://crrev.com/805a27e134507d54d0bc80e52a312b1b21312572/media/engine/webrtc_video_engine_unittest.cc

Comment 51 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/260a71d47c0c6b1912261a4462455261d9676bf0

commit 260a71d47c0c6b1912261a4462455261d9676bf0
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Feb 07 14:24:02 2019

Delete deprecated method PeerConnectionFactory::CreateVideoSource

Bug:  webrtc:6353 
Change-Id: Icb8847b234e7a844a4dff9ff44861f6967ac7b5b
Reviewed-on: https://webrtc-review.googlesource.com/c/118661
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26587}
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/api/peer_connection_factory_proxy.h
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/api/peer_connection_interface.cc
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/api/peer_connection_interface.h
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/pc/BUILD.gn
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/pc/peer_connection.cc
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/pc/peer_connection_factory.cc
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/pc/peer_connection_factory.h
[delete] https://crrev.com/59ab1cf081967353c1ae31f9d8111ec9b17284b2/pc/video_capturer_track_source.cc
[delete] https://crrev.com/59ab1cf081967353c1ae31f9d8111ec9b17284b2/pc/video_capturer_track_source.h
[delete] https://crrev.com/59ab1cf081967353c1ae31f9d8111ec9b17284b2/pc/video_capturer_track_source_unittest.cc
[modify] https://crrev.com/260a71d47c0c6b1912261a4462455261d9676bf0/sdk/android/src/jni/pc/sdp_observer.h

Comment 53 by nisse@webrtc.org, Feb 8

Project Member
Status: Fixed (was: Assigned)

Sign in to add a comment