New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 5836 link

Starred by 38 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue chromium:571918



Sign in to add a comment

Setting DSCP constraint on windows7 OS does not work

Reported by rajkumar...@gmail.com, Apr 28 2016

Issue description

What steps will reproduce the problem?
1. Set 'googdscp' constraint to true and make webrtc call to another webrtc page on chrome browser.

DSCP value marked on the packets is 0x00, which is default forwarding "Standard" service class. The same scenario when tested on mac and linux OS works perfectly with the DSCP value marked on the packet to be 2E(i.e., 46 - Expedited forwarding)

What is the expected result?
Default value of DSCP for voice/video calls should be set correctly.

What do you see instead?
DSCP value marked on the packets is 0x00, which is default forwarding "Standard" service class.

What version of the product are you using? On what operating system?
Chrome 50, Windows 7 Os

Please provide any additional information below.

The same scenario when tested on mac OS and linux works perfectly with the DSCP value marked on the packet to be 2E(i.e., 46 - Expedited forwarding)


 
Project Member

Comment 1 by braveyao@webrtc.org, May 2 2016

Cc: braveyao@webrtc.org
Components: Network
Owner: pthatcher@webrtc.org
pthatcher@, please help to have a check.
Project Member

Comment 2 by pthatcher@webrtc.org, May 2 2016

Cc: sergeyu@chromium.org
Owner: deadbeef@webrtc.org
This may not be possible for Win 7.
Project Member

Comment 3 by pthatcher@webrtc.org, May 2 2016

Labels: EngTriaged
Project Member

Comment 4 by honghaiz@webrtc.org, Oct 18 2016

Labels: -Pri-2 Pri-1
Project Member

Comment 5 by pthatcher@google.com, Oct 26 2016

Labels: -Pri-1 Pri-2
This is not a P1.
Project Member

Comment 6 by anatolid@chromium.org, Dec 5 2016

Status: Assigned (was: Unconfirmed)
[bulk-edit] This issue appears to have been triaged (as evidenced by the presence of the EngTriaged label) and also has an Owner -- hence, changing its status to Assigned. If the currently set Owner is wrong, then please re-assign to a correct Owner, or remove Owner and set status to Available.
Could you please provide an estimated target milestone for this, as we have this issue reported from few customer escalations. Recommend if this can be moved to Pri:1, as it has high impact on Contact center customer currently.

thanks!

Comment 8 by ashr...@avaya.com, Jan 17 2017

Any updates ?
Request to communicate us on the milestone targeted for this atleast.
Project Member

Comment 10 by deadbeef@webrtc.org, Feb 6 2017

Labels: M-58
Sorry for not noticing your request earlier. We'll aim for fixing this in M58.

Comment 11 by bak...@gmail.com, Feb 10 2017

Looking forward for the update
Project Member

Comment 12 by anatolid@chromium.org, Feb 23 2017

Will this make it to M58?
Project Member

Comment 13 by deadbeef@chromium.org, Feb 23 2017

Labels: -M-58 M-59
No; bumping milestone. This is still high on our priorities though so it's more likely to hit M59.

Comment 14 by art...@aircall.io, Mar 18 2017

Hi,
Any update? Is it still planned for release in M59 or is it more likely to hit M60?
Thanks!
Project Member

Comment 15 by deadbeef@webrtc.org, Mar 22 2017

Some other things have come up, but it's still possible we'll get to it.
Project Member

Comment 16 by anatolid@webrtc.org, Apr 18 2017

Labels: -M-59
Removing the milestone since there is no estimate on when this is likely to be looked at (as per #15). Please update the milestone accordingly otherwise.

Comment 17 by art...@aircall.io, Jul 7 2017

Any updates on this one? 
Project Member

Comment 18 by deadbeef@webrtc.org, Jul 18 2017

We may look at this soon. After some brief investigation, I found this: https://support.microsoft.com/en-us/help/2733528/policy-based-qos-not-working-in-windows-7-clients

It sounds like starting in Windows 7, DSCP markings are only enabled if the network interface is attached to a "domain". Here's something more of an explanation: https://technet.microsoft.com/en-us/library/dd919203(v=ws.10).aspx

There's this too: https://blogs.msdn.microsoft.com/wndp/2009/01/27/qos-in-windows-7/

I still don't completely understand this, but wanted to make a note of it before I forgot.
Project Member

Comment 19 by zstein@webrtc.org, Dec 20 2017

Cc: zstein@webrtc.org
Project Member

Comment 21 by zstein@webrtc.org, Jul 2

The underlying problem here is that DSCP markings need to be set per-destination IP on Windows for unconnected UDP sockets.
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86cf2b472f51547ab2ded2a843740bddc70ad15c

commit 86cf2b472f51547ab2ded2a843740bddc70ad15c
Author: Tim Haloun <thaloun@chromium.org>
Date: Fri Sep 28 00:20:39 2018

Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456.

Bug: webrtc:5836
Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157
Reviewed-on: https://chromium-review.googlesource.com/1191925
Commit-Queue: Tim Haloun <thaloun@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594931}
[modify] https://crrev.com/86cf2b472f51547ab2ded2a843740bddc70ad15c/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/86cf2b472f51547ab2ded2a843740bddc70ad15c/net/socket/udp_socket_win.cc
[modify] https://crrev.com/86cf2b472f51547ab2ded2a843740bddc70ad15c/net/socket/udp_socket_win.h

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0eeeca538c1fc0fafeb9ba9aec06ad2c1e22325

commit c0eeeca538c1fc0fafeb9ba9aec06ad2c1e22325
Author: Tim Haloun <thaloun@chromium.org>
Date: Fri Sep 28 20:48:47 2018

Revert "Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456."

This reverts commit 86cf2b472f51547ab2ded2a843740bddc70ad15c.

Reason for revert: Likely causing build flakiness: https://bugs.chromium.org/p/chromium/issues/detail?id=890293#c2

Original change's description:
> Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456.
> 
> Bug: webrtc:5836
> Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157
> Reviewed-on: https://chromium-review.googlesource.com/1191925
> Commit-Queue: Tim Haloun <thaloun@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594931}

TBR=pauljensen@chromium.org,rch@chromium.org,thaloun@chromium.org

Change-Id: If2502da611962557ecf4eb4da2760860a3c9540a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5836
Reviewed-on: https://chromium-review.googlesource.com/1252529
Reviewed-by: Fran├žois Doray <fdoray@chromium.org>
Commit-Queue: Fran├žois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595207}
[modify] https://crrev.com/c0eeeca538c1fc0fafeb9ba9aec06ad2c1e22325/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/c0eeeca538c1fc0fafeb9ba9aec06ad2c1e22325/net/socket/udp_socket_win.cc
[modify] https://crrev.com/c0eeeca538c1fc0fafeb9ba9aec06ad2c1e22325/net/socket/udp_socket_win.h

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce5b549367c7c4fa0818064553818d69ba894a79

commit ce5b549367c7c4fa0818064553818d69ba894a79
Author: Tim Haloun <thaloun@chromium.org>
Date: Mon Oct 08 22:34:46 2018

Reland "Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456."

This is a reland of 86cf2b472f51547ab2ded2a843740bddc70ad15c

Original change's description:
> Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456.
> 
> Bug: webrtc:5836
> Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157
> Reviewed-on: https://chromium-review.googlesource.com/1191925
> Commit-Queue: Tim Haloun <thaloun@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594931}

Bug: webrtc:5836
Change-Id: I77d7bde804e9d0b906da659865b058456419390a
Reviewed-on: https://chromium-review.googlesource.com/c/1252913
Commit-Queue: Tim Haloun <thaloun@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597711}
[modify] https://crrev.com/ce5b549367c7c4fa0818064553818d69ba894a79/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/ce5b549367c7c4fa0818064553818d69ba894a79/net/socket/udp_socket_win.cc
[modify] https://crrev.com/ce5b549367c7c4fa0818064553818d69ba894a79/net/socket/udp_socket_win.h

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66923ce781889c8fae9e56d2963dddc7d461f012

commit 66923ce781889c8fae9e56d2963dddc7d461f012
Author: Tim Haloun <thaloun@chromium.org>
Date: Sat Oct 27 01:01:06 2018

Re-enable QoS for UDPSocket under Windows.

 - Move QoSCreateHandle to a background task, letting critical socket operations continue unblocked while it executes.
 - Improve resetting handle when it returns REINITIALIZATION_NEEDED
 - Widen unit tests
 - Undo ifdef disabling QOS that was added because of hangs/stalls noted in bug 812137

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I383955c2a218f23974a3f5e7044ae0464e99a43f
Bug: 812137, webrtc:5836
Reviewed-on: https://chromium-review.googlesource.com/c/1195936
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Tim Haloun <thaloun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603269}
[modify] https://crrev.com/66923ce781889c8fae9e56d2963dddc7d461f012/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/66923ce781889c8fae9e56d2963dddc7d461f012/net/socket/udp_socket_win.cc
[modify] https://crrev.com/66923ce781889c8fae9e56d2963dddc7d461f012/net/socket/udp_socket_win.h
[modify] https://crrev.com/66923ce781889c8fae9e56d2963dddc7d461f012/services/network/p2p/socket_udp.cc

Project Member

Comment 26 by steveanton@webrtc.org, Dec 27

Owner: thaloun@chromium.org
Status: Started (was: Assigned)
Tim, is this fixed now?
Blocking: chromium:571918

Sign in to add a comment