Project: webrtc Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 4784 webrtc should only use proxy route when chrome has proxy-server specified.
Starred by 7 users Project Member Reported by guoweis@webrtc.org, Jun 19 2015 Back to list
Status: Verified
Owner:
User never visited
Closed: Sep 2015
Cc:
Components:
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 4783



Sign in to add a comment
What steps will reproduce the problem?
1.
2.
3.

What is the expected result?


What do you see instead?


Please use labels and text to provide additional information.

 
Project Member Comment 1 by guoweis@webrtc.org, Jun 19 2015
Blocking: webrtc:4783
Project Member Comment 2 by pthatcher@webrtc.org, Jun 22 2015
Labels: EngTriaged
Project Member Comment 3 by bugdroid1@chromium.org, Aug 26 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/13d35f6ffc71c1a649a902369a6fa5637d05d9b0

commit 13d35f6ffc71c1a649a902369a6fa5637d05d9b0
Author: Guo-wei Shieh <guoweis@webrtc.org>
Date: Wed Aug 26 22:32:56 2015

Add check to prevent TURN usage if the protocol is not allowed.

There are 2 ways to design this.

1. TCP Only mode: this means that we disable all UDP protocols across board.
2. disallow TURN over UDP. Along with DISABLE_UDP, DISABLE_STUN, we should achieve the same result.

I'm going with #2.

BUG= webrtc:4784 
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1311153003 .

Cr-Commit-Position: refs/heads/master@{#9791}

[modify] http://crrev.com/13d35f6ffc71c1a649a902369a6fa5637d05d9b0/webrtc/p2p/base/portallocator.h
[modify] http://crrev.com/13d35f6ffc71c1a649a902369a6fa5637d05d9b0/webrtc/p2p/client/basicportallocator.cc
[modify] http://crrev.com/13d35f6ffc71c1a649a902369a6fa5637d05d9b0/webrtc/p2p/client/portallocator_unittest.cc

Project Member Comment 4 by bugdroid1@chromium.org, Aug 29 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca

commit a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca
Author: guoweis <guoweis@chromium.org>
Date: Sat Aug 29 01:33:28 2015

Create a new preference which disables UDP protocol for WebRTC. The preference will be used in an extension. The extension API CL will follow.

WebRTC by default uses UDP to connect to peer and TURN servers. This could lead to ip leak when using proxy server to hide the IP. Introduce a preference which disallows any usage of UDP protocol.

This is similar to how we added "enable_multiple_routes" (CL: https://codereview.chromium.org/916873004/) and is based on ongoing CL https://codereview.webrtc.org/1311153003/

BUG= webrtc:4784 

Review URL: https://codereview.chromium.org/1309543004

Cr-Commit-Position: refs/heads/master@{#346294}

[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/chrome/browser/renderer_preferences_util.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/chrome/browser/ui/browser_ui_prefs.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/chrome/common/pref_names.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/chrome/common/pref_names.h
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/content/common/view_messages.h
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/content/public/common/renderer_preferences.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/content/public/common/renderer_preferences.h
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/content/renderer/p2p/port_allocator.cc
[modify] http://crrev.com/a84ace48ac5c7c257913ce4f6ed9ab88d7eb9dca/content/renderer/p2p/port_allocator.h

Project Member Comment 5 by bugdroid1@chromium.org, Sep 1 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2e0415f2fe42c419ce1660c9acd331f3a174ba

commit be2e0415f2fe42c419ce1660c9acd331f3a174ba
Author: guoweis <guoweis@chromium.org>
Date: Tue Sep 01 23:40:18 2015

Add `privacy.network.webRTCNonProxiedUdpTransportEnabled` to extensions API

Expose the preference to extensions' privacy API. Disabling this preference prevents non-proxied UDP to be used as it leads to IP leak when using WebRTC. Currently, this is effectively disabling all UDP traffic until UDP supporting proxy is available in chrome.

This is based on an ongoing CL https://codereview.chromium.org/1309543004

BUG= webrtc:4784 

Review URL: https://codereview.chromium.org/1315223002

Cr-Commit-Position: refs/heads/master@{#346786}

[modify] http://crrev.com/be2e0415f2fe42c419ce1660c9acd331f3a174ba/chrome/browser/extensions/api/preference/preference_api.cc
[modify] http://crrev.com/be2e0415f2fe42c419ce1660c9acd331f3a174ba/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] http://crrev.com/be2e0415f2fe42c419ce1660c9acd331f3a174ba/chrome/common/extensions/api/privacy.json
[modify] http://crrev.com/be2e0415f2fe42c419ce1660c9acd331f3a174ba/chrome/test/data/extensions/api_test/preference/standard/test.js

Project Member Comment 6 by bugdroid1@chromium.org, Sep 2 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b380551e511287fabf9f89b45db3f371542219d

commit 5b380551e511287fabf9f89b45db3f371542219d
Author: guoweis <guoweis@chromium.org>
Date: Wed Sep 02 06:53:45 2015

Simple variable renaming: remove transport.

Based on feedback from https://codereview.chromium.org/1315223002, removing all "transport" from variable names.

BUG= webrtc:4784 

Review URL: https://codereview.chromium.org/1307943011

Cr-Commit-Position: refs/heads/master@{#346855}

[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/browser/extensions/api/preference/preference_api.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/browser/renderer_preferences_util.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/browser/ui/browser_ui_prefs.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/common/pref_names.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/chrome/common/pref_names.h
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/content/common/view_messages.h
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/content/public/common/renderer_preferences.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/content/public/common/renderer_preferences.h
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/content/renderer/p2p/port_allocator.cc
[modify] http://crrev.com/5b380551e511287fabf9f89b45db3f371542219d/content/renderer/p2p/port_allocator.h

Project Member Comment 7 by tnakamura@webrtc.org, Sep 16 2015
Labels: Mstone-47
guoweis@ - can this be considered fixed?
Project Member Comment 8 by guoweis@webrtc.org, Sep 22 2015
Status: Fixed
Project Member Comment 9 by tnakamura@webrtc.org, Oct 26 2015
Cc: tnakamura@webrtc.org
Status: Verified
lgtm with 47.0.2526.27 + Chrome with --proxy-server + latest WebRTC network limiter extension (not yet released) in mode 3.
Project Member Comment 10 by guoweis@webrtc.org, Oct 27 2015
 Issue 4783  has been merged into this issue.
Project Member Comment 11 by kjellander@webrtc.org, Oct 5 2016
Labels: M-47
Sign in to add a comment