New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 16 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Enhancement



Sign in to add a comment

Implement and tune high fps screenshare

Project Member Reported by mflodman@webrtc.org, Jan 9 2015 Back to list

Issue description

Implement and tune high fps screenshare.
 
Project Member

Comment 1 by vikasmarwaha@webrtc.org, Mar 31 2015

Should we move the milestone, if its not done for M43?
Project Member

Comment 2 by sprang@webrtc.org, Apr 7 2015

Labels: -Pri-1 -Mstone-43 Pri-2 Mstone-44
Project Member

Comment 3 by tnakamura@webrtc.org, Jan 29 2016

Labels: -Mstone-44
I don't see any CLs linked to this bug, so I don't think it's been fixed. I'm therefore leaving this in an open state, but I am removing the milestone label since this bug hasn't been updated in quite some time.
Project Member

Comment 4 by mflodman@webrtc.org, Dec 1 2016

Labels: M-57
Status: Started (was: Assigned)
Project Member

Comment 5 by anatolid@webrtc.org, Jan 11 2017

Will this make it to M57?
Project Member

Comment 6 by sprang@webrtc.org, Jan 13 2017

Labels: -M-57 M-58
Some, but not all of it.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/44303ea0ffad4ddc0944361a32f9243e01e776b0

commit 44303ea0ffad4ddc0944361a32f9243e01e776b0
Author: sprang <sprang@webrtc.org>
Date: Wed Jan 18 13:19:13 2017

Revert of Add experimental simulcast screen content mode (patchset #5 id:80001 of https://codereview.webrtc.org/2636443002/ )

Reason for revert:
Breaks chromium.

Original issue's description:
> Add experimental simulcast screen content mode
>
> BUG=webrtc:4172
>
> Review-Url: https://codereview.webrtc.org/2636443002
> Cr-Commit-Position: refs/heads/master@{#16135}
> Committed: https://chromium.googlesource.com/external/webrtc/+/a28e971e3bc8a06f366f0ef82cc7168b05a83b59

TBR=perkj@webrtc.org,asapersson@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2643763002
Cr-Commit-Position: refs/heads/master@{#16145}

[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/media/engine/simulcast.cc
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/media/engine/simulcast.h
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h
[modify] https://crrev.com/44303ea0ffad4ddc0944361a32f9243e01e776b0/webrtc/modules/video_coding/video_codec_initializer.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/429600d7d00b526b3b35b6387b7d72a053709860

commit 429600d7d00b526b3b35b6387b7d72a053709860
Author: sprang <sprang@webrtc.org>
Date: Thu Jan 26 14:12:26 2017

Reland of Add experimental simulcast screen content mode

The original CL was reverted because of a bug discovered by the
chromium bots. Description of that CL:

> Review-Url: https://codereview.webrtc.org/2636443002
> Cr-Commit-Position: refs/heads/master@{#16135}
> Committed: https://chromium.googlesource.com/external/webrtc/+/a28e971e3bc8a06f366f0ef82cc7168b05a83b59

The first patch set of this CL is the same as r16135.
Subsequence patch sets are the fixes applied.
Some new test cases have been added, which reveal a few more bugs that
have also been fixed.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2641133002
Cr-Commit-Position: refs/heads/master@{#16299}

[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/media/engine/simulcast.cc
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/media/engine/simulcast.h
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/BUILD.gn
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc
[modify] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/video_codec_initializer.cc
[add] https://crrev.com/429600d7d00b526b3b35b6387b7d72a053709860/webrtc/modules/video_coding/video_codec_initializer_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 1 2017

Labels: merge-merged-57
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/71394677e4dc343ca5c0f996037207a9bd9616c9

commit 71394677e4dc343ca5c0f996037207a9bd9616c9
Author: Erik Språng <sprang@webrtc.org>
Date: Wed Feb 01 13:42:59 2017

Merge to 57: Add experimental simulcast screen content mode

This is a cherry pick of https://codereview.webrtc.org/2641133002/

BUG=webrtc:4172,  chromium:687106 
R=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2660403007 .
Cr-Commit-Position: refs/branch-heads/57@{#2}
Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}

[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/simulcast.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/simulcast.h
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/video_codec_initializer.cc
[add] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/video_codec_initializer_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d

commit b1ca073db43f8fdcb715d5642d5aa7da7582eb0d
Author: sprang <sprang@webrtc.org>
Date: Wed Feb 01 16:38:12 2017

Rename adaptation api methods, extended vie_encoder unit test.

Use AdaptDown/AdaptUp instead of ScaleDown/ScaleUp, since we may want to
adapt using other means than resolution.

Also, extend vie_encoder with unit test that actually uses frames scaled
to resolution as determined by VideoAdapter, since that seems to be the
default implementation.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2652893015
Cr-Commit-Position: refs/heads/master@{#16402}

[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/modules/video_coding/utility/quality_scaler.cc
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/modules/video_coding/utility/quality_scaler.h
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/test/frame_generator.cc
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/test/frame_generator.h
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/video/overuse_frame_detector_unittest.cc
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/video/vie_encoder.h
[modify] https://crrev.com/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d/webrtc/video/vie_encoder_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/84a3759825ec3bcba104196148be15aabc258a08

commit 84a3759825ec3bcba104196148be15aabc258a08
Author: sprang <sprang@webrtc.org>
Date: Fri Feb 10 15:04:27 2017

Change rtc::VideoSinkWants to have target and a max pixel count

The current method with max_pixel_count and max_pixel_count_step_up,
where only one should be used at a time and this first signaling an
inclusive upper bound and other other an exclusive lower bound, makes
for a lot of confusion.

I've updated this to have a desired target and a maximum instead. The
source should select a resolution as close to the target as possible,
but no higher than the maximum.

I intend to also add similar frame rate settings in an upcoming cl.

BUG=webrtc:4172,webrtc:6850

Review-Url: https://codereview.webrtc.org/2672793002
Cr-Commit-Position: refs/heads/master@{#16533}

[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/call/call_perf_tests.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videoadapter.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videoadapter.h
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videocapturer.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videocapturer_unittest.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/base/videosourceinterface.h
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/video/vie_encoder.h
[modify] https://crrev.com/84a3759825ec3bcba104196148be15aabc258a08/webrtc/video/vie_encoder_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/be03724ae1a1fc677d15ff77a90b0e578d98c4ce

commit be03724ae1a1fc677d15ff77a90b0e578d98c4ce
Author: sprang <sprang@webrtc.org>
Date: Mon Feb 13 10:38:17 2017

Fix nits in vie_encoder

Updated comment.
Don't call AdaptUp/AdaptDown in tests without first emitting a frame.
Handle frame received precondition in AdaptUp/AdaptDown with DCHECK
instead of return.

BUG=webrtc:4172, webrtc:6850

Review-Url: https://codereview.webrtc.org/2690023002
Cr-Commit-Position: refs/heads/master@{#16572}

[modify] https://crrev.com/be03724ae1a1fc677d15ff77a90b0e578d98c4ce/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/be03724ae1a1fc677d15ff77a90b0e578d98c4ce/webrtc/video/vie_encoder_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/3ebabf1c2983c99bfea9fe47373920d23dd99f55

commit 3ebabf1c2983c99bfea9fe47373920d23dd99f55
Author: sprang <sprang@webrtc.org>
Date: Thu Feb 16 15:35:22 2017

Screen content simulcast layers should not be downscaled.

Fix config so, size isn't downscaled, add unit test coverage.

BUG= webrtc:7171 , webrtc:4172

Review-Url: https://codereview.webrtc.org/2692343007
Cr-Commit-Position: refs/heads/master@{#16648}

[modify] https://crrev.com/3ebabf1c2983c99bfea9fe47373920d23dd99f55/webrtc/media/engine/simulcast.cc
[modify] https://crrev.com/3ebabf1c2983c99bfea9fe47373920d23dd99f55/webrtc/media/engine/webrtcvideoengine2_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0a71dc836641acdaaa63b2724f83c822dbb58ce7

commit 0a71dc836641acdaaa63b2724f83c822dbb58ce7
Author: Erik Språng <sprang@webrtc.org>
Date: Tue Feb 21 14:18:16 2017

Merge to 57: Screen content simulcast layers should not be downscaled.

Fix config so, size isn't downscaled, add unit test coverage.

BUG= webrtc:7171 , webrtc:4172

Original Review-Url: https://codereview.webrtc.org/2692343007
Original Cr-Commit-Position: refs/heads/master@{#16648}

R=mflodman@webrtc.org

Review-Url: https://codereview.webrtc.org/2709733002 .
Cr-Commit-Position: refs/branch-heads/57@{#6}
Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}

[modify] https://crrev.com/0a71dc836641acdaaa63b2724f83c822dbb58ce7/webrtc/media/engine/simulcast.cc
[modify] https://crrev.com/0a71dc836641acdaaa63b2724f83c822dbb58ce7/webrtc/media/engine/webrtcvideoengine2_unittest.cc

Project Member

Comment 16 by anatolid@chromium.org, Feb 23 2017

Will this issue be fixed/closed in time for M58 cut?
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/f24a06406a5e0863fee82d6470bb655d3b4ac2af

commit f24a06406a5e0863fee82d6470bb655d3b4ac2af
Author: sprang <sprang@webrtc.org>
Date: Tue Feb 28 21:23:26 2017

Recreate WebrtcVideoSendStream if screen content setting is changed.

This avoids the situation where an encoder, not supporting certain
screen content settings, is created for a config where screencast is
off, and later ReconfigureEncoder() is called updating the configuration
but not the encoder instance, causing an inconsistency in the encoder's
InitEncode() call.

TBR=pthatcher@webrtc.org
BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2710493008
Cr-Commit-Position: refs/heads/master@{#16921}

[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/media/engine/fakewebrtcvideoengine.h
[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/video/video_send_stream.h
[modify] https://crrev.com/f24a06406a5e0863fee82d6470bb655d3b4ac2af/webrtc/video/video_send_stream_tests.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/5271ea6571c1e6d0c38f13636181f800b58d7494

commit 5271ea6571c1e6d0c38f13636181f800b58d7494
Author: sprang <sprang@webrtc.org>
Date: Wed Mar 01 09:58:17 2017

Switch temporal layer impl used for screenshare upper simulcast stream.

Use default temporal layers instead of the RealtimeTemporalLayers one.
When using low fps, having a single stream with much higher bitrate than
the lower simulcast stream causes poor rampup behavior.

Tested manually.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2723983002
Cr-Commit-Position: refs/heads/master@{#16934}

[modify] https://crrev.com/5271ea6571c1e6d0c38f13636181f800b58d7494/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

Project Member

Comment 19 by anatolid@webrtc.org, Mar 6 2017

Should we bump this to M59?
Project Member

Comment 20 by anatolid@webrtc.org, Mar 8 2017

Labels: -M-58 M-59
Bumping to M59 after chatting to Erik.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6

commit 72acf2526177bb4dbb5103cd6e165eb4361a5ae6
Author: sprang <sprang@webrtc.org>
Date: Tue Mar 21 18:54:11 2017

Add framerate to VideoSinkWants and ability to signal on overuse

In ViEEncoder, try to reduce framerate instead of resolution if the
current degradation preference is maintain-resolution rather than
balanced.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2716643002
Cr-Commit-Position: refs/heads/master@{#17327}

[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/call/bitrate_estimator_tests.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/call/call_perf_tests.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/fakevideocapturer.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/fakevideorenderer.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videoadapter.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videoadapter.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videocapturer.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videocapturer_unittest.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/base/videosourceinterface.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/engine/fakewebrtccall.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/engine/fakewebrtccall.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/BUILD.gn
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/call_test.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/frame_generator_capturer.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/frame_generator_capturer.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/vcm_capturer.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/vcm_capturer.h
[add] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/video_capturer.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/test/video_capturer.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/send_statistics_proxy.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/video_quality_test.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/vie_encoder.h
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/72acf2526177bb4dbb5103cd6e165eb4361a5ae6/webrtc/video_send_stream.h

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/8b45b11144c968b4173215c76f78c710c9a2ed0b

commit 8b45b11144c968b4173215c76f78c710c9a2ed0b
Author: skvlad <skvlad@webrtc.org>
Date: Tue Mar 21 20:26:06 2017

Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #14 id:250001 of https://codereview.webrtc.org/2716643002/ )

Reason for revert:
Breaks perf tests:
https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1679
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/2325

Original issue's description:
> Add framerate to VideoSinkWants and ability to signal on overuse
>
> In ViEEncoder, try to reduce framerate instead of resolution if the
> current degradation preference is maintain-resolution rather than
> balanced.
>
> BUG=webrtc:4172
>
> Review-Url: https://codereview.webrtc.org/2716643002
> Cr-Commit-Position: refs/heads/master@{#17327}
> Committed: https://chromium.googlesource.com/external/webrtc/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6

TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,sprang@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2764133002
Cr-Commit-Position: refs/heads/master@{#17331}

[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/call/bitrate_estimator_tests.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/call/call_perf_tests.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/fakevideocapturer.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/fakevideorenderer.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videoadapter.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videoadapter.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videocapturer.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videocapturer_unittest.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/base/videosourceinterface.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/engine/fakewebrtccall.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/engine/fakewebrtccall.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/BUILD.gn
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/call_test.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/frame_generator_capturer.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/frame_generator_capturer.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/vcm_capturer.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/vcm_capturer.h
[delete] https://crrev.com/e27f1e764ef45f6489cf192de843ca912a05a101/webrtc/test/video_capturer.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/test/video_capturer.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/send_statistics_proxy.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/video_quality_test.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/vie_encoder.h
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/8b45b11144c968b4173215c76f78c710c9a2ed0b/webrtc/video_send_stream.h

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18899fc19e8597057da7394d470cd955487ec733

commit 18899fc19e8597057da7394d470cd955487ec733
Author: sprang <sprang@chromium.org>
Date: Wed Mar 29 11:52:32 2017

Add workaround for type change in webrtc api.

As of cl https://codereview.webrtc.org/2781433002/ the max_pixel_count
type of rtc::VideoWinkWants will change from an Optional<int> to a plain
int. Until that CL has landed and been imported into Chrome, use a type
alias that will work with either.

BUG=webrtc:4172

Review-Url: https://codereview.chromium.org/2785683002
Cr-Commit-Position: refs/heads/master@{#460356}

[modify] https://crrev.com/18899fc19e8597057da7394d470cd955487ec733/content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51

commit 3ea3c77e93121b1ab9d5e46641e6764f2cca0d51
Author: sprang <sprang@webrtc.org>
Date: Thu Mar 30 14:23:48 2017

Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2764133002/ )

Reason for revert:
Found issue with test case, will add fix to reland cl.

Original issue's description:
> Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #14 id:250001 of https://codereview.webrtc.org/2716643002/ )
>
> Reason for revert:
> Breaks perf tests:
> https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1679
> https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/2325
>
> Original issue's description:
> > Add framerate to VideoSinkWants and ability to signal on overuse
> >
> > In ViEEncoder, try to reduce framerate instead of resolution if the
> > current degradation preference is maintain-resolution rather than
> > balanced.
> >
> > BUG=webrtc:4172
> >
> > Review-Url: https://codereview.webrtc.org/2716643002
> > Cr-Commit-Position: refs/heads/master@{#17327}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6
>
> TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,sprang@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4172
>
> Review-Url: https://codereview.webrtc.org/2764133002
> Cr-Commit-Position: refs/heads/master@{#17331}
> Committed: https://chromium.googlesource.com/external/webrtc/+/8b45b11144c968b4173215c76f78c710c9a2ed0b

TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2781433002
Cr-Commit-Position: refs/heads/master@{#17474}

[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/call/bitrate_estimator_tests.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/call/call_perf_tests.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/fakevideocapturer.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/fakevideorenderer.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videoadapter.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videoadapter.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videocapturer.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videocapturer_unittest.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/base/videosourceinterface.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/engine/fakewebrtccall.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/engine/fakewebrtccall.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/BUILD.gn
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/call_test.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/frame_generator_capturer.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/frame_generator_capturer.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/vcm_capturer.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/vcm_capturer.h
[add] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/video_capturer.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/test/video_capturer.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/send_statistics_proxy.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/video_quality_test.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/vie_encoder.h
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51/webrtc/video_send_stream.h

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/f9ed235c9b7248694edcb46feb1f29ce7456ab59

commit f9ed235c9b7248694edcb46feb1f29ce7456ab59
Author: lliuu <lliuu@webrtc.org>
Date: Thu Mar 30 17:44:38 2017

Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #8 id:410001 of https://codereview.webrtc.org/2781433002/ )

Reason for revert:
This has resulted in failure of CallPerfTest.ReceivesCpuOveruseAndUnderuse test on the Win7 build bot https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1780

Original issue's description:
> Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2764133002/ )
>
> Reason for revert:
> Found issue with test case, will add fix to reland cl.
>
> Original issue's description:
> > Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #14 id:250001 of https://codereview.webrtc.org/2716643002/ )
> >
> > Reason for revert:
> > Breaks perf tests:
> > https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1679
> > https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/2325
> >
> > Original issue's description:
> > > Add framerate to VideoSinkWants and ability to signal on overuse
> > >
> > > In ViEEncoder, try to reduce framerate instead of resolution if the
> > > current degradation preference is maintain-resolution rather than
> > > balanced.
> > >
> > > BUG=webrtc:4172
> > >
> > > Review-Url: https://codereview.webrtc.org/2716643002
> > > Cr-Commit-Position: refs/heads/master@{#17327}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6
> >
> > TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,sprang@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4172
> >
> > Review-Url: https://codereview.webrtc.org/2764133002
> > Cr-Commit-Position: refs/heads/master@{#17331}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/8b45b11144c968b4173215c76f78c710c9a2ed0b
>
> TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:4172
>
> Review-Url: https://codereview.webrtc.org/2781433002
> Cr-Commit-Position: refs/heads/master@{#17474}
> Committed: https://chromium.googlesource.com/external/webrtc/+/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51

TBR=ilnik@webrtc.org,stefan@webrtc.org,asapersson@webrtc.org,sprang@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2783183003
Cr-Commit-Position: refs/heads/master@{#17477}

[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/call/bitrate_estimator_tests.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/call/call_perf_tests.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/fakevideocapturer.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/fakevideorenderer.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videoadapter.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videoadapter.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videocapturer.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videocapturer_unittest.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/base/videosourceinterface.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/engine/fakewebrtccall.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/engine/fakewebrtccall.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/BUILD.gn
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/call_test.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/frame_generator_capturer.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/frame_generator_capturer.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/vcm_capturer.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/vcm_capturer.h
[delete] https://crrev.com/7a3615b6b394bfe12a0ab528dee0dd33620e0e63/webrtc/test/video_capturer.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/test/video_capturer.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/send_statistics_proxy.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/video_quality_test.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/vie_encoder.h
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/f9ed235c9b7248694edcb46feb1f29ce7456ab59/webrtc/video_send_stream.h

Project Member

Comment 27 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/c5d62e29ca21da19a89c0a287c2d5231afa6465a

commit c5d62e29ca21da19a89c0a287c2d5231afa6465a
Author: sprang <sprang@webrtc.org>
Date: Mon Apr 03 06:53:04 2017

Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2783183003/ )

Reason for revert:
Seem to be a flaky test rather than an issue with this cl. Creating reland, will add code to reduce flakiness to that test.

Original issue's description:
> Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #8 id:410001 of https://codereview.webrtc.org/2781433002/ )
>
> Reason for revert:
> This has resulted in failure of CallPerfTest.ReceivesCpuOveruseAndUnderuse test on the Win7 build bot https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1780
>
> Original issue's description:
> > Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2764133002/ )
> >
> > Reason for revert:
> > Found issue with test case, will add fix to reland cl.
> >
> > Original issue's description:
> > > Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #14 id:250001 of https://codereview.webrtc.org/2716643002/ )
> > >
> > > Reason for revert:
> > > Breaks perf tests:
> > > https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1679
> > > https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/2325
> > >
> > > Original issue's description:
> > > > Add framerate to VideoSinkWants and ability to signal on overuse
> > > >
> > > > In ViEEncoder, try to reduce framerate instead of resolution if the
> > > > current degradation preference is maintain-resolution rather than
> > > > balanced.
> > > >
> > > > BUG=webrtc:4172
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2716643002
> > > > Cr-Commit-Position: refs/heads/master@{#17327}
> > > > Committed: https://chromium.googlesource.com/external/webrtc/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6
> > >
> > > TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,sprang@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4172
> > >
> > > Review-Url: https://codereview.webrtc.org/2764133002
> > > Cr-Commit-Position: refs/heads/master@{#17331}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/8b45b11144c968b4173215c76f78c710c9a2ed0b
> >
> > TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=webrtc:4172
> >
> > Review-Url: https://codereview.webrtc.org/2781433002
> > Cr-Commit-Position: refs/heads/master@{#17474}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51
>
> TBR=ilnik@webrtc.org,stefan@webrtc.org,asapersson@webrtc.org,sprang@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4172
>
> Review-Url: https://codereview.webrtc.org/2783183003
> Cr-Commit-Position: refs/heads/master@{#17477}
> Committed: https://chromium.googlesource.com/external/webrtc/+/f9ed235c9b7248694edcb46feb1f29ce7456ab59

R=ilnik@webrtc.org,stefan@webrtc.org
BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2789823002
Cr-Commit-Position: refs/heads/master@{#17498}

[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/call/BUILD.gn
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/call/bitrate_estimator_tests.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/call/call_perf_tests.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/fakevideocapturer.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/fakevideorenderer.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videoadapter.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videoadapter.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videoadapter_unittest.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videocapturer.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videocapturer_unittest.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/base/videosourceinterface.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/engine/fakewebrtccall.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/engine/fakewebrtccall.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/BUILD.gn
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/call_test.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/frame_generator_capturer.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/frame_generator_capturer.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/vcm_capturer.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/vcm_capturer.h
[add] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/video_capturer.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/test/video_capturer.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/send_statistics_proxy.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/video_quality_test.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/vie_encoder.h
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/c5d62e29ca21da19a89c0a287c2d5231afa6465a/webrtc/video_send_stream.h

Project Member

Comment 28 by anatolid@chromium.org, May 9 2017

Erik, are we going to close this or more work is expected?
Project Member

Comment 29 by sprang@webrtc.org, May 10 2017

I'd like to verify performance more first, and then remove the experimental flags.
Project Member

Comment 30 by anatolid@chromium.org, May 10 2017

Labels: -M-59 M-60
Great, thanks for the update. I'll push it to M60 then.
Project Member

Comment 31 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/dceb42da3e7d24ffeee93e20c4ce1ce90953bf88

commit dceb42da3e7d24ffeee93e20c4ce1ce90953bf88
Author: sprang <sprang@webrtc.org>
Date: Tue May 23 13:45:08 2017

Update screen simulcast config and fix periodic encoder param update

Lower then bitrate so that the delta between the highest layer of the
lower stream and lowest layer of the higher stream is not too large.

Also fix a bug in vie_encoder where the codec was not perioducally
updated unless a new bitrate estimate was triggered.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2791273002
Cr-Commit-Position: refs/heads/master@{#18232}

[modify] https://crrev.com/dceb42da3e7d24ffeee93e20c4ce1ce90953bf88/webrtc/media/engine/simulcast.cc

Project Member

Comment 32 by anatolid@chromium.org, May 29 2017

Is this finished or should we bump to M61?
Project Member

Comment 33 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6c4bbfa06f0cdc9f1ba51757dc78ffc4547c5672

commit 6c4bbfa06f0cdc9f1ba51757dc78ffc4547c5672
Author: sprang <sprang@webrtc.org>
Date: Tue May 30 17:08:23 2017

Update max TL0 frame interval for screensharing.

The previous limit leaved no margin for RTT.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2911243002
Cr-Commit-Position: refs/heads/master@{#18333}

[modify] https://crrev.com/6c4bbfa06f0cdc9f1ba51757dc78ffc4547c5672/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

Project Member

Comment 34 by anatolid@chromium.org, May 31 2017

Labels: -M-60 M-61
Project Member

Comment 35 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/fda496a31e5c4d0aac98d3309eb288495748ba8f

commit fda496a31e5c4d0aac98d3309eb288495748ba8f
Author: sprang <sprang@webrtc.org>
Date: Thu Jun 15 11:21:07 2017

Set overuse detector max frame interval based on target frame rate.

Currently there is a hard limit for the estimated captured frame
interval of 45ms. As the encoder utilization is calculated as
(input frame interval)/(encode time), overuse signals can be triggered
even though there is plenty of time to go around if the fps is low.

However, in order to avoid falsly estimating low encode usage in case
the capturer has a dynamic frame rate, set the frame interval based on
the actual current max framerate.

BUG=webrtc:4172

Review-Url: https://codereview.webrtc.org/2918143003
Cr-Commit-Position: refs/heads/master@{#18610}

[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/encoder_rtcp_feedback_unittest.cc
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/overuse_frame_detector.cc
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/overuse_frame_detector.h
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/overuse_frame_detector_unittest.cc
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/vie_encoder.h
[modify] https://crrev.com/fda496a31e5c4d0aac98d3309eb288495748ba8f/webrtc/video/vie_encoder_unittest.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/02569adfd492d84e2e568f3512a67ab45b96fc34

commit 02569adfd492d84e2e568f3512a67ab45b96fc34
Author: sprang <sprang@webrtc.org>
Date: Thu Jul 06 12:05:50 2017

Update screen simulcast config

Lower then bitrate so that the delta between the highest layer of the
lower stream and lowest layer of the higher stream is not too large.

BUG=webrtc:4172

This is a reland of the following CL:

Review-Url: https://codereview.webrtc.org/2791273002
Cr-Commit-Position: refs/heads/master@{#18232}
Committed: https://chromium.googlesource.com/external/webrtc/+/dceb42da3e7d24ffeee93e20c4ce1ce90953bf88

https: //codereview.webrtc.org/2883963002
Review-Url: https://codereview.webrtc.org/2966833002
Cr-Commit-Position: refs/heads/master@{#18913}

[modify] https://crrev.com/02569adfd492d84e2e568f3512a67ab45b96fc34/webrtc/media/engine/simulcast.cc

Project Member

Comment 37 by anatolid@webrtc.org, Aug 14 2017

Shall we bump this to M62?
Project Member

Comment 38 by sprang@webrtc.org, Aug 15 2017

Labels: -M-61 M-62
Project Member

Comment 39 by anatolid@webrtc.org, Sep 4 2017

Shall we bump this to M63? Or maybe remove the label altogether if the ETA is unclear?
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d692ef9749d6b77bc341b243046dcef3ba733069

commit d692ef9749d6b77bc341b243046dcef3ba733069
Author: Niels Möller <nisse@webrtc.org>
Date: Thu Oct 05 07:26:20 2017

Update comments for rename of ScalingObserverInterface.

Was renamed to AdaptationObserverInterface in cl
https://codereview.webrtc.org/2652893015/.

Bug: webrtc:4172
Change-Id: Ie2194a1fd5fe985913716963292af701006f18dd
Reviewed-on: https://webrtc-review.googlesource.com/6420
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20155}
[modify] https://crrev.com/d692ef9749d6b77bc341b243046dcef3ba733069/modules/video_coding/utility/quality_scaler.h
[modify] https://crrev.com/d692ef9749d6b77bc341b243046dcef3ba733069/video/video_stream_encoder.h

Project Member

Comment 41 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/28a06b16cc4daa9f380ad45af8acfd11b6057283

commit 28a06b16cc4daa9f380ad45af8acfd11b6057283
Author: Erik Språng <sprang@webrtc.org>
Date: Mon Dec 18 15:28:39 2017

Smoother frame dropping when screenshare_layers limits fps

Currently, when input fps is higher than the configured target fps in
screenshare_layers, we drop frames with the help of a rate tracker using
a one second sliding window. This is not optimal.
For instance, given a 5fps limit and a 30fps capturer, the window will
not be saturated until we have added the first 5 frames. Then we will
drop all frames until the oldest one drops out, at which point we can
immediately fill it's place. This results in quick 5 frame bursts every
second.

In addition to rate tracker, also set a limit on minimum interval
required between input frames, based on target frame rate.

Bug: webrtc:4172
Change-Id: I49f0abf4d549673cc6b3fafe580b529ea3feaf57
Reviewed-on: https://webrtc-review.googlesource.com/34380
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21325}
[modify] https://crrev.com/28a06b16cc4daa9f380ad45af8acfd11b6057283/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/28a06b16cc4daa9f380ad45af8acfd11b6057283/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/afb3fc35581b91dc8b967fd5c5af1222e06532d0

commit afb3fc35581b91dc8b967fd5c5af1222e06532d0
Author: Erik Språng <sprang@webrtc.org>
Date: Tue Dec 19 11:21:11 2017

Revert "Smoother frame dropping when screenshare_layers limits fps"

This reverts commit 28a06b16cc4daa9f380ad45af8acfd11b6057283.

Reason for revert: Causes some unexpected perf changes.

Original change's description:
> Smoother frame dropping when screenshare_layers limits fps
> 
> Currently, when input fps is higher than the configured target fps in
> screenshare_layers, we drop frames with the help of a rate tracker using
> a one second sliding window. This is not optimal.
> For instance, given a 5fps limit and a 30fps capturer, the window will
> not be saturated until we have added the first 5 frames. Then we will
> drop all frames until the oldest one drops out, at which point we can
> immediately fill it's place. This results in quick 5 frame bursts every
> second.
> 
> In addition to rate tracker, also set a limit on minimum interval
> required between input frames, based on target frame rate.
> 
> Bug: webrtc:4172
> Change-Id: I49f0abf4d549673cc6b3fafe580b529ea3feaf57
> Reviewed-on: https://webrtc-review.googlesource.com/34380
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21325}

TBR=ilnik@webrtc.org,sprang@webrtc.org

Change-Id: I7ca5b0c847310dbb11dce28773082eac946c0ba4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:4172
Reviewed-on: https://webrtc-review.googlesource.com/34780
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21354}
[modify] https://crrev.com/afb3fc35581b91dc8b967fd5c5af1222e06532d0/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/afb3fc35581b91dc8b967fd5c5af1222e06532d0/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Jan 12

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/27a457d172677b8906d26ad3fb779133c9d97d9d

commit 27a457d172677b8906d26ad3fb779133c9d97d9d
Author: Erik Språng <sprang@webrtc.org>
Date: Fri Jan 12 14:40:40 2018

Smoother frame dropping when screenshare_layers limits fps

This is a reland of https://webrtc-review.googlesource.com/34380

The main problem with that CL was that we used frame timestamps as basis
for frame dropping, but those might not be continuous or even populated
in some circumstances.

Additionally, I found that the bitrate was off since the encoder does
not not take the dropped frames into account, so if we drop every other
frame continiusoly, the bitrate sent will be around half of the target.

Patch set 1 is the original CL, subsequent patch sets cotains fixes.

Bug: webrtc:4172
Change-Id: I8ec8dddcebf4ce44f28dd9055cf9c46bbd68e4a6
Reviewed-on: https://webrtc-review.googlesource.com/39201
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21601}
[modify] https://crrev.com/27a457d172677b8906d26ad3fb779133c9d97d9d/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/27a457d172677b8906d26ad3fb779133c9d97d9d/modules/video_coding/codecs/vp8/screenshare_layers.h
[modify] https://crrev.com/27a457d172677b8906d26ad3fb779133c9d97d9d/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Jan 22

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/db9e9d5486c40f4b78513fedc79b9b22ad3e5751

commit db9e9d5486c40f4b78513fedc79b9b22ad3e5751
Author: Erik Språng <sprang@webrtc.org>
Date: Mon Jan 22 21:15:29 2018

Make screenshare_layers frame dropper less aggressive

Try to use frame timestamps first if they look reasonable, otherwise
use realtime clock.
Also, lower limit from 90% of target to 85%.

Bug: webrtc:4172, chromium:802290
Change-Id: Iad489be7c7cf637345be4795e5089936ab9fab07
Reviewed-on: https://webrtc-review.googlesource.com/41041
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21729}
[modify] https://crrev.com/db9e9d5486c40f4b78513fedc79b9b22ad3e5751/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/db9e9d5486c40f4b78513fedc79b9b22ad3e5751/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Feb 2

Labels: merge-merged-65
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8faa0889cccd94d0f2cf57f7f26b76b22a51315e

commit 8faa0889cccd94d0f2cf57f7f26b76b22a51315e
Author: Erik Språng <sprang@webrtc.org>
Date: Fri Feb 02 14:26:17 2018

Merge to M65: Make screenshare_layers frame dropper less aggressive

Try to use frame timestamps first if they look reasonable, otherwise
use realtime clock.
Also, lower limit from 90% of target to 85%.

Original Change Id: Iad489be7c7cf637345be4795e5089936ab9fab07
Originally Reviewed On: https://webrtc-review.googlesource.com/41041

Bug: webrtc:4172, chromium:802290
Change-Id: Iad489be7c7cf637345be4795e5089936ab9fab07
Reviewed-on: https://webrtc-review.googlesource.com/47440
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/branch-heads/65@{#9}
Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637}
[modify] https://crrev.com/8faa0889cccd94d0f2cf57f7f26b76b22a51315e/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/8faa0889cccd94d0f2cf57f7f26b76b22a51315e/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Sign in to add a comment