New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 4135 link

Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

WebRtcVideoMediaChannelSimulcastTest.SimulcastSend tests flaky

Project Member Reported by kjellander@webrtc.org, Jan 3 2015

Issue description

What steps will reproduce the problem?
1. Build WebRTC on Windows
2. Run libjingle_media_unittest

What is the expected result?
The test should always pass

What do you see instead?
One of the WebRtcVideoMediaChannelSimulcastTest.SimulcastSend_* tests sometimes flakes out and fails like this:
[ RUN      ] WebRtcVideoMediaChannelSimulcastTest.SimulcastSend_1280x720
e:\b\build\slave\win\build\src\talk\media\webrtc\webrtcvideoengine_unittest.cc(2972): error: Value of: NumRtpPackets()
  Actual: 4
Expected: total_num_packets
Which is: 3
e:\b\build\slave\win\build\src\talk\media\webrtc\webrtcvideoengine_unittest.cc(2973): error: Value of: NumRtpBytes()
  Actual: 1106
Expected: total_num_bytes
Which is: 870
[  FAILED  ] WebRtcVideoMediaChannelSimulcastTest.SimulcastSend_1280x720 (110 ms)

Examples:
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release/builds/3461/steps/libjingle_media_unittest/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release/builds/3467/steps/libjingle_media_unittest/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release/builds/3419/steps/libjingle_media_unittest/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/3346/steps/libjingle_media_unittest/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Win64%20Release/builds/3381/steps/libjingle_media_unittest/logs/stdio

Please use labels and text to provide additional information.

 
Project Member

Comment 1 by kjellander@webrtc.org, Jan 3 2015

Cc: stefan@webrtc.org
Project Member

Comment 2 by pbos@webrtc.org, Jan 4 2015

Cc: pthatcher@webrtc.org mflodman@webrtc.org
Labels: -OS-Windows OS-All
Status: Available
Summary: WebRtcVideoMediaChannelSimulcastTest.SimulcastSend tests flaky (was: WebRtcVideoMediaChannelSimulcastTest.SimulcastSend tests flaky on Windows)
Looks to me like SetSend(false) doesn't completely stop all packets. I think RTCP packets are possibly sent even though the channels aren't sending, not sure if that accounts for this difference, but it looks like one more packet than expected has been sent before stats are checked.

I'm not sure who should have this, these tests have been broken for as long as I can remember. +cc'ing a few people, mflodman@, let me know if I should bump my priorities on this one, otherwise I'll let it stay marked as Available.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d95435c17ae13670b3a41ee6153a93c5f6eb9118

commit d95435c17ae13670b3a41ee6153a93c5f6eb9118
Author: kjellander@webrtc.org <kjellander@webrtc.org>
Date: Tue Jan 06 11:01:35 2015

Disable WebRtcVideoMediaChannelSimulcastTest.SimulcastSend tests on Win

These tests have turned out to be flaky on Windows.

BUG=4135
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8004 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/d95435c17ae13670b3a41ee6153a93c5f6eb9118/talk/media/webrtc/webrtcvideoengine_unittest.cc

Project Member

Comment 4 by stefan@webrtc.org, Jan 7 2015

Sounds to me like a good way to fix this would be to only count RTP packets and not RTCP?
Project Member

Comment 5 by mflodman@webrtc.org, Jan 7 2015

Start/Stop Send used to decide if we should send RTCP SR or RR, RTCP was sent as long as there was a valid transport attached to the channel. IIRC.

With the new API and the removal of duplex channels, StopSend should stop RTCP and not only RTP. SR/RR will be decided by the nature of the channel/stream.
Project Member

Comment 6 by stefan@webrtc.org, Jan 7 2015

Right, so then this should be fixed with the new API?
Project Member

Comment 7 by pbos@webrtc.org, Jan 7 2015

SGTM. It's not implemented like that right now I think, but we should follow up with that in the future.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/07c83a13857c11e324a8966914c2ca30be365114

commit 07c83a13857c11e324a8966914c2ca30be365114
Author: kjellander@webrtc.org <kjellander@webrtc.org>
Date: Wed Jan 07 10:36:53 2015

Disable WebRtcVideoMediaChannelSimulcastTest.SimulcastSend tests on Win (take 2)

In https://webrtc-codereview.appspot.com/35669004/ the wrong
define was used (OS_WIN only exists in Chromium code).

BUG=4135
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8008 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/07c83a13857c11e324a8966914c2ca30be365114/talk/media/webrtc/webrtcvideoengine_unittest.cc

Project Member

Comment 9 by juberti@webrtc.org, Jan 7 2015

Labels: Area-Network
Project Member

Comment 10 by pthatcher@webrtc.org, Jan 12 2015

Labels: mstone-44 EngTriaged
Owner: decurtis@webrtc.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ff9462eb540023b1ff8d0fda860504121a3b6f8a

commit ff9462eb540023b1ff8d0fda860504121a3b6f8a
Author: sprang@webrtc.org <sprang@webrtc.org>
Date: Mon Jan 19 12:06:35 2015

Disable WebRtcVideoMediaChannelSimulcastTest::SimulcastSend_* on tsan.

Tests are flaky on tsan, disabling for now.

BUG=4135
R=kjellander@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36839004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8089 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/ff9462eb540023b1ff8d0fda860504121a3b6f8a/talk/media/webrtc/webrtcvideoengine_unittest.cc

Project Member

Comment 12 by juberti@webrtc.org, Feb 1 2016

Labels: -Mstone-44
Owner: pthatcher@webrtc.org
Project Member

Comment 13 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 14 by anatolid@webrtc.org, Dec 14 2016

Owner: ----
Project Member

Comment 15 by sheriffbot@chromium.org, Sep 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.


Project Member

Comment 16 by anatolid@webrtc.org, Nov 1

Status: Available (was: Untriaged)
[bulk-edit] Setting status to Available since it's likely that this issue shouldn't be archived yet. Also changing Pri to 3 due to long period of inactivity (indicating low priority).

Sign in to add a comment