New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 4134 link

Starred by 7 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

RelayServerTest.TestExpiration in rtc_unittests is flaky

Project Member Reported by kjellander@webrtc.org, Jan 3 2015

Issue description

What steps will reproduce the problem?
1. Build rtc_unittests on Mac
2. Run rtc_unittests

What is the expected result?
All tests pass.

What do you see instead?
Sometimes the RelayServerTest.TestExpiration is flaky and fails like this:

[ RUN      ] RelayServerTest.TestExpiration
../../webrtc/p2p/base/relayserver_unittest.cc:511: Failure
Value of: res.get() != NULL
  Actual: false
Expected: true
[  FAILED  ] RelayServerTest.TestExpiration (9002 ms)

This was first seen at
http://build.chromium.org/p/client.webrtc/builders/Mac32%20Debug/builds/3051/steps/rtc_unittests/logs/stdio
which makes me think https://code.google.com/p/webrtc/source/detail?r=7977 is related.

More failures:
http://build.chromium.org/p/client.webrtc/builders/Mac32%20Release/builds/3309/steps/rtc_unittests/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/3145/steps/rtc_unittests/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Mac32%20Debug/builds/3059/steps/rtc_unittests/logs/stdio

Please use labels and text to provide additional information.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/aeb0dd30791c8d3f2954038d0a73c60c2e00565c

commit aeb0dd30791c8d3f2954038d0a73c60c2e00565c
Author: kjellander@webrtc.org <kjellander@webrtc.org>
Date: Sat Jan 03 17:47:05 2015

Disable RelayServerTest.TestExpiration on Mac.

The test is flaky on Mac.
BUG=4134
TBR=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7992 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/aeb0dd30791c8d3f2954038d0a73c60c2e00565c/webrtc/p2p/base/relayserver_unittest.cc

Project Member

Comment 3 by pbos@webrtc.org, Jan 4 2015

Labels: -OS-Mac OS-All
Summary: RelayServerTest.TestExpiration in rtc_unittests is flaky (was: RelayServerTest.TestExpiration in rtc_unittests is flaky on Mac)
Nothing indicating that this is Mac-only. :)
Project Member

Comment 4 by andrew@webrtc.org, Jan 5 2015

This has also popped up frequently on Linux Memcheck of late:
http://chromegw/i/client.webrtc/builders/Linux%20Memcheck/builds/2999

I'm disabling it for all platforms.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/4796cb93dc80f7921a1724e5da87a1bbb0fc3717

commit 4796cb93dc80f7921a1724e5da87a1bbb0fc3717
Author: andrew@webrtc.org <andrew@webrtc.org>
Date: Mon Jan 05 23:56:19 2015

Disable flaky RelayServerTest.TestExpiration on all platforms.

BUG=4134
TBR=pthatcher

Review URL: https://webrtc-codereview.appspot.com/37529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8001 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/4796cb93dc80f7921a1724e5da87a1bbb0fc3717/webrtc/p2p/base/relayserver_unittest.cc

Project Member

Comment 6 by juberti@webrtc.org, Jan 7 2015

Labels: Area-Network
Project Member

Comment 7 by pthatcher@webrtc.org, Jan 12 2015

Labels: EngTriaged Mstone-43
Owner: guoweis@webrtc.org
We should probably just delete RelayServer.
Project Member

Comment 8 by vikasmarwaha@webrtc.org, Mar 31 2015

should we keep same milestone or update it?
Project Member

Comment 9 by pthatcher@webrtc.org, Apr 1 2015

Labels: -Mstone-43 Mstone-44
Project Member

Comment 10 by pthatcher@webrtc.org, Feb 8 2016

Labels: -Mstone-44
Owner: deadbeef@webrtc.org
Project Member

Comment 11 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 12 by deadbeef@chromium.org, Apr 3 2018

Owner: ----
Status: Available (was: Assigned)
Clearing owner and setting status to Available, since there haven't been any updates for > 1 year. Will be assigned again once priority is high enough.

Sign in to add a comment