New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cricket::P2PTransportChannel::OnUnknownAddress duplicates connection creation logic

Reported by aab11223...@hotmail.com, Dec 28 2014 Back to list

Issue description

What steps will reproduce the problem?
1. look @ cricket::P2PTransportChannel::OnUnknownAddress

What is the expected result?
uses cricket::P2PTransportChannel::CreateConnection to create prflx connections if needed.

What do you see instead?
subset (e.g. some checks and logging missing) logic in cricket::P2PTransportChannel::CreateConnection is duplicated.

What version of the product are you using? On what operating system?
r7977

Please provide any additional information below.
attached patch just reuses cricket::P2PTransportChannel::CreateConnection in  cricket::P2PTransportChannel::OnUnknownAddress. was useful for me since e.g. does stuff log connection creates, etc.

 
03-p2ptransortchannel-cxn-code-dedup.diff
1.1 KB Download
Project Member

Comment 1 by braveyao@webrtc.org, Dec 29 2014

Cc: braveyao@webrtc.org
Labels: Area-Network
Owner: jiayl@webrtc.org
@jiay, please help to evaluate this!

Comment 2 Deleted

Project Member

Comment 3 by pthatcher@webrtc.org, Dec 29 2014

Labels: EngTriaged
Owner: guoweis@webrtc.org
Guoweis, can you work to land this patch?

Please make sure the author fills in one of the agreements at:

http://www.webrtc.org/contributing#TOC-Contributor-Agreement and get added to the AUTHORS file.


Project Member

Comment 4 by guoweis@webrtc.org, Jan 10 2015

In CreateConnection, a look up is done to make sure there is no existing connection with that remote candidate address. A similar but not exactly the same check was done priority to invoke port->CreateConnection inside the OnUnknownAddress.

I'm not totally sure about this change. However, if you could tell me which logging you think is missing, we could consider adding it instead.

Does this address your concern? 
Project Member

Comment 5 by pthatcher@webrtc.org, Feb 8 2016

Owner: honghaiz@webrtc.org
Honghai, can you take a quick look and see if this is worth taking still?  This code has changed a lot in the last year.
Project Member

Comment 6 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 7 by anatolid@chromium.org, Dec 5 2016

Status: Assigned
[bulk-edit] This issue appears to have been triaged (as evidenced by the presence of the EngTriaged label) and also has an Owner -- hence, changing its status to Assigned. If the currently set Owner is wrong, then please re-assign to a correct Owner, or remove Owner and set status to Available.
Project Member

Comment 8 by deadbeef@chromium.org, Apr 3

Owner: ----
Status: Available
Clearing owner and setting status to Available, since there haven't been any updates for > 1 year. Will be assigned again once priority is high enough.

Sign in to add a comment