New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users
Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
Implement RTP/RTCP extensions for mid value transport
Reported by docfara...@gmail.com, Nov 25 2014 Back to list
Looking at the webrtc.org code, it does not appear that there is support for setting the mid of an RTP stream for the purpose of satisfying draft-ietf-mmusic-sdp-bundle-negotiation-12 Section 13.
 
Project Member Comment 1 by braveyao@webrtc.org, Nov 27 2014
Cc: braveyao@webrtc.org
Owner: juberti@webrtc.org
@justin, any comment?
Project Member Comment 2 by juberti@webrtc.org, Dec 16 2014
Labels: Area-Network
Owner: pthatcher@webrtc.org
Not implemented yet.
Project Member Comment 3 by pthatcher@webrtc.org, Dec 29 2014
Labels: EngTriaged Mstone-44
Status: Assigned
Project Member Comment 4 by tnakamura@webrtc.org, Jan 29 2016
Labels: -Mstone-44
I don't see any CLs linked to this bug, so I don't think it's been fixed. I'm therefore leaving this in an open state, but I am removing the milestone label since this bug hasn't been updated in quite some time.
Project Member Comment 5 by bugdroid1@chromium.org, Jul 21 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a3251dd83f2e3d988e32504a62ec2cf9bba06585

commit a3251dd83f2e3d988e32504a62ec2cf9bba06585
Author: Steve Anton <steveanton@webrtc.org>
Date: Fri Jul 21 17:33:25 2017

Add parsing/serializing for MID RTP header extension.

This is the first in a series of CLs to add support for media
identification as part of unified plan SDP.

Bug: webrtc:4050
Change-Id: I0eb5639d240a9a1412c2b047a33d5112e4901f26
Reviewed-on: https://chromium-review.googlesource.com/576374
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19111}
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/common_types.h
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/source/rtp_header_extension_map.cc
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/source/rtp_packet.cc
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
[modify] https://crrev.com/a3251dd83f2e3d988e32504a62ec2cf9bba06585/webrtc/test/fuzzers/rtp_packet_fuzzer.cc

Project Member Comment 6 by bugdroid1@chromium.org, Aug 17
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/b3329179a712212083209d5c44814d4cc6587904

commit b3329179a712212083209d5c44814d4cc6587904
Author: Steve Anton <steveanton@webrtc.org>
Date: Thu Aug 17 23:01:59 2017

Rename RsidResolutionObserver to SsrcBindingObserver.

This rename prepares SsrcBindingObserver to be used for observing all
the ways a sink can be bound to SSRCs (e.g., MID, payload types).

Bug: webrtc:4050
Change-Id: I16b68481d01f921c326a33f5f2baf79d8b3f12e2
Reviewed-on: https://chromium-review.googlesource.com/590762
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19396}
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/BUILD.gn
[delete] https://crrev.com/ed447aedb855f7e6141fe627c16c27b800348b0c/webrtc/call/rsid_resolution_observer.h
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/rtcp_demuxer.cc
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/rtcp_demuxer.h
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/rtcp_demuxer_unittest.cc
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/rtp_demuxer.cc
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/rtp_demuxer.h
[modify] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/rtp_demuxer_unittest.cc
[add] https://crrev.com/b3329179a712212083209d5c44814d4cc6587904/webrtc/call/ssrc_binding_observer.h

Project Member Comment 7 by bugdroid1@chromium.org, Aug 18
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/53c7ba632d587b449122e03d7c5e74b12e5d24ab

commit 53c7ba632d587b449122e03d7c5e74b12e5d24ab
Author: Steve Anton <steveanton@webrtc.org>
Date: Fri Aug 18 17:33:08 2017

Add BUNDLE processing to RtpDemuxer.

Extends the RtpDemuxer to do demuxing according to the BUNDLE spec,
using MID and payload types in addition to RSID and SSRC. Also extends
SsrcBindingObserver to receive notification for all types of SSRC
binding that can occur with the new algorithm.

Bug: webrtc:4050
Change-Id: Ie2f347f90d5074ab537fa1162fa7314dd292b68b
Reviewed-on: https://chromium-review.googlesource.com/578628
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19415}
[modify] https://crrev.com/53c7ba632d587b449122e03d7c5e74b12e5d24ab/webrtc/call/rtp_demuxer.cc
[modify] https://crrev.com/53c7ba632d587b449122e03d7c5e74b12e5d24ab/webrtc/call/rtp_demuxer.h
[modify] https://crrev.com/53c7ba632d587b449122e03d7c5e74b12e5d24ab/webrtc/call/rtp_demuxer_unittest.cc
[modify] https://crrev.com/53c7ba632d587b449122e03d7c5e74b12e5d24ab/webrtc/call/rtp_rtcp_demuxer_helper.h
[modify] https://crrev.com/53c7ba632d587b449122e03d7c5e74b12e5d24ab/webrtc/call/ssrc_binding_observer.h

Project Member Comment 8 by anatolid@chromium.org, Sep 11
Is there more work planned here?
Project Member Comment 9 by deadbeef@chromium.org, Sep 11
Yes; we still need to make use of the MID-based demuxing now in RtpDemuxer, and we also need to negotiate use of the header extension and send it when negotiated.
Sign in to add a comment