New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

libjingle related memory tests issue, tsan/lsan/memcheck/dmemory etc

Reported by wu@webrtc.org, Jul 25 2014

Issue description

Comment 1 by wu@webrtc.org, Jul 25 2014

 Issue 2078  has been merged into this issue.

Comment 2 by wu@webrtc.org, Jul 25 2014

Cc: perkj@webrtc.org
 Issue 1205  has been merged into this issue.

Comment 3 by wu@webrtc.org, Jul 25 2014

Cc: kjellander@webrtc.org
 Issue 2100  has been merged into this issue.

Comment 4 by wu@webrtc.org, Jul 25 2014

 Issue 2263  has been merged into this issue.

Comment 5 by wu@webrtc.org, Jul 25 2014

 Issue 2527  has been merged into this issue.

Comment 6 by wu@webrtc.org, Jul 25 2014

 Issue 2528  has been merged into this issue.

Comment 7 by wu@webrtc.org, Jul 25 2014

 Issue 3158  has been merged into this issue.

Comment 8 by wu@webrtc.org, Jul 25 2014

Cc: mflodman@webrtc.org henrike@webrtc.org
 Issue 3324  has been merged into this issue.

Comment 9 by wu@webrtc.org, Jul 25 2014

 Issue 3345  has been merged into this issue.
Project Member

Comment 10 by kjellander@webrtc.org, Sep 3 2014

Owner: pbos@webrtc.org
Status: Assigned
pbos@ will hopefully be able to do some suppression work for LSan, so we can enable it in the main waterfall. Today we have a bot in FYI that has been red for ages: http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20LSan%20%28and%20ASan%29
Project Member

Comment 11 by pbos@webrtc.org, Sep 3 2014

For my memory suppressions are here: tools/lsan/suppressions.txt
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 8 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7098

------------------------------------------------------------------
r7098 | kjellander@webrtc.org | 2014-09-08T10:06:37.006726Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/DEPS&spec=svn7098&r_previous=7097&r=7098&format=side

Roll chromium_revision 94532b1..ea769fd

Summary of changes (git diff 94532b1..ea769fd DEPS):
* buildtools 2328da4..ea4dc0e
* third_party/android_tools 3186999..7fc902d
* third_party/boringssl 6c7aed0..7bdec13
* third_party/libjpeg_turbo 2ed5319..3963fbc
* third_party/libvpx 982d147..ceebbcc (r291730:291805)
* third_party/nss 90c5f9a..7b5b6ec
* third_party/usrsctp/usrsctplib e6e1833..8975bd5

BUG=3608
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19279004
-----------------------------------------------------------------
Project Member

Comment 13 by vikasmarwaha@webrtc.org, Oct 17 2014

 Issue 2263  has been merged into this issue.
Project Member

Comment 14 by vikasmarwaha@webrtc.org, Oct 17 2014

Status: Available
Project Member

Comment 15 by pbos@webrtc.org, Dec 1 2014

Cc: pbos@webrtc.org
Owner: ----
LSan+MSan are enabled in the main waterfall now and I've no immediate plans to do any additional work here.

There's tools/lsan/suppressions.txt which would be worth removing leak suppressions from.
Project Member

Comment 16 by hta@webrtc.org, Mar 8 2016

Note - peerconnection_unittest.cc still has an #if !defined(THREAD_SANITIZER) in it (referencing  bug 1205 ) rather than using suppressions. There's a scattering of them elsewhere too. Should there be a witch-hunt to get them to use suppressions instead?

Project Member

Comment 17 by kjellander@webrtc.org, Mar 8 2016

Suppressions can only be used when there's a sanitizer error produced when running the test. If the test is simply just failing when being run under TSan (without producing sanitizer errors), it needs to be disabled with an ifdef (or for some of the older tools, by adding an entry in a matching txt file in https://chromium.googlesource.com/external/webrtc/+/master/tools/valgrind-webrtc/gtest_exclude). 

I would guess the case for peerconnection_unittest.cc is the latter.
Project Member

Comment 19 by kjellander@webrtc.org, Dec 1 2016

Cc: -henrike@webrtc.org

Sign in to add a comment