New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CommonFormats/AudioProcessingTest take too long

Project Member Reported by andresp@webrtc.org, Jul 8 2014

Issue description

There seems to be around 47 formats and each tests takes like 20 seconds...
This is 16mins of the total 26mins duration of modules_unittests.

Can this be reduced?

Can the formats be tested faster? in parallel?
Can the test be moved into modules_tests?
 
Project Member

Comment 1 by bjornv@webrtc.org, Jul 9 2014

Labels: Area-SignalProcessing
Moving it to modules_tests sounds like a good first step at least since its character is more of integration test rather than unit test.
We should then definitely try to reduce the process time. Thanks for creating the bug
Project Member

Comment 2 by tina.legrand@webrtc.org, Oct 30 2014

Labels: EngTriaged IceBox
Project Member

Comment 3 by bjornv@webrtc.org, May 26 2015

Cc: bjornv@webrtc.org
Project Member

Comment 4 by bjornv@webrtc.org, Jun 9 2015

Cc: -bjornv@webrtc.org henrik.lundin@webrtc.org tina.legrand@webrtc.org
Owner: ----
Status: Available
Project Member

Comment 5 by henrik.lundin@webrtc.org, Nov 18 2015

Cc: -henrik.lundin@webrtc.org solenberg@webrtc.org pbos@webrtc.org
Owner: henrik.lundin@webrtc.org
Project Member

Comment 6 by henrik.lundin@webrtc.org, Nov 18 2015

Cc: andrew@webrtc.org kwiberg@webrtc.org
 Issue 4713  has been merged into this issue.
Project Member

Comment 7 by pbos@webrtc.org, Nov 18 2015

Labels: -IceBox
They're now tested in parallel, I think the reasonable path here is to reduce per-test time if that's feasible, or reduce the number of combinations tested.

Also I wanna thaw this (-IceBox) because we've done some work on reducing trybot/buildbot times and this is currently a Major Blocker, yessir!
Project Member

Comment 8 by tina.legrand@webrtc.org, Nov 19 2015

Labels: IceBox
Adding back Icebox, until we start the work.
Project Member

Comment 9 by henrik.lundin@webrtc.org, Nov 25 2015

Components: Audio
Labels: fixit
Project Member

Comment 10 by henrik.lundin@webrtc.org, Oct 5 2016

Components: -SignalProcessing
Project Member

Comment 11 by tina.legrand@webrtc.org, Nov 16 2016

Status: Assigned (was: Available)
Project Member

Comment 12 by tina.legrand@webrtc.org, Nov 10 2017

Henrik, is this still relevant?
Project Member

Comment 13 by henrik.lundin@webrtc.org, Nov 17 2017

Yes, this is still relevant. There are 48 tests in this suite, and they take 180 seconds in total to run (on my Linux Z620).

Sign in to add a comment