New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2015
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 3520



Sign in to add a comment

Implement send-side bit-exactness test for ACM

Project Member Reported by henrik.lundin@webrtc.org, Jun 27 2014

Issue description

This is part of the ACM redesign project.

 
Project Member

Comment 1 by henrik.lundin@webrtc.org, Jun 27 2014

Blocking: webrtc:3520
Project Member

Comment 2 by henrik.lundin@webrtc.org, Aug 15 2014

Status: Started
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6949

------------------------------------------------------------------
r6949 | henrik.lundin@webrtc.org | 2014-08-21T08:59:14.894368Z

Changed paths:
   A http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/acm2/acm_send_test.cc&spec=svn6949&r_previous=6948&r=6949&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc&spec=svn6949&r_previous=6948&r=6949&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/modules.gyp&spec=svn6949&r_previous=6948&r=6949&format=side
   A http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/acm2/acm_send_test.h&spec=svn6949&r_previous=6948&r=6949&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi&spec=svn6949&r_previous=6948&r=6949&format=side

Add send-side bit-exactness test for AudioCoding Module

This test verifies bit exactness for the send-side of ACM. The test
setup is a chain of three different test classes:

test::AcmSendTest -> AcmSenderBitExactness -> test::AcmReceiveTest

The receiver side is driving the test by requesting new packets from
AcmSenderBitExactness::NextPacket(). This method, in turn, asks for the
packet from test::AcmSendTest::NextPacket, which inserts audio from the
input file until one packet is produced. (The input file loops
indefinitely.)  Before passing the packet to the receiver, the
AcmSenderBitExactness class verifies the packet header and updates a
payload checksum with the new payload. The decoded output from the
receiver is also verified with a (separate) checksum.

The current CL only adds tests for 30 ms and 60 ms iSAC. More codecs
will be added in coming changes.

BUG= 3521 
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20179004
-----------------------------------------------------------------
Project Member

Comment 5 by tina.legrand@webrtc.org, Oct 30 2014

Labels: EngTriaged Mstone-41
Project Member

Comment 6 by vikasmarwaha@webrtc.org, Jan 8 2015

still target for m41 or should we update milestone?
Project Member

Comment 7 by henrik.lundin@webrtc.org, Jan 9 2015

Labels: -Pri-1 -Mstone-41 Pri-2 Mstone-42
I'm probably going to do more work under this issue. Bumping to M42.
Project Member

Comment 8 by jansson@webrtc.org, Feb 17 2015

M42 still realistic? If not please bump.
Project Member

Comment 9 by henrik.lundin@webrtc.org, Feb 17 2015

Status: Fixed
Even though no more work has been attributed to this issue, I think we can mark this as done for now.
Project Member

Comment 10 by tnakamura@webrtc.org, Feb 27 2015

Cc: tnakamura@webrtc.org
Status: Verified
Since it looks like tests were added (#3, #4), I'm marking this as verified.
Project Member

Comment 11 by kjellander@webrtc.org, Oct 5 2016

Labels: M-42

Sign in to add a comment