New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 3514 link

Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

libjingle_peerconnection_unittest fails Linux Memcheck

Project Member Reported by kjellander@webrtc.org, Jun 25 2014

Issue description

What steps will reproduce the problem?
1. Sync WebRTC r6517 in a Linux workspace with Valgrind setup (see www.chromium.org/developers/how-tos/using-valgrind/building-valgrind)
2. GYP_DEFINES=build_for_tool=memcheck webrtc/build/gyp_webrtc
3. Compile 
4. Run tools/valgrind-webrtc/webrtc_tests.sh --test libjingle_peerconnection_unittest --tool memcheck --target Release --build-dir out

What is the expected result?
I expect the tests to pass and no memory warnings to be created.

What do you see instead?
Test fails sometimes, like this:

The PeerConnectionEndToEndTest.DataChannelIdAssignment test fails
flakily like this:
[----------] 1 test from PeerConnectionEndToEndTest
[ RUN ] PeerConnectionEndToEndTest.DataChannelIdAssignment
WARNING: no real random source present!
../../talk/app/webrtc/test/peerconnectiontestwrapper.cc:216: Failure
Value of: CheckForConnection()
Actual: false
Expected: true
[ FAILED ] PeerConnectionEndToEndTest.DataChannelIdAssignment (13215 ms)
[----------] 1 test from PeerConnectionEndToEndTest (13223 ms total)

It's probably timing related.
Example: http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/1938/steps/libjingle_peerconnection_unittest/logs/stdio

Please use labels and text to provide additional information.

I should have referred to this when I committed r6518.
 

Comment 1 by vrk@webrtc.org, Oct 14 2014

Labels: Area-Network

Comment 2 by vrk@webrtc.org, Nov 3 2014

Labels: EngTriaged Mstone-42
Project Member

Comment 3 by pthatcher@webrtc.org, Feb 19 2015

Labels: -Mstone-42 Mstone-44
This looks like it's not hitting m42.  Update it if I'm wrong.
Project Member

Comment 4 by juberti@webrtc.org, Feb 1 2016

Cc: -wu@webrtc.org juberti@webrtc.org
Labels: -Mstone-44 Hotlist-Testing
Owner: pthatcher@webrtc.org
Project Member

Comment 5 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 6 by deadbeef@chromium.org, Mar 30 2018

Cc: -juberti@webrtc.org
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment