Project: webrtc Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users
Status: Started
Owner:
Cc:
Components:
OS: ----
Pri: 3
Type: Enhancement



Sign in to add a comment
Remove macros in signal_processing_library
Project Member Reported by bjornv@webrtc.org, May 14 2014 Back to list
Feature description (please include a link to the functional spec):
We should avoid macros. Some are not even used, some are simply trivial operations and some can be turned into functions.

Eng owner:
bjornv@webrtc.org


 
Project Member Comment 1 by bugdroid1@chromium.org, May 15 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6169

------------------------------------------------------------------
r6169 | bjornv@webrtc.org | 2014-05-15T07:22:53.816600Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6169&r_previous=6168&r=6169&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6169&r_previous=6168&r=6169&format=side

common_audio: Removes unused macros

* WEBRTC_SPL_MUL_32_32_RSFT32BI
* WEBRTC_SPL_IS_NEG

BUG=3348
TESTED=trybots, common_audio_unittests
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18449004
-----------------------------------------------------------------
Project Member Comment 2 by bugdroid1@chromium.org, May 16 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6179

------------------------------------------------------------------
r6179 | bjornv@webrtc.org | 2014-05-16T06:38:47.488461Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6179&r_previous=6178&r=6179&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6179&r_previous=6178&r=6179&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/randomization_functions.c&spec=svn6179&r_previous=6178&r=6179&format=side

common_audio/signal_processing: Removed macro WEBRTC_SPL_MAX_SEED_USED

* Moved the macro to randomization_functions and made it static const.
* Made WebRtc_IncreaseSeed() static, since it is not used outside this function.
* Style guide changes.

BUG=3348,3353
TESTED=trybots, common_audio_unittests, modules_unittests, modules_tests
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21459004
-----------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, May 16 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6180

------------------------------------------------------------------
r6180 | bjornv@webrtc.org | 2014-05-16T06:40:31.152956Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6180&r_previous=6179&r=6180&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6180&r_previous=6179&r=6180&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c&spec=svn6180&r_previous=6179&r=6180&format=side

common_audio/signal_processing: Removed macro WEBRTC_SPL_SUB_SAT_W16

Macro was only mapping a function used in one place.

BUG=3348
TESTED=trybots, unittests
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17499004
-----------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, May 16 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6184

------------------------------------------------------------------
r6184 | bjornv@webrtc.org | 2014-05-16T12:11:20.138499Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6184&r_previous=6183&r=6184&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6184&r_previous=6183&r=6184&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_hist.c&spec=svn6184&r_previous=6183&r=6184&format=side

common_audio/signal_processing: Removes macro WEBRTC_SPL_UMUL_RSFT16

This macro was only used on two lines in iSACfix and I replaced those with the operations the macro performed.

BUG=3348
TESTED=trybots, manual unittests
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14529004
-----------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Jun 5 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6336

------------------------------------------------------------------
r6336 | bjornv@webrtc.org | 2014-06-05T08:42:53.697765Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6336&r_previous=6335&r=6336&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c&spec=svn6336&r_previous=6335&r=6336&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6336&r_previous=6335&r=6336&format=side

common_audio/signal_processing: Removed macro WEBRTC_SPL_MUL_16_16_RSFT_WITH_FIXROUND

This macro was only used at two places in fixed point iSAC, where it has been replaced with the operation.

BUG=3348,3353
TESTED=trybots
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15669004
-----------------------------------------------------------------
Project Member Comment 6 by bugdroid1@chromium.org, Jun 11 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6392

------------------------------------------------------------------
r6392 | bjornv@webrtc.org | 2014-06-11T06:39:03.660963Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6392&r_previous=6391&r=6392&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6392&r_previous=6391&r=6392&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn6392&r_previous=6391&r=6392&format=side

common_audio/signal_processing: Moves WEBRTC_SPL_UMUL_16_16_RSFT16 to iSAC fix

This macro is only used by the fixed point version of iSAC. Replacing the (five) locations in arith_routines_logist.c, where it is used, with the actual operation.

BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14659004
-----------------------------------------------------------------
Project Member Comment 7 by bugdroid1@chromium.org, Jun 11 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6393

------------------------------------------------------------------
r6393 | bjornv@webrtc.org | 2014-06-11T06:53:20.089827Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6393&r_previous=6392&r=6393&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn6393&r_previous=6392&r=6393&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn6393&r_previous=6392&r=6393&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn6393&r_previous=6392&r=6393&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6393&r_previous=6392&r=6393&format=side

common_audio/signal_processing: Removes macro WEBRTC_SPL_RSHIFT_U16

This macro is only used at a few places and implies a cast to uint16_t before right shifting. All places already use uint16_t. Further, the amount of shifts applied in the macro has no sanity check for negativity, makes the macro dangerous to use.

BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16669004
-----------------------------------------------------------------
Project Member Comment 8 by bugdroid1@chromium.org, Jun 16 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6444

------------------------------------------------------------------
r6444 | bjornv@webrtc.org | 2014-06-16T10:30:14.465168Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn6444&r_previous=6443&r=6444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn6444&r_previous=6443&r=6444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6444&r_previous=6443&r=6444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6444&r_previous=6443&r=6444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c&spec=svn6444&r_previous=6443&r=6444&format=side

common_audio: Removes macro WEBRTC_SPL_LSHIFT_U16

We should avoid macros in general (see style guide) and the shift ones are particular dangerous since they assume that the user apply a non-negative shift.

Related CL: https://webrtc-codereview.appspot.com/16669004

BUG=3348,3353
TESTED=trybots and manually on linux
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19719004
-----------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Jul 3 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6591

------------------------------------------------------------------
r6591 | bjornv@webrtc.org | 2014-07-03T13:38:53.572091Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6591&r_previous=6590&r=6591&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_c.c&spec=svn6591&r_previous=6590&r=6591&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6591&r_previous=6590&r=6591&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn6591&r_previous=6590&r=6591&format=side

common_audio: Removes macro WEBRTC_SPL_SHIFT_W16

We should avoid macros in general (see style guide). This shift macro is not a severe one, since there is a check for negativity.

BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15799004
-----------------------------------------------------------------
Project Member Comment 10 by bugdroid1@chromium.org, Aug 12 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6871

------------------------------------------------------------------
r6871 | bjornv@webrtc.org | 2014-08-12T10:54:50.984361Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6871&r_previous=6870&r=6871&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/spl_inl_mips.h&spec=svn6871&r_previous=6870&r=6871&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c&spec=svn6871&r_previous=6870&r=6871&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/spl_inl_armv7.h&spec=svn6871&r_previous=6870&r=6871&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6871&r_previous=6870&r=6871&format=side

common_audio/signal_processing: Removes macro WEBRTC_SPL_MUL_32_32_RSFT32

The macro is only used at four places in iSAC fixed point and the macro have been replaced at those places.
In addition, it is used in a unit test, but throws a warning treated as error (issue3674).

The macro has both MIPS and armv7 optimizations. Removing them impacts only MIPS platforms without DSP ASE. This may cause a very small increase in complexity when using iSAC fix.
The armv7 optimizations are not used anywhere, since specific ones are used inline in iSAC fix.

BUG=3348,3353,3674
TESTED=locally and trybots
R=ljubomir.papuga@gmail.com, tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16299004
-----------------------------------------------------------------
Project Member Comment 11 by bugdroid1@chromium.org, Aug 14 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6899

------------------------------------------------------------------
r6899 | bjornv@webrtc.org | 2014-08-14T07:26:28.968327Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6899&r_previous=6898&r=6899&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6899&r_previous=6898&r=6899&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/splitting_filter.c&spec=svn6899&r_previous=6898&r=6899&format=side

common_audio/signal_processing: Remove macro WEBRTC_SPL_SUB_SAT_W32

This macro is literally using the function WebRtcSpl_SubSatW32(), hence there is no need for a macro.

BUG=3348, 3353
TESTED=locally on Linux and trybots
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14149004
-----------------------------------------------------------------
Project Member Comment 12 by bjornv@webrtc.org, Aug 15 2014
r6907 | bjornv@webrtc.org | 2014-08-15T05:17:20.325567Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn6907&r_previous=6906&r=6907&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6907&r_previous=6906&r=6907&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_hist.c&spec=svn6907&r_previous=6906&r=6907&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6907&r_previous=6906&r=6907&format=side

common_audio/signal_processing: Remove macro WEBRTC_SPL_UMUL_32_16_RSFT16

Macros should in general be avoided. WEBRTC_SPL_UMUL_32_16_RSFT16 is only used in iSAC fixed point as part of multiplying with LSB and MSB. A better approach is to have one function for that complete operation in iSAC.

This CL removes the macro and replace the operation locally.

BUG=3148, 3353
TESTED=locally on Linux and trybots
R=tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16349004

Project Member Comment 13 by bugdroid1@chromium.org, Aug 18 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6916

------------------------------------------------------------------
r6916 | bjornv@webrtc.org | 2014-08-18T12:01:02.083170Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6916&r_previous=6915&r=6916&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6916&r_previous=6915&r=6916&format=side

common_audio/signal_processing: Remove unused macros WEBRTC_SPL_GET_BYTE and WEBRTC_SPL_SET_BYTE

These two macros are not used anywhere in webrtc. Previously used in old neteq (I think).

BUG=3348,3353
TESTED=manually on linux and trybots
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18149004
-----------------------------------------------------------------
Project Member Comment 14 by bugdroid1@chromium.org, Aug 20 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6935

------------------------------------------------------------------
r6935 | bjornv@webrtc.org | 2014-08-20T10:09:34.246814Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c&spec=svn6935&r_previous=6934&r=6935&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/encode.c&spec=svn6935&r_previous=6934&r=6935&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6935&r_previous=6934&r=6935&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c&spec=svn6935&r_previous=6934&r=6935&format=side

Refactoring common_audio: Remove macro WEBRTC_SPL_MEMMOVE_W16

Yet another macro that utilizes a function directly.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18159004
-----------------------------------------------------------------
Project Member Comment 15 by bugdroid1@chromium.org, Aug 21 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6947

------------------------------------------------------------------
r6947 | bjornv@webrtc.org | 2014-08-21T06:13:57.446950Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/spl_inl_mips.h&spec=svn6947&r_previous=6946&r=6947&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/spl_inl_armv7.h&spec=svn6947&r_previous=6946&r=6947&format=side

Refactoring common_audio/signal_processing: Remove unused macro WEBRTC_SPL_MUL_32_32_RSFT32BI

The WEBRTC_SPL_MUL_32_32_RSFT32BI macro was removed in r6169, since it was unused. This CL removes the arm and mips optimizations of it.

BUG=3348, 3353
TESTED=locally and trybots
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17149004
-----------------------------------------------------------------
Project Member Comment 16 by bugdroid1@chromium.org, Aug 25 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6960

------------------------------------------------------------------
r6960 | bjornv@webrtc.org | 2014-08-25T07:44:52.607764Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.S&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_neon.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/auto_corr_to_refl_coef.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c&spec=svn6960&r_previous=6959&r=6960&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_c.c&spec=svn6960&r_previous=6959&r=6960&format=side

Refactoring common_audio/signal_processing: Replaces trivial macros

The macros WEBRTC_SPL_ADD_SAT_W16 and WEBRTC_SPL_ADD_SAT_W32 make direct use of the corresponding functions WebRtcSpl_AddSatW16() and WebRtcSpl_AddSatW32().
This CL replaces these macros in the code.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21199004
-----------------------------------------------------------------
Project Member Comment 17 by bugdroid1@chromium.org, Aug 25 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6961

------------------------------------------------------------------
r6961 | bjornv@webrtc.org | 2014-08-25T10:23:22.413283Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h&spec=svn6961&r_previous=6960&r=6961&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6961&r_previous=6960&r=6961&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.c&spec=svn6961&r_previous=6960&r=6961&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6961&r_previous=6960&r=6961&format=side

common_audio/signal_processing: Remove macro WEBRTC_SPL_MEMCPY_W8

This macro is nothing but memcpy() and further used at one single place in webrtc, so it makes no sense to keep it. Replaced the operation where it is used.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16359004
-----------------------------------------------------------------
Project Member Comment 18 by bugdroid1@chromium.org, Aug 25 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6962

------------------------------------------------------------------
r6962 | bjornv@webrtc.org | 2014-08-25T10:32:22.655580Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.c&spec=svn6962&r_previous=6961&r=6962&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6962&r_previous=6961&r=6962&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h&spec=svn6962&r_previous=6961&r=6962&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6962&r_previous=6961&r=6962&format=side

Revert 6961 "common_audio/signal_processing: Remove macro WEBRTC..."

> common_audio/signal_processing: Remove macro WEBRTC_SPL_MEMCPY_W8
> 
> This macro is nothing but memcpy() and further used at one single place in webrtc, so it makes no sense to keep it. Replaced the operation where it is used.
> 
> BUG=3348,3353
> TESTED=locally on linux and trybots
> R=kwiberg@webrtc.org, tina.legrand@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/16359004

TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22499004
-----------------------------------------------------------------
Project Member Comment 19 by bugdroid1@chromium.org, Aug 25 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6963

------------------------------------------------------------------
r6963 | bjornv@webrtc.org | 2014-08-25T11:19:05.936117Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h&spec=svn6963&r_previous=6962&r=6963&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6963&r_previous=6962&r=6963&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.c&spec=svn6963&r_previous=6962&r=6963&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6963&r_previous=6962&r=6963&format=side

Re-landing r6961

common_audio/signal_processing: Remove macro WEBRTC_SPL_MEMCPY_W8

This macro is nothing but memcpy() and further used at one single place in webrtc, so it makes no sense to keep it. Replaced the operation where it is used.

BUG=3348,3353
TESTED=locally on linux
TBR=aluebs@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18259004
-----------------------------------------------------------------
Project Member Comment 20 by bugdroid1@chromium.org, Aug 25 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6964

------------------------------------------------------------------
r6964 | bjornv@webrtc.org | 2014-08-25T11:42:42.376259Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_c.c&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn6964&r_previous=6963&r=6964&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn6964&r_previous=6963&r=6964&format=side

Refactoring common_audio: Replace trivial multiplication macro

This multiplication macro literally use the '*' operator, so there is no need for it.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22109004
-----------------------------------------------------------------
Project Member Comment 21 by bugdroid1@chromium.org, Aug 26 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6976

------------------------------------------------------------------
r6976 | bjornv@webrtc.org | 2014-08-26T10:25:10.664504Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c&spec=svn6976&r_previous=6975&r=6976&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6976&r_previous=6975&r=6976&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_mips.c&spec=svn6976&r_previous=6975&r=6976&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c&spec=svn6976&r_previous=6975&r=6976&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn6976&r_previous=6975&r=6976&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6976&r_previous=6975&r=6976&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn6976&r_previous=6975&r=6976&format=side

Refactoring common_audio/signal_processing: Remove macro WEBRTC_SPL_UDIV

This macro is a direct use of the division operator without checking for division by zero. Hence, it is dangerous to use.
This CL replaces the macro with '/' at place.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14169004
-----------------------------------------------------------------
Project Member Comment 22 by bjornv@webrtc.org, Aug 26 2014
Status: Started
Project Member Comment 23 by bugdroid1@chromium.org, Aug 28 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6998

------------------------------------------------------------------
r6998 | bjornv@webrtc.org | 2014-08-28T12:57:32.380311Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/analog_agc.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c&spec=svn6998&r_previous=6997&r=6998&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn6998&r_previous=6997&r=6998&format=side

common_audio: Removed macro WEBRTC_SPL_DIV

The macro has no built-in divide by zero check. The only thing that is done is casting to int32_t.
In addition a bug was discovered where it was supposed to do a division with rounding, but instead did a division with truncation + addition by 2. This is corrected in this CL.

BUG=3348,3353
TESTED=locally on Linux
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19129004
-----------------------------------------------------------------
Project Member Comment 24 by bugdroid1@chromium.org, Sep 5 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7076

------------------------------------------------------------------
r7076 | bjornv@webrtc.org | 2014-09-05T06:01:53.081302Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7076&r_previous=7075&r=7076&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7076&r_previous=7075&r=7076&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn7076&r_previous=7075&r=7076&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_mips.c&spec=svn7076&r_previous=7075&r=7076&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7076&r_previous=7075&r=7076&format=side

common_audio: Replaced WEBRTC_SPL_LSHIFT_U32 with << in audio_processing

Affected components:
* AECMobile
  - Added a help function since the same operation was performed several times.
* Auto Gain Control
* Noise Suppression (fixed point)

BUG=3348,3353
TESTED=locally on Linux
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20219004
-----------------------------------------------------------------
Project Member Comment 25 by bugdroid1@chromium.org, Sep 8 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7100

------------------------------------------------------------------
r7100 | bjornv@webrtc.org | 2014-09-08T11:19:39.424515Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_processing/main/source/deflickering.cc&spec=svn7100&r_previous=7099&r=7100&format=side

video_processing: Removed usage of WEBRTC_SPL_UMUL_16_16

The trivial macro WEBRTC_SPL_UMUL_16_16 is nothing but plain mutliplication of casted values. This CL explicitly use "*" at place and casts if necessary.

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23499004
-----------------------------------------------------------------
Project Member Comment 26 by bugdroid1@chromium.org, Sep 8 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7101

------------------------------------------------------------------
r7101 | bjornv@webrtc.org | 2014-09-08T11:21:56.591764Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn7101&r_previous=7100&r=7101&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7101&r_previous=7100&r=7101&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_neon.c&spec=svn7101&r_previous=7100&r=7101&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7101&r_previous=7100&r=7101&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7101&r_previous=7100&r=7101&format=side

audio_processing: Removed use of macro WEBRTC_SPL_UMUL_16_16

The macro replaced is a trivial multiplication after explicit casts to uint16_t and uint32_t. This CL replaces its use with "*" and adds explicit casts if necessary.

Affected components:
* AECMobile
* AGC
* Noise Suppression (fixed point version)

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27389004
-----------------------------------------------------------------
Project Member Comment 27 by bugdroid1@chromium.org, Sep 30 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7320

------------------------------------------------------------------
r7320 | bjornv@webrtc.org | 2014-09-29T09:40:38.959804Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn7320&r_previous=7319&r=7320&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/main/source/crc.c&spec=svn7320&r_previous=7319&r=7320&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn7320&r_previous=7319&r=7320&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_hist.c&spec=svn7320&r_previous=7319&r=7320&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c&spec=svn7320&r_previous=7319&r=7320&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn7320&r_previous=7319&r=7320&format=side

common_audio refactoring: Removed macro WEBRTC_SPL_LSHIFT_U32

The macro is a trivial shift operator including a cast before shift. There is no guard against negative shifts. Replaced with << at place and added casts when necessary.

Affects both fixed and float point versions of iSAC

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27369004
-----------------------------------------------------------------
Project Member Comment 28 by bugdroid1@chromium.org, Sep 30 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7321

------------------------------------------------------------------
r7321 | bjornv@webrtc.org | 2014-09-29T10:56:27.566307Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_neon.c&spec=svn7321&r_previous=7320&r=7321&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7321&r_previous=7320&r=7321&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/lpc_to_refl_coef.c&spec=svn7321&r_previous=7320&r=7321&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7321&r_previous=7320&r=7321&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7321&r_previous=7320&r=7321&format=side

audio_processing: Replaced macro WEBRTC_SPL_LSHIFT_W16 with <<

A trivial macro that serves no purpose. Affected components are:
* audio_processing/nsx
* audio_processing/agc
* audio_processing/aecm
* common_audio/LpcToReflCoef

BUG=3348,3353
TESTED=locally on linux
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22539004
-----------------------------------------------------------------
Project Member Comment 29 by bugdroid1@chromium.org, Sep 30 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7329

------------------------------------------------------------------
r7329 | bjornv@webrtc.org | 2014-09-30T09:26:36.827996Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/high_pass_filter_impl.cc&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_neon.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_neon.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_c.c&spec=svn7329&r_previous=7328&r=7329&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/analog_agc.c&spec=svn7329&r_previous=7328&r=7329&format=side

audio_processing: Replaced trivial macro WEBRTC_SPL_LSHIFT_W32 with <<

Affected components:
* AECM
* AGC
* HPF
* NSx

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27629004
-----------------------------------------------------------------
Project Member Comment 30 by bugdroid1@chromium.org, Sep 30 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7330

------------------------------------------------------------------
r7330 | bjornv@webrtc.org | 2014-09-30T09:29:28.402673Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7330&r_previous=7329&r=7330&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7330&r_previous=7329&r=7330&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn7330&r_previous=7329&r=7330&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/analog_agc.c&spec=svn7330&r_previous=7329&r=7330&format=side

audio_processing: Removed usage of macro WEBRTC_SPL_MUL

WEBRTC_SPL_MUL is a trivial multiplication after casting to int32_t. This is already taken care of by the compiler which makes the macro unnecessary.

Affected components:
* AGC
* NSx

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25429004
-----------------------------------------------------------------
Project Member Comment 31 by bugdroid1@chromium.org, Oct 2 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7366

------------------------------------------------------------------
r7366 | bjornv@webrtc.org | 2014-10-02T08:07:05.185797Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/analog_agc.c&spec=svn7366&r_previous=7365&r=7366&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_mips.c&spec=svn7366&r_previous=7365&r=7366&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7366&r_previous=7365&r=7366&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7366&r_previous=7365&r=7366&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn7366&r_previous=7365&r=7366&format=side

audio_processing: Replaced WEBRTC_SPL_RSHIFT_U32 with >>

A trivial macro that is replaced. Affected components:
* AGC
* NSx

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29599005
-----------------------------------------------------------------
Project Member Comment 32 by bugdroid1@chromium.org, Oct 8 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7396

------------------------------------------------------------------
r7396 | bjornv@webrtc.org | 2014-10-08T15:36:30.573684Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_hist.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/get_cd_vec.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/smooth_out_data.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/refiner.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/poly_to_lsp.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/lsf_to_lsp.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/fft.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn7396&r_previous=7395&r=7396&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c&spec=svn7396&r_previous=7395&r=7396&format=side

audio_coding: Replaced macro WEBRTC_SPL_RSHIFT_W16 with >>

Replaced trivial shift macro with >>. The actual implementation of the macro is simply >>.

Affected codecs:
* ilbc
* isac/fix

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23889004
-----------------------------------------------------------------
Project Member Comment 33 by bugdroid1@chromium.org, Oct 9 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7404

------------------------------------------------------------------
r7404 | bjornv@webrtc.org | 2014-10-09T08:47:02.084947Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/poly_to_lsp.c&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/lsp_to_lsf.c&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c&spec=svn7404&r_previous=7403&r=7404&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c&spec=svn7404&r_previous=7403&r=7404&format=side

common_audio: Removed macro WEBRTC_SPL_LSHIFT_W16

The macro was a trivial << operation and where used has been replaced by <<. Affected components are
* ilbc
* isacfix

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22919005
-----------------------------------------------------------------
Project Member Comment 34 by bugdroid1@chromium.org, Oct 13 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7432

------------------------------------------------------------------
r7432 | bjornv@webrtc.org | 2014-10-13T13:01:13.142546Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_neon.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/refl_coef_to_lpc.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/spl_sqrt.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_c.c&spec=svn7432&r_previous=7431&r=7432&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/analog_agc.c&spec=svn7432&r_previous=7431&r=7432&format=side

audio_processing: Replaced macro WEBRTC_SPL_RSHIFT_W16 with >>

The implementation of WEBRTC_SPL_RSHIFT_W16 is simply >>. This CL removes the macro usage in audio_processing and signal_processing.

Affected components:
* aecm
* agc
* nsx

Indirectly affecting (through signal_processing changes)
* codecs/cng
* codecs/isac/fix
* codecs/isac/main

BUG=3348,3353
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28699005
-----------------------------------------------------------------
Project Member Comment 35 by bugdroid1@chromium.org, Oct 13 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7434

------------------------------------------------------------------
r7434 | bjornv@webrtc.org | 2014-10-13T14:00:43.903328Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn7434&r_previous=7433&r=7434&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/vad/vad_core.c&spec=svn7434&r_previous=7433&r=7434&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn7434&r_previous=7433&r=7434&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7434&r_previous=7433&r=7434&format=side

common_audio: Removed macro WEBRTC_SPL_RSHIFT_W16

Replaced the trivial right shift macro at remaining 4 places and removed from signal_processing.

Affected components:
* vad
* aecm

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25849004
-----------------------------------------------------------------
Project Member Comment 36 by bugdroid1@chromium.org, Oct 15 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7454

------------------------------------------------------------------
r7454 | bjornv@webrtc.org | 2014-10-15T09:31:40.565967Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_mips.c&spec=svn7454&r_previous=7453&r=7454&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_neon.c&spec=svn7454&r_previous=7453&r=7454&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7454&r_previous=7453&r=7454&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core_c.c&spec=svn7454&r_previous=7453&r=7454&format=side

audio_processing/ns: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>

Affects fixed point version of Noise Suppression.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26809004
-----------------------------------------------------------------
Project Member Comment 37 by bugdroid1@chromium.org, Oct 15 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7455

------------------------------------------------------------------
r7455 | bjornv@webrtc.org | 2014-10-15T11:16:48.711541Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/digital_agc.c&spec=svn7455&r_previous=7454&r=7455&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/agc/analog_agc.c&spec=svn7455&r_previous=7454&r=7455&format=side

audio_processing/agc: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>

Affects AGC only.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31709004
-----------------------------------------------------------------
Project Member Comment 38 by bugdroid1@chromium.org, Oct 15 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7456

------------------------------------------------------------------
r7456 | bjornv@webrtc.org | 2014-10-15T12:51:23.229620Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_c.c&spec=svn7456&r_previous=7455&r=7456&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core_mips.c&spec=svn7456&r_previous=7455&r=7456&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/high_pass_filter_impl.cc&spec=svn7456&r_previous=7455&r=7456&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/ns/nsx_core.c&spec=svn7456&r_previous=7455&r=7456&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c&spec=svn7456&r_previous=7455&r=7456&format=side

audio_processing: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>

Also includes a typo in a comment.
Affects
* aecm
* hpf

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29769004
-----------------------------------------------------------------
Project Member Comment 39 by bugdroid1@chromium.org, Oct 20 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7473

------------------------------------------------------------------
r7473 | bjornv@webrtc.org | 2014-10-20T08:24:54.180831Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq/expand.cc&spec=svn7473&r_previous=7472&r=7473&format=side

audio_coding/neteq: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24009004
-----------------------------------------------------------------
Project Member Comment 40 by bugdroid1@chromium.org, Oct 20 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7474

------------------------------------------------------------------
r7474 | bjornv@webrtc.org | 2014-10-20T08:26:41.315263Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c&spec=svn7474&r_previous=7473&r=7474&format=side

audio_coding/codecs/isac/main: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30739004
-----------------------------------------------------------------
Project Member Comment 41 by bugdroid1@chromium.org, Oct 21 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7480

------------------------------------------------------------------
r7480 | bjornv@webrtc.org | 2014-10-21T07:17:24.450525Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/lsf_to_poly.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/smooth_out_data.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/xcorr_coef.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/refiner.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/sort_sq.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/do_plc.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/poly_to_lsp.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/lsf_to_lsp.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_augmentation.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/window32_w32.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/smooth.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_calc.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/chebyshev.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/cb_search_core.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/interpolate.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/hp_input.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/hp_output.c&spec=svn7480&r_previous=7479&r=7480&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/ilbc/cb_construct.c&spec=svn7480&r_previous=7479&r=7480&format=side

audio_coding/codecs/ilbc: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>

Removed usage of trivial macro.

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29789004
-----------------------------------------------------------------
Project Member Comment 42 by bugdroid1@chromium.org, Oct 28 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7543

------------------------------------------------------------------
r7543 | bjornv@webrtc.org | 2014-10-28T13:03:10.940399Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn7543&r_previous=7542&r=7543&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn7543&r_previous=7542&r=7543&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn7543&r_previous=7542&r=7543&format=side

common_audio: Removed trivial macro WEBRTC_SPL_UMUL_16_16

The macro made a cast to uint16_t before a plain multiplication. At the few places where it was used the variables were already uint16_t.

Affected components:
* isac/fix

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29869004
-----------------------------------------------------------------
Project Member Comment 43 by bugdroid1@chromium.org, Oct 28 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7544

------------------------------------------------------------------
r7544 | bjornv@webrtc.org | 2014-10-28T13:05:43.134027Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_c.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/transform.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter_c.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/lattice.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_mips.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_hist.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/lattice_c.c&spec=svn7544&r_previous=7543&r=7544&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c&spec=svn7544&r_previous=7543&r=7544&format=side

audio_coding/codecs/isac/fix: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>"

BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23119004
-----------------------------------------------------------------
Project Member Comment 44 by bugdroid1@chromium.org, Oct 29 2014
The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7558

------------------------------------------------------------------
r7558 | bjornv@webrtc.org | 2014-10-29T10:29:16.623778Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/splitting_filter.c&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/lpc_to_refl_coef.c&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/include/signal_processing_library.h&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/complex_fft.c&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/division_operations.c&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/spl_sqrt.c&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/signal_processing_unittest.cc&spec=svn7558&r_previous=7557&r=7558&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/signal_processing/levinson_durbin.c&spec=svn7558&r_previous=7557&r=7558&format=side

common_audio: Removed macro WEBRTC_SPL_RSHIFT_W32

Replaces the trivial macro WEBRTC_SPL_RSHIFT_W32 with >> at various places in common_audio and removes it.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26989004
-----------------------------------------------------------------
Project Member Comment 45 by tina.legrand@webrtc.org, Oct 30 2014
Labels: EngTriaged IceBox
Project Member Comment 46 by bugdroid1@chromium.org, Jan 8 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/5e5b32706aa1ac3790feac97e7dc2557845a2a71

commit 5e5b32706aa1ac3790feac97e7dc2557845a2a71
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Thu Jan 08 17:25:34 2015

audio_processing/agc: Removed usage of macro WEBRTC_SPL_MUL_16_16 in legacy/agc

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)

BUG=3348, 3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8023 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/5e5b32706aa1ac3790feac97e7dc2557845a2a71/webrtc/modules/audio_processing/agc/legacy/analog_agc.c
[modify] http://crrev.com/5e5b32706aa1ac3790feac97e7dc2557845a2a71/webrtc/modules/audio_processing/agc/legacy/digital_agc.c

Project Member Comment 47 by bugdroid1@chromium.org, Jan 8 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/dec649cbabe4aa6c3b150664d73ee17a8e0ec76f

commit dec649cbabe4aa6c3b150664d73ee17a8e0ec76f
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Thu Jan 08 17:34:33 2015

audio_processing/ns: Replaced WEBRTC_SPL_MUL_16_16 macro with *

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)

BUG=3348, 3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8024 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/dec649cbabe4aa6c3b150664d73ee17a8e0ec76f/webrtc/modules/audio_processing/ns/nsx_core.c
[modify] http://crrev.com/dec649cbabe4aa6c3b150664d73ee17a8e0ec76f/webrtc/modules/audio_processing/ns/nsx_core_c.c
[modify] http://crrev.com/dec649cbabe4aa6c3b150664d73ee17a8e0ec76f/webrtc/modules/audio_processing/ns/nsx_core_mips.c
[modify] http://crrev.com/dec649cbabe4aa6c3b150664d73ee17a8e0ec76f/webrtc/modules/audio_processing/ns/nsx_core_neon.c

Project Member Comment 48 by bugdroid1@chromium.org, Jan 8 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/758d6d431ef527130ab95cd20f0e42bb543d6da8

commit 758d6d431ef527130ab95cd20f0e42bb543d6da8
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Thu Jan 08 17:52:56 2015

audio_processing/aecm: Removed usage of macro WEBRTC_SPL_MUL_16_16

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)

BUG=3348, 3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8025 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/758d6d431ef527130ab95cd20f0e42bb543d6da8/webrtc/modules/audio_processing/aecm/aecm_core.c
[modify] http://crrev.com/758d6d431ef527130ab95cd20f0e42bb543d6da8/webrtc/modules/audio_processing/aecm/aecm_core_c.c
[modify] http://crrev.com/758d6d431ef527130ab95cd20f0e42bb543d6da8/webrtc/modules/audio_processing/aecm/aecm_core_mips.c

Project Member Comment 49 by bugdroid1@chromium.org, Jan 12 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a7add19cf4dfce4ebe7e4ed24da3e1c49d5ddcc1

commit a7add19cf4dfce4ebe7e4ed24da3e1c49d5ddcc1
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Mon Jan 12 21:12:29 2015

audio_processing: Replaced macro WEBRTC_SPL_MUL_16_16 with * in high_pass_filter

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)

BUG=3348,3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8044 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/a7add19cf4dfce4ebe7e4ed24da3e1c49d5ddcc1/webrtc/modules/audio_processing/high_pass_filter_impl.cc

Project Member Comment 50 by bugdroid1@chromium.org, Jan 26 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d25c0340516339718fa06f72ca41d93c7870cac8

commit d25c0340516339718fa06f72ca41d93c7870cac8
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Mon Jan 26 15:32:47 2015

Refactor common_audio/vad: Removed usage of macro WEBRTC_SPL_MUL_16_16()

BUG=3348,3353
TESTED=Locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8152 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/d25c0340516339718fa06f72ca41d93c7870cac8/webrtc/common_audio/vad/vad_filterbank.c
[modify] http://crrev.com/d25c0340516339718fa06f72ca41d93c7870cac8/webrtc/common_audio/vad/vad_gmm.c
[modify] http://crrev.com/d25c0340516339718fa06f72ca41d93c7870cac8/webrtc/common_audio/vad/vad_sp.c

Project Member Comment 51 by bugdroid1@chromium.org, Feb 13 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ba97ea69f0b8bb73a837869211627b705eac8f98

commit ba97ea69f0b8bb73a837869211627b705eac8f98
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Fri Feb 13 09:51:40 2015

audio_coding/codec/ilbc: Removed usage of macro WEBRTC_SPL_MUL_16_16

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)

Some other minor code cleanup also exists.

BUG=3348, 3353
TESTED=locally on Mac and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34179004

Cr-Commit-Position: refs/heads/master@{#8358}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8358 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/bw_expand.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/cb_construct.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_calc.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/cb_search.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/cb_search_core.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/chebyshev.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/do_plc.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/encode.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/enh_upsample.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/frame_classify.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/gain_dequant.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/gain_quant.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/get_cd_vec.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/get_sync_seq.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/hp_input.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/hp_output.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/lsf_to_lsp.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/my_corr.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/nearest_neighbor.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/poly_to_lsp.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/refiner.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/simple_lsf_dequant.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/smooth.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/smooth_out_data.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/state_construct.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/vq3.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/vq4.c
[modify] http://crrev.com/ba97ea69f0b8bb73a837869211627b705eac8f98/webrtc/modules/audio_coding/codecs/ilbc/window32_w32.c

Project Member Comment 52 by bugdroid1@chromium.org, Mar 1 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd

commit 2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Sun Mar 01 19:50:41 2015

audio_coding/codec/ilbc: Removed usage of WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
    (WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parantheses and style changes

BUG=3348, 3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39139004

Cr-Commit-Position: refs/heads/master@{#8544}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8544 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_augmentation.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/cb_search.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/chebyshev.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/do_plc.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/interpolate_samples.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/lsf_to_lsp.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/lsp_to_lsf.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/poly_to_lsp.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/window32_w32.c
[modify] http://crrev.com/2f6ae0de5b0ca98cdcf3fd3c5a9848a5814aaddd/webrtc/modules/audio_coding/codecs/ilbc/xcorr_coef.c

Project Member Comment 53 by bugdroid1@chromium.org, Mar 9 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/600587d5ac96c270612716ab76d813e0c275f98c

commit 600587d5ac96c270612716ab76d813e0c275f98c
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Mon Mar 09 13:30:28 2015

Refactor audio_coding/neteq: Removed usage of macro WEBRTC_SPL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
    ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

In addition an implicit cast from int32_t to int16_t was removed, which was a bug.

BUG=3348, 3353
TESTED=Locally on Mac and trybots
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41179004

Cr-Commit-Position: refs/heads/master@{#8653}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8653 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/600587d5ac96c270612716ab76d813e0c275f98c/webrtc/modules/audio_coding/neteq/background_noise.cc
[modify] http://crrev.com/600587d5ac96c270612716ab76d813e0c275f98c/webrtc/modules/audio_coding/neteq/normal.cc

Project Member Comment 54 by bugdroid1@chromium.org, Mar 10 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1afbdc7555b4bcf9da3bc12ed60e32a0ac0dd297

commit 1afbdc7555b4bcf9da3bc12ed60e32a0ac0dd297
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Tue Mar 10 06:37:47 2015

Refactor audio_processing/agc: Removes usage of macro WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

BUG=3348,3353
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47449004

Cr-Commit-Position: refs/heads/master@{#8664}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8664 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/1afbdc7555b4bcf9da3bc12ed60e32a0ac0dd297/webrtc/modules/audio_processing/agc/legacy/analog_agc.c

Project Member Comment 55 by bugdroid1@chromium.org, Mar 10 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/b38b009d216bc6fc45934d8dafa9e7489ec8e91a

commit b38b009d216bc6fc45934d8dafa9e7489ec8e91a
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Tue Mar 10 06:40:02 2015

Refactor audio_processing/aecm: Removed usage of macro WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

In addition an implicit cast from int32_t to int16_t was removed, which was a bug.

BUG=3348,3353
TESTED=Locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41169004

Cr-Commit-Position: refs/heads/master@{#8665}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8665 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/b38b009d216bc6fc45934d8dafa9e7489ec8e91a/webrtc/modules/audio_processing/aecm/aecm_core.c
[modify] http://crrev.com/b38b009d216bc6fc45934d8dafa9e7489ec8e91a/webrtc/modules/audio_processing/aecm/aecm_core_c.c

Project Member Comment 56 by bugdroid1@chromium.org, Mar 10 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/7ef8b12a3b70b3abdd5b0bf56051d61ec19724e2

commit 7ef8b12a3b70b3abdd5b0bf56051d61ec19724e2
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Tue Mar 10 07:09:30 2015

Refactor audio_processing/ns: Removes usage of macro WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

BUG=3348,3353
TESTED=Locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41149004

Cr-Commit-Position: refs/heads/master@{#8666}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8666 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/7ef8b12a3b70b3abdd5b0bf56051d61ec19724e2/webrtc/modules/audio_processing/ns/nsx_core.c
[modify] http://crrev.com/7ef8b12a3b70b3abdd5b0bf56051d61ec19724e2/webrtc/modules/audio_processing/ns/nsx_core_c.c
[modify] http://crrev.com/7ef8b12a3b70b3abdd5b0bf56051d61ec19724e2/webrtc/modules/audio_processing/ns/nsx_core_mips.c
[modify] http://crrev.com/7ef8b12a3b70b3abdd5b0bf56051d61ec19724e2/webrtc/modules/audio_processing/ns/nsx_core_neon.c

Project Member Comment 57 by bugdroid1@chromium.org, Mar 16 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/bc2bb34419021fb3be4f87eb062cf0a9ed52675a

commit bc2bb34419021fb3be4f87eb062cf0a9ed52675a
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Fri Mar 13 12:58:03 2015

Refactor audio_coding/codecs/isac: Removed usage of macro WEBRTC_SPL_MUL_16_16

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see
common_audio/signal_processing/include/spl_inl_armv7.h and
common_audio/signal_processing/include/spl_inl_mips.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int
or int32_t)

Some other minor code cleanup also exists.

BUG=3348,3353
TESTED=locally on Mac and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42639004

Cr-Commit-Position: refs/heads/master@{#8717}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8717 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/fft.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.S
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/initialize.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/lattice.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c
[modify] http://crrev.com/bc2bb34419021fb3be4f87eb062cf0a9ed52675a/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter_c.c

Project Member Comment 58 by bugdroid1@chromium.org, Mar 20 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d

commit 4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Fri Mar 20 06:01:06 2015

Refactor audio_coding/ilbc: removes usage of macro WEBRTC_SPL_LSHIFT_W32

The macro is defined as
#define WEBRTC_SPL_LSHIFT_W32(a, b) ((a) << (b))
It is a trivial operation that need no macro. In fact it may be confusing for to the user, since it can be interpreted as having an implicit cast to int32_t.

Also removes unnecessary casts to int32_t from int16_t.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48519004

Cr-Commit-Position: refs/heads/master@{#8800}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8800 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_augmentation.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_calc.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/cb_search_core.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/chebyshev.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/gain_quant.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/hp_input.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/hp_output.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/smooth.c
[modify] http://crrev.com/4ab23d0e8f468d9f1e3ce4ffb50df070d8d06c6d/webrtc/modules/audio_coding/codecs/ilbc/window32_w32.c

Project Member Comment 59 by bugdroid1@chromium.org, Mar 20 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6069032ebb9026bc22ae18d1c4b8e8315140a907

commit 6069032ebb9026bc22ae18d1c4b8e8315140a907
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Fri Mar 20 07:03:28 2015

Refactor audio_coding/isac: removed usage of macro WEBRTC_SPL_LSHIFT_W32

The macro is defined as
#define WEBRTC_SPL_LSHIFT_W32(a, b) ((a) << (b))
It is a trivial operation that need no macro. In fact it may be confusing for to the user, since it can be interpreted as having an implicit cast to int32_t.

BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44659004

Cr-Commit-Position: refs/heads/master@{#8801}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8801 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/6069032ebb9026bc22ae18d1c4b8e8315140a907/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

Project Member Comment 60 by bugdroid1@chromium.org, Mar 25 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1ccd8b4281f8d3ebbc51e70a96ac186e787a7114

commit 1ccd8b4281f8d3ebbc51e70a96ac186e787a7114
Author: Bjorn Volcker <bjornv@webrtc.org>
Date: Wed Mar 25 12:29:49 2015

Refactor common_audio/signal_processing: Removed usage of WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

BUG=3348, 3353
TESTED=locally on Linux for both fixed and floating point and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49499004

Cr-Commit-Position: refs/heads/master@{#8853}

[modify] http://crrev.com/1ccd8b4281f8d3ebbc51e70a96ac186e787a7114/webrtc/common_audio/signal_processing/energy.c
[modify] http://crrev.com/1ccd8b4281f8d3ebbc51e70a96ac186e787a7114/webrtc/common_audio/signal_processing/ilbc_specific_functions.c
[modify] http://crrev.com/1ccd8b4281f8d3ebbc51e70a96ac186e787a7114/webrtc/common_audio/signal_processing/include/signal_processing_library.h
[modify] http://crrev.com/1ccd8b4281f8d3ebbc51e70a96ac186e787a7114/webrtc/common_audio/signal_processing/refl_coef_to_lpc.c
[modify] http://crrev.com/1ccd8b4281f8d3ebbc51e70a96ac186e787a7114/webrtc/common_audio/signal_processing/vector_scaling_operations.c

Project Member Comment 61 by bugdroid1@chromium.org, Mar 25 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/3fbf99c44a30f09d4e3402e192067d053ced5c55

commit 3fbf99c44a30f09d4e3402e192067d053ced5c55
Author: Bjorn Volcker <bjornv@webrtc.org>
Date: Wed Mar 25 13:37:24 2015

Refactor common_audio/vad: Removed usage of WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

BUG=3347, 3348, 3353
TESTED=locally on Linux for both fixed and floating point and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44799004

Cr-Commit-Position: refs/heads/master@{#8857}

[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_core.c
[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_filterbank.c
[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_gmm.c
[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_sp.c

Project Member Comment 62 by bugdroid1@chromium.org, Apr 2 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d4e75016a3836c3aab992afff6bfd8d5e3862aac

commit d4e75016a3836c3aab992afff6bfd8d5e3862aac
Author: Bjorn Volcker <bjornv@chromium.org>
Date: Thu Apr 02 04:59:38 2015

Refactor audio_coding/codecs/isac/fix: Removed usage of trivial macro WEBRTC_SPL_LSHIFT_W32()

The macro is defined as
#define WEBRTC_SPL_LSHIFT_W32(a, b) ((a) << (b))
hence trivial.
The macro name may in fact mislead the user to assume a cast/truncation to int32_t is done.
- Removing usage of it.
- Some style changes.

BUG=3348, 3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/46749005

Cr-Commit-Position: refs/heads/master@{#8918}

[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_hist.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/lattice.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_c.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_mips.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c
[modify] http://crrev.com/d4e75016a3836c3aab992afff6bfd8d5e3862aac/webrtc/modules/audio_coding/codecs/isac/fix/source/transform.c

Project Member Comment 63 by bugdroid1@chromium.org, Apr 10 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/f2822edf611ff187eab61abccd9edb2edac4ba64

commit f2822edf611ff187eab61abccd9edb2edac4ba64
Author: Bjorn Volcker <bjornv@chromium.org>
Date: Fri Apr 10 06:06:45 2015

Refactor audio_coding/codecs/isac/fix: Removed usage of macro WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes
- removed commented code lines used during development
- excluded fft.c since there are neon optimizations used and a removal may cause a performance regression

BUG=3348, 3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48799004

Cr-Commit-Position: refs/heads/master@{#8967}

[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_plc.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_c.c
[modify] http://crrev.com/f2822edf611ff187eab61abccd9edb2edac4ba64/webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c

Project Member Comment 64 by bugdroid1@chromium.org, Apr 13 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/61a4b04f4004edb91e9ee6b76d4d01971a795ed6

commit 61a4b04f4004edb91e9ee6b76d4d01971a795ed6
Author: Bjorn Volcker <bjornv@chromium.org>
Date: Mon Apr 13 13:43:50 2015

Refactor common_audio/vad: Removed usage of trivial macro WEBRTC_SPL_MUL_16_16(a, b)

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

BUG=3348,3353
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43129004

Cr-Commit-Position: refs/heads/master@{#8986}

[modify] http://crrev.com/61a4b04f4004edb91e9ee6b76d4d01971a795ed6/webrtc/common_audio/vad/vad_filterbank.c

Project Member Comment 65 by bugdroid1@chromium.org, Apr 13 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0f911d71a75f9fbfc1006a1fdedfd6a7f6a6af62

commit 0f911d71a75f9fbfc1006a1fdedfd6a7f6a6af62
Author: Bjorn Volcker <bjornv@chromium.org>
Date: Mon Apr 13 13:45:17 2015

Refactor audio_processing/nsx: Removed usage of macro WEBRTC_SPL_MEMCPY_W16

The macro assumes int16_t pointers, but there is no check for it.

BUG=3348,3353
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48959004

Cr-Commit-Position: refs/heads/master@{#8987}

[modify] http://crrev.com/0f911d71a75f9fbfc1006a1fdedfd6a7f6a6af62/webrtc/modules/audio_processing/ns/nsx_core.c
[modify] http://crrev.com/0f911d71a75f9fbfc1006a1fdedfd6a7f6a6af62/webrtc/modules/audio_processing/ns/nsx_core_mips.c
[modify] http://crrev.com/0f911d71a75f9fbfc1006a1fdedfd6a7f6a6af62/webrtc/modules/audio_processing/ns/nsx_core_neon.c

Project Member Comment 66 by bugdroid1@chromium.org, Apr 24 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/affcfb2f16fa93b9e583f2af0c43881d09ff25de

commit affcfb2f16fa93b9e583f2af0c43881d09ff25de
Author: Bjorn Volcker <bjornv@chromium.org>
Date: Fri Apr 24 06:12:07 2015

Refactor common_audio/signal_processing: Removed usage of trivial macro WEBRTC_SPL_MUL_16_16

The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

Also includes
- style changes
- replaced pointer operations with direct element access

BUG=3348,3353
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48949004

Cr-Commit-Position: refs/heads/master@{#9075}

[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/complex_fft.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/division_operations.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/filter_ar.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/filter_ma_fast_q12.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/ilbc_specific_functions.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/levinson_durbin.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/lpc_to_refl_coef.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/spl_sqrt.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/sqrt_of_one_minus_x_squared.c
[modify] http://crrev.com/affcfb2f16fa93b9e583f2af0c43881d09ff25de/webrtc/common_audio/signal_processing/vector_scaling_operations.c

Project Member Comment 67 by bjornv@webrtc.org, May 26 2015
Cc: bjornv@webrtc.org
Project Member Comment 68 by bjornv@webrtc.org, Jun 30 2015
Cc: -bjornv@webrtc.org
Owner: ----
Project Member Comment 69 by tina.legrand@webrtc.org, Nov 24 2015
Owner: tina.legrand@webrtc.org
Project Member Comment 70 by henrik.lundin@webrtc.org, Oct 5 2016
Components: Audio
Project Member Comment 71 by henrik.lundin@webrtc.org, Oct 5 2016
Components: -SignalProcessing
Sign in to add a comment