New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Archived
Owner:
Last visit 17 days ago
Closed: Nov 2017
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Enhancement



Sign in to add a comment

Complete refactoring of VAD

Project Member Reported by bjornv@webrtc.org, May 14 2014

Issue description

Feature description (please include a link to the functional spec):
A refactoring project of the VAD component was started in 2012, but have been put on hold for a while. Time to complete it.

Eng owner: bjornv@webrtc.org



 
Project Member

Comment 1 by bjornv@webrtc.org, Aug 19 2014

Status: Assigned
Project Member

Comment 2 by tina.legrand@webrtc.org, Oct 30 2014

Labels: EngTriaged IceBox
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/3fbf99c44a30f09d4e3402e192067d053ced5c55

commit 3fbf99c44a30f09d4e3402e192067d053ced5c55
Author: Bjorn Volcker <bjornv@webrtc.org>
Date: Wed Mar 25 13:37:24 2015

Refactor common_audio/vad: Removed usage of WEBRTC_SPL_MUL_16_16_RSFT

The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

BUG= 3347 ,  3348 ,  3353 
TESTED=locally on Linux for both fixed and floating point and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44799004

Cr-Commit-Position: refs/heads/master@{#8857}

[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_core.c
[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_filterbank.c
[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_gmm.c
[modify] http://crrev.com/3fbf99c44a30f09d4e3402e192067d053ced5c55/webrtc/common_audio/vad/vad_sp.c

Project Member

Comment 4 by bjornv@webrtc.org, May 26 2015

Cc: bjornv@webrtc.org
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/de4703c5d1290da22feeb708fe915179884e210f

commit de4703c5d1290da22feeb708fe915179884e210f
Author: Bjorn Volcker <bjornv@webrtc.org>
Date: Wed May 27 05:22:58 2015

Refactor common_audio/vad: Create now returns the handle directly instead of an error code

Changed the WebRtcVad_Create() function to the more conventional format of returning the handle directly instead of an error code to take care of.
In addition NULL was changed to nullptr in the files where it applied.

Affected components:
* AGC
* VAD
* NetEQ

BUG= 441 ,  3347 
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/51919004

Cr-Commit-Position: refs/heads/master@{#9291}

[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/common_audio/vad/include/webrtc_vad.h
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/common_audio/vad/vad.cc
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/common_audio/vad/vad_unittest.cc
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/common_audio/vad/webrtc_vad.c
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/modules/audio_coding/neteq/post_decode_vad.cc
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/modules/audio_coding/neteq/test/RTPencode.cc
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/modules/audio_processing/agc/standalone_vad.cc
[modify] http://crrev.com/de4703c5d1290da22feeb708fe915179884e210f/webrtc/modules/audio_processing/voice_detection_impl.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/c3deaa30d51dc6336365f0fee3843419fa8616f9

commit c3deaa30d51dc6336365f0fee3843419fa8616f9
Author: Bjorn Volcker <bjornv@webrtc.org>
Date: Thu May 28 12:30:22 2015

common_audio/vad: Removes head allocation failure check

Related to https://webrtc-codereview.appspot.com/51919004/ where Create() was changed. This CL removes a useless malloc failure check.

BUG= 441 ,  3347 
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/51109004

Cr-Commit-Position: refs/heads/master@{#9312}

[modify] http://crrev.com/c3deaa30d51dc6336365f0fee3843419fa8616f9/webrtc/common_audio/vad/include/webrtc_vad.h
[modify] http://crrev.com/c3deaa30d51dc6336365f0fee3843419fa8616f9/webrtc/common_audio/vad/webrtc_vad.c

Project Member

Comment 7 by bjornv@webrtc.org, Jun 30 2015

Cc: -bjornv@webrtc.org
Owner: ----
Status: Available
Project Member

Comment 8 by tina.legrand@webrtc.org, Nov 24 2015

Owner: tina.legrand@webrtc.org
Project Member

Comment 9 by henrik.lundin@webrtc.org, Oct 5 2016

Components: Audio
Project Member

Comment 10 by henrik.lundin@webrtc.org, Oct 5 2016

Components: -SignalProcessing
Project Member

Comment 11 by tina.legrand@webrtc.org, Nov 7 2017

Status: Archived (was: Available)
[Bulk edit] This issue hasn't been modified the last twelve months -> archiving.

If this is still a valid issue that should be open, please reopen again.

Sign in to add a comment