New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Re-enable NetEq tests for Android

Project Member Reported by henrik.lundin@webrtc.org, May 14 2014

Issue description

Several tests were disabled for Android in https://code.google.com/p/webrtc/issues/detail?id=2037. These should be re-enabled.

The tests are disabled with the macro DISABLED_ON_ANDROID.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6143

------------------------------------------------------------------
r6143 | henrik.lundin@webrtc.org | 2014-05-14T10:42:03.167776Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/decoder_database_unittest.cc&spec=svn6143&r_previous=6142&r=6143&format=side

Re-enable NetEQ DecoderDatabase test for Android

The test was failing because iLBC is not enabled on Android. Now, the
test is using PCM16B instead.

BUG= 3343 
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16519004
-----------------------------------------------------------------
Project Member

Comment 2 by bugdroid1@chromium.org, May 14 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6144

------------------------------------------------------------------
r6144 | henrik.lundin@webrtc.org | 2014-05-14T11:45:22.596462Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/neteq_external_decoder_unittest.cc&spec=svn6144&r_previous=6143&r=6144&format=side

Re-enable NetEqExternalDecoderTest for Android

The test runs without problems now.

BUG= 3343 
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16519005
-----------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6168

------------------------------------------------------------------
r6168 | henrik.lundin@webrtc.org | 2014-05-15T07:14:00.006176Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/neteq_unittest.cc&spec=svn6168&r_previous=6167&r=6168&format=side

Re-enable almost all NetEqDecodingTests for Android

All but three tests in NetEqDecodingTest could be re-enabled without
any changes. Also making sure that the TestNetworkStatistics test exits
on first diff. (Otherwise, the log output gets flooded with error
messages.)

The tests that are still disabled are:
NetEqDecodingTest.TestBitExactness
NetEqDecodingTest.TestNetworkStatistics
NetEqDecodingTest.DecoderError

BUG= 3343 
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20489004
-----------------------------------------------------------------
Project Member

Comment 4 by henrik.lundin@webrtc.org, May 19 2014

Labels: neteq
Project Member

Comment 5 by tina.legrand@webrtc.org, Aug 13 2014

Labels: Area-SignalProcessing
Project Member

Comment 6 by tina.legrand@webrtc.org, Oct 30 2014

Labels: EngTriaged IceBox
Project Member

Comment 7 by tnakamura@webrtc.org, Nov 4 2015

Cc: -henrike@webrtc.org
This bug hasn't been modified for more than a year. Is this still a valid open issue? I can't tell from reading the CL descriptions linked above if all relevant tests have since been re-enabled. :)
Project Member

Comment 8 by henrik.lundin@webrtc.org, Nov 5 2015

We still have a few DISABLED_ON_ANDROID in the NetEq code. Leave it open.
Project Member

Comment 9 by henrik.lundin@webrtc.org, Nov 25 2015

Components: Audio
Labels: fixit
Project Member

Comment 10 by henrik.lundin@webrtc.org, Dec 8 2015

Cc: henrik.lundin@webrtc.org
Owner: ivoc@webrtc.org
Project Member

Comment 11 by ivoc@webrtc.org, Dec 8 2015

I found the following NetEq test cases that are disabled on android: 
NetEqStereoTestNoJitter.RunTest
NetEqStereoTestPositiveDrift.RunTest
NetEqStereoTestNegativeDrift.RunTest
NetEqStereoTestDelays.RunTest
NetEqStereoTestLosses.RunTest
NetEqDecodingTest.TestBitExactness
NetEqDecodingTest.DecoderError

I will have a look to see what I can do.
Project Member

Comment 12 by 76821325...@developer.gserviceaccount.com, Jan 20 2016

Project Member

Comment 13 by henrik.lundin@webrtc.org, Oct 5 2016

Components: -SignalProcessing
Project Member

Comment 14 by tina.legrand@webrtc.org, Nov 7 2017

Status: Archived (was: Started)
[Bulk edit] This issue hasn't been modified the last twelve months -> archiving.

If this is still a valid issue that should be open, please reopen again.

Sign in to add a comment