New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users
Status: WontFix
Owner:
Closed: Nov 7
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Enhancement



Sign in to add a comment
Implement unit tests for Audio Conference Mixer module
Reported by hlundin@google.com, May 7 2014 Back to list
The Audio Conference Mixer module lacks proper testing.

 
Comment 1 by hellner@google.com, May 7 2014
Cc: pbos@webrtc.org
There used to be a test from GIPS which was removed in this cl: https://code.google.com/p/webrtc/source/detail?r=4511

It was never ported to using gtest so it was deleted.

Don't know if the code is still usable.
Project Member Comment 2 by henrik.lundin@webrtc.org, May 7 2014
We can probably use that as a starting point.

Project Member Comment 3 by henrik.lundin@webrtc.org, May 8 2014
Owner: henrik.lundin@webrtc.org
Project Member Comment 4 by henrik.lundin@webrtc.org, May 22 2014
Cc: xians@webrtc.org
Project Member Comment 5 by tina.legrand@webrtc.org, Aug 13 2014
Labels: Area-Audio
Project Member Comment 6 by tina.legrand@webrtc.org, Oct 30 2014
Labels: EngTriaged IceBox
Project Member Comment 7 by tnakamura@webrtc.org, Nov 4 2015
Cc: -henrike@webrtc.org -xians@webrtc.org
This bug hasn't been modified for more than a year. Is this still a valid open issue?
Project Member Comment 8 by henrik.lundin@webrtc.org, Nov 5 2015
It still needs to be done if/when we start working on the mixer.
Project Member Comment 9 by tina.legrand@webrtc.org, Nov 7
Status: Archived
[Bulk edit] This issue hasn't been modified the last twelve months -> archiving.

If this is still a valid issue that should be open, please reopen again.
Project Member Comment 10 by henrik.lundin@webrtc.org, Nov 17
Cc: ale...@webrtc.org
aleloi@: the legacy AudioConferenceMixer is gone (https://codereview.webrtc.org/3015553002). Would you say that we have a better unit testing situation with the new one?
Project Member Comment 11 by ale...@webrtc.org, Nov 17
Yes, the testing situation is better. There are a two low-prio bugs webrtc:7364 and webrtc:8036 to add even more tests. We don't have test coverage for running more than one stream through the decoder, fake network, encoder and mixer. I looked into the possibility to extending CallTests and found it difficult. I heard rumors that someone else is working on CallTests to make that possible.
Project Member Comment 12 by henrik.lundin@webrtc.org, Nov 17
Status: WontFix
Thanks. Then this is obsolete, because the component no longer exists, and the replacement is better tested.
Sign in to add a comment