Project: webrtc Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users
Status: Assigned
Owner:
Cc:
Components:
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
Move all third-party code to a third_party directory.
Project Member Reported by andrew@webrtc.org, Apr 26 2014 Back to list
We have several one-off third-party files commingling with our code, documented here:
https://code.google.com/p/webrtc/source/browse/trunk/webrtc/LICENSE_THIRD_PARTY

The LICENSE_THIRD_PARTY approach is not acceptable; all of these files should be moved to a third_party directory.

More details here:
https://docs.google.com/a/google.com/document/d/1wg2U2W8_XYcAF4wU-PPfmV4ib8fFwNxu5vrVSudTI9A/edit
 
Project Member Comment 1 by niklas.enbom@webrtc.org, May 6 2014
Owner: niklas.enbom@webrtc.org
First round of inventory. 

common_audio/signal_processing/spl_sqrt_floor.c
common_audio/signal_processing/spl_sqrt_floor_arm.S
- Posted to mailing list, email verification on OK to use.

modules/audio_coding/codecs/g711/main/source/g711.c
modules/audio_coding/codecs/g711/main/source/g711.h
modules/audio_coding/codecs/g722/main/source/g722_decode.c
modules/audio_coding/codecs/g722/main/source/g722_enc_dec.h
modules/audio_coding/codecs/g722/main/source/g722_encode.c
- SpanDSP, modified files so we need to host a copy.


modules/audio_coding/codecs/isac/main/source/fft.c
- Olesen

modules/audio_device/mac/portaudio/pa_memorybarrier.h
modules/audio_device/mac/portaudio/pa_ringbuffer.c
modules/audio_device/mac/portaudio/pa_ringbuffer.h
- PortAudio, only used on WebRTC standalone. Replace or pull from https://subversion.assembla.com/svn/portaudio/portaudio/trunk/src/common/

modules/audio_processing/aec/aec_rdft.c
modules/audio_processing/utility/fft4g.c
-http://www.kurims.kyoto-u.ac.jp/~ooura/fft.html

system_wrappers/interface/scoped_ptr.h
- Copy from Chromium, will be merged with libJingle/base

system_wrappers/source/condition_variable_event_win.cc
- http://www1.cse.wustl.edu/~schmidt/ACE-copying.html

system_wrappers/source/set_thread_name_win.h
- http://msdn.microsoft.com/en-us/library/xcb2z8hs(VS.71).aspx 

system_wrappers/source/spreadsortlib/constants.hpp
system_wrappers/source/spreadsortlib/spreadsort.hpp
- http://www.boost.org/LICENSE_1_0.txt. Can we replace this?


Project Member Comment 2 by andrew@webrtc.org, May 6 2014
AFAIU, since we have freedom to add Chromium code with the webrtc header, there's no need to consider those files here.
Comment 3 by vrk@webrtc.org, Oct 14 2014
Labels: Area-Internals
Project Member Comment 4 by tnakamura@webrtc.org, Nov 4 2015
Cc: -henrike@webrtc.org kjellander@webrtc.org
This bug hasn't been modified for more than a year. Is this still a valid open issue?
Project Member Comment 5 by andrew@webrtc.org, Nov 4 2015
This is still an issue. It could be non-negligible effort to move some of the stuff, so not sure the extent to which it's worthwhile.

FWIW, I'm looking at removing spreadsortlib.
Sign in to add a comment