New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Assigned
Owner:
User never visited
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Every Linux try bot fails on MouseCursorMonitorTest

Project Member Reported by andrew@webrtc.org, Apr 22 2014

Issue description

For example:
http://build.chromium.org/p/tryserver.webrtc/builders/linux/builds/2830/steps/modules_unittests/logs/stdio

[----------] 3 tests from MouseCursorMonitorTest
[ RUN      ] MouseCursorMonitorTest.FromScreen
X Error of failed request:  BadCursor (invalid Cursor parameter)
  Major opcode of failed request:  142 (XFIXES)
  Minor opcode of failed request:  25 (XFixesGetCursorImageAndName)
  Resource id in failed request:  0x12d
  Serial number of failed request:  10
  Current serial number in output stream:  10
 INFO    run_isolated(252): rmtree(/mnt/data/b/build/slave/linux64/isolate-2014-04-215NotLJ)
Stopping Xvfb with pid 5337 ...
Xvfb pid file removed
 
Project Member

Comment 1 by andrew@webrtc.org, Apr 22 2014

Starting with you Henrik, as it seems to be a problem inherent to the bots (not the test).
Project Member

Comment 2 by andrew@webrtc.org, Apr 24 2014

Some more info here (and presumably why others aren't complaining): this happens for "git try -t modules_unittests" but not a generic "git try". Is there some startup step that's getting skipped in the former case?

Comment 3 by holmer@google.com, May 20 2014

Cc: henrik.lundin@webrtc.org
Henrik, do you have any updates on this? This was reported to me again today by hlundin.
Project Member

Comment 4 by kjellander@webrtc.org, May 20 2014

I'm afraid I don't have any idea what may be causing this.
I suggest we wait for the switch to recipes for the trybots (commits bots were completed today!), then we can see if the problem persists and add custom steps for this to debug it more closely.
Project Member

Comment 5 by henrik.lundin@webrtc.org, May 22 2014

I can reproduce this "locally". If I ssh in to my own linux workstation, I get consistent failures:

$ out/Debug/modules_unittests --gtest_filter=MouseCursorMonitorTest*
Note: Google Test filter = MouseCursorMonitorTest*
[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from MouseCursorMonitorTest
[ RUN      ] MouseCursorMonitorTest.FromScreen
modules_unittests: ../../webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc:62: virtual void webrtc::MouseCursorMonitorTest_FromScreen_Test::TestBody(): Assertion `capturer.get()' failed.
Aborted (core dumped)

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 2 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6300

------------------------------------------------------------------
r6300 | henrik.lundin@webrtc.org | 2014-06-02T14:17:06.012492Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc&spec=svn6300&r_previous=6299&r=6300&format=side

Disable MouseCursorMonitorTest.FromScreen

The test is flaky.

BUG=3245
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/21579004
-----------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 2 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6301

------------------------------------------------------------------
r6301 | henrik.lundin@webrtc.org | 2014-06-02T14:52:34.115101Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc&spec=svn6301&r_previous=6300&r=6301&format=side

Disable MouseCursorMonitorTest

Last attempt reverted. Trying again in a different way.

This CL effectively reverts r6300.

BUG=3245
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/20549004
-----------------------------------------------------------------
Project Member

Comment 9 by kjellander@webrtc.org, Sep 9 2014

Cc: sergeyu@chromium.org
Owner: jiayl@webrtc.org
Following up on this old disabling. jiayl do you know if this has been fixed and can be enabled again?
Project Member

Comment 10 by jiayl@webrtc.org, Sep 9 2014

It doesn't look like fixed.

Sergey,

Any idea on how to fix this?
Project Member

Comment 11 by sergeyu@chromium.org, Sep 30 2014

I think this should fix it: https://webrtc-codereview.appspot.com/31519004/
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 1 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=7362

------------------------------------------------------------------
r7362 | sergeyu@chromium.org | 2014-10-01T23:07:12.980782Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc&spec=svn7362&r_previous=7361&r=7362&format=side

Add error trap for XFixesGetCursorImage()

BUG=https://code.google.com/p/webrtc/issues/detail?id=3245
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31519004
-----------------------------------------------------------------
Project Member

Comment 13 by henrik.lundin@webrtc.org, Oct 2 2014

FWIW: I can still repro as in #5 above using r7369. SSH into my own linux machine, then:

$ out/Debug/modules_unittests --gtest_filter=MouseCursorMonitorTest* --gtest_also_run_disabled_tests
Note: Google Test filter = MouseCursorMonitorTest*
[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from MouseCursorMonitorTest
[ RUN      ] MouseCursorMonitorTest.DISABLED_FromScreen
modules_unittests: ../../webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc:67: virtual void webrtc::MouseCursorMonitorTest_DISABLED_FromScreen_Test::TestBody(): Assertion `capturer.get()' failed.
Aborted (core dumped)

Comment 14 by vrk@webrtc.org, Oct 14 2014

Labels: Area-Desktop
Project Member

Comment 15 by juberti@webrtc.org, Jan 7 2015

Labels: -Area-Desktop Area-GetUserMedia-Desktop
Project Member

Comment 16 by juberti@webrtc.org, Jan 7 2015

Labels: -Area-GetUserMedia-Desktop Area-Desktop
Project Member

Comment 17 by anatolid@webrtc.org, Nov 3 2016

Is this still a valid issue?
Project Member

Comment 18 by henrik.lundin@webrtc.org, Nov 10 2016

Yes. Recent repro (r15018):

out/Default/modules_unittests --gtest_filter=MouseCursorMonitorTest* --gtest_also_run_disabled_tests
Note: Google Test filter = MouseCursorMonitorTest*
[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from MouseCursorMonitorTest
[ RUN      ] MouseCursorMonitorTest.DISABLED_FromScreen
modules_unittests: ../../webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc:70: virtual void webrtc::MouseCursorMonitorTest_DISABLED_FromScreen_Test::TestBody(): Assertion `capturer.get()' failed.
Aborted (core dumped)


Sign in to add a comment