Project: webrtc Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 15 users
Status: Available
Owner: ----
Cc:
Components:
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
SCTP DataChannel stream id assignment does not respect the negotiated max stream count
Project Member Reported by jiayl@chromium.org, Apr 2 2014 Back to list
Currently Chrome allows Javascript to choose any unused 16-bit number as the DataChannel id, which will cause failure if it exceeds the negotiated max stream count (1024 by defalut) for the SCTP association.

We need to implement a way to renegotiate and re-setup the max stream count.
 
Project Member Comment 1 by jiayl@webrtc.org, Apr 2 2014
Cc: juberti@webrtc.org pthatcher@google.com lally@webrtc.org ldixon@webrtc.org
Labels: SCTP Area-PeerConnection
Owner: jiayl@webrtc.org
Status: Assigned
Comment 2 by lally@webrtc.org, Apr 2 2014
Yikes, ok.  Well I guess it's on the developer for invoking the appropriate overhead.

I suppose a check on sid in the OPEN path can prefix the opening with a SCTP_ADD_STREAMS process first.
Project Member Comment 3 by juberti@webrtc.org, Apr 2 2014
Max stream count is being removed from the spec, so I think we can just ignore this unless it is currently causing problems.
Project Member Comment 4 by ldixon@webrtc.org, Sep 5 2014
We probably do want to allow ourselves to use the full 16 bits; so there is a little work to do here to remove the currently imposed default limit, right?
Project Member Comment 5 by ldixon@webrtc.org, Sep 5 2014
Cc: braveyao@webrtc.org vikasmarwaha@webrtc.org
 Issue 3783  has been merged into this issue.
Project Member Comment 6 by pthatcher@webrtc.org, Oct 16 2014
Labels: Mstone-41 EngTriaged
Owner: lally@webrtc.org
Lally and Lucas,

Do you guys know what we need to do to allow JS to use any SID without errors?
Comment 7 by ldixon@google.com, Oct 26 2014
Yes, Lally has a fix; should be ready very soon.
Comment 8 by lally@webrtc.org, Dec 3 2014
Updating based on discussion -- we're waiting for usrsctp to allow sparse SID state (to reduce memory usage), and then we'll pump the max-SID to 64K (from 1K now) in the SCTP INIT message.
Project Member Comment 9 by pthatcher@webrtc.org, Jan 7 2015
Labels: -Mstone-41 Mstone-42
Project Member Comment 10 by pthatcher@webrtc.org, Feb 19 2015
Labels: -Mstone-42 Mstone-44
This looks like it's not hitting m42.  Update it if I'm wrong.
Project Member Comment 11 by braveyao@webrtc.org, May 5 2015
 Issue 4618  has been merged into this issue.
Project Member Comment 12 by juberti@webrtc.org, May 5 2015
Lally, has the max sid issue been resolved yet in usrsctp?
Project Member Comment 13 by tnakamura@webrtc.org, Jan 29 2016
Cc: -vikasmarwaha@webrtc.org
Labels: -Mstone-44
I don't see any CLs linked to this bug, so I don't think it's been fixed. Removing milestone label since this bug hasn't been updated in quite some time.
Project Member Comment 14 by juberti@webrtc.org, Jan 30 2016
Labels: -EngTriaged
Marking for retriage - does usrsctp allow sparse SID state now?
Project Member Comment 15 by pthatcher@webrtc.org, Feb 1 2016
Labels: EngTriaged
Project Member Comment 16 by pthatcher@webrtc.org, Nov 8 2016
Labels: Pri-3
Project Member Comment 17 by kjellander@webrtc.org, Dec 1 2016
Owner: ----
Status: Available
Removing lally@webrtc.org since he left Google a while ago.
Project Member Comment 18 by kjellander@webrtc.org, Dec 1 2016
Cc: -lally@webrtc.org
Comment 19 Deleted
Sign in to add a comment