New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Archived
Owner:
Last visit 17 days ago
Closed: Aug 2017
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Enhancement



Sign in to add a comment

Remove internal sources from VideoEncoders

Project Member Reported by pbos@webrtc.org, Mar 13 2014 Back to list

Issue description

Instead of specifying internal_source() separately a VideoEncoder should state whether it's providing frames or not.

If it's internal_source(), assert on VideoSendStream input that it's not receiving frames through raw-frame input.
 
Project Member

Comment 1 by mflodman@webrtc.org, Sep 30 2014

Labels: Area-Video
Project Member

Comment 2 by pbos@webrtc.org, May 1 2015

Cc: mflodman@webrtc.org stefan@webrtc.org
 Issue 2855  has been merged into this issue.
Project Member

Comment 3 by pbos@webrtc.org, May 1 2015

Cc: noahric@chromium.org
Project Member

Comment 4 by mflodman@webrtc.org, Dec 10 2015

I think the right thing is rather to remove this field when it's not used anymore.

Peter,
Can you take a look at that?
Project Member

Comment 5 by noahric@chromium.org, Dec 16 2015

FYI, it's still in use by at least one product :) Can you hold off a month or three?
Project Member

Comment 6 by pbos@webrtc.org, Dec 17 2015

Cc: pbos@webrtc.org
Owner: noahric@chromium.org
Agreed, Noah I'll let you own it. Let me know (reassign) if you want me to clean it up when you're done, I don't think it's a bunch of work.
Project Member

Comment 7 by pbos@webrtc.org, Dec 17 2015

Summary: Remove internal sources from VideoEncoders
Project Member

Comment 8 by mflodman@webrtc.org, Mar 1 2016

Cc: sprang@webrtc.org
Labels: EngTriaged
20160502_192836.jpg
0 bytes View Download
Project Member

Comment 10 by mflodman@webrtc.org, Aug 4 2017

Status: Archived (was: Assigned)
[Bulk edit] This issue was created more than a year ago and hasn't been modified the last six months -> archiving.

If this is still a valid issue that should be open, please reopen again.

Sign in to add a comment