New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Enhancement



Sign in to add a comment

Make the AEC stats aggregation window independent of polling period.

Project Member Reported by andrew@webrtc.org, Mar 4 2014

Issue description

This could get called by different consumers at different periods. It makes sense for us to specify an aggregation window that is best for the stats, and just report the latest value when polled.
 
Project Member

Comment 1 by andrew@webrtc.org, Apr 3 2014

Cc: andrew@webrtc.org
Owner: tina.legrand@webrtc.org
Over to Tina for eventual prioritization.
Project Member

Comment 2 by tina.legrand@webrtc.org, Oct 30 2014

Labels: EngTriaged IceBox
Project Member

Comment 3 by bjornv@webrtc.org, Oct 31 2014

I think we should prioritize this higher since it is more or less needed for proper UMA stats to work. We can't for example look at AecDelayBasedQuality metrics for other usage than Hangouts.
Project Member

Comment 4 by bjornv@webrtc.org, Dec 29 2014

Cc: -bjornv@webrtc.org tina.legrand@webrtc.org
Labels: -IceBox Mstone-42
Owner: bjornv@webrtc.org
Removed from IceBox and set a new milestone, since this is something we will need in a near future.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/70117a83d464fa650b9fe68644cd253456e34958

commit 70117a83d464fa650b9fe68644cd253456e34958
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Tue Jan 27 11:30:54 2015

AEC: Implements a new function for calculating delay metrics

Two new member variables have been added and the code for calculating the delay metrics have been moved to a function.

BUG= 2994 
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8163 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/70117a83d464fa650b9fe68644cd253456e34958/webrtc/modules/audio_processing/aec/aec_core.c
[modify] http://crrev.com/70117a83d464fa650b9fe68644cd253456e34958/webrtc/modules/audio_processing/aec/aec_core_internal.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/5614cf16e71e59e4785deca05249d9a06f746d66

commit 5614cf16e71e59e4785deca05249d9a06f746d66
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Tue Jan 27 18:09:52 2015

audio_processing: Use fixed aggregation window in delay metrics

Previously, the delay estimate history was reset every time the metrics were pulled. This required all clients to be on the same thread and make use of one call.

Now we use a fixed aggregation window of one second and when a client pulls the metrics you get the latest value.
Under certain circumstances like tests you would like to have the aggregation window set to the recording length. We therefore turn on the fixed aggregation window after the first call.

BUG= 2994 
TESTED=locally on Mac and trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38759004

Cr-Commit-Position: refs/heads/master@{#8170}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8170 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/5614cf16e71e59e4785deca05249d9a06f746d66/webrtc/modules/audio_processing/aec/aec_core.c
[modify] http://crrev.com/5614cf16e71e59e4785deca05249d9a06f746d66/webrtc/modules/audio_processing/aec/aec_core_internal.h

Project Member

Comment 7 by bjornv@webrtc.org, Feb 6 2015

Status: Started
Project Member

Comment 8 by jansson@webrtc.org, Feb 17 2015

bjornv@ is out, I suppose there are more work to be done here? If so please bump to M43 unless someones else takes over.
Project Member

Comment 9 by bjornv@webrtc.org, Mar 3 2015

Labels: -Mstone-42 Mstone-43
The EchoDelayMetrics have been completed, but not EchoMetrics, which currently is only pulled by one user. Targeting these stats for M43.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 5 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d7a212e8b9c76b7c6eaefc6a432b2422b3fe0ab9

commit d7a212e8b9c76b7c6eaefc6a432b2422b3fe0ab9
Author: bjornv@webrtc.org <bjornv@webrtc.org>
Date: Thu Mar 05 16:14:18 2015

audio_processing/aec: Increased delay metrics aggregation window to five seconds

The known clients (GetStats and UMA histogram in Chrome) use at least 5 second aggregation window. There is no particular value in calculating the metrics more often.

The CL also includes a small refactoring moving a declaration inside an if statement.

BUG= 2994 
TEST=N/A
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40219004

Cr-Commit-Position: refs/heads/master@{#8619}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8619 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/d7a212e8b9c76b7c6eaefc6a432b2422b3fe0ab9/webrtc/modules/audio_processing/aec/aec_core.c

Project Member

Comment 11 by bjornv@webrtc.org, Apr 1 2015

Labels: -Mstone-43 Mstone-45
We have the EchoDelayMetrics under fixed aggregation window. Will extend to EchoMetrics when multiple clients request it. Currently only GetStats pull the stats.
Project Member

Comment 12 by bjornv@webrtc.org, Jun 10 2015

Cc: henrik.lundin@webrtc.org
Project Member

Comment 13 by bjornv@webrtc.org, Jun 30 2015

Owner: tina.legrand@webrtc.org
Project Member

Comment 14 by tina.legrand@webrtc.org, Jan 28 2016

Labels: -Mstone-45
Project Member

Comment 15 by henrik.lundin@webrtc.org, Oct 5 2016

Components: Audio
Project Member

Comment 16 by henrik.lundin@webrtc.org, Oct 5 2016

Components: -SignalProcessing
Project Member

Comment 17 by tina.legrand@webrtc.org, Nov 7 2017

Status: Archived (was: Started)
[Bulk edit] This issue hasn't been modified the last twelve months -> archiving.

If this is still a valid issue that should be open, please reopen again.

Sign in to add a comment