New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 30
Cc:
Components:
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-5


Sign in to add a comment

Flaky libjingle_p2p_unittest test: P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay

Project Member Reported by kjellander@webrtc.org, Feb 8 2014 Back to list

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2014

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=5510

------------------------------------------------------------------------
r5510 | kjellander@webrtc.org | 2014-02-08T21:35:20.224870Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/talk/p2p/base/p2ptransportchannel_unittest.cc&spec=svn5510&r_previous=5509&r=5510&format=side

Disable failing libjingle_p2p_unittest test on Linux

I realize this diables 84 test cases and for all platforms, which
I'm not really comfortable with. I tried finding a better way but
couldn't without doing significant changes to the file.
I think the tests either needs to be fixed or otherwise refactored
in order to make more fine-grained disabling possible.

Another (too) large disabling was done by holmer@ in
https://webrtc-codereview.appspot.com/2227004 where he should only have
disabled them on Windows, if the failures in webrtc:2383 was all that
caused those flakes.

BUG= 2907 
TEST=Verified this ran 0 tests:
out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8309004
------------------------------------------------------------------------
Cc: -mallinath@webrtc.org wu@webrtc.org
Owner: mallinath@webrtc.org
Actually r5505 was committed to resolve these failures. Also all the failure logs are from < 5505. Let me try to run try jobs by enabling these tests.
Project Member

Comment 3 by kjellander@webrtc.org, Feb 9 2014

Status: Fixed
OK, it wasn't clear to me that was the purpose with r5505. I'll revert and we'll see how the test behaves. Otherwise we can just revert the revert again to disable easily. I'll marked this as Fixed for now.
Project Member

Comment 4 by kjellander@webrtc.org, Feb 9 2014

Status: Assigned
... and we're back disabling it. The test failed right away at http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio so I reverted my revert again.

I can easily get the test to fail on my machine with r5512 using:
out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay --gtest_repeat=100  --gtest_break_on_failure
Alright, sorry for the trouble.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 10 2014

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=5511

------------------------------------------------------------------------
r5511 | kjellander@webrtc.org | 2014-02-09T18:21:00.117156Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/talk/p2p/base/p2ptransportchannel_unittest.cc&spec=svn5511&r_previous=5510&r=5511&format=side

Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"

According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
r5505 was committed to resolve exactly these flakes.
Let's revert the disabling and see.

BUG= 2907 
TBR=mallinath@webrtc.org

> Disable failing libjingle_p2p_unittest test on Linux
> 
> I realize this diables 84 test cases and for all platforms, which
> I'm not really comfortable with. I tried finding a better way but
> couldn't without doing significant changes to the file.
> I think the tests either needs to be fixed or otherwise refactored
> in order to make more fine-grained disabling possible.
> 
> Another (too) large disabling was done by holmer@ in
> https://webrtc-codereview.appspot.com/2227004 where he should only have
> disabled them on Windows, if the failures in webrtc:2383 was all that
> caused those flakes.
> 
> BUG= 2907 
> TEST=Verified this ran 0 tests:
> out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8309004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8329004
------------------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2014

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=5513

------------------------------------------------------------------------
r5513 | kjellander@webrtc.org | 2014-02-09T18:48:56.587218Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/talk/p2p/base/p2ptransportchannel_unittest.cc&spec=svn5513&r_previous=5512&r=5513&format=side

Revert 5511 "Revert 5510 "Disable failing libjingle_p2p_unittest..."

So, the test apparently failed right away at 

http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio


> Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
> 
> According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
> r5505 was committed to resolve exactly these flakes.
> Let's revert the disabling and see.
> 
> BUG= 2907 
> TBR=mallinath@webrtc.org
> 
> > Disable failing libjingle_p2p_unittest test on Linux
> > 
> > I realize this diables 84 test cases and for all platforms, which
> > I'm not really comfortable with. I tried finding a better way but
> > couldn't without doing significant changes to the file.
> > I think the tests either needs to be fixed or otherwise refactored
> > in order to make more fine-grained disabling possible.
> > 
> > Another (too) large disabling was done by holmer@ in
> > https://webrtc-codereview.appspot.com/2227004 where he should only have
> > disabled them on Windows, if the failures in webrtc:2383 was all that
> > caused those flakes.
> > 
> > BUG= 2907 
> > TEST=Verified this ran 0 tests:
> > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> > TBR=wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/8309004
> 
> TBR=kjellander@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8329004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8339004
------------------------------------------------------------------------

Comment 8 by vrk@webrtc.org, Oct 14 2014

Labels: Area-Network

Comment 9 by vrk@webrtc.org, Nov 3 2014

Cc: mallinath@webrtc.org
Labels: Mstone-42 EngTriaged
Owner: pthatcher@google.com
Project Member

Comment 10 by pthatcher@webrtc.org, Feb 19 2015

Labels: -Mstone-42 Mstone-44
This looks like it's not hitting m42.  Update it if I'm wrong.
Project Member

Comment 11 by pbos@webrtc.org, Feb 23 2015

Is this covering P2PTransportChannelTest.TestNAT_PORT_RESTRICTEDToNAT_SYMMETRIC_THEN_CONEAsGiceNoneSharedUfrag since it's also Gice related?

Observed here (unrelated CL): http://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/3449/steps/rtc_unittests/logs/stdio
Project Member

Comment 12 by pbos@webrtc.org, Feb 23 2015

Cc: pbos@webrtc.org
Owner: pthatcher@webrtc.org
Project Member

Comment 13 by tnakamura@webrtc.org, Feb 1 2016

Cc: -mallinath@webrtc.org -wu@webrtc.org
Labels: -Mstone-44 Hotlist-Testing
I don't see any recent CLs linked to this bug, so I don't think it's been fixed. I'm therefore leaving this in an open state, but I am removing the milestone label since this bug hasn't been updated in quite some time.
Project Member

Comment 14 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 15 by deadbeef@chromium.org, Mar 30

Owner: deadbeef@webrtc.org
Status: Fixed (was: Assigned)
Flakiness should have been fixed by: https://codereview.webrtc.org/2125823004

Sign in to add a comment