New issue
Advanced search Search tips
Starred by 21 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 19
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We're Getting Warning 4373:s on Windows

Project Member Reported by phoglund@webrtc.org, Feb 6 2012

Issue description

What steps will reproduce the problem?
1. Remove the 4373 suppression in msvs_disabled_warnings in src/build/common.gypi.
2. Compile on Windows.

What is the expected output? What do you see instead?
We get warnings (which will be treated as errors) instead of a successful build.

Please use labels and text to provide additional information.
These warnings are likely because of unnecessary use of const int in certain signatures. Not sure if it's possible to get rid of the warnings with the current version of the googlemock library.
 
Project Member

Comment 1 by alberto@google.com, Mar 8 2012

Labels: -Type-Defect -Priority-Low Type-Bug Pri-3
Status: Assigned
Project Member

Comment 2 by phoglund@webrtc.org, Aug 15 2012

Status: WontFix
I don't see that this is important enough to fix, so I'll close this one if no-one objects?
Project Member

Comment 3 by kjellander@webrtc.org, Dec 19 2014

Cc: phoglund@webrtc.org pbos@webrtc.org
Owner: ----
Status: Available
This makes GYP and GN ugly, since it's so easy to fix (right?) I think we should consider that.
Project Member

Comment 4 by kjellander@webrtc.org, Dec 19 2014

 Issue 4121  has been merged into this issue.
Project Member

Comment 5 by juberti@webrtc.org, Jan 7 2015

Labels: Area-Build
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/8649fed1b83882d2f25d3c58a3464a0a59a22225

commit 8649fed1b83882d2f25d3c58a3464a0a59a22225
Author: kjellander@webrtc.org <kjellander@webrtc.org>
Date: Thu Jan 08 21:22:01 2015

GN: Fix Windows build.

This required a tiny include fix in
src/third_party/winsdk_samples/src
which was committed in
https://code.google.com/p/webrtc/source/detail?r=7951

This incorporates contribution from vchigrin@yandex-team.ru
in https://webrtc-codereview.appspot.com/29299004/

BUG= 261 ,1348, 4105 
R=pbos@webrtc.org
TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8027 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/DEPS
[add] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/third_party/winsdk_samples/BUILD.gn
[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/third_party/winsdk_samples/OWNERS
[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/webrtc/modules/audio_coding/BUILD.gn
[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/webrtc/modules/rtp_rtcp/BUILD.gn
[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/webrtc/modules/video_coding/BUILD.gn
[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/webrtc/video_engine/BUILD.gn
[modify] http://crrev.com/8649fed1b83882d2f25d3c58a3464a0a59a22225/webrtc/voice_engine/BUILD.gn

Comment 8 Deleted

Project Member

Comment 9 by pbos@webrtc.org, Sep 19 2017

Cc: -pbos@webrtc.org
+++
Project Member

Comment 11 by phoglund@webrtc.org, Jan 18

Owner: phoglund@webrtc.org
Status: Assigned (was: Available)
Project Member

Comment 13 by phoglund@webrtc.org, Jan 19

Status: Fixed (was: Assigned)

Sign in to add a comment