New issue
Advanced search Search tips
Starred by 21 users

Issue metadata

Status: Fixed
Closed: Jan 2018
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Sign in to add a comment

We're Getting Warning 4373:s on Windows

Project Member Reported by, Feb 6 2012

Issue description

What steps will reproduce the problem?
1. Remove the 4373 suppression in msvs_disabled_warnings in src/build/common.gypi.
2. Compile on Windows.

What is the expected output? What do you see instead?
We get warnings (which will be treated as errors) instead of a successful build.

Please use labels and text to provide additional information.
These warnings are likely because of unnecessary use of const int in certain signatures. Not sure if it's possible to get rid of the warnings with the current version of the googlemock library.
Project Member

Comment 1 by, Mar 8 2012

Labels: -Type-Defect -Priority-Low Type-Bug Pri-3
Status: Assigned
Project Member

Comment 2 by, Aug 15 2012

Status: WontFix
I don't see that this is important enough to fix, so I'll close this one if no-one objects?
Project Member

Comment 3 by, Dec 19 2014

Owner: ----
Status: Available
This makes GYP and GN ugly, since it's so easy to fix (right?) I think we should consider that.
Project Member

Comment 4 by, Dec 19 2014

 Issue 4121  has been merged into this issue.
Project Member

Comment 5 by, Jan 7 2015

Labels: Area-Build
Project Member

Comment 6 by, Jan 8 2015

The following revision refers to this bug:

commit 8649fed1b83882d2f25d3c58a3464a0a59a22225
Author: <>
Date: Thu Jan 08 21:22:01 2015

GN: Fix Windows build.

This required a tiny include fix in
which was committed in

This incorporates contribution from

BUG= 261 , 1348 , 4105

Review URL:

git-svn-id: 4adac7df-926f-26a2-2b94-8c16560cd09d


Comment 8 Deleted

Project Member

Comment 9 by, Sep 19 2017

Project Member

Comment 11 by, Jan 18 2018

Status: Assigned (was: Available)
Project Member

Comment 13 by, Jan 19 2018

Status: Fixed (was: Assigned)

Sign in to add a comment