Convert options and statistics from explicitly-typed fields to dictionaries (e.g. chromium's base::Value or win's VARIANT)
Reported by firstname.lastname@example.org, Oct 21 2013
Today webrtc & libjingle use structs to pass options and statistics around. This causes a lot of unnecessary work that is effectively generic serializing/deserializing, as well as verbosity in code that needs to mention each field explicitly instead of simply doing a walk of the dictionary. chromium's base::Value (or a similar nestable/mergable dictionary) could replace the use of protobufs in options and explicit-parameter-passing in stats. Example uses: http://cr/55119537-p10 and https://webrtc-codereview.appspot.com/2429004/ 3rd-party docs: base::Value: https://code.google.com/p/chromium/codesearch#chromium/src/base/values.h VARIANT: http://msdn.microsoft.com/en-us/library/windows/desktop/dd373687(v=vs.85).aspx
Dec 17 2014,
Jan 6 2015,
We'd like to focus on rewriting VideoOptions and AudioOptions to use base::Value or similar. We should not add any more VideoOptions until this is cleaned up.
Jan 6 2015,
Jan 7 2015,
(Note that you're with this labling essentially saying that we don't add any VideoOptions before M44, that sounds like it might be unreasonable to me.)
Feb 1 2016,
I don't see any recent CLs linked to this bug, so I don't think it's been fixed. I'm therefore leaving this in an open state, but I am removing the milestone label since this bug hasn't been updated in quite some time.
Nov 8 2016,
Dec 14 2016,
Sep 19 2017,
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available.
Sign in to add a comment