New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert options and statistics from explicitly-typed fields to dictionaries (e.g. chromium's base::Value or win's VARIANT)

Reported by fischman@webrtc.org, Oct 21 2013

Issue description

Today webrtc & libjingle use structs to pass options and statistics around.
This causes a lot of unnecessary work that is effectively generic serializing/deserializing, as well as verbosity in code that needs to mention each field explicitly instead of simply doing a walk of the dictionary.  

chromium's base::Value (or a similar nestable/mergable dictionary) could replace the use of protobufs in options and explicit-parameter-passing in stats.  

Example uses: http://cr/55119537-p10 and https://webrtc-codereview.appspot.com/2429004/

3rd-party docs:
base::Value: https://code.google.com/p/chromium/codesearch#chromium/src/base/values.h
VARIANT: http://msdn.microsoft.com/en-us/library/windows/desktop/dd373687(v=vs.85).aspx
 

Comment 1 by vrk@webrtc.org, Dec 17 2014

Labels: Area-PeerConnection
Project Member

Comment 2 by pthatcher@webrtc.org, Jan 6 2015

Cc: pbos@webrtc.org
Owner: pthatcher@webrtc.org
We'd like to focus on rewriting VideoOptions and AudioOptions to use base::Value or similar.  

We should not add any more VideoOptions until this is cleaned up.
Project Member

Comment 3 by pthatcher@webrtc.org, Jan 6 2015

Labels: EngTriaged mstone-44
Project Member

Comment 4 by pbos@webrtc.org, Jan 7 2015

(Note that you're with this labling essentially saying that we don't add any VideoOptions before M44, that sounds like it might be unreasonable to me.)
Project Member

Comment 5 by tnakamura@webrtc.org, Feb 1 2016

Labels: -Mstone-44
I don't see any recent CLs linked to this bug, so I don't think it's been fixed. I'm therefore leaving this in an open state, but I am removing the milestone label since this bug hasn't been updated in quite some time.
Project Member

Comment 6 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 7 by anatolid@webrtc.org, Dec 14 2016

Cc: pthatcher@webrtc.org
Owner: ----
Project Member

Comment 8 by pbos@webrtc.org, Sep 19 2017

Cc: -pbos@webrtc.org
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 19 (2 days ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.


Sign in to add a comment