Project: webrtc Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 2414 VCM & WEBRTC_VIDEO error #defines are out of sync
Starred by 7 users Reported by fischman@webrtc.org, Sep 23 2013 Back to list
Status: Assigned
Owner:
Cc:
Components:
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
video_error_codes.h says NOTE: in sync with video_coding_module_defines.h but several codes appear to be out of sync:

#define WEBRTC_VIDEO_CODEC_ERROR -1
==VCM_GENERAL_ERROR, but then what is VCM_CODEC_ERROR for?

#define WEBRTC_VIDEO_CODEC_ERR_SIZE -5
== VCM_UNKNOWN_PAYLOAD, even though "unknown payload" sounds different to "err size"; are they really the same?

#define WEBRTC_VIDEO_CODEC_TIMEOUT -6
==VCM_CODEC_ERROR, but the former seems much more specific than the latter.

I assume some/all of these are artifacts of history, but don't know which are benign and which may be problematical.

Stefan: do you know?  (can benign ones be commented to that effect in the code?)
 
Project Member Comment 1 by stefan@webrtc.org, Oct 1 2013
We should probably remove that note as I don't see any point in keeping them in sync. I would actually go as far as entirely removing defined error codes for VCM and just returning -1. I think that would be fine.
Comment 2 by vrk@webrtc.org, Oct 14 2014
Labels: Area-Build
Project Member Comment 3 by tnakamura@webrtc.org, Nov 4 2015
Cc: pbos@webrtc.org mflodman@webrtc.org kjellander@webrtc.org
This bug hasn't been modified for more than a year. Is this still a valid open issue?
Project Member Comment 4 by stefan@webrtc.org, Nov 5 2015
I don't think this has changed, so I guess it's valid, but maybe not super high priority...
Project Member Comment 5 by pbos@webrtc.org, Nov 5 2015
Should this request just be changed to remove excess error codes for codecs and have bools for the interface level?

WEBRTC_VIDEO_CODEC_ERR_PARAMETER for instance should probably be replaced with a DCHECK and death.
Project Member Comment 6 by pbos@webrtc.org, Nov 5 2015
The only useful ones I know of WEBRTC_VIDEO_CODEC_* are OK, ERROR and FALLBACK_SOFTWARE.
Project Member Comment 7 by stefan@webrtc.org, Mar 31
Labels: -Pri-2 Pri-3
Sign in to add a comment