New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 2414 link

Starred by 11 users

Issue metadata

Status: Archived
Closed: Oct 2
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Sign in to add a comment

VCM & WEBRTC_VIDEO error #defines are out of sync

Reported by, Sep 23 2013

Issue description

video_error_codes.h says NOTE: in sync with video_coding_module_defines.h but several codes appear to be out of sync:

==VCM_GENERAL_ERROR, but then what is VCM_CODEC_ERROR for?

== VCM_UNKNOWN_PAYLOAD, even though "unknown payload" sounds different to "err size"; are they really the same?

==VCM_CODEC_ERROR, but the former seems much more specific than the latter.

I assume some/all of these are artifacts of history, but don't know which are benign and which may be problematical.

Stefan: do you know?  (can benign ones be commented to that effect in the code?)
Project Member

Comment 1 by, Oct 1 2013

We should probably remove that note as I don't see any point in keeping them in sync. I would actually go as far as entirely removing defined error codes for VCM and just returning -1. I think that would be fine.

Comment 2 by, Oct 14 2014

Labels: Area-Build
Project Member

Comment 3 by, Nov 4 2015

This bug hasn't been modified for more than a year. Is this still a valid open issue?
Project Member

Comment 4 by, Nov 5 2015

I don't think this has changed, so I guess it's valid, but maybe not super high priority...
Project Member

Comment 5 by, Nov 5 2015

Should this request just be changed to remove excess error codes for codecs and have bools for the interface level?

WEBRTC_VIDEO_CODEC_ERR_PARAMETER for instance should probably be replaced with a DCHECK and death.
Project Member

Comment 6 by, Nov 5 2015

The only useful ones I know of WEBRTC_VIDEO_CODEC_* are OK, ERROR and FALLBACK_SOFTWARE.
Project Member

Comment 7 by, Mar 31 2017

Labels: -Pri-2 Pri-3
Project Member

Comment 8 by, Sep 19 2017

Project Member

Comment 9 by, Oct 2

Status: Archived (was: Assigned)

Sign in to add a comment