New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 30
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

p2ptransportchannel_unittest flaky on win bots

Project Member Reported by stefan@webrtc.org, Sep 17 2013 Back to list

Issue description

e:\b\build\slave\win\build\src\talk\p2p\base\p2ptransportchannel_unittest.cc(505): error: Value of: CheckDataOnChannel(ep2_ch1(), data, len)
Actual: false
Expected: true
http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/1126/steps/libjingle_p2p_unittest/logs/TestOPENToNAT_FULL_CONEAsGiceBothSharedUfrag


e:\b\build\slave\win\build\src\talk\p2p\base\p2ptransportchannel_unittest.cc(505): error: Value of: CheckDataOnChannel(ep2_ch1(), data, len)
Actual: false
Expected: true
[022:682] Removed binding TESTICEUFRAG0000, 1 remaining
[022:682] Removed binding TESTICEUFRAG0001, 0 remaining
http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/1120/steps/libjingle_p2p_unittest/logs/TestOPENToNAT_DOUBLE_CONEAsGiceBothSharedUfragWithMinimumStepDelay

Disabling both tests.
 

Comment 1 by wu@webrtc.org, Sep 18 2013

Cc: wu@webrtc.org
Owner: mallinath@webrtc.org
Project Member

Comment 2 by juberti@webrtc.org, Mar 26 2014

Cc: juberti@webrtc.org
Owner: jiayl@webrtc.org
Assigning to Jiayang.

Comment 4 by vrk@webrtc.org, Oct 14 2014

Labels: Area-Network

Comment 5 by vrk@webrtc.org, Nov 3 2014

Labels: Mstone-42 EngTriaged
Project Member

Comment 6 by pthatcher@webrtc.org, Feb 19 2015

Labels: -Mstone-42 Mstone-44
This looks like it's not hitting m42.  Update it if I'm wrong.
Project Member

Comment 7 by juberti@webrtc.org, Feb 1 2016

Cc: -wu@webrtc.org -henrike@webrtc.org
Labels: -Mstone-44 Hotlist-Testing
Owner: pthatcher@webrtc.org
Project Member

Comment 8 by deadbeef@webrtc.org, Jul 7 2016

Owner: deadbeef@webrtc.org
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/62351c9923b557b41e90c228ae8c3209a10796c5

commit 62351c9923b557b41e90c228ae8c3209a10796c5
Author: Taylor Brandstetter <deadbeef@webrtc.org>
Date: Thu Aug 11 23:05:07 2016

Fixing problems with ICE candidate pair prioritization.

The main issue was that upon receiving a binding response with a srflx
mapped address attribute, the local candidate was not updated from local
to srflx. This means the two ICE agents view the same pair differently;
one sees it as "X<->srflx" while the other sees it as "local<->X". This
causes sub-optimal prioritization and could result in the wrong pair
being selected if using aggressive nomination.

The other issue was that TCP prflx candidates were not differentiated from
UDP prflx candidates. This lead to TCP prflx candidates prioritized above TCP
host candidates.

After fixing these issues, I was able to re-enable many disabled tests, as well
as restore the check for the candidate types of the controlled agent.

BUG= webrtc:1953 , webrtc:2383 
R=honghaiz@webrtc.org, pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/2125823004 .

Cr-Commit-Position: refs/heads/master@{#13734}

[modify] https://crrev.com/62351c9923b557b41e90c228ae8c3209a10796c5/webrtc/p2p/base/p2ptransportchannel_unittest.cc
[modify] https://crrev.com/62351c9923b557b41e90c228ae8c3209a10796c5/webrtc/p2p/base/port.cc
[modify] https://crrev.com/62351c9923b557b41e90c228ae8c3209a10796c5/webrtc/p2p/base/port.h

Project Member

Comment 10 by pthatcher@webrtc.org, Nov 8 2016

Labels: Pri-3
Project Member

Comment 11 by deadbeef@chromium.org, Mar 30

Status: Fixed
Flakiness should be fixed by the above CL.

Sign in to add a comment