New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 2372 link

Starred by 6 users

Issue metadata

Status: Archived
Last visit > 30 days ago
Closed: Mar 2018
NextAction: ----
OS: ----
Pri: 3
Type: Patch

Sign in to add a comment

Patch for /trunk/webrtc/modules/rtp_rtcp/source/ (use "1" as sending SSRC for FIRs)

Reported by, Sep 13 2013

Issue description

Use "1" as the sending ssrc for FIRs, so that they will successfully pass SsrcMuxFilter::DemuxPacket().  Without this, all FIRs are dropped when received, unless the sender's ssrc has been (incorrectly) added as a known stream.
393 bytes View Download
Project Member

Comment 1 by, Sep 13 2013

I think it would make more sense to do this at a higher level.  In particular, to change VideoConference::CreateStream from this:


To something like this:

  uint32 feedback_ssrc = 1;
      MakeReceiveEndpointConfig(config, feedback_ssrc, stream.get());

Comment 2 by, Oct 14 2014

Labels: Area-Network

Comment 3 by, Nov 3 2014

Labels: EngTriaged Mstone-41
Status: Assigned
Hey Peter, can you take this for M41? Myles & team still really want this fix.
Project Member

Comment 4 by, Dec 10 2014

Labels: -Mstone-41
Myles, I believe this has been fixed, has it not?  That file in the code is way different now, at least.
Project Member

Comment 5 by, Nov 8 2016

Labels: Pri-3
Project Member

Comment 6 by, Mar 30 2018

Status: Archived (was: Assigned)
Summary: Patch for /trunk/webrtc/modules/rtp_rtcp/source/ (use "1" as sending SSRC for FIRs) (was: Patch for /trunk/webrtc/modules/rtp_rtcp/source/
Archiving since the patch is obsolete and the issue is assumed fixed.

Sign in to add a comment