Patch for /trunk/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (use "1" as sending SSRC for FIRs)
|Reported by email@example.com, Sep 13 2013||Back to list|
Use "1" as the sending ssrc for FIRs, so that they will successfully pass SsrcMuxFilter::DemuxPacket(). Without this, all FIRs are dropped when received, unless the sender's ssrc has been (incorrectly) added as a known stream.
Sep 13 2013,
I think it would make more sense to do this at a higher level. In particular, to change VideoConference::CreateStream from this: endpoint->CreateReceiveEndpoint( MakeReceiveEndpointConfig( config, allocated_send_ssrcs_[make_pair(config.participant_name(), config.stream_name())]->SSRC()), stream.get()); To something like this: uint32 feedback_ssrc = 1; endpoint->CreateReceiveEndpoint( MakeReceiveEndpointConfig(config, feedback_ssrc, stream.get());
Oct 14 2014,
Nov 3 2014,
Hey Peter, can you take this for M41? Myles & team still really want this fix.
Dec 10 2014,
Myles, I believe this has been fixed, has it not? That file in the code is way different now, at least.
Nov 8 2016,
Archiving since the patch is obsolete and the issue is assumed fixed.
Sign in to add a comment