New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users
Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Patch



Sign in to add a comment
Patch for /trunk/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
Reported by mylesj@google.com, Sep 13 2013 Back to list
Use "1" as the sending ssrc for FIRs, so that they will successfully pass SsrcMuxFilter::DemuxPacket().  Without this, all FIRs are dropped when received, unless the sender's ssrc has been (incorrectly) added as a known stream.
 
rtcp_sender.cc.patch
393 bytes View Download
Project Member Comment 1 by pthatcher@google.com, Sep 13 2013
I think it would make more sense to do this at a higher level.  In particular, to change VideoConference::CreateStream from this:

  endpoint->CreateReceiveEndpoint(
      MakeReceiveEndpointConfig(
          config,
          allocated_send_ssrcs_[make_pair(config.participant_name(),
                                         config.stream_name())]->SSRC()),
      stream.get());

To something like this:

  uint32 feedback_ssrc = 1;
  endpoint->CreateReceiveEndpoint(
      MakeReceiveEndpointConfig(config, feedback_ssrc, stream.get());
Comment 2 by vrk@webrtc.org, Oct 14 2014
Labels: Area-Network
Comment 3 by vrk@webrtc.org, Nov 3 2014
Cc: myles@google.com
Labels: EngTriaged Mstone-41
Owner: pthatcher@webrtc.org
Status: Assigned
Hey Peter, can you take this for M41? Myles & team still really want this fix.
Project Member Comment 4 by pthatcher@google.com, Dec 10 2014
Labels: -Mstone-41
Myles, I believe this has been fixed, has it not?  That file in the code is way different now, at least.
Project Member Comment 5 by pthatcher@webrtc.org, Nov 8 2016
Labels: Pri-3
Sign in to add a comment