New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users
Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
PeerConnectionTest.java & RTCPeerConnection.mm should be written using callbacks instead of serializing waits
Reported by fischman@webrtc.org, Jul 22 2013 Back to list
The PC unittest in Java (and in ObjC when the latter was cloned from it) was written in a faux-serial style; instead, the test should phrase its expectations via callbacks to speed it up and to make it less brittle to event delivery timing.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/app/webrtc/javatests/src/org/webrtc/PeerConnectionTest.java&q=f:peerconnectiontest.java%20todo&sq=package:chromium&type=cs&l=323
 
Comment 1 by fischman@webrtc.org, Jul 26 2013
Labels: -2013Q3 2013Q3-CQ
Comment 2 by vrk@webrtc.org, Oct 15 2014
Labels: Area-PeerConnection
Comment 3 by vrk@webrtc.org, Oct 16 2014
Labels: -2013Q3-CQ icebox EngTriaged
Project Member Comment 4 by tnakamura@webrtc.org, Nov 4 2015
Cc: pthatcher@webrtc.org
This bug hasn't been modified for more than a year. Is this still a valid open issue?
Project Member Comment 5 by pthatcher@webrtc.org, Nov 8 2016
Labels: Pri-3
Sign in to add a comment