New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 32 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 2
Type: Enhancement



Sign in to add a comment

Enable Chrome clang plugins

Project Member Reported by andrew@webrtc.org, Nov 30 2011 Back to list

Issue description

When enabled, clang on Mac reports a large number of chromium-style warnings. A few examples:
- Complex constructor has an inlined body.
- Complex class/struct needs an explicit out-of-line destructor.
- virtual methods with non-empty bodies shouldn't be declared inline.
- Overridden method must have "virtual" keyword.

These are probably good practices to follow. Should we fix these warnings and enable the plugins?
 
Project Member

Comment 1 by alberto@google.com, Mar 8 2012

Labels: -Priority-Low Pri-3
Project Member

Comment 2 by alberto@google.com, Mar 8 2012

Status: Assigned (was: NULL)

Comment 3 by cd@webrtc.org, Mar 26 2012

Another thing worth noting is that change 1059 (addition of 'clang_use_chrome_plugins%': 0) has the fortunate side effect of increasing the performance of AEC by 8% for the straight C path and 12% for the SSE2 path.

Before enabling back, please check performance impact.
Project Member

Comment 4 by andrew@webrtc.org, May 1 2012

It was actually the switch to clang in r1059 that improved performance. We have no intention of rolling that back.
Project Member

Comment 5 by thakis@chromium.org, Jul 2 2012

What's AEC?
Project Member

Comment 6 by andrew@webrtc.org, Jul 3 2012

Acoustic echo cancellation. It removes the played-out audio from the recorded stream, which would otherwise be perceived as an echo by the remote participant.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2012

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=2152

------------------------------------------------------------------------
r2152 | andrew@webrtc.org | 2012-05-01T21:39:34.117824Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/src/build/common.gypi&spec=svn2152&r_previous=2151&r=2152&format=side

Disable clang Chrome plugins on all platforms.

(Will fix Linux-clang bot).

TBR=wu@webrtc.org
BUG=issue163
TEST=build on Linux-clang

Review URL: https://webrtc-codereview.appspot.com/545005
------------------------------------------------------------------------
Project Member

Comment 8 by kjellander@webrtc.org, Nov 21 2012

Cc: phoglund@webrtc.org
This sounds like a good tool for us to have since it catches bad coding style earlier. 
Should we assign this issue to someone to get these things fixed? 

Getting our codebase closer to Chromium style should be something to strive for and the required code modifications seem fairly easy to do.

To see the warnings: just set run gyp_chromium with -Dclang_use_chrome_plugins=1 and then compile with Clang.
Project Member

Comment 9 by phoglund@webrtc.org, Nov 21 2012

How many warnings are there to fix?
Project Member

Comment 10 by pbos@webrtc.org, May 20 2013

Owner: pbos@webrtc.org
I've done some work on reducing clang warnings, I can take this. Assign it back to you if you still want it Niklas.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 30 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4426

------------------------------------------------------------------------
r4426 | pbos@webrtc.org | 2013-07-30T12:32:59.955115Z

Changed paths:
   A http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/dummy/audio_device_utility_dummy.cc&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/dummy/audio_device_utility_dummy.h&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/linux/audio_device_alsa_linux.h&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/audio_device.gypi&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/audio_device_impl.h&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/linux/audio_device_utility_linux.h&spec=svn4426&r_previous=4425&r=4426&format=side
   A http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/dummy/audio_device_dummy.cc&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/dummy/audio_device_dummy.h&spec=svn4426&r_previous=4425&r=4426&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h&spec=svn4426&r_previous=4425&r=4426&format=side

Fix some chromium-style warnings in webrtc/modules/audio_device/

BUG=163
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1897005
------------------------------------------------------------------------
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 30 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4427

------------------------------------------------------------------------
r4427 | pbos@webrtc.org | 2013-07-30T12:50:59.985888Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/tools/simple_command_line_parser.cc&spec=svn4427&r_previous=4426&r=4427&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/tools/simple_command_line_parser.h&spec=svn4427&r_previous=4426&r=4427&format=side

Fix some chromium-style warnings in webrtc/tools/

BUG=163
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1908004
------------------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 30 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4428

------------------------------------------------------------------------
r4428 | pbos@webrtc.org | 2013-07-30T13:08:38.416405Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/testsupport/frame_reader.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/testsupport/frame_reader.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/libtest/include/bit_flip_encryption.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/include/channel_transport.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/testsupport/trace_to_stderr.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/testsupport/trace_to_stderr.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/testsupport/frame_writer.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_socket_manager_posix.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/testsupport/frame_writer.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_socket_posix.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_socket_posix.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_transport_impl.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/libtest/helpers/bit_flip_encryption.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_transport_impl.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_socket_wrapper.cc&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/libtest/include/random_encryption.h&spec=svn4428&r_previous=4427&r=4428&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/test/channel_transport/udp_socket_wrapper.h&spec=svn4428&r_previous=4427&r=4428&format=side

Fix some chromium-style warnings in webrtc/test/

BUG=163
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1907004
------------------------------------------------------------------------
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 30 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4429

------------------------------------------------------------------------
r4429 | pbos@webrtc.org | 2013-07-30T15:18:31.064414Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/test/videoprocessor.h&spec=svn4429&r_previous=4428&r=4429&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/test/stats.cc&spec=svn4429&r_previous=4428&r=4429&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/test/stats.h&spec=svn4429&r_previous=4428&r=4429&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/test/predictive_packet_manipulator.h&spec=svn4429&r_previous=4428&r=4429&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/i420/main/interface/i420.h&spec=svn4429&r_previous=4428&r=4429&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/test/packet_manipulator.h&spec=svn4429&r_previous=4428&r=4429&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/codecs/test/videoprocessor.cc&spec=svn4429&r_previous=4428&r=4429&format=side

Fix some chromium-style warnings in webrtc/modules/video_coding/

BUG=163
R=mikhal@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1901005
------------------------------------------------------------------------
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 31 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4442

------------------------------------------------------------------------
r4442 | pbos@webrtc.org | 2013-07-31T15:16:20.065758Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc&spec=svn4442&r_previous=4441&r=4442&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/bitrate_controller/bitrate_controller_impl.h&spec=svn4442&r_previous=4441&r=4442&format=side

Fix some chromium-style warnings in webrtc/modules/bitrate_controller/

BUG=163
R=pwestin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1903004
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 31 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4444

------------------------------------------------------------------------
r4444 | pbos@webrtc.org | 2013-07-31T15:17:19.923361Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/forward_error_correction.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_sender.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtcp_sender.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.cc&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/rtp_header_parser.cc&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h&spec=svn4444&r_previous=4443&r=4444&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/source/forward_error_correction.cc&spec=svn4444&r_previous=4443&r=4444&format=side

Fix some chromium-style warnings in webrtc/modules/rtp_rtcp/

BUG=163
R=pwestin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1904005
------------------------------------------------------------------------
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 31 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4445

------------------------------------------------------------------------
r4445 | pbos@webrtc.org | 2013-07-31T15:18:19.675781Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/pacing/include/paced_sender.h&spec=svn4445&r_previous=4444&r=4445&format=side

Fix some chromium-style warnings in webrtc/modules/pacing/

BUG=163
R=pwestin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1902005
------------------------------------------------------------------------
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 31 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4446

------------------------------------------------------------------------
r4446 | pbos@webrtc.org | 2013-07-31T15:32:43.500178Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/desktop_capture/desktop_region.cc&spec=svn4446&r_previous=4445&r=4446&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/desktop_capture/desktop_region.h&spec=svn4446&r_previous=4445&r=4446&format=side

Fix some chromium-style warnings in webrtc/modules/desktop_capture/

BUG=163
R=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/1904004
------------------------------------------------------------------------
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 31 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4447

------------------------------------------------------------------------
r4447 | pbos@webrtc.org | 2013-07-31T15:54:00.413705Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_dtmf_playout.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/background_noise.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_amrwb.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/tools/input_audio_file.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_red.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/tools/input_audio_file.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/post_decode_vad.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_amr.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_isac.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/test/NETEQTEST_DummyRTPpacket.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/audio_decoder.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_g722.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/delay_manager.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/decoder_database.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/decoder_database.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_pcm16b.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_cng.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/background_noise.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_cng.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_generic_codec.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_generic_codec.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_ilbc.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/post_decode_vad.cc&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_pcma.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/interface/audio_decoder.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/delay_manager.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/accelerate.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq/test/NETEQTEST_CodecClass.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_opus.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_celt.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq/test/NETEQTEST_DummyRTPpacket.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/neteq4/decision_logic_fax.h&spec=svn4447&r_previous=4446&r=4447&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_coding/main/source/acm_pcmu.h&spec=svn4447&r_previous=4446&r=4447&format=side

Add some virtual and OVERRIDEs in webrtc/modules/audio_coding/

BUG=163
TBR=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1900004
------------------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 1 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4464

------------------------------------------------------------------------
r4464 | pbos@webrtc.org | 2013-08-01T17:26:15.935003Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/thread.cc&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/interface/thread_wrapper.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/clock.cc&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/thread_posix.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/interface/clock.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/rw_lock_generic.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/condition_variable_posix.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/critical_section_posix.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/file_impl.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/trace_posix.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/rw_lock_posix.h&spec=svn4464&r_previous=4463&r=4464&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/source/event_posix.h&spec=svn4464&r_previous=4463&r=4464&format=side

Fix some chromium-style warnings in webrtc/system_wrappers/

BUG=163
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1906004
------------------------------------------------------------------------
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 5 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4472

------------------------------------------------------------------------
r4472 | pbos@webrtc.org | 2013-08-02T11:44:11.212004Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/echo_cancellation_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/high_pass_filter_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/audio_processing_impl.cc&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/processing_component.cc&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/audio_processing_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/processing_component.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/gain_control_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/level_estimator_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/include/audio_processing.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/voice_detection_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/echo_control_mobile_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_processing/noise_suppression_impl.h&spec=svn4472&r_previous=4471&r=4472&format=side

Fix some chromium-style warnings in webrtc/modules/audio_processing/

BUG=163
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1902004
------------------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 5 2013

The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=4473

------------------------------------------------------------------------
r4473 | pbos@webrtc.org | 2013-08-02T11:44:38.058185Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/resampler/push_sinc_resampler.h&spec=svn4473&r_previous=4472&r=4473&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_audio/resampler/sinusoidal_linear_chirp_source.h&spec=svn4473&r_previous=4472&r=4473&format=side

Add some virtual and OVERRIDEs in webrtc/common_audio/

BUG=163
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1899004
------------------------------------------------------------------------
Project Member

Comment 24 by kjellander@webrtc.org, Aug 27 2013

Labels: Dev-QAReview-NA
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 25 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6966

------------------------------------------------------------------
r6966 | kjellander@webrtc.org | 2014-08-25T14:15:35.067508Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/base/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_processing/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/utility/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/common_video/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_coding/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_conference_mixer/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/desktop_capture/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/remote_bitrate_estimator/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/bitrate_controller/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/rtp_rtcp/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/media_file/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/system_wrappers/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/pacing/BUILD.gn&spec=svn6966&r_previous=6965&r=6966&format=side

GN: Disable Chromium clang plugins for standalone build.

Now that WebRTC has rolled the chromium_revision past
http://crrev.com/284372 in r6784, clang has become the
default compiler. Since WebRTC standalone code doesn't
yet compile the Chromium Clang plugins enabled, this CL
disables them for the parts of the code that doesn't yet pass
compilation with them enabled.

The buildbots are using Goma which is not yet switched
over to Clang by default. That's why they're not red yet.

BUG=163
TEST=Passing compile locally on Linux using:
gn gen out/Debug --args="build_with_chromium=false is_debug=true" && ninja
-C out/Debug
gn gen out/Release --args="build_with_chromium=false is_debug=false" && ninja
-C out/Release
gn gen out/Default --args="build_with_chromium=false os=\"android\" cpu_arch=\"arm\" arm_version=7" && ninja -C out/Default

R=brettw@chromium.org

Review URL: https://webrtc-codereview.appspot.com/16279004
-----------------------------------------------------------------

Comment 26 by vrk@webrtc.org, Sep 29 2014

Labels: Area-Internals
Project Member

Comment 27 by kjellander@webrtc.org, Nov 6 2014

Cc: kwiberg@webrtc.org
Labels: -Pri-3 Pri-2
This is getting increasingly annoying and it would be useful for everyone if we could enable these warnings by default. Example: https://webrtc-codereview.appspot.com/25019004/ failed GN bots only and it took engineering time for both author and reviewer to figure out why (since it's disabled globally in GYP, but needs a per-target entry in GN).
Project Member

Comment 28 by pbos@webrtc.org, Nov 6 2014

Cc: pbos@webrtc.org
Owner: ----
Status: Available (was: NULL)
I don't have time to spend on it right now.
Project Member

Comment 29 by bugdroid1@chromium.org, Feb 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90

commit ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90
Author: kwiberg@webrtc.org <kwiberg@webrtc.org>
Date: Thu Feb 26 13:59:22 2015

Fix style violations in common_types.h and config.h

Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.

The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.

BUG=163
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26089004

Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/talk/libjingle.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/talk/libjingle_examples.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/talk/libjingle_tests.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/base/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/base/base.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/common.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/common_audio/BUILD.gn
[add] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/common_types.cc
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/common_types.h
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/common_video/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/common_video/common_video.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/config.cc
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/config.h
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/libjingle/libjingle.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_coding/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_coding/neteq/neteq.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_coding/neteq/neteq_tests.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_device/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_device/audio_device.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_processing/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/audio_processing/audio_processing.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/media_file/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/media_file/media_file.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/modules.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/remote_bitrate_estimator/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/rtp_rtcp/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/utility/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_capture/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_capture/video_capture.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_coding/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_coding/codecs/tools/video_codecs_tools.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_coding/codecs/vp8/vp8.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_coding/video_coding_test.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_render/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/modules/video_render/video_render.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/p2p/p2p.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/system_wrappers/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/system_wrappers/system_wrappers.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/test/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/test/test.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/test/webrtc_test_common.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/video/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/video_engine/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/video_engine/test/auto_test/vie_auto_test.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/video_engine/test/libvietest/libvietest.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/video_engine/video_engine_core.gypi
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/voice_engine/BUILD.gn
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/voice_engine/voice_engine.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/webrtc_examples.gyp
[modify] http://crrev.com/ac2d27d9ae74eb8d28ec0d5f12f70fa64461ab90/webrtc/webrtc_tests.gypi

Project Member

Comment 30 by kwiberg@webrtc.org, Feb 26 2015

Owner: kwiberg@webrtc.org
Status: Started (was: NULL)
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 9 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/67186fe00cc68cbe03aa66d17fb4962458ca96d2

commit 67186fe00cc68cbe03aa66d17fb4962458ca96d2
Author: kwiberg@webrtc.org <kwiberg@webrtc.org>
Date: Mon Mar 09 22:21:53 2015

Fix clang style warnings in webrtc/base

Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.

Not inlining virtual functions with simple bodies such as

  { return false; }

strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.

BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47429004

Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/talk/LICENSE_THIRD_PARTY
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/BUILD.gn
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asynchttprequest.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncinvoker-inl.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncinvoker.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncinvoker.h
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncpacketsocket.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncpacketsocket.h
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncresolverinterface.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncresolverinterface.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncsocket.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncsocket.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asynctcpsocket.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/asyncudpsocket.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/autodetectproxy.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/autodetectproxy.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/bandwidthsmoother.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/bandwidthsmoother.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/base.gyp
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/buffer.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/buffer.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/cpumonitor.h
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/cryptstring.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/cryptstring.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/diskcache.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/fileutils.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/fileutils.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/firewallsocketserver.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/firewallsocketserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/helpers.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httpbase.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httpbase.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httpclient.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httpcommon.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httpcommon.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httprequest.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httprequest.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/httpserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/macasyncsocket.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/maccocoasocketserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/macsocketserver.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/macsocketserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/macwindowpicker.h
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/md5digest.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/md5digest.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/messagequeue.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/messagequeue.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/multipart.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/natserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/natsocketfactory.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/natsocketfactory.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nattypes.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nethelpers.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nethelpers.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/network.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/network.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nssidentity.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nssidentity.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nssstreamadapter.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/nssstreamadapter.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/openssladapter.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/openssldigest.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/opensslidentity.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/opensslidentity.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/opensslstreamadapter.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/optionsfile.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/optionsfile.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/physicalsocketserver.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/physicalsocketserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/profiler.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/profiler.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/proxyinfo.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/proxyinfo.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/proxyserver.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/proxyserver.h
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sha1digest.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sha1digest.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/signalthread.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/signalthread.h
[add] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sigslot.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sigslot.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/socketadapters.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/socketadapters.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/socketpool.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/socketstream.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslidentity.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslidentity.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslsocketfactory.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslsocketfactory.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslstreamadapter.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslstreamadapter.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslstreamadapterhelper.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/sslstreamadapterhelper.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/stream.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/stream.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/systeminfo.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/systeminfo.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/task.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/task.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/taskparent.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/taskparent.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/taskrunner.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/testclient.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/thread.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/transformadapter.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/transformadapter.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/unixfilesystem.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/virtualsocketserver.cc
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/virtualsocketserver.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/worker.h
[modify] http://crrev.com/67186fe00cc68cbe03aa66d17fb4962458ca96d2/webrtc/base/x11windowpicker.h

Project Member

Comment 32 by bugdroid1@chromium.org, Mar 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/dad85aa53bb3e93115e1e1c7ac5b5af992c4bef3

commit dad85aa53bb3e93115e1e1c7ac5b5af992c4bef3
Author: kwiberg@webrtc.org <kwiberg@webrtc.org>
Date: Tue Mar 10 00:59:54 2015

Chromium build fix: Include new .cc files in rtc_base

r8656 added a couple of new .cc files to rtc_base. Two of them turned
out to mistakenly be in the set excluded from the Chromium build.

TBR=kjellander@webrtc.org, tommi@webrtc.org
BUG=163

Review URL: https://webrtc-codereview.appspot.com/44589004

Cr-Commit-Position: refs/heads/master@{#8659}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8659 4adac7df-926f-26a2-2b94-8c16560cd09d

[modify] http://crrev.com/dad85aa53bb3e93115e1e1c7ac5b5af992c4bef3/webrtc/base/BUILD.gn
[modify] http://crrev.com/dad85aa53bb3e93115e1e1c7ac5b5af992c4bef3/webrtc/base/base.gyp

Project Member

Comment 33 by bugdroid1@chromium.org, Apr 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/e1c1ee211ebe81298dee14dbe18b98213d22a8c6

commit e1c1ee211ebe81298dee14dbe18b98213d22a8c6
Author: Karl Wiberg <kwiberg@webrtc.org>
Date: Tue Apr 07 08:36:09 2015

EncodedVideoData is unused, so remove it

I'm doing cleanups for bug 163, and would rather remove
this class than fix it.

BUG=163
R=pbos@webrtc.org
TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49589004

Cr-Commit-Position: refs/heads/master@{#8931}

[modify] http://crrev.com/e1c1ee211ebe81298dee14dbe18b98213d22a8c6/webrtc/modules/interface/module_common_types.h

Project Member

Comment 34 by bugdroid1@chromium.org, Apr 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef

commit 2519c45d00a5bd9b91930b74b35afb7d4b5bcbef
Author: Karl Wiberg <kwiberg@webrtc.org>
Date: Tue Apr 07 14:12:57 2015

Fix clang style warnings in webrtc/modules/audio_coding

Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.

BUG=163
R=henrik.lundin@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44979004

Cr-Commit-Position: refs/heads/master@{#8938}

[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/BUILD.gn
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/acm_generic_codec.cc
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/acm_generic_codec.h
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/audio_coding_module.cc
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/nack.cc
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/acm2/nack.h
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/main/interface/audio_coding_module.h
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/audio_coding/neteq/audio_decoder_impl.h
[modify] http://crrev.com/2519c45d00a5bd9b91930b74b35afb7d4b5bcbef/webrtc/modules/interface/module.h

Project Member

Comment 35 by bugdroid1@chromium.org, Apr 9 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/7f6c4d42a2605d1da39af3f957a46cf57b043b84

commit 7f6c4d42a2605d1da39af3f957a46cf57b043b84
Author: Karl Wiberg <kwiberg@webrtc.org>
Date: Thu Apr 09 13:44:22 2015

Fix clang style warnings in webrtc/modules/audio_coding/neteq

Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.

BUG=163
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44109004

Cr-Commit-Position: refs/heads/master@{#8960}

[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/BUILD.gn
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/accelerate.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/audio_classifier.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/audio_classifier.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/audio_multi_vector.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/audio_multi_vector.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/audio_vector.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/audio_vector.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/buffer_level_filter.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/buffer_level_filter.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/decision_logic_fax.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/decision_logic_normal.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/delay_peak_detector.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/delay_peak_detector.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/dtmf_buffer.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/dtmf_buffer.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/dtmf_tone_generator.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/dtmf_tone_generator.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/expand.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/expand.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/merge.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/merge.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/neteq_impl.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/neteq_impl.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/packet_buffer.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/packet_buffer.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/preemptive_expand.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/sync_buffer.h
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/timestamp_scaler.cc
[modify] http://crrev.com/7f6c4d42a2605d1da39af3f957a46cf57b043b84/webrtc/modules/audio_coding/neteq/timestamp_scaler.h

I have a fix for webrtc/sound -> https://codereview.webrtc.org/1425533003
Project Member

Comment 37 by bugdroid1@chromium.org, Oct 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a35ae7f507cc4e909dd4253106c97528db315adb

commit a35ae7f507cc4e909dd4253106c97528db315adb
Author: tfarina <tfarina@chromium.org>
Date: Thu Oct 29 11:50:08 2015

Fix chromium-style warnings in webrtc/sound/.

Tested on Linux with the following command lines:

$ ./webrtc/build/gyp_webrtc -Dclang_use_chrome_plugins=1
$ ninja -C out/Release rtc_sound

BUG=webrtc:163
R=perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1425533003

Cr-Commit-Position: refs/heads/master@{#10447}

[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/alsasoundsystem.cc
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/alsasoundsystem.h
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/nullsoundsystem.cc
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/nullsoundsystem.h
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/nullsoundsystemfactory.h
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/platformsoundsystemfactory.h
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/sound.gyp
[add] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/soundinputstreaminterface.cc
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/soundinputstreaminterface.h
[add] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/soundoutputstreaminterface.cc
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/soundoutputstreaminterface.h
[modify] http://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb/webrtc/sound/soundsystemproxy.h

Project Member

Comment 38 by kjellander@webrtc.org, Dec 7 2015

Labels: size-small fixit
Owner: ----
Status: Available
The number of warnings polluting the GN build (example: https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn) is growing so I'd love to see this getting fixed.
Project Member

Comment 39 by kjellander@webrtc.org, Dec 7 2015

Components: Build
Summary: Should we enable Chrome clang plugins
Project Member

Comment 40 by pbos@webrtc.org, Dec 7 2015

Labels: -size-small size-large
I think this is insanely large (way past size-large). kwiberg@ can update if this is wrong.

Comment 41 Deleted

Comment 42 Deleted

Project Member

Comment 43 by bugdroid1@chromium.org, Feb 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3

commit d1f718bb1ead2d0287bdb75ff8772ac74636b2d3
Author: peah <peah@webrtc.org>
Date: Mon Feb 22 10:13:28 2016

Changes in the wav_file implementation in order to
avoid clang warnings.
The changes does not change any of the functionality
in the code.

BUG=webrtc:163

Review URL: https://codereview.webrtc.org/1710083006

Cr-Commit-Position: refs/heads/master@{#11705}

[modify] https://crrev.com/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3/webrtc/common_audio/wav_file.cc
[modify] https://crrev.com/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3/webrtc/common_audio/wav_file.h

Project Member

Comment 44 by bugdroid1@chromium.org, Feb 26 2016

Labels: merge-merged-50
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3

commit d1f718bb1ead2d0287bdb75ff8772ac74636b2d3
Author: peah <peah@webrtc.org>
Date: Mon Feb 22 10:13:28 2016

Changes in the wav_file implementation in order to
avoid clang warnings.
The changes does not change any of the functionality
in the code.

BUG=webrtc:163

Review URL: https://codereview.webrtc.org/1710083006

Cr-Commit-Position: refs/heads/master@{#11705}

[modify] https://crrev.com/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3/webrtc/common_audio/wav_file.cc
[modify] https://crrev.com/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3/webrtc/common_audio/wav_file.h

Project Member

Comment 45 by pbos@webrtc.org, Feb 29 2016

Labels: -merge-merged-50
Project Member

Comment 46 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1aee0b5bd98eade203d8d4c0a05a85414ad15896

commit 1aee0b5bd98eade203d8d4c0a05a85414ad15896
Author: maxmorin <maxmorin@webrtc.org>
Date: Mon Aug 15 18:46:19 2016

Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG= webrtc:6170 , webrtc:163
NOTRY=True

Review-Url: https://codereview.webrtc.org/2219653004
Cr-Commit-Position: refs/heads/master@{#13759}

[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/api/test/fakeaudiocapturemodule_unittest.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/media/engine/webrtcvoiceengine.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/modules/audio_device/android/audio_device_unittest.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/modules/audio_device/include/audio_device_defines.h
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/modules/audio_device/test/audio_device_test_api.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/modules/audio_device/test/func_test_manager.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/modules/audio_device/test/func_test_manager.h
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/voice_engine/voe_base_impl.cc
[modify] https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896/webrtc/voice_engine/voe_base_impl.h

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be

commit 88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be
Author: maxmorin <maxmorin@webrtc.org>
Date: Tue Aug 16 07:56:09 2016

Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG= webrtc:6170 ,webrtc:163
NOTRY=True

Review-Url: https://codereview.webrtc.org/2222563002
Cr-Commit-Position: refs/heads/master@{#13768}

[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/api/test/fakeaudiocapturemodule.h
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/audio_device_generic.cc
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/audio_device_generic.h
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/audio_device_impl.cc
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/audio_device_impl.h
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/include/audio_device.h
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/include/fake_audio_device.h
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/include/mock_audio_device.h
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/win/audio_device_core_win.cc
[modify] https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be/webrtc/modules/audio_device/win/audio_device_core_win.h

Project Member

Comment 48 by ale...@webrtc.org, Aug 24 2016

I did a little attempt on this with the goal of enabling the flag on the new mixer, but was unsure about how to handle webrtc/common.h.

common.h is a header that is not part of any build target. It's mostly not included outside of audio, but is used implicitly by everything that includes "webrtc/common.h".

Is it OK to create a target for it and add an accompanying .cc file? There is a comment in the file saying "this method is inline so webrtc public API depends only on the headers."


> git grep "webrtc/common.h" -- "*.[ch]*"
webrtc/config.h:#include "webrtc/common.h"
webrtc/media/engine/webrtcvoiceengine.cc:#include "webrtc/common.h"
webrtc/media/engine/webrtcvoiceengine.h:#include "webrtc/common.h"
webrtc/modules/audio_coding/test/APITest.cc:#include "webrtc/common.h"
webrtc/modules/audio_coding/test/PacketLossTest.cc:#include "webrtc/common.h"
webrtc/modules/audio_coding/test/TestRedFec.cc:#include "webrtc/common.h"
webrtc/modules/audio_coding/test/delay_test.cc:#include "webrtc/common.h"
webrtc/modules/audio_coding/test/utility.cc:#include "webrtc/common.h"
webrtc/modules/audio_processing/include/audio_processing.h:#include "webrtc/common.h"
webrtc/modules/audio_processing/test/process_test.cc:#include "webrtc/common.h"
webrtc/test/call_test.cc:#include "webrtc/common.h"
webrtc/test/common_unittest.cc:#include "webrtc/common.h"
webrtc/voice_engine/channel.cc:#include "webrtc/common.h"
webrtc/voice_engine/channel_manager.cc:#include "webrtc/common.h"
webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h:#include "webrtc/common.h"
webrtc/voice_engine/voe_base_impl.cc:#include "webrtc/common.h"

Project Member

Comment 49 by pbos@webrtc.org, Aug 24 2016

Cc: -pbos@webrtc.org
Project Member

Comment 50 by pbos@webrtc.org, Aug 24 2016

Labels: -fixit -size-large

Comment 51 Deleted

Project Member

Comment 55 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/b8e56ee320261decdba85b97ca6c5a6187e0af17

commit b8e56ee320261decdba85b97ca6c5a6187e0af17
Author: kwiberg <kwiberg@webrtc.org>
Date: Mon Aug 29 13:37:33 2016

Fix Chromium clang plugin warnings

This adds a new file, webrtc/modules/audio_coding/neteq/tools/packet_source.cc, so that I'll have somewhere to put the new non-inlined methods.

NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2290593002
Cr-Commit-Position: refs/heads/master@{#13956}

[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/BUILD.gn
[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc
[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.h
[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/neteq/neteq.gypi
[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/neteq/tools/packet.cc
[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/neteq/tools/packet.h
[add] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/neteq/tools/packet_source.cc
[modify] https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17/webrtc/modules/audio_coding/neteq/tools/packet_source.h

Project Member

Comment 56 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/65fc8b9138cf49131486d3fc28b50c7ab565cabb

commit 65fc8b9138cf49131486d3fc28b50c7ab565cabb
Author: kwiberg <kwiberg@webrtc.org>
Date: Mon Aug 29 17:05:24 2016

Fix Chromium clang plugin warnings

NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2291503002
Cr-Commit-Position: refs/heads/master@{#13959}

[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/BUILD.gn
[add] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/common.cc
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/common.gyp
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/common.h
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/BUILD.gn
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.cc
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/test/Channel.h
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/test/PCMFile.cc
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/test/PCMFile.h
[modify] https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb/webrtc/modules/audio_coding/test/utility.h

Project Member

Comment 57 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/942c8515bc5f0936c1ebf894a426adf4d5392fc6

commit 942c8515bc5f0936c1ebf894a426adf4d5392fc6
Author: kwiberg <kwiberg@webrtc.org>
Date: Mon Aug 29 20:10:29 2016

Fix Chromium clang plugin warnings

BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2288593004
Cr-Commit-Position: refs/heads/master@{#13961}

[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/common_audio/blocker.cc
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/common_audio/blocker.h
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/common_audio/channel_buffer.cc
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/common_audio/channel_buffer.h
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/common_audio/lapped_transform.cc
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/common_audio/lapped_transform.h
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/modules/audio_processing/BUILD.gn
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/modules/audio_processing/test/test_utils.cc
[modify] https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6/webrtc/modules/audio_processing/test/test_utils.h

Project Member

Comment 59 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/83ffe453ec2f1ec165a0ffc58a1327599505349c

commit 83ffe453ec2f1ec165a0ffc58a1327599505349c
Author: kwiberg <kwiberg@webrtc.org>
Date: Mon Aug 29 21:46:07 2016

Fix Chromium clang plugin warnings

NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2288153002
Cr-Commit-Position: refs/heads/master@{#13964}

[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/BUILD.gn
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/aec/echo_cancellation.cc
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/aec/echo_cancellation.h
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/audio_processing_impl.cc
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/audio_processing_impl.h
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/echo_cancellation_impl.h
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/echo_control_mobile_impl.h
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/level_controller/signal_classifier.cc
[modify] https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c/webrtc/modules/audio_processing/level_controller/signal_classifier.h

Project Member

Comment 61 by kjellander@webrtc.org, Aug 30 2016

Cc: kjellander@webrtc.org
Project Member

Comment 62 by anatolid@webrtc.org, Oct 7 2016

What's the status of this? Is any more work planned on this issue?
Project Member

Comment 63 by kwiberg@webrtc.org, Oct 8 2016

It would be an overstatement to say that more work is *planned*, I'd say. This isn't high enough on our prio list to get big chunks of time allocated to it, but there's a small handful of brave souls whittling away at it when we get the chance. And if nothing else, we at least try to avoid adding new suppressions of these warnings, in an attempt to keep new code clean. (In case this isn't spelled out anywhere: the warnings have been switched on, but a large number of build targets are suppressing them.)
Project Member

Comment 65 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/509eadd554de6bf938da08071c5d2c2541703134

commit 509eadd554de6bf938da08071c5d2c2541703134
Author: terelius <terelius@webrtc.org>
Date: Mon Oct 24 10:24:17 2016

Fix chromium-style warnings.

Separate the null implementation from rtp_rtcp_defines.h, and follow chromium style guide for virtual functions.

BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2400993002
Cr-Commit-Position: refs/heads/master@{#14738}

[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/BUILD.gn
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/rtp_rtcp.gypi
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
[add] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/rtp_rtcp_defines_nullimpl.cc
[add] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/rtp_rtcp_defines_nullimpl.h
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
[modify] https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134/webrtc/modules/rtp_rtcp/test/testAPI/test_api.h

Project Member

Comment 66 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2206c959f1e319234ad658506405f1e2459a6399

commit 2206c959f1e319234ad658506405f1e2459a6399
Author: terelius <terelius@webrtc.org>
Date: Mon Oct 24 13:43:25 2016

Revert of Fix some chromium style warnings in remote_bitrate_estimator.h (patchset #1 id:1 of https://codereview.webrtc.org/2387113008/ )

Reason for revert:
Broke internal project.

Original issue's description:
> Fix some chromium style warnings in remote_bitrate_estimator.h
>
> BUG=webrtc:163
>
> Committed: https://crrev.com/c22bcf4f4bed1f05b5e59127f93b58129cd2627f
> Cr-Commit-Position: refs/heads/master@{#14737}

TBR=stefan@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2444923002
Cr-Commit-Position: refs/heads/master@{#14743}

[modify] https://crrev.com/2206c959f1e319234ad658506405f1e2459a6399/webrtc/modules/congestion_controller/congestion_controller.cc
[modify] https://crrev.com/2206c959f1e319234ad658506405f1e2459a6399/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
[modify] https://crrev.com/2206c959f1e319234ad658506405f1e2459a6399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc
[modify] https://crrev.com/2206c959f1e319234ad658506405f1e2459a6399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h

Project Member

Comment 67 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/838cdb3db6a24b9be3a3d2700144197935415463

commit 838cdb3db6a24b9be3a3d2700144197935415463
Author: terelius <terelius@webrtc.org>
Date: Mon Oct 24 16:38:22 2016

Revert of Fix chromium-style warnings. (patchset #1 id:1 of https://codereview.webrtc.org/2400993002/ )

Reason for revert:
Broke internal project

Original issue's description:
> Fix chromium-style warnings.
>
> Separate the null implementation from rtp_rtcp_defines.h, and follow chromium style guide for virtual functions.
>
> BUG=webrtc:163
>
> Committed: https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134
> Cr-Commit-Position: refs/heads/master@{#14738}

TBR=danilchap@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2449523002
Cr-Commit-Position: refs/heads/master@{#14750}

[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/BUILD.gn
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/rtp_rtcp.gypi
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
[delete] https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400/webrtc/modules/rtp_rtcp/source/rtp_rtcp_defines_nullimpl.cc
[delete] https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400/webrtc/modules/rtp_rtcp/source/rtp_rtcp_defines_nullimpl.h
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
[modify] https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463/webrtc/modules/rtp_rtcp/test/testAPI/test_api.h

Project Member

Comment 68 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/e183121657fa2daf2985f264cff8dd30cd63b97d

commit e183121657fa2daf2985f264cff8dd30cd63b97d
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Oct 26 20:15:42 2016

Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2436503004
Cr-Commit-Position: refs/heads/master@{#14793}

[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/BUILD.gn
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/cropping_window_capturer.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/desktop_and_cursor_composer.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/desktop_capture_options.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/desktop_capture_options.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/desktop_frame_win.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/mac/desktop_configuration.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/mac/desktop_configuration.mm
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/mouse_cursor_monitor_win.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/screen_capturer.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/screen_capturer_mac.mm
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/screen_capturer_mock_objects.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/screen_capturer_x11.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/d3d_device.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/d3d_device.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/dxgi_texture.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/dxgi_texture.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/window_capturer.h
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/window_capturer_mac.mm
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/window_capturer_null.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/window_capturer_win.cc
[modify] https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d/webrtc/modules/desktop_capture/window_capturer_x11.cc

Project Member

Comment 69 by kjellander@webrtc.org, Jan 25 2017

Cc: oprypin@webrtc.org
Oleh: if you want you can work on this as well.
Just pick any of the hits from https://cs.chromium.org/search/?q=bugs.webrtc.org/163&sq=package:chromium&type=cs and delete the suppressed config and compile. Then fix warnings according to the Chromium Clang plugins guidelines (https://www.chromium.org/developers/coding-style/chromium-style-checker-errors) and upload a CL. Much preferred is to make multiple small CLs rather than large ones (they're so tedious to review).

Project Member

Comment 70 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/8dd4ec3324215aee19a58c4d050175bb93af1948

commit 8dd4ec3324215aee19a58c4d050175bb93af1948
Author: aleloi <aleloi@webrtc.org>
Date: Mon Feb 20 12:17:53 2017

Fix clang style warnings in webrtc/base/thread.h

TBR=tommi@webrtc.org
BUG=webrtc:163
NOTRY=True # trivial change, last round of tests passed.

Review-Url: https://codereview.webrtc.org/2706843002
Cr-Commit-Position: refs/heads/master@{#16715}

[modify] https://crrev.com/8dd4ec3324215aee19a58c4d050175bb93af1948/webrtc/base/thread.cc
[modify] https://crrev.com/8dd4ec3324215aee19a58c4d050175bb93af1948/webrtc/base/thread.h

Comment 71 Deleted

Project Member

Comment 72 by kjellander@webrtc.org, Apr 24 2017

Summary: Enable Chrome clang plugins (was: Should we enable Chrome clang plugins)
Project Member

Comment 73 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/76e62b0d3861c94a9c9ab780ee8bde888ac08170

commit 76e62b0d3861c94a9c9ab780ee8bde888ac08170
Author: nisse <nisse@webrtc.org>
Date: Wed May 31 09:24:52 2017

Address some violations of chromium-style.

BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2913793002
Cr-Commit-Position: refs/heads/master@{#18345}

[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/call/rtp_transport_controller_send.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/call/rtp_transport_controller_send.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/call/rtx_receive_stream.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/call/rtx_receive_stream.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/delay_based_bwe.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/delay_based_bwe.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/median_slope_estimator.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/median_slope_estimator.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/probe_bitrate_estimator.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/congestion_controller/send_side_congestion_controller.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/pacing/paced_sender.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/pacing/packet_router.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/remote_bitrate_estimator/bwe_defines.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/rtp_rtcp/source/rtp_packet.cc
[modify] https://crrev.com/76e62b0d3861c94a9c9ab780ee8bde888ac08170/webrtc/modules/rtp_rtcp/source/rtp_packet.h

Comment 74 Deleted

Project Member

Comment 75 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291

commit af551a1956d2ec3a388cf7e0e88c7ee2c2b61291
Author: Steve Anton <steveanton@webrtc.org>
Date: Mon Oct 23 23:25:17 2017

Enable the clang style plugin in rtc_base/

Enabled the plugin and cleaned up all issues it found.

Bug: webrtc:163
Change-Id: Id63f0deb7b335690157ab157c35177b7836688da
Reviewed-on: https://webrtc-review.googlesource.com/14660
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20401}
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/BUILD.gn
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/buffer_unittest.cc
[add] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/fakesslidentity.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/fakesslidentity.h
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/filerotatingstream_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/httpbase_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/httpcommon.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/messagequeue_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/network.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/network.h
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/network_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/nullsocketserver_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/physicalsocketserver.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/physicalsocketserver_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/proxy_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/rtccertificate_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/rtccertificategenerator_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/signalthread_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/sigslot_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/socket_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/socket_unittest.h
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/sslidentity_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/sslstreamadapter_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/stream_unittest.cc
[add] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/testechoserver.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/testechoserver.h
[add] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/testutils.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/testutils.h
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/thread_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/virtualsocket_unittest.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/win32socketserver.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/win32socketserver.h
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/win32window.cc
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/win32window.h
[modify] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/win32window_unittest.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a17ce27b20d2933b455b9dd4dcc50498858d9bda

commit a17ce27b20d2933b455b9dd4dcc50498858d9bda
Author: Steve Anton <steveanton@webrtc.org>
Date: Tue Oct 24 00:43:59 2017

Revert "Enable the clang style plugin in rtc_base/"

This reverts commit af551a1956d2ec3a388cf7e0e88c7ee2c2b61291.

Reason for revert: Fails to compile on Chromium FYI bot: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/21375

Original change's description:
> Enable the clang style plugin in rtc_base/
> 
> Enabled the plugin and cleaned up all issues it found.
> 
> Bug: webrtc:163
> Change-Id: Id63f0deb7b335690157ab157c35177b7836688da
> Reviewed-on: https://webrtc-review.googlesource.com/14660
> Commit-Queue: Steve Anton <steveanton@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20401}

TBR=steveanton@webrtc.org,kwiberg@webrtc.org

Change-Id: Iafdf4bc1744a981b5d7d38e4a0c5b2d88753f00a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:163
Reviewed-on: https://webrtc-review.googlesource.com/14740
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20402}
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/BUILD.gn
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/buffer_unittest.cc
[delete] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/fakesslidentity.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/fakesslidentity.h
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/filerotatingstream_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/httpbase_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/httpcommon.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/messagequeue_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/network.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/network.h
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/network_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/nullsocketserver_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/physicalsocketserver.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/physicalsocketserver_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/proxy_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/rtccertificate_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/rtccertificategenerator_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/signalthread_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/sigslot_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/socket_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/socket_unittest.h
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/sslidentity_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/sslstreamadapter_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/stream_unittest.cc
[delete] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/testechoserver.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/testechoserver.h
[delete] https://crrev.com/af551a1956d2ec3a388cf7e0e88c7ee2c2b61291/rtc_base/testutils.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/testutils.h
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/thread_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/virtualsocket_unittest.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/win32socketserver.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/win32socketserver.h
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/win32window.cc
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/win32window.h
[modify] https://crrev.com/a17ce27b20d2933b455b9dd4dcc50498858d9bda/rtc_base/win32window_unittest.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9de3aaccc95544f701d84e820c7d1231738077ce

commit 9de3aaccc95544f701d84e820c7d1231738077ce
Author: Steve Anton <steveanton@webrtc.org>
Date: Tue Oct 24 20:50:13 2017

Reland "Enable the clang style plugin in rtc_base/"

This is a reland of Id63f0deb7b335690157ab157c35177b7836688da.

Original change's description:
> Enable the clang style plugin in rtc_base/
> 
> Enabled the plugin and cleaned up all issues it found.
> 
> Bug: webrtc:163
> Change-Id: Id63f0deb7b335690157ab157c35177b7836688da
> Reviewed-on: https://webrtc-review.googlesource.com/14660
> Commit-Queue: Steve Anton <steveanton@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20401}

Bug: webrtc:163
Change-Id: I861a5fe741215115b0e7a2be9c0786836ff5376e
Reviewed-on: https://webrtc-review.googlesource.com/15040
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20416}
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/BUILD.gn
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/buffer_unittest.cc
[add] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/fakesslidentity.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/fakesslidentity.h
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/filerotatingstream_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/httpbase_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/httpcommon.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/messagequeue_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/network.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/network.h
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/network_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/nullsocketserver_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/physicalsocketserver.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/physicalsocketserver_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/proxy_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/rtccertificate_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/rtccertificategenerator_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/signalthread_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/sigslot_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/socket_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/socket_unittest.h
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/sslidentity_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/sslstreamadapter_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/stream_unittest.cc
[add] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/testechoserver.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/testechoserver.h
[add] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/testutils.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/testutils.h
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/thread_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/virtualsocket_unittest.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/win32socketserver.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/win32socketserver.h
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/win32window.cc
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/win32window.h
[modify] https://crrev.com/9de3aaccc95544f701d84e820c7d1231738077ce/rtc_base/win32window_unittest.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ca7d54e16a9497dceb8a30a44648bc8e9514c70c

commit ca7d54e16a9497dceb8a30a44648bc8e9514c70c
Author: Steve Anton <steveanton@webrtc.org>
Date: Thu Oct 26 04:36:34 2017

Fix clang style warnings in p2p/base/stun.h

Bug: webrtc:163
Change-Id: Ief9c59f80f36d3339fd40bed9f33e8c6eeef4f90
Reviewed-on: https://webrtc-review.googlesource.com/15781
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20434}
[modify] https://crrev.com/ca7d54e16a9497dceb8a30a44648bc8e9514c70c/p2p/base/stun.cc
[modify] https://crrev.com/ca7d54e16a9497dceb8a30a44648bc8e9514c70c/p2p/base/stun.h

Project Member

Comment 80 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9d4a2e6fd26d36d118267eda73e7372feeb292ba

commit 9d4a2e6fd26d36d118267eda73e7372feeb292ba
Author: Steve Anton <steveanton@webrtc.org>
Date: Thu Oct 26 23:14:37 2017

Move inlined methods from p2p/base/packetsocketfactory.h

Bug: webrtc:163
Change-Id: I9c1eee77032326c2cafc38dabdd415583f9e1817
Reviewed-on: https://webrtc-review.googlesource.com/16067
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20453}
[modify] https://crrev.com/9d4a2e6fd26d36d118267eda73e7372feeb292ba/p2p/BUILD.gn
[add] https://crrev.com/9d4a2e6fd26d36d118267eda73e7372feeb292ba/p2p/base/packetsocketfactory.cc
[modify] https://crrev.com/9d4a2e6fd26d36d118267eda73e7372feeb292ba/p2p/base/packetsocketfactory.h

Project Member

Comment 81 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/36b28db88758d54270d7ad8452034a5b4395b152

commit 36b28db88758d54270d7ad8452034a5b4395b152
Author: Steve Anton <steveanton@webrtc.org>
Date: Thu Oct 26 23:22:18 2017

Fix clang style warnings in api/candidate.h

Bug: webrtc:163
Change-Id: I694194d34573b1f2e4769bf52ec861127940d017
Reviewed-on: https://webrtc-review.googlesource.com/15940
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20454}
[modify] https://crrev.com/36b28db88758d54270d7ad8452034a5b4395b152/api/BUILD.gn
[add] https://crrev.com/36b28db88758d54270d7ad8452034a5b4395b152/api/candidate.cc
[modify] https://crrev.com/36b28db88758d54270d7ad8452034a5b4395b152/api/candidate.h

Project Member

Comment 82 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed

commit 1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed
Author: Steve Anton <steveanton@webrtc.org>
Date: Mon Oct 30 18:44:09 2017

Fix clang style warnings in p2p/base/port.h and its subclasses

Bug: webrtc:163
Change-Id: I8308bf1f1b4cf57edd2eb8fda010cb8b667771a2
Reviewed-on: https://webrtc-review.googlesource.com/16361
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20483}
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/BUILD.gn
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/port.cc
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/port.h
[add] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/portinterface.cc
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/portinterface.h
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/relayport.cc
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/relayport.h
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/stunport.cc
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/stunport.h
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/tcpport.cc
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/tcpport.h
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/turnport.cc
[modify] https://crrev.com/1cf1b7d66fbc8b0abfb0e6c92770597b2102d3ed/p2p/base/turnport.h

Project Member

Comment 83 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/33f69db1c8a51a212995a26e3b77d90cccc685c7

commit 33f69db1c8a51a212995a26e3b77d90cccc685c7
Author: Steve Anton <steveanton@webrtc.org>
Date: Mon Oct 30 19:51:49 2017

Fix clang style warnings in p2p/base/packettransport files

Bug: webrtc:163
Change-Id: I10fb72c1ae01b6715f4d13e43860c80a6dfc9d87
Reviewed-on: https://webrtc-review.googlesource.com/16362
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20485}
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/BUILD.gn
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/dtlstransport.cc
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/dtlstransport.h
[add] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/dtlstransportinternal.cc
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/dtlstransportinternal.h
[add] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/icetransportinternal.cc
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/icetransportinternal.h
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/p2ptransportchannel.cc
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/p2ptransportchannel.h
[add] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/packettransportinternal.cc
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/packettransportinternal.h
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/udptransport.cc
[modify] https://crrev.com/33f69db1c8a51a212995a26e3b77d90cccc685c7/p2p/base/udptransport.h

Project Member

Comment 84 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/7995d8cddeaa6529e95b80375742263748ee568a

commit 7995d8cddeaa6529e95b80375742263748ee568a
Author: Steve Anton <steveanton@webrtc.org>
Date: Tue Oct 31 16:58:22 2017

Fix clang style warnings in p2p/base/portallocator files

Bug: webrtc:163
Change-Id: Id576819149a6a9dcd65a03668bc51e76c71ad820
Reviewed-on: https://webrtc-review.googlesource.com/17003
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20503}
[modify] https://crrev.com/7995d8cddeaa6529e95b80375742263748ee568a/p2p/base/portallocator.cc
[modify] https://crrev.com/7995d8cddeaa6529e95b80375742263748ee568a/p2p/base/portallocator.h
[modify] https://crrev.com/7995d8cddeaa6529e95b80375742263748ee568a/p2p/client/basicportallocator.cc
[modify] https://crrev.com/7995d8cddeaa6529e95b80375742263748ee568a/p2p/client/basicportallocator.h

Project Member

Comment 86 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/f2737d23d1baee312804cdd7f1c3e074a3338a0f

commit f2737d23d1baee312804cdd7f1c3e074a3338a0f
Author: Steve Anton <steveanton@webrtc.org>
Date: Wed Nov 01 00:19:05 2017

Enable the clang style plugin in primary p2p/ target

Bug: webrtc:163
Change-Id: I318982ee549fe71cd48f74cdfad4173506742411
Reviewed-on: https://webrtc-review.googlesource.com/17040
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20509}
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/api/BUILD.gn
[add] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/api/proxy.cc
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/api/proxy.h
[add] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/api/umametrics.cc
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/api/umametrics.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/BUILD.gn
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/asyncstuntcpsocket.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/jseptransport.cc
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/jseptransport.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/packetlossestimator.cc
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/packetlossestimator.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/port.cc
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/port.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/relayserver.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/stunrequest.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/turnserver.cc
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/base/turnserver.h
[modify] https://crrev.com/f2737d23d1baee312804cdd7f1c3e074a3338a0f/p2p/client/socketmonitor.h

Project Member

Comment 87 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/845bb7319679c15dcc94f1aaa5bc8c6ea245e9b0

commit 845bb7319679c15dcc94f1aaa5bc8c6ea245e9b0
Author: Steve Anton <steveanton@webrtc.org>
Date: Wed Dec 06 18:12:06 2017

Fix clang style errors in api/jsep.h

In this case, clang style forbids inline definitions for virtual
functions.

Bug: webrtc:163
Change-Id: Id924cadb0a1d32e12cdb691c57fbda5f5b022638
Reviewed-on: https://webrtc-review.googlesource.com/29441
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Reviewed-by: Zhi Huang <zhihuang@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21126}
[modify] https://crrev.com/845bb7319679c15dcc94f1aaa5bc8c6ea245e9b0/api/BUILD.gn
[add] https://crrev.com/845bb7319679c15dcc94f1aaa5bc8c6ea245e9b0/api/jsep.cc
[modify] https://crrev.com/845bb7319679c15dcc94f1aaa5bc8c6ea245e9b0/api/jsep.h

Project Member

Comment 88 by bugdroid1@chromium.org, Feb 7

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f

commit 2a5ce2bcf8bf87545dc98084c27b622a6e089f2f
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Wed Feb 07 09:48:28 2018

Fix clang style errors in rtp_rtcp and dependant targets

Mark functions with override instead of virtual.
Add explicit non-trivial constructors/assign operators/destructors.
Define them in .cc files instead of inlining
use auto* instead of auto when deduced type is raw pointer

Bug: webrtc:163
Change-Id: I4d8a05d6a64fcc2ca16d02c5fcf9488fda832a6d
Reviewed-on: https://webrtc-review.googlesource.com/48781
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21927}
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/api/BUILD.gn
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/api/mediastreaminterface.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/api/mediastreaminterface.h
[add] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/api/rtpreceiverinterface.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/api/rtpreceiverinterface.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/common_video/h264/sps_parser.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/common_video/h264/sps_parser.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/logging/BUILD.gn
[add] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/logging/rtc_event_log/rtc_event_log.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/logging/rtc_event_log/rtc_event_log.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/remote_bitrate_estimator/test/bwe_test_logging.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/remote_bitrate_estimator/test/bwe_test_logging.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/BUILD.gn
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/flexfec_sender.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/forward_error_correction.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/packet_loss_stats.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/packet_loss_stats.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/receive_statistics_impl.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/receive_statistics_impl.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtcp_sender.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_format_h264.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_format_h264.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_format_video_generic.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_format_video_generic.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_format_vp8.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_format_vp9.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_header_parser.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_packet_history.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_packet_history.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_audio.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_audio.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_impl.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_strategy.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_strategy.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_video.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_receiver_video.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/ulpfec_generator.cc
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/ulpfec_generator.h
[modify] https://crrev.com/2a5ce2bcf8bf87545dc98084c27b622a6e089f2f/modules/rtp_rtcp/source/ulpfec_receiver_impl.h

Project Member

Comment 89 by mbonadei@webrtc.org, Feb 9

Cc: mbonadei@webrtc.org
Project Member

Comment 90 by mbonadei@webrtc.org, Feb 9

It looks like the amount of suppressions has proliferated during these years. As of today, the three lines to suppress the warning has been copy/pasted in 174 locations in the WebRTC BUILD.gn files.

$ git grep "Suppress warnings from the Chromium Clang plugin" | wc -l
     174

We can probably move these to the webrtc.gni file (even if it is not trivial because GN doesn't have a way to check if an element is part of a list).

Should we just fix these warnings and remove the following snippet from the 174 locations?

if (!build_with_chromium && is_clang) {
  # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
  suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
Project Member

Comment 91 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9486b117daac09c9f7ac8450ccda835938cf3150

commit 9486b117daac09c9f7ac8450ccda835938cf3150
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Fri Mar 09 12:27:35 2018

Enable and fix chromium clang warnings in rtp_rtcp test targets

Bug: webrtc:163
Change-Id: I4ed3e63296d8bf06536a83196d597c7a906ba11c
Reviewed-on: https://webrtc-review.googlesource.com/60802
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22357}
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/logging/BUILD.gn
[add] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/logging/rtc_event_log/mock/mock_rtc_event_log.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/logging/rtc_event_log/mock/mock_rtc_event_log.h
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/BUILD.gn
[add] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.h
[add] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.h
[add] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h
[add] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_rtp_rtcp.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/byte_io_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/fec_test_helper.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/fec_test_helper.h
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/receive_statistics_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/remote_ntp_time_estimator_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/rtp_receiver_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/test/testAPI/test_api.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/test/BUILD.gn
[add] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/test/mock_transport.cc
[modify] https://crrev.com/9486b117daac09c9f7ac8450ccda835938cf3150/test/mock_transport.h

Project Member

Comment 92 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/01aa210fad68f1006528d32d388b307c22990734

commit 01aa210fad68f1006528d32d388b307c22990734
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri Mar 09 14:49:15 2018

Revert "Enable and fix chromium clang warnings in rtp_rtcp test targets"

This reverts commit 9486b117daac09c9f7ac8450ccda835938cf3150.

Reason for revert: Breaks downstream project

Original change's description:
> Enable and fix chromium clang warnings in rtp_rtcp test targets
> 
> Bug: webrtc:163
> Change-Id: I4ed3e63296d8bf06536a83196d597c7a906ba11c
> Reviewed-on: https://webrtc-review.googlesource.com/60802
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22357}

TBR=danilchap@webrtc.org,phoglund@webrtc.org,terelius@webrtc.org

Change-Id: I2c3777ea9f26813bdb395e7fd68f6b49443586ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:163
Reviewed-on: https://webrtc-review.googlesource.com/61060
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22365}
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/logging/BUILD.gn
[delete] https://crrev.com/d4bc01b7dd1ae25e64b4f270088eda079dc23fd9/logging/rtc_event_log/mock/mock_rtc_event_log.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/logging/rtc_event_log/mock/mock_rtc_event_log.h
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/BUILD.gn
[delete] https://crrev.com/d4bc01b7dd1ae25e64b4f270088eda079dc23fd9/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.h
[delete] https://crrev.com/d4bc01b7dd1ae25e64b4f270088eda079dc23fd9/modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.h
[delete] https://crrev.com/d4bc01b7dd1ae25e64b4f270088eda079dc23fd9/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h
[delete] https://crrev.com/d4bc01b7dd1ae25e64b4f270088eda079dc23fd9/modules/rtp_rtcp/mocks/mock_rtp_rtcp.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/byte_io_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/fec_test_helper.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/fec_test_helper.h
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/receive_statistics_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/remote_ntp_time_estimator_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/rtp_receiver_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/test/testAPI/test_api.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/test/BUILD.gn
[delete] https://crrev.com/d4bc01b7dd1ae25e64b4f270088eda079dc23fd9/test/mock_transport.cc
[modify] https://crrev.com/01aa210fad68f1006528d32d388b307c22990734/test/mock_transport.h

Project Member

Comment 93 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/dd7e284ce8bd86c9e13413b29777d1527f2cbe31

commit dd7e284ce8bd86c9e13413b29777d1527f2cbe31
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Fri Mar 09 16:04:35 2018

Reland "Enable and fix chromium clang warnings in rtp_rtcp test targets"

This reverts commit 01aa210fad68f1006528d32d388b307c22990734.

Reason for revert: downstream project adjusted

Original change's description:
> Revert "Enable and fix chromium clang warnings in rtp_rtcp test targets"
> 
> This reverts commit 9486b117daac09c9f7ac8450ccda835938cf3150.
> 
> Reason for revert: Breaks downstream project
> 
> Original change's description:
> > Enable and fix chromium clang warnings in rtp_rtcp test targets
> > 
> > Bug: webrtc:163
> > Change-Id: I4ed3e63296d8bf06536a83196d597c7a906ba11c
> > Reviewed-on: https://webrtc-review.googlesource.com/60802
> > Reviewed-by: Björn Terelius <terelius@webrtc.org>
> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#22357}
> 
> TBR=danilchap@webrtc.org,phoglund@webrtc.org,terelius@webrtc.org
> 
> Change-Id: I2c3777ea9f26813bdb395e7fd68f6b49443586ea
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:163
> Reviewed-on: https://webrtc-review.googlesource.com/61060
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22365}

TBR=danilchap@webrtc.org,phoglund@webrtc.org,oprypin@webrtc.org,terelius@webrtc.org

Change-Id: I0b4cb6d05b37caeb52cca9abf95417ad3ad6f76b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:163
Reviewed-on: https://webrtc-review.googlesource.com/61080
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22368}
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/logging/BUILD.gn
[add] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/logging/rtc_event_log/mock/mock_rtc_event_log.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/logging/rtc_event_log/mock/mock_rtc_event_log.h
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/BUILD.gn
[add] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.h
[add] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.h
[add] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h
[add] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_rtp_rtcp.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/byte_io_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/fec_test_helper.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/fec_test_helper.h
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/receive_statistics_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/remote_ntp_time_estimator_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/rtp_receiver_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/test/testAPI/test_api.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/test/BUILD.gn
[add] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/test/mock_transport.cc
[modify] https://crrev.com/dd7e284ce8bd86c9e13413b29777d1527f2cbe31/test/mock_transport.h

Project Member

Comment 94 by bugdroid1@chromium.org, Mar 27

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/be682d47ace03c1eb5845bebc4a66d1219b85216

commit be682d47ace03c1eb5845bebc4a66d1219b85216
Author: Niels Möller <nisse@webrtc.org>
Date: Tue Mar 27 08:11:21 2018

Fix chromium warnings for SdpVideoFormat.

Bug: webrtc:163
Change-Id: I29ad3c00116692f047456df7721ba636bbb2ca89
Reviewed-on: https://webrtc-review.googlesource.com/64723
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22618}
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/BUILD.gn
[add] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video/encoded_frame.cc
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video/encoded_frame.h
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video_codecs/BUILD.gn
[add] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video_codecs/sdp_video_format.cc
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video_codecs/sdp_video_format.h
[add] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video_codecs/video_decoder.cc
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/api/video_codecs/video_decoder.h
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/BUILD.gn
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/codec_timer.cc
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/codec_timer.h
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/frame_buffer2.cc
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/frame_buffer2.h
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/include/video_coding_defines.h
[add] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/modules/video_coding/video_coding_defines.cc
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/video/BUILD.gn
[modify] https://crrev.com/be682d47ace03c1eb5845bebc4a66d1219b85216/video/video_stream_decoder_impl.cc

Project Member

Comment 95 by bugdroid1@chromium.org, Apr 5

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a680a6a4af2cb9182709737261eddd767e7a707e

commit a680a6a4af2cb9182709737261eddd767e7a707e
Author: Paulina Hensman <phensman@webrtc.org>
Date: Thu Apr 05 11:22:03 2018

Enable and fix chromium clang warnings in sdk/android targets.

Targets:
base_jni, internal_jni, video_jni, vp8_jni and vp9_jni

Bug: webrtc:163
Change-Id: I4aa68c81e6e7cbe5fdf78c90e464b46c55633252
Reviewed-on: https://webrtc-review.googlesource.com/66820
Commit-Queue: Paulina Hensman <phensman@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22744}
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/api/videosourceinterface.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/api/videosourceinterface.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/common_video/i420_buffer_pool.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/common_video/include/i420_buffer_pool.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/common_video/include/video_frame.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/common_video/video_frame.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/adaptedvideotracksource.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/adaptedvideotracksource.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/codec.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/codec.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/videobroadcaster.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/videobroadcaster.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/videosourcebase.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/base/videosourcebase.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/engine/videodecodersoftwarefallbackwrapper.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/engine/videodecodersoftwarefallbackwrapper.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/engine/videoencodersoftwarefallbackwrapper.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/media/engine/videoencodersoftwarefallbackwrapper.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/modules/video_coding/codecs/vp8/include/vp8.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/modules/video_coding/codecs/vp9/include/vp9.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/modules/video_coding/utility/moving_average.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/modules/video_coding/utility/moving_average.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/BUILD.gn
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidmediadecoder.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidmediadecoder_jni.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidmediaencoder.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidmediaencoder_jni.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidnetworkmonitor.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidnetworkmonitor.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidvideotracksource.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/androidvideotracksource.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/video_renderer.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videodecoderfactorywrapper.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videodecoderfactorywrapper.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videodecoderwrapper.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videodecoderwrapper.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videoencoderfactorywrapper.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videoencoderfactorywrapper.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videoencoderwrapper.cc
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videoencoderwrapper.h
[modify] https://crrev.com/a680a6a4af2cb9182709737261eddd767e7a707e/sdk/android/src/jni/videoframe.cc

Project Member

Comment 96 by bugdroid1@chromium.org, Apr 9

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/11b34f4d08da0644544c6de458c325c557179481

commit 11b34f4d08da0644544c6de458c325c557179481
Author: Paulina Hensman <phensman@webrtc.org>
Date: Mon Apr 09 13:55:49 2018

Remove chromium clang style errors affecting sdk/android/media_jni

Bug: webrtc:163
Change-Id: I1e98174817ca032ee13f9a6a386803382843389d
Reviewed-on: https://webrtc-review.googlesource.com/67360
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Paulina Hensman <phensman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22796}
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/api/BUILD.gn
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/api/audio_options.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/api/audio_options.h
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/BUILD.gn
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/audio_receive_stream.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/audio_receive_stream.h
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/audio_state.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/audio_state.h
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/call.h
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/call_config.cc
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/call_config.h
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/flexfec_receive_stream.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/call/flexfec_receive_stream.h
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/BUILD.gn
[add] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/base/mediachannel.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/base/mediachannel.h
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/base/mediaengine.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/base/mediaengine.h
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/base/streamparams.cc
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/media/base/streamparams.h
[modify] https://crrev.com/11b34f4d08da0644544c6de458c325c557179481/sdk/android/BUILD.gn

Sign in to add a comment