New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 13 users
Status: Available
Owner:
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Enhancement



Sign in to add a comment
Remove constraints due to legacy bit-exactness
Project Member Reported by henrik.lundin@webrtc.org, Feb 1 2013 Back to list
There are currently a number of places in the code for NetEq4 where odd things are implemented in order to maintain bit-exactness with NetEQ 3. These should eventually be removed. When that happens, we have to generate new reference output vectors for the bit-exactness unit tests.

This includes:
- Remove size constraint on PacketBuffer.
- Simplify calculations in BackgroundNoise::IncrementEnergyThreshold().
- Remove restriction on sample rate in PostDecodeVad.
- Look for all places where the #define LEGACY_BITEXACT is used. These indicate places where the code has been altered away from “the expected” to something more peculiar, in order to maintain bit-exactness.

 
Project Member Comment 1 by henrik.lundin@webrtc.org, Feb 1 2013
Owner: tina.legrand@webrtc.org
Project Member Comment 2 by kjellander@webrtc.org, Aug 27 2013
Labels: Dev-QAReview-NA
Project Member Comment 3 by tina.legrand@webrtc.org, Sep 10 2013
Owner: henrik.lundin@webrtc.org
Project Member Comment 4 by henrik.lundin@webrtc.org, Oct 14 2013
Labels: Pri-3
Project Member Comment 5 by henrik.lundin@webrtc.org, Oct 14 2013
Labels: -Pri-3 Pri-2
Comment 6 Deleted
Comment 7 Deleted
Project Member Comment 8 by henrik.lundin@webrtc.org, Dec 4 2013
Labels: Area-SignalProcessing
Project Member Comment 9 by henrik.lundin@webrtc.org, Dec 4 2013
Labels: hotlist-neteq-14Q1
Project Member Comment 10 by henrik.lundin@webrtc.org, Mar 4 2014
Labels: neteq
Project Member Comment 11 by henrik.lundin@webrtc.org, Mar 5 2014
Labels: -Pri-2 Pri-1
Project Member Comment 12 by henrik.lundin@webrtc.org, Mar 5 2014
Cc: jan.skoglund@webrtc.org
Project Member Comment 13 by tina.legrand@webrtc.org, Oct 30 2014
Labels: EngTriaged IceBox
Project Member Comment 14 by tnakamura@webrtc.org, Nov 4 2015
This bug hasn't been modified for more than a year. Is this still a valid open issue?
Project Member Comment 15 by henrik.lundin@webrtc.org, Nov 5 2015
Labels: -hotlist-neteq4 -hotlist-neteq-14Q1
Still valid and open.
Project Member Comment 16 by henrik.lundin@webrtc.org, Jul 1 2016
Cc: ossu@webrtc.org
Components: -SignalProcessing Audio
Labels: -Pri-1 Pri-3
Project Member Comment 17 by bugdroid1@chromium.org, Jul 8 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/108ecec51ce5d55bcbe455f7a1cb778dd3cb2b22

commit 108ecec51ce5d55bcbe455f7a1cb778dd3cb2b22
Author: ossu <ossu@webrtc.org>
Date: Fri Jul 08 15:45:18 2016

Removed LEGACY_BITEXACT from neteq_impl.cc and updated the ACM unit tests.

I'll be rewriting AcmReceiver soon and am trying to reduce the amount of
old stuff that needs to be supported.

I've manually checked the outputs of the AcmReceiver bitexactness
tests with this change. A large part of the tests are still bitexact,
with one section only differing slightly in timings. Nothing audible
unless playing the old and new versions back simultaneously.

The output of NetEqDecoderTest were also changed due to this CL, although only on android. I built and ran the test locally and compared the audio output manually - the changes were the same as for the other tests; i.e. very slight timing changes for a part of the output.

I updated the network stats checksum for android without analyzing it further. I expect it goes hand-in-hand with the changes to the output; i.e. the changes in it are fine because the audio output is fine. Likely, the stats will show changes in the usage of CNG, since that is what the code changes.

BUG=webrtc:1361

Review-Url: https://codereview.webrtc.org/2117763002
Cr-Commit-Position: refs/heads/master@{#13415}

[modify] https://crrev.com/108ecec51ce5d55bcbe455f7a1cb778dd3cb2b22/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc
[modify] https://crrev.com/108ecec51ce5d55bcbe455f7a1cb778dd3cb2b22/webrtc/modules/audio_coding/neteq/neteq_impl.cc
[modify] https://crrev.com/108ecec51ce5d55bcbe455f7a1cb778dd3cb2b22/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

Comment 19 Deleted
Sign in to add a comment