New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 44 users
Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2013
Cc:
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
Android support for AppRTC
Project Member Reported by juberti@webrtc.org, Nov 29 2012 Back to list
Allow Android sample app to connect to AppRTC room, via URL intent (i.e. apprtc.appspot.com URLs, when clicked, trigger the WebRTC sample app to connect to the specified room)

 
Comment 1 by fischman@webrtc.org, Nov 30 2012
Cc: leozwang@webrtc.org
Status: Started
Will require adding libjingle (and its deps) to webrtc/trunk/DEPS as well as porting the signalling/session-establishment from the apprtc app to WebRTCDemo.
Project Member Comment 2 by dwkang@webrtc.org, Dec 6 2012
Cc: dwkang@webrtc.org
Project Member Comment 3 by bugdroid1@chromium.org, Jan 11 2013
The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=3367

------------------------------------------------------------------------
r3367 | fischman@webrtc.org | 2013-01-11T23:15:06.291595Z

Changed paths:
   A http://code.google.com/p/webrtc/source/diff?path=/deps/third_party/junit&spec=svn3367&r_previous=3366&r=3367&format=side
   A http://code.google.com/p/webrtc/source/diff?path=/deps/third_party/junit/README.webrtc&spec=svn3367&r_previous=3366&r=3367&format=side
   A http://code.google.com/p/webrtc/source/diff?path=/deps/third_party/junit/junit-4.11.jar&spec=svn3367&r_previous=3366&r=3367&format=side

Add junit-4.11.jar to webrtc's third-party directory.  
Will be used in testing Java APIs.

BUG= webrtc:1169 
Review URL: https://webrtc-codereview.appspot.com/1028009
------------------------------------------------------------------------
Comment 4 by nahu...@gmail.com, Jan 17 2013
I'd be happy to help test this out if needed.
Progress!
https://webrtc-codereview.appspot.com/1105010 is landed in webrtc/trunk (not yet rolled to  webrtc/stable which is what stock libjingle uses)
CLs out for review: 
https://webrtc-codereview.appspot.com/1105009/ 
http://cr/42908747-p10 (Google-internal only until landing)
Project Member Comment 6 by bugdroid1@chromium.org, Feb 22 2013
The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=3554

------------------------------------------------------------------------
r3554 | fischman@webrtc.org | 2013-02-20T23:13:46.751626Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/build/common.gypi&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_capture/android/video_capture_android.cc&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_capture/android/device_info_android.cc&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_capture/android/device_info_android.h&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_render/android/java/org/webrtc/videoengine/ViERenderer.java&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_capture/android/java/org/webrtc/videoengine/VideoCaptureDeviceInfoAndroid.java&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_capture/android/java/org/webrtc/videoengine/VideoCaptureAndroid.java&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_render/android/video_render_android_impl.cc&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/android/org/webrtc/voiceengine/WebRTCAudioDevice.java&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/audio_device/linux/latebindingsymboltable_linux.cc&spec=svn3554&r_previous=3553&r=3554&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/voice_engine/voe_video_sync_impl.cc&spec=svn3554&r_previous=3553&r=3554&format=side

Misc cleanups to webrtc/android code:
- Replace some deprecated calls/enums with their more modern equivalents.
- Clean up some usage of global data and/or hide it better
- Catch specific exceptions instead of Exception, and log the exception instead
  of just its message.
- Random log message cleanups
- Added a build_with_libjingle gyp variable to mimic build_with_chromium for
  when webrtc is built as part of a libjingle project but not part of chromium.

BUG= webrtc:1169 
TEST=none

Review URL: https://webrtc-codereview.appspot.com/1105010
------------------------------------------------------------------------
Comment 7 by fischman@webrtc.org, Feb 27 2013
Internal CL landed as 43137117 and rolled into the public repo as https://code.google.com/p/libjingle/source/detail?r=286
Only outstanding CL at this point is https://webrtc-codereview.appspot.com/1105009/ which I need to recreate as a patch to the webrtc codebase now that the samples have moved.
Project Member Comment 8 by bugdroid1@chromium.org, Mar 3 2013
The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=3596

------------------------------------------------------------------------
r3596 | fischman@webrtc.org | 2013-03-03T17:28:03.387067Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/modules/video_capture/android/java/org/webrtc/videoengine/VideoCaptureAndroid.java&spec=svn3596&r_previous=3595&r=3596&format=side

VideoCaptureAndroid can now capture just buffers without also rendering to a SurfaceView.
This saves ~15% CPU on a Nexus 7 running AppRTCDemo.

BUG= 1169 

Review URL: https://webrtc-codereview.appspot.com/1150005
------------------------------------------------------------------------
Comment 9 by fischman@webrtc.org, Mar 10 2013
Status: Fixed
Reflector for Android to talk to GAE channels landed in r3644.
Project Member Comment 10 by bugdroid1@chromium.org, Mar 11 2013
The following revision refers to this bug:
    http://code.google.com/p/webrtc/source/detail?r=3644

------------------------------------------------------------------------
r3644 | fischman@webrtc.org | 2013-03-10T18:28:08.145123Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/samples/js/apprtc/index.html&spec=svn3644&r_previous=3643&r=3644&format=side
   A http://code.google.com/p/webrtc/source/diff?path=/trunk/samples/js/apprtc/html/android_channel.html&spec=svn3644&r_previous=3643&r=3644&format=side

Added an android_channel.html reflector page to allow Android apps to use a
WebView to speak the Channel API from Google AppEngine.

BUG= webrtc:1169 

Review URL: https://webrtc-codereview.appspot.com/1145006
------------------------------------------------------------------------
Sign in to add a comment