New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 12 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
NextAction: ----
OS: ----
Pri: 3
Type: Other



Sign in to add a comment

Fix webrtc copyright boilerplate

Project Member Reported by andrew@webrtc.org, Oct 30 2012 Back to list

Issue description

Our copyright boilerplate should look like this:
Copyright <year> The WebRTC Project Authors. All rights reserved.

It's currently:
Copyright (c) <year> The WebRTC project authors. All Rights Reserved.

We should fix all files in one go, then adjust the presubmit checks to not allow the old format.

Corresponding Chromium issue here:
http://code.google.com/p/chromium/issues/detail?id=140977
 
Project Member

Comment 1 by fbarchard@google.com, Oct 30 2012

For year, its the creation year, and should not be updated in the future.
If unknown, leave it as is.
Could use svn to get oldest year, with sed script to search/replace.
Project Member

Comment 2 by andrew@webrtc.org, Oct 30 2012

As Chromium is doing, we won't make an attempt to update existing incorrect copyright years.
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2014

The following revision refers to this bug:
  http://code.google.com/p/webrtc/source/detail?r=6235

------------------------------------------------------------------
r6235 | fischman@webrtc.org | 2014-05-23T17:27:18.972665Z

Changed paths:
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/webrtc/PRESUBMIT.py&spec=svn6235&r_previous=6234&r=6235&format=side
   M http://code.google.com/p/webrtc/source/diff?path=/trunk/talk/PRESUBMIT.py&spec=svn6235&r_previous=6234&r=6235&format=side

PRESUBMIT.py: accept variants on the copyright message that are present in the codebase.

Example files that this makes ok instead of flagging include:
  talk/base/signalthread_unittest.cc
  talk/base/thread_unittest.cc
  webrtc/base/signalthread_unittest.cc
  webrtc/base/thread.cc
  webrtc/base/thread.h
  webrtc/base/thread_unittest.cc

BUG=1027
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19539006
-----------------------------------------------------------------
Project Member

Comment 4 by juberti@webrtc.org, Dec 16 2014

Labels: Area-Internals
Project Member

Comment 5 by andrew@webrtc.org, Nov 3 2015

Owner: ----
Status: Available

Sign in to add a comment