New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
HW: ----
NextAction: ----
OS: ----
Priority: ----
Type: Bug

Blocked on:
issue 8573
issue 8755



Sign in to add a comment
link

Issue 8562: Cleanup Friday - February 2019

Reported by ahaas@chromium.org, Dec 7 Project Member

Issue description

Tracking bug for Cleanup Friday - 2019 - 02 - 01

See backlog for inspiration: https://docs.google.com/spreadsheets/d/1UEyD-_-6wo_is5VHeFZDEnvyVyP8x3vQT0VsuA3L2SU/edit#gid=0

Cleanup projects are
* Include what you use (clemensh@)
* Fixing flaky tests (mslekova@)
* Remove deprecated API (yangguo@, delphik@)
 
Showing comments 33 - 132 of 132 Older

Comment 34 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4ba29d05036cef4d29f695768bac6b1b3703b27b

commit 4ba29d05036cef4d29f695768bac6b1b3703b27b
Author: Igor Sheludko <ishell@chromium.org>
Date: Wed Dec 19 19:58:20 2018

[cleanup][heap] Fix kPointerSize usages in src/heap/

Bug: v8:8477, v8:8562
Change-Id: Iaa995c8fbb9f309dadac4e308d727f628fdb8b3c
Reviewed-on: https://chromium-review.googlesource.com/c/1384314
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58379}
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/globals.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/concurrent-marking.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/factory.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/heap-inl.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/heap.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/heap.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/incremental-marking.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/mark-compact-inl.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/mark-compact.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/mark-compact.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/marking.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/object-stats.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/scavenger-inl.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/slot-set.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/spaces.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/spaces.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/store-buffer.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/store-buffer.h
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/heap/sweeper.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/src/profiler/sampling-heap-profiler.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/heap/heap-utils.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/heap/test-compaction.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/heap/test-invalidated-slots.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/heap/test-mark-compact.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/heap/test-spaces.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/unittests/heap/marking-unittest.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/test/unittests/heap/slot-set-unittest.cc
[modify] https://crrev.com/4ba29d05036cef4d29f695768bac6b1b3703b27b/tools/v8heapconst.py

Comment 35 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a01508e23085f3a7fe187c39720fcf0ebdb9a1d1

commit a01508e23085f3a7fe187c39720fcf0ebdb9a1d1
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Dec 20 15:33:27 2018

[wasm] Remove hack around named constructors

Avoid named constructors for Value and Control and the hack to also have
them on subclasses.
Instead, add a new template type and a constructor to create the subtype
from this template. Instead of the named constructors on the subtype,
we now create a template and initialize the subtype from the template.

R=herhut@chromium.org

Bug: v8:8562
Change-Id: I374fc4104ab1ae5769c587bdf5a4ca7f9a0a10d7
Reviewed-on: https://chromium-review.googlesource.com/c/1382454
Reviewed-by: Stephan Herhut <herhut@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58408}
[modify] https://crrev.com/a01508e23085f3a7fe187c39720fcf0ebdb9a1d1/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/a01508e23085f3a7fe187c39720fcf0ebdb9a1d1/src/wasm/function-body-decoder-impl.h
[modify] https://crrev.com/a01508e23085f3a7fe187c39720fcf0ebdb9a1d1/src/wasm/graph-builder-interface.cc

Comment 36 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f63a657ed95e2778c6b8261fd7aff171df9180d4

commit f63a657ed95e2778c6b8261fd7aff171df9180d4
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Fri Dec 21 10:45:03 2018

[deoptimizer] Refactor GenerateDeoptimizationEntries

This reduces preprocessor-expanded source size by 64,359 from

gen         (   21 files):    71,570 to    1,613,100 (   23x)
src         (  624 files):   367,830 to   52,964,659 (  144x)
test        (  392 files):   490,924 to   37,360,916 (   76x)
third_party (  432 files):   239,085 to    9,547,902 (   40x)
total       ( 1521 files): 1,184,093 to  102,461,098 (   87x)

to

gen         (   21 files):    71,570 to    1,613,100 (   23x)
src         (  624 files):   367,837 to   52,919,005 (  144x)
test        (  392 files):   490,924 to   37,342,211 (   76x)
third_party (  432 files):   239,085 to    9,547,902 (   40x)
total       ( 1521 files): 1,184,100 to  102,396,739 (   86x)

Bug: v8:8562
Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a
Reviewed-on: https://chromium-review.googlesource.com/c/1384091
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58424}
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/api.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/arm/deoptimizer-arm.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/arm64/deoptimizer-arm64.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/compiler/backend/arm/unwinding-info-writer-arm.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/compiler/backend/arm64/unwinding-info-writer-arm64.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/compiler/backend/code-generator.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/compiler/backend/unwinding-info-writer.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/compiler/backend/x64/unwinding-info-writer-x64.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/deoptimizer.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/deoptimizer.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/eh-frame.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/frames.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/heap/mark-compact-inl.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/ia32/deoptimizer-ia32.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/macro-assembler-inl.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/mips/deoptimizer-mips.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/mips64/deoptimizer-mips64.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/objects.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/ppc/deoptimizer-ppc.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/profiler/profiler-listener.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/register-arch.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/s390/assembler-s390.h
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/s390/deoptimizer-s390.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/v8.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/f63a657ed95e2778c6b8261fd7aff171df9180d4/test/cctest/BUILD.gn

Comment 37 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4b4175d7fff9e6ce968fd581ec3b46665e254cfb

commit 4b4175d7fff9e6ce968fd581ec3b46665e254cfb
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Fri Dec 21 10:57:06 2018

Revert "[deoptimizer] Refactor GenerateDeoptimizationEntries"

This reverts commit f63a657ed95e2778c6b8261fd7aff171df9180d4.

Reason for revert: breaks compile on lite mode:

https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8926535782549686576/+/steps/build/0/steps/compile/0/stdout


Original change's description:
> [deoptimizer] Refactor GenerateDeoptimizationEntries
> 
> This reduces preprocessor-expanded source size by 64,359 from
> 
> gen         (   21 files):    71,570 to    1,613,100 (   23x)
> src         (  624 files):   367,830 to   52,964,659 (  144x)
> test        (  392 files):   490,924 to   37,360,916 (   76x)
> third_party (  432 files):   239,085 to    9,547,902 (   40x)
> total       ( 1521 files): 1,184,093 to  102,461,098 (   87x)
> 
> to
> 
> gen         (   21 files):    71,570 to    1,613,100 (   23x)
> src         (  624 files):   367,837 to   52,919,005 (  144x)
> test        (  392 files):   490,924 to   37,342,211 (   76x)
> third_party (  432 files):   239,085 to    9,547,902 (   40x)
> total       ( 1521 files): 1,184,100 to  102,396,739 (   86x)
> 
> Bug: v8:8562
> Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a
> Reviewed-on: https://chromium-review.googlesource.com/c/1384091
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58424}

TBR=ulan@chromium.org,jarin@chromium.org,sigurds@chromium.org

Change-Id: I06e6f95255a3cea6a428713e9e841781425dffe8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8562
Reviewed-on: https://chromium-review.googlesource.com/c/1387494
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58425}
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/api.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/arm/deoptimizer-arm.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/arm64/deoptimizer-arm64.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/compiler/backend/arm/unwinding-info-writer-arm.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/compiler/backend/arm64/unwinding-info-writer-arm64.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/compiler/backend/code-generator.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/compiler/backend/unwinding-info-writer.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/compiler/backend/x64/unwinding-info-writer-x64.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/deoptimizer.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/deoptimizer.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/eh-frame.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/frames.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/heap/mark-compact-inl.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/ia32/deoptimizer-ia32.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/macro-assembler-inl.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/mips/deoptimizer-mips.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/mips64/deoptimizer-mips64.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/objects.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/ppc/deoptimizer-ppc.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/profiler/profiler-listener.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/register-arch.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/s390/assembler-s390.h
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/s390/deoptimizer-s390.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/v8.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/4b4175d7fff9e6ce968fd581ec3b46665e254cfb/test/cctest/BUILD.gn

Comment 38 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d183d42fe7049d947c8d89e0b46b48550db0d3d4

commit d183d42fe7049d947c8d89e0b46b48550db0d3d4
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri Dec 21 11:52:43 2018

[cleanup][x64] Final set of x64-specific kPointerSize fixes

Bug: v8:8477, v8:8562
Change-Id: I28a8244ef22035db85b520d86aa6d5578c7c7f5d
Reviewed-on: https://chromium-review.googlesource.com/c/1384309
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58426}
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/regexp/x64/regexp-macro-assembler-x64.h
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/s390/assembler-s390.h
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/assembler-x64-inl.h
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/assembler-x64.cc
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/assembler-x64.h
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/eh-frame-x64.cc
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/frame-constants-x64.h
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/d183d42fe7049d947c8d89e0b46b48550db0d3d4/test/cctest/test-macro-assembler-x64.cc

Comment 39 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2a72b8acee0371e838e8fa693497322236e12f2a

commit 2a72b8acee0371e838e8fa693497322236e12f2a
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Fri Dec 21 14:30:17 2018

Reland "[deoptimizer] Refactor GenerateDeoptimizationEntries"

This is a reland of f63a657ed95e2778c6b8261fd7aff171df9180d4

Original change's description:
> [deoptimizer] Refactor GenerateDeoptimizationEntries
>
> This reduces preprocessor-expanded source size by 64,359 from
>
> gen         (   21 files):    71,570 to    1,613,100 (   23x)
> src         (  624 files):   367,830 to   52,964,659 (  144x)
> test        (  392 files):   490,924 to   37,360,916 (   76x)
> third_party (  432 files):   239,085 to    9,547,902 (   40x)
> total       ( 1521 files): 1,184,093 to  102,461,098 (   87x)
>
> to
>
> gen         (   21 files):    71,570 to    1,613,100 (   23x)
> src         (  624 files):   367,837 to   52,919,005 (  144x)
> test        (  392 files):   490,924 to   37,342,211 (   76x)
> third_party (  432 files):   239,085 to    9,547,902 (   40x)
> total       ( 1521 files): 1,184,100 to  102,396,739 (   86x)
>
> Bug: v8:8562
> Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a
> Reviewed-on: https://chromium-review.googlesource.com/c/1384091
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58424}

TBR=jarin@chromium.org,ulan@chromium.org

Bug: v8:8562
Change-Id: I7a8a350414941f49c6155ff43e36e0cb0b2006e5
Reviewed-on: https://chromium-review.googlesource.com/c/1387497
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58437}
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/api.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/arm/deoptimizer-arm.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/arm64/deoptimizer-arm64.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/assembler.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/compiler/backend/arm/unwinding-info-writer-arm.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/compiler/backend/arm64/unwinding-info-writer-arm64.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/compiler/backend/code-generator.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/compiler/backend/unwinding-info-writer.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/compiler/backend/x64/unwinding-info-writer-x64.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/deoptimizer.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/deoptimizer.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/eh-frame.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/external-reference.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/external-reference.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/frames.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/heap/mark-compact-inl.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/ia32/deoptimizer-ia32.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/macro-assembler-inl.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/mips/deoptimizer-mips.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/mips64/deoptimizer-mips64.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/objects.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/ppc/deoptimizer-ppc.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/profiler/profiler-listener.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/register-arch.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/s390/assembler-s390.h
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/s390/deoptimizer-s390.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/v8.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/2a72b8acee0371e838e8fa693497322236e12f2a/test/cctest/BUILD.gn

Comment 40 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf61562ff11436ccd4adf3885b36b286f3caaf91

commit cf61562ff11436ccd4adf3885b36b286f3caaf91
Author: Dan Elphick <delphick@chromium.org>
Date: Fri Dec 21 16:16:40 2018

[cleanup] Remove last uses of CreateDefaultPlatform

Convert all remaining v8::platform::CreateDefaultPlatform uses to
v8::platform::NewDefaultPlatform which returns a std::unique_ptr. This
method was originally deprecated in
https://chromium-review.googlesource.com/755033.

Bug: v8:8562
Change-Id: Ia3dce828f5cc9c757728c2c135398699f8fe2c50
Reviewed-on: https://chromium-review.googlesource.com/c/1388466
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618544}
[modify] https://crrev.com/cf61562ff11436ccd4adf3885b36b286f3caaf91/testing/libfuzzer/fuzzers/javascript_parser_proto_fuzzer.cc
[modify] https://crrev.com/cf61562ff11436ccd4adf3885b36b286f3caaf91/testing/libfuzzer/fuzzers/v8_fuzzer.cc
[modify] https://crrev.com/cf61562ff11436ccd4adf3885b36b286f3caaf91/third_party/blink/common/test/run_all_unittests.cc

Comment 41 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc0832ef5294b0abffe1c892a5d055ce0e202b0a

commit cc0832ef5294b0abffe1c892a5d055ce0e202b0a
Author: Dan Elphick <delphick@chromium.org>
Date: Mon Dec 24 11:31:23 2018

[cleanup] Fix uses of deprecated v8 GetPropertyNames

Replace deprecated GetPropertyNames() with
GetPropertyNames(context).ToLocalChecked(). The previous version
obtained the Context implicitly which could be wrong if the Context
was not properly restored. Additionally the previous version does not
force checking of the exception status which the new version does via
the V8_WARN_UNUSED_RESULT macro.

Bug: v8:7286, v8:8562
Change-Id: If144eb10b4ba0f045ac13af02d1054ffa7e492c1
Reviewed-on: https://chromium-review.googlesource.com/c/1388107
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618817}
[modify] https://crrev.com/cc0832ef5294b0abffe1c892a5d055ce0e202b0a/content/renderer/v8_value_converter_impl_unittest.cc

Comment 42 by bugdroid1@chromium.org, Dec 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/19b361e301c0f924fa71e88269cb6bd7f673d25f

commit 19b361e301c0f924fa71e88269cb6bd7f673d25f
Author: Igor Sheludko <ishell@chromium.org>
Date: Thu Dec 27 03:14:42 2018

[cleanup][csa] Fix kPointerSize usages in CSA

Bug: v8:8477, v8:8562
Change-Id: I6ef4291ebd6c2bb6acc4b525014ec02a88d45281
Reviewed-on: https://chromium-review.googlesource.com/c/1388525
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58471}
[modify] https://crrev.com/19b361e301c0f924fa71e88269cb6bd7f673d25f/src/code-stub-assembler.cc
[modify] https://crrev.com/19b361e301c0f924fa71e88269cb6bd7f673d25f/src/code-stub-assembler.h

Comment 43 by bugdroid1@chromium.org, Dec 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a44cf83b0fa90319271276e2283b2b0383d498d

commit 4a44cf83b0fa90319271276e2283b2b0383d498d
Author: Igor Sheludko <ishell@chromium.org>
Date: Thu Dec 27 03:48:55 2018

[cleanup][csa] Introduce Times[SystemPointer|Tagged]Size instead of TimesPointerSize

Bug: v8:8477, v8:8562
Change-Id: I54b857cdacf9360b95d64147a486a0d5fa1ffe10
Reviewed-on: https://chromium-review.googlesource.com/c/1388526
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58473}
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/builtins/builtins-microtask-queue-gen.cc
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/code-stub-assembler.cc
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/code-stub-assembler.h
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/elements-kind.h
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/src/ic/accessor-assembler.cc
[modify] https://crrev.com/4a44cf83b0fa90319271276e2283b2b0383d498d/test/cctest/test-elements-kind.cc

Comment 45 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8

commit 94ba6c6f400c38372a1fd40ff0d27978e1cd18c8
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Jan 02 12:49:18 2019

Replace some LazyInstances by standard C++ methods

Introduce a LeakyObject template and use that to implement static
lazily initialized objects that never get destructed. This was done in a
hand-crafted and complex way before via LazyInstance and
LazyStaticInstance.

R=tebbi@chromium.org

Bug: v8:8600, v8:8562
Change-Id: Id160996753b2cb1baf0f4b2cec9e1727f1d01512
Reviewed-on: https://chromium-review.googlesource.com/c/1388539
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58494}
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/allocation.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/assert-scope.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/base/lazy-instance.h
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/basic-block-profiler.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/compiler/common-operator.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/compiler/js-operator.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/compiler/machine-operator.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/compiler/simplified-operator.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/compiler/type-cache.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/libsampler/sampler.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/profiler/cpu-profiler.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/register-configuration.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/runtime/runtime-test.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/thread-id.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/wasm/wasm-engine.cc
[modify] https://crrev.com/94ba6c6f400c38372a1fd40ff0d27978e1cd18c8/src/x64/disasm-x64.cc

Comment 46 by bugdroid1@chromium.org, Jan 2

Project Member

Comment 47 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/088bdc00e49bddfb45238320769fde64210a008a

commit 088bdc00e49bddfb45238320769fde64210a008a
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Jan 02 17:13:39 2019

Store TypeCache as pointer instead of reference

Apart from being more in-line with the style guide, this allows to use
DEFINE_LAZY_LEAKY_OBJECT_GETTER for defining {TypeCache::Get}.

R=tebbi@chromium.org

Bug: v8:8562
Change-Id: I016b28624950ce9404180fc1ca1a232551f75cd0
Reviewed-on: https://chromium-review.googlesource.com/c/1392201
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58500}
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/access-builder.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/access-info.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/access-info.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/escape-analysis-reducer.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/js-native-context-specialization.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/js-typed-lowering.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/operation-typer.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/operation-typer.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/representation-change.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/representation-change.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/simplified-lowering.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/type-cache.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/type-cache.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/typed-optimization.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/typed-optimization.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/typer.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/typer.h
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/src/compiler/verifier.cc
[modify] https://crrev.com/088bdc00e49bddfb45238320769fde64210a008a/test/cctest/compiler/test-representation-change.cc

Comment 48 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5ea59597cf86f588e38e7e6756b58aa5843412ac

commit 5ea59597cf86f588e38e7e6756b58aa5843412ac
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 03 12:09:09 2019

[Liftoff] Remove all computation of "half indexes"

Instead, always pass an index and an enum pointing to either half.

R=titzer@chromium.org

Bug: v8:6600, v8:8562
Change-Id: I7e73bd97bfc7ebf644b242980aa0a73cd5f18949
Reviewed-on: https://chromium-review.googlesource.com/c/1392189
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58516}
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/arm/liftoff-assembler-arm.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/arm64/liftoff-assembler-arm64.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/ia32/liftoff-assembler-ia32.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/liftoff-assembler.cc
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/liftoff-assembler.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/mips/liftoff-assembler-mips.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/ppc/liftoff-assembler-ppc.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/s390/liftoff-assembler-s390.h
[modify] https://crrev.com/5ea59597cf86f588e38e7e6756b58aa5843412ac/src/wasm/baseline/x64/liftoff-assembler-x64.h

Comment 49 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0b25bbbe5f47d60d7598a0af6344cff8155e7194

commit 0b25bbbe5f47d60d7598a0af6344cff8155e7194
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 03 12:54:10 2019

Remove deprecated 'throw()' specifier

This specifier is deprecated and will be removed in C++20. Replace it
with V8_NOEXCEPT where is makes sense and remove it otherwise. Also
remove redundant constructors.

R=tebbi@chromium.org

Bug: v8:8562
Change-Id: I1335dcac5cac14b62b655cfd507decd4de653043
Reviewed-on: https://chromium-review.googlesource.com/c/1392204
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58517}
[modify] https://crrev.com/0b25bbbe5f47d60d7598a0af6344cff8155e7194/src/zone/zone-allocator.h

Comment 50 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4339f5f179a64f476ff5a3a0b283c2f37aad2150

commit 4339f5f179a64f476ff5a3a0b283c2f37aad2150
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 03 12:55:15 2019

[base] Refactor STATIC_CHAR_VECTOR into a template

Templates are nicer than macros, and in this case it's not more complex.

R=tebbi@chromium.org

Bug: v8:8562
Change-Id: I3aea7b4138f144166418c0827dd7c58ea459c670
Reviewed-on: https://chromium-review.googlesource.com/c/1392200
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58518}
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/asmjs/asm-js.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/contexts.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/heap/factory.h
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/messages.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/parsing/scanner.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/runtime/runtime-test.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/uri.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/vector.h
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/wasm/wasm-debug.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/src/wasm/wasm-js.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/test/cctest/test-api.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/test/cctest/test-compiler.cc
[modify] https://crrev.com/4339f5f179a64f476ff5a3a0b283c2f37aad2150/test/cctest/test-serialize.cc

Comment 51 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/195686d37c027083c267eceac44e63ffca5c299a

commit 195686d37c027083c267eceac44e63ffca5c299a
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Jan 08 11:59:19 2019

Advance GetProperyNames/GetOwnPropertyNames deprecation

Change Object::GetPropertyNames/GetOwnPropertyNames from
V8_DEPRECATE_SOON to V8_DEPRECATED.

Bug: v8:7286, v8:8562
Change-Id: I2c601e6bf729e8fb68be8bc9a7b1618da61934af
Reviewed-on: https://chromium-review.googlesource.com/c/1393285
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58624}
[modify] https://crrev.com/195686d37c027083c267eceac44e63ffca5c299a/include/v8.h

Comment 52 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ba56d282515b891df4f1f070651418b147bce6dd

commit ba56d282515b891df4f1f070651418b147bce6dd
Author: Stephan Herhut <herhut@chromium.org>
Date: Thu Jan 10 08:54:53 2019

[regalloc] Cleanup use of kMaxFpRegisters

Minor refactoring to introduce kMaxRegisters instead of relying on
the fact that kMaxGpRegisters <= kMaxFpRegisters.

Bug: v8:8562
Change-Id: If8221a799199c62d5262cfad762489a5088351c7
Reviewed-on: https://chromium-review.googlesource.com/c/1403120
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Stephan Herhut <herhut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58687}
[modify] https://crrev.com/ba56d282515b891df4f1f070651418b147bce6dd/src/compiler/backend/register-allocator.cc
[modify] https://crrev.com/ba56d282515b891df4f1f070651418b147bce6dd/src/compiler/backend/register-allocator.h
[modify] https://crrev.com/ba56d282515b891df4f1f070651418b147bce6dd/src/register-configuration.h

Comment 53 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b9854da1eca9c3734b0715818b7f68c70874f3cd

commit b9854da1eca9c3734b0715818b7f68c70874f3cd
Author: Andreas Haas <ahaas@chromium.org>
Date: Fri Jan 11 15:18:47 2019

[fuzzer] Remove the wasm section fuzzers

The fuzzers were already removed on the chrome side and therefore
inactive, see https://crrev.com/c/1194228.

R=machenbach@chromium.org

Bug: v8:8562
Change-Id: I0cf5ec6d07e07452c5168ea952f45028bcea1c85
Reviewed-on: https://chromium-review.googlesource.com/c/1406678
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58750}
[modify] https://crrev.com/b9854da1eca9c3734b0715818b7f68c70874f3cd/BUILD.gn
[modify] https://crrev.com/b9854da1eca9c3734b0715818b7f68c70874f3cd/test/fuzzer/BUILD.gn
[modify] https://crrev.com/b9854da1eca9c3734b0715818b7f68c70874f3cd/test/fuzzer/testcfg.py
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-data-section.cc
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-function-sigs-section.cc
[modify] https://crrev.com/b9854da1eca9c3734b0715818b7f68c70874f3cd/test/fuzzer/wasm-fuzzer-common.cc
[modify] https://crrev.com/b9854da1eca9c3734b0715818b7f68c70874f3cd/test/fuzzer/wasm-fuzzer-common.h
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-globals-section.cc
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-imports-section.cc
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-memory-section.cc
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-names-section.cc
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm-types-section.cc
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_data_section/foo
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_function_sigs_section/foo
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_globals_section/foo
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_imports_section/foo
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_memory_section/foo
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_names_section/foo
[delete] https://crrev.com/94d84cc934e312ab8d48d085e2608084e118ec1c/test/fuzzer/wasm_types_section/foo

Comment 54 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b39d0634bcb1b895c6c5802e0d51200b7cb17bb4

commit b39d0634bcb1b895c6c5802e0d51200b7cb17bb4
Author: Stephan Herhut <herhut@chromium.org>
Date: Mon Jan 14 20:09:16 2019

[cleanup] Fix printing of wasm locals overview

The raw wasm printer was not printing the last entry of the
locals declarations. Now it does.

Bug: v8:8562
Change-Id: Ib51c674b747f95079c544131f18462d203f0933f
Reviewed-on: https://chromium-review.googlesource.com/c/1409364
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Stephan Herhut <herhut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58805}
[modify] https://crrev.com/b39d0634bcb1b895c6c5802e0d51200b7cb17bb4/src/wasm/function-body-decoder.cc

Comment 55 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/102e22658d3eb24e790654f76bf57de8dc4fdcb3

commit 102e22658d3eb24e790654f76bf57de8dc4fdcb3
Author: Jakob Kummerow <jkummerow@chromium.org>
Date: Tue Jan 15 01:20:11 2019

[cleanup] Use Page::FromHeapObject where applicable

It is slightly faster than Page::FromAddress(o->address()) (saves
one instruction), and more concise than Page::FromAddress(o->ptr()).
Same for MemoryChunk::FromHeapObject().

Bug: v8:8562
Change-Id: I9dc2b787aed5cad2d4087850dfa2e8eb157ad225
Reviewed-on: https://chromium-review.googlesource.com/c/1405031
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58806}
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/factory.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/heap-inl.h
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/heap.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/incremental-marking.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/mark-compact-inl.h
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/mark-compact.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/mark-compact.h
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/spaces-inl.h
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/spaces.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/heap/spaces.h
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/src/snapshot/serializer.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/heap-utils.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-array-buffer-tracker.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-compaction.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-external-string-tracker.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-invalidated-slots.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-page-promotion.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-spaces.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/heap/test-weak-references.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/test-api.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/test-serialize.cc
[modify] https://crrev.com/102e22658d3eb24e790654f76bf57de8dc4fdcb3/test/cctest/test-unboxed-doubles.cc

Comment 56 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/94fbd51b9596c52f49c390a8c5e0893bae63f123

commit 94fbd51b9596c52f49c390a8c5e0893bae63f123
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Jan 15 10:57:26 2019

[base] Move EnumSet to its own header

EnumSet currently lives in src/utils.h, which is a conglomerate of many
different helper functions and classes. In order to remove unneeded
include, move the EnumSet to its own header.

R=titzer@chromium.org

Bug: v8:7490, v8:8562
Change-Id: I979814167e87b914e9807b03e342d8b34e514331
Reviewed-on: https://chromium-review.googlesource.com/c/1409430
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58818}
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/BUILD.gn
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/asmjs/asm-parser.h
[add] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/base/enum-set.h
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/compiler/backend/arm/instruction-selector-arm.cc
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/compiler/backend/gap-resolver.cc
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/compiler/machine-operator.h
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/utils.h
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/src/wasm/module-compiler.cc
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/test/cctest/cctest.h
[modify] https://crrev.com/94fbd51b9596c52f49c390a8c5e0893bae63f123/test/cctest/test-parsing.cc

Comment 57 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a16c1250e03b3ffa8bd8c020c122555f14f88b7f

commit a16c1250e03b3ffa8bd8c020c122555f14f88b7f
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Jan 15 11:04:56 2019

Advance SetWasmCompileStreamingCallback deprecation

Change Isolate::SetWasmCompileStreamingCallback from
V8_DEPRECATE_SOON to V8_DEPRECATED.

Bug: v8:8562
Change-Id: I57b2e72817fe5b580fe6dc123a2389247010cb43
Reviewed-on: https://chromium-review.googlesource.com/c/1411634
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58819}
[modify] https://crrev.com/a16c1250e03b3ffa8bd8c020c122555f14f88b7f/include/v8.h

Comment 58 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bc3d7298809cdf990aea2d0755f8263392e1ba7e

commit bc3d7298809cdf990aea2d0755f8263392e1ba7e
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Jan 15 14:23:46 2019

[api] Advance CreateDefaultPlatform deprecation

Change platform::CreateDefaultPlatform from V8_DEPRECATE_SOON to
V8_DEPRECATED.

Bug: v8:8562
Change-Id: I053ff29b27dcd454960007bfd6597a01e1b2e62a
Reviewed-on: https://chromium-review.googlesource.com/c/1411636
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58831}
[modify] https://crrev.com/bc3d7298809cdf990aea2d0755f8263392e1ba7e/include/libplatform/libplatform.h

Comment 59 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b121cde9011ac418249e14bf83e3e72349054de8

commit b121cde9011ac418249e14bf83e3e72349054de8
Author: Dan Elphick <delphick@chromium.org>
Date: Wed Jan 16 14:25:13 2019

[api] Add Check method to Maybe

This new method returns no value and just verifies that the Maybe is not
Empty. This is intended to be used for functions like Object::Set that
return a Maybe<bool> but only use "emptiness" to indicate its result and
where ToLocalChecked() appears to be discarding information.

Also comments Object::Set to indicate that Check() is the preferred way
of asserting that the Set should always succeed.

R=yangguo

Bug: v8:8562
Change-Id: Ic3b45e42fa9ba0b53f1a764660a56041e64f087b
Reviewed-on: https://chromium-review.googlesource.com/c/1414912
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58852}
[modify] https://crrev.com/b121cde9011ac418249e14bf83e3e72349054de8/include/v8.h

Comment 60 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1887b306922dbd8b9e3eb4729d8def6565d1932b

commit 1887b306922dbd8b9e3eb4729d8def6565d1932b
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Jan 16 15:36:28 2019

[cleanup] Remove redundant PipelineImpl::Run implementations

A minor cleanup I saw while working on related stuff.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: If11fe1dae3820e61ed3807cfefd33dc229903ffb
Reviewed-on: https://chromium-review.googlesource.com/c/1414915
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58855}
[modify] https://crrev.com/1887b306922dbd8b9e3eb4729d8def6565d1932b/src/compiler/pipeline.cc

Comment 61 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4064757cbf6806e24f91b30eeb766b1a0681609b

commit 4064757cbf6806e24f91b30eeb766b1a0681609b
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Jan 16 18:17:35 2019

[cleanup] Clean up base::EnumSet

After moving to its own header, this CL cleans up some parts of the
interface. It fixes names and const-declarations of simple accessors,
and adds a named constructor to make it explicit that an EnumSet should
be constructed from an integral value.
Also refactor the use in cctest.h to have less statically declared
constants. Instead, just create the set of extensions in the individual
tests.

R=titzer@chromium.org

Bug: v8:8562
Change-Id: I6178d1aba25afa1d7f54c29ccf81505c165e7cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1409366
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58862}
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/src/asmjs/asm-js.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/src/base/enum-set.h
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/src/compiler/backend/gap-resolver.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/src/compiler/machine-operator.h
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/src/wasm/module-compiler.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/cctest.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/cctest.h
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/test-compiler.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/test-cpu-profiler.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/test-log-stack-tracer.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/test-parsing.cc
[modify] https://crrev.com/4064757cbf6806e24f91b30eeb766b1a0681609b/test/cctest/test-profile-generator.cc

Comment 62 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/edab9a202197b39a1a78b13f3cb922e91dc21b9a

commit edab9a202197b39a1a78b13f3cb922e91dc21b9a
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 17 08:20:36 2019

Use forwarding constructors for MacroAssembler

and TurboAssembler. Instead of listing all the different combinations
of arguments (which is one more now, temporarily), just forward all
arguments down via MacroAssembler and TurboAssembler to
TurboAssemblerBase.
Interestingly, this requires more specific types sometimes (int instead
of size_t), since further down the forwarding chain, the compiler does
not recognize any more that the value is a constant, and emits a
warning about a possibly truncating implicit conversion.

R=mstarzinger@chromium.org

Bug: v8:8689, v8:8562
Change-Id: Ifd13d2210ee64251c0075c0d9b68cacd5107d9ab
Reviewed-on: https://chromium-review.googlesource.com/c/1414913
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58869}
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/arm/assembler-arm.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/arm64/assembler-arm64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/assembler.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/builtins/builtins.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/ia32/assembler-ia32.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/mips/assembler-mips.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/mips64/assembler-mips64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/arm/regexp-macro-assembler-arm.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/arm64/regexp-macro-assembler-arm64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/ia32/regexp-macro-assembler-ia32.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/ia32/regexp-macro-assembler-ia32.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/mips/regexp-macro-assembler-mips.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/mips64/regexp-macro-assembler-mips64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/regexp/x64/regexp-macro-assembler-x64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/turbo-assembler.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/turbo-assembler.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/x64/assembler-x64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/test/cctest/test-assembler-mips.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/test/cctest/test-assembler-mips64.cc
[modify] https://crrev.com/edab9a202197b39a1a78b13f3cb922e91dc21b9a/test/cctest/test-assembler-x64.cc

Comment 63 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469

commit 1a1f4e1ef432dd1ffdafa538f7a330733a7a8469
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 17 11:57:07 2019

[test] Refactor AllocateAssemblerBuffer

Refactor the AllocateAssemblerBuffer helper for the new Assembler API.
This is the only non-mechanical part, all other callsites that create
Assembler instances can be trivially changed to the new API. This will
be done in a separate CL.

R=mstarzinger@chromium.org

Bug: v8:8689, v8:8562
Change-Id: I6c150748eeea778d9b70f41fd66fbb1221035a1b
Reviewed-on: https://chromium-review.googlesource.com/c/1415490
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58881}
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/cctest/test-assembler-arm64.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/cctest/test-assembler-x64.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/cctest/test-icache.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/cctest/test-macro-assembler-arm.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/cctest/test-macro-assembler-x64.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/cctest/wasm/test-jump-table-assembler.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/common/assembler-tester.h
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-arm-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-arm64-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-ia32-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-mips-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-mips64-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-ppc-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-s390-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/assembler/turbo-assembler-x64-unittest.cc
[modify] https://crrev.com/1a1f4e1ef432dd1ffdafa538f7a330733a7a8469/test/unittests/wasm/trap-handler-x64-unittest.cc

Comment 64 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/edfb8cadd03c26d97256f1ecd3335db545c9895c

commit edfb8cadd03c26d97256f1ecd3335db545c9895c
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 17 12:39:57 2019

[assembler] Remove legacy constructor

Refactor all call sites to use the new API introduced in
https://crrev.com/c/1411347 and remove the legacy constructors.

R=mstarzinger@chromium.org

Bug: v8:8689, v8:8562
Change-Id: Id73686413726b2860f551dd200ef4b8823ef3034
Reviewed-on: https://chromium-review.googlesource.com/c/1415491
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58884}
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/arm/assembler-arm.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/arm64/assembler-arm64.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/assembler.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/builtins/builtins.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/deoptimizer.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/ia32/assembler-ia32.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/mips/assembler-mips.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/mips64/assembler-mips64.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/regexp/ia32/regexp-macro-assembler-ia32.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/turbo-assembler.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/wasm/baseline/ia32/liftoff-assembler-ia32.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/wasm/baseline/liftoff-assembler.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/wasm/baseline/mips/liftoff-assembler-mips.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/wasm/baseline/x64/liftoff-assembler-x64.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/wasm/jump-table-assembler.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/src/x64/assembler-x64.h
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/assembler-helper-arm.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/heap/test-weak-references.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-assembler-arm.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-assembler-arm64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-assembler-ia32.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-assembler-mips.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-assembler-mips64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-assembler-x64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-disasm-arm.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-disasm-arm64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-disasm-ia32.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-disasm-mips.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-disasm-mips64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-disasm-x64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-macro-assembler-mips.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-macro-assembler-mips64.cc
[modify] https://crrev.com/edfb8cadd03c26d97256f1ecd3335db545c9895c/test/cctest/test-sync-primitives-arm64.cc

Comment 65 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fa06d7071a43db0568c02309c97177e593fbc8e3

commit fa06d7071a43db0568c02309c97177e593fbc8e3
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jan 17 13:45:46 2019

[test] Remove TEARDOWN macro, use managed pointers instead

Clean-up to remove explicit resource deallocation by using unique_ptr
instead.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I603cf1b9e2cfe33bc7e6bd84cdd228cf10ff20ba
Reviewed-on: https://chromium-review.googlesource.com/c/1415492
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58886}
[modify] https://crrev.com/fa06d7071a43db0568c02309c97177e593fbc8e3/test/cctest/test-assembler-arm64.cc

Comment 66 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/acdd3c1025980524063185df90ea7bd2dd3343f3

commit acdd3c1025980524063185df90ea7bd2dd3343f3
Author: Andreas Haas <ahaas@chromium.org>
Date: Fri Jan 18 10:05:47 2019

[cleanup] Fix comment in cancelable-task.h

TBR=clemensh@chromium.org
No-Try: true
No-Presubmit: true
No-Treechecks: true

Bug: v8:8562
Change-Id: Ic44219287a1cc1047460b4ba7b95b8fb6e6e4b9a
Reviewed-on: https://chromium-review.googlesource.com/c/1420757
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58914}
[modify] https://crrev.com/acdd3c1025980524063185df90ea7bd2dd3343f3/src/cancelable-task.h

Comment 67 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6d6825f29501f1970ffe965ba9252930eee68f1a

commit 6d6825f29501f1970ffe965ba9252930eee68f1a
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri Jan 18 13:22:02 2019

[cleanup] Fix kPointerSize usages in the rest of runtime

Bug: v8:8477, v8:8562
Change-Id: Ieb677e0989f77ed207567d468faec0bf92752967
Reviewed-on: https://chromium-review.googlesource.com/c/1388529
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58922}
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/api.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/arguments.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/base/platform/platform.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/bit-vector.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/bootstrapper.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/code-stub-assembler.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/constant-pool.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/constant-pool.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/deoptimizer.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/deoptimizer.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/disassembler.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/eh-frame.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/elements-kind.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/elements.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/external-reference-table.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/feedback-vector-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/feedback-vector.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/field-index-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/field-index.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/frames-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/frames.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/frames.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/ic/accessor-assembler.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/ic/ic.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/ic/keyed-store-generic.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/isolate-allocator.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/isolate-data.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/isolate.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/isolate.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/layout-descriptor-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/layout-descriptor.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/lookup-cache-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/machine-type.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/memcopy.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects-debug.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects-inl.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/cell.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/feedback-cell.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/foreign.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/free-space.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/heap-object.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/oddball.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/objects/struct.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/property-details.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/regexp/regexp-stack.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/roots.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/runtime/runtime-internal.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/runtime/runtime-scopes.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/runtime/runtime-strings.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/snapshot/embedded-file-writer.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/snapshot/natives.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/snapshot/serializer.cc
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/src/utils.h
[modify] https://crrev.com/6d6825f29501f1970ffe965ba9252930eee68f1a/test/cctest/compiler/graph-builder-tester.h

Comment 68 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d7ad2e583b4172215bdea24541ba484f35d0eec6

commit d7ad2e583b4172215bdea24541ba484f35d0eec6
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Tue Jan 22 14:11:20 2019

Remove unnecessary includes

This saves about 80,000 LoC after preprocessor expansion.

Bug: v8:8562
Change-Id: I67b20edb73b801ddcc2937b84468241e3076535f
Reviewed-on: https://chromium-review.googlesource.com/c/1425906
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58989}
[modify] https://crrev.com/d7ad2e583b4172215bdea24541ba484f35d0eec6/src/arguments.cc
[modify] https://crrev.com/d7ad2e583b4172215bdea24541ba484f35d0eec6/src/lookup-cache.cc

Comment 69 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8a6d3118305df74d77c05495a2f29c1d2027dc54

commit 8a6d3118305df74d77c05495a2f29c1d2027dc54
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Jan 22 15:26:32 2019

[isolate] Remove dead declaration and dead definition

{Isolate::per_isolate_thread_data_key()} is not even defined, and
{Isolate::isolate_key()} is unused.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I490989510865903c702158e33621c9990052c2a8
Reviewed-on: https://chromium-review.googlesource.com/c/1425907
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58997}
[modify] https://crrev.com/8a6d3118305df74d77c05495a2f29c1d2027dc54/src/isolate.h

Comment 70 by bugdroid, Jan 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/147d05011d698c6784f80ed62b75335adec83d87

commit 147d05011d698c6784f80ed62b75335adec83d87
Author: Simon Zünd <szuend@chromium.org>
Date: Mon Jan 28 11:51:27 2019

[refactor] Change method names in FrameArrayIterator

This CL changes 'HasNext' to 'HasFrame' and 'Next' to 'Advance' to
better reflect the semantics of the iterator.
'Next' usually returns the next element.

R=jgruber@chromium.org

Bug: v8:8562
Change-Id: Idbd1c084c39dd4a10c1c6a6db7782637b9b16cc4
Reviewed-on: https://chromium-review.googlesource.com/c/1436023
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59117}
[modify] https://crrev.com/147d05011d698c6784f80ed62b75335adec83d87/src/messages.cc
[modify] https://crrev.com/147d05011d698c6784f80ed62b75335adec83d87/src/messages.h

Comment 71 by bugdroid, Jan 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e532e84362849ca494e6da6098269dec24ad03c8

commit e532e84362849ca494e6da6098269dec24ad03c8
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Jan 28 14:23:55 2019

[Liftoff] Fix KIntConst typo

Now that I saw the typo I cannot unsee it anymore, but somehow this
typo went unrecognized for nearly 12 months (since
https://crrev.com/c/904443).

R=ahaas@chromium.org

Bug: v8:8562
Change-Id: Iafaeb2313dcfa305007c3c87e8f0440d8b15980e
Reviewed-on: https://chromium-review.googlesource.com/c/1436021
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59125}
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/arm/liftoff-assembler-arm.h
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/arm64/liftoff-assembler-arm64.h
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/ia32/liftoff-assembler-ia32.h
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/liftoff-assembler.cc
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/liftoff-assembler.h
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/mips/liftoff-assembler-mips.h
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
[modify] https://crrev.com/e532e84362849ca494e6da6098269dec24ad03c8/src/wasm/baseline/x64/liftoff-assembler-x64.h

Comment 72 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a7f59888165aa17d32b7f53c64f3f9b0f9814533

commit a7f59888165aa17d32b7f53c64f3f9b0f9814533
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Jan 29 12:31:58 2019

[wasm][test] Rename {Link} to {SetExecutable}

There is no linking stage any more, and all the {Link} method did was
to set the module to executable. Thus rename the method to reflect that.

R=ahaas@chromium.org

Bug: v8:8562
Change-Id: Ifc83b5cbbb1377312d7c318e50a0f9d1ede45aa6
Reviewed-on: https://chromium-review.googlesource.com/c/1439237
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59167}
[modify] https://crrev.com/a7f59888165aa17d32b7f53c64f3f9b0f9814533/test/cctest/wasm/test-wasm-interpreter-entry.cc
[modify] https://crrev.com/a7f59888165aa17d32b7f53c64f3f9b0f9814533/test/cctest/wasm/wasm-run-utils.cc
[modify] https://crrev.com/a7f59888165aa17d32b7f53c64f3f9b0f9814533/test/cctest/wasm/wasm-run-utils.h

Comment 73 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/06193b0b796124eb53bd8779965db61b4f82c770

commit 06193b0b796124eb53bd8779965db61b4f82c770
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed Jan 30 10:13:24 2019

[api] Move forward deprecations around Persistent handles

In future, weak handles will be considered as independent and MarkActive() will
not be supported anymore. Users should switch to TracedGlobal, when relying on
special cases for using handles with v8::EmbedderHeapTracer.

Bug: chromium:923361, v8:8562
Change-Id: Ic6e01a1ab59a25c5fb0aa2ebfb8ddb02e454d72d
Reviewed-on: https://chromium-review.googlesource.com/c/1443064
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59194}
[modify] https://crrev.com/06193b0b796124eb53bd8779965db61b4f82c770/include/v8.h
[modify] https://crrev.com/06193b0b796124eb53bd8779965db61b4f82c770/test/cctest/test-global-handles.cc

Comment 74 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7

commit 0243ba8027165e2fd8b6ef1cda292dd1a2d853c7
Author: Igor Sheludko <ishell@chromium.org>
Date: Wed Jan 30 16:49:46 2019

[cleanup][x32] Remove x32 leftovers from x64 assembler, pt.1

addp, andp, cmpp, decp, incp, leap, negp, orp, subp, testp, xorp,
shrp, sarp, shlp are replaced with respective quad-word instructions.

Some wrongly-used xxxp instructions in regexp code are replaced with xxxl.

Bug: v8:8621, v8:8562
Change-Id: If5fe3229a35805b8ef84d3e1ffa05cf9ed91ceef
Reviewed-on: https://chromium-review.googlesource.com/c/1446451
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59217}
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/wasm/baseline/x64/liftoff-assembler-x64.h
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/x64/assembler-x64.h
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/0243ba8027165e2fd8b6ef1cda292dd1a2d853c7/src/x64/macro-assembler-x64.h

Comment 75 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3974a6558e82084dff07cebac48ffbd56d3f9a94

commit 3974a6558e82084dff07cebac48ffbd56d3f9a94
Author: Simon Zünd <szuend@chromium.org>
Date: Thu Jan 31 11:40:35 2019

[cleanup] Remove duplicate getter in Signature class

R=tebbi@chromium.org

Bug: v8:7793, v8:8562
Change-Id: I783a6d76edd20b73b25cc81395ecadbedd346e8b
Reviewed-on: https://chromium-review.googlesource.com/c/1447775
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59239}
[modify] https://crrev.com/3974a6558e82084dff07cebac48ffbd56d3f9a94/src/torque/types.cc
[modify] https://crrev.com/3974a6558e82084dff07cebac48ffbd56d3f9a94/src/torque/types.h

Comment 76 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/75eb52c7f4a342e4ddac7ded003f091b561cecef

commit 75eb52c7f4a342e4ddac7ded003f091b561cecef
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Thu Jan 31 13:10:18 2019

[wasm] Remove dead {WasmDebugInfo::GetScopeDetails}.

R=clemensh@chromium.org
BUG=v8:8562

Change-Id: I13e566b95785edf788de842b833cb7f5bc2b731d
Reviewed-on: https://chromium-review.googlesource.com/c/1447771
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59242}
[modify] https://crrev.com/75eb52c7f4a342e4ddac7ded003f091b561cecef/src/wasm/wasm-debug.cc
[modify] https://crrev.com/75eb52c7f4a342e4ddac7ded003f091b561cecef/src/wasm/wasm-objects.h

Comment 77 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae

commit 0d809f9d9b25a0c1a2828ef817a9bfd405d85cae
Author: Igor Sheludko <ishell@chromium.org>
Date: Thu Jan 31 14:00:41 2019

[cleanup][x32] Remove x32 leftovers from x64 assembler, pt.2

movXXXp are replaced with respective movXXXq.

Drive-by cleanup: unified the way we generate movq with other mov instructions.

Bug: v8:8621, v8:8562
Change-Id: I5c65dccf4e460cad5c3cee3dfabfd6ce39abc244
Reviewed-on: https://chromium-review.googlesource.com/c/1446096
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59243}
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/debug/x64/debug-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/wasm/baseline/x64/liftoff-assembler-x64.h
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/x64/assembler-x64-inl.h
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/x64/assembler-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/x64/assembler-x64.h
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/0d809f9d9b25a0c1a2828ef817a9bfd405d85cae/src/x64/macro-assembler-x64.h

Comment 78 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e8c3d743cb77e642f509f7a39bb9c5acad90587f

commit e8c3d743cb77e642f509f7a39bb9c5acad90587f
Author: Igor Sheludko <ishell@chromium.org>
Date: Thu Jan 31 14:43:20 2019

[cleanup][x32] Remove x32 leftovers, pt.3

Bug: v8:8621, v8:8562
Change-Id: I79014f92ba95d21b31ff28cb615a01aa00d0d5d6
Reviewed-on: https://chromium-review.googlesource.com/c/1448271
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59245}
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/gdb-jit.cc
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/globals.h
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/log.cc
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/regexp/x64/regexp-macro-assembler-x64.h
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/wasm/baseline/arm/liftoff-assembler-arm.h
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/x64/assembler-x64.h
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/x64/deoptimizer-x64.cc
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/x64/frame-constants-x64.h
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/e8c3d743cb77e642f509f7a39bb9c5acad90587f/test/cctest/test-lockers.cc

Comment 79 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e004fe75f70ac01287027a666d62771558ddb5fe

commit e004fe75f70ac01287027a666d62771558ddb5fe
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Thu Jan 31 16:14:34 2019

[ic] Don't unroll the loop in AccessorAssembler::HandlePolymorphicCase().

Previously AccessorAssembler::HandlePolymorphicCase() had 4 versions of
the inner loop unrolled, but we always had to check against the length
after 1 (POLYMORPHIC with name) or 2 (regular POLYMORPHIC) unrolled
iterations anyways, so there's not a lot of benefit to unrolling besides
the potentially better branch prediction in some cases. But that doesn't
seem to be beneficial even in extreme cases (in fact on ARM cores we
might get some benefit from having less code instead), and probably
doesn't justify the additional C++ / generated code.

I used the following extreme micro-benchmark to check the worst case
performance impact:

```js
function test(o, n) {
  var result;
  for (var i = 0; i < n; ++i) {
    result = o.x;
  }
  return result;
}

const N = 1e8;
const objs = [{x: 0}, {x:1,a:1}, {x:2,b:2}, {x:3,c:3}];
for (var j = 0; j < objs.length; ++j) test(objs[j], N);

console.time('Time');
for (var j = 0; j < objs.length; ++j) test(objs[j], N);
console.timeEnd('Time');
```

Running this with --noopt shows a ~1% performance regression with this
patch on a beefy z840 gLinux workstation, which gives me some confidence
that overall this patch is going to be neutral and maybe beneficial in
case of less powerful ARM cores.

Note to performance sheriffs: This could potentially tank some
performance tests. In that case we may need to revisit the unrolling.

Bug: v8:8562
Change-Id: I731599a7778da1992d981d36022c407ef5c735eb
Reviewed-on: https://chromium-review.googlesource.com/c/1448275
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59252}
[modify] https://crrev.com/e004fe75f70ac01287027a666d62771558ddb5fe/src/ic/accessor-assembler.cc
[modify] https://crrev.com/e004fe75f70ac01287027a666d62771558ddb5fe/src/ic/accessor-assembler.h

Comment 80 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a1cc076e934fb712b9d7621ded5138e23678871b

commit a1cc076e934fb712b9d7621ded5138e23678871b
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Feb 01 07:29:19 2019

[isolate] Remove unused save_context field

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I05abb6d9e594c797cad558befac4376b376bc514
Reviewed-on: https://chromium-review.googlesource.com/c/1448274
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59267}
[modify] https://crrev.com/a1cc076e934fb712b9d7621ded5138e23678871b/src/isolate.cc
[modify] https://crrev.com/a1cc076e934fb712b9d7621ded5138e23678871b/src/isolate.h

Comment 82 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a9e93572d42663867fc62ef456b4fb1a92234c5a

commit a9e93572d42663867fc62ef456b4fb1a92234c5a
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Feb 01 10:13:30 2019

[test] Check for illegal uses of mjsunit methods

The assertThrows and assertDoesNotThrow methods expect either a
function to execute, or a string to eval. In several tests however we
accidentally passed the *result* of the statement to be tested instead
of the code.
This CL adds check to catch such error early, and removes wrong uses.
In most places, we do not need to use assertDoesNotThrow anyway,
because exceptions are handled as test failures.

Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
MjsUnitAssertionErrors correctly.

R=mathias@chromium.org

Bug: v8:8562
Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
Reviewed-on: https://chromium-review.googlesource.com/c/1439238
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59277}
[modify] https://crrev.com/a9e93572d42663867fc62ef456b4fb1a92234c5a/test/mjsunit/mjsunit.js
[modify] https://crrev.com/a9e93572d42663867fc62ef456b4fb1a92234c5a/test/mjsunit/regress/regress-3218530.js
[modify] https://crrev.com/a9e93572d42663867fc62ef456b4fb1a92234c5a/test/mjsunit/regress/regress-687.js
[modify] https://crrev.com/a9e93572d42663867fc62ef456b4fb1a92234c5a/test/mjsunit/regress/regress-crbug-715455.js
[modify] https://crrev.com/a9e93572d42663867fc62ef456b4fb1a92234c5a/test/mjsunit/wasm/errors.js

Comment 84 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/14c06a34dbf5c339fe66bdbe691c806031780686

commit 14c06a34dbf5c339fe66bdbe691c806031780686
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Feb 01 12:12:41 2019

Revert "[test] Check for illegal uses of mjsunit methods"

This reverts commit a9e93572d42663867fc62ef456b4fb1a92234c5a.

Reason for revert:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23956
Happened already 2 builds earlier, but the output is corrupted due to
an outage.

Original change's description:
> [test] Check for illegal uses of mjsunit methods
> 
> The assertThrows and assertDoesNotThrow methods expect either a
> function to execute, or a string to eval. In several tests however we
> accidentally passed the *result* of the statement to be tested instead
> of the code.
> This CL adds check to catch such error early, and removes wrong uses.
> In most places, we do not need to use assertDoesNotThrow anyway,
> because exceptions are handled as test failures.
> 
> Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
> MjsUnitAssertionErrors correctly.
> 
> R=​mathias@chromium.org
> 
> Bug: v8:8562
> Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
> Reviewed-on: https://chromium-review.googlesource.com/c/1439238
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59277}

TBR=ahaas@chromium.org,clemensh@chromium.org,mathias@chromium.org

Change-Id: Iec06c95dd3223f27297e5c6e02835d26b5e753e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8562
Reviewed-on: https://chromium-review.googlesource.com/c/1449634
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59284}
[modify] https://crrev.com/14c06a34dbf5c339fe66bdbe691c806031780686/test/mjsunit/mjsunit.js
[modify] https://crrev.com/14c06a34dbf5c339fe66bdbe691c806031780686/test/mjsunit/regress/regress-3218530.js
[modify] https://crrev.com/14c06a34dbf5c339fe66bdbe691c806031780686/test/mjsunit/regress/regress-687.js
[modify] https://crrev.com/14c06a34dbf5c339fe66bdbe691c806031780686/test/mjsunit/regress/regress-crbug-715455.js
[modify] https://crrev.com/14c06a34dbf5c339fe66bdbe691c806031780686/test/mjsunit/wasm/errors.js

Comment 85 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7ab09b390ffabf79c9a306a9d5bfc44ed90f8f44

commit 7ab09b390ffabf79c9a306a9d5bfc44ed90f8f44
Author: Marja Hölttä <marja@chromium.org>
Date: Fri Feb 01 12:37:30 2019

[iwyu] debug.h iwyu

BUG=v8:7490,v8:8562

Change-Id: I0fb021492d723abe59728cc23bd4b138d68b702e
Reviewed-on: https://chromium-review.googlesource.com/c/1449614
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59286}
[modify] https://crrev.com/7ab09b390ffabf79c9a306a9d5bfc44ed90f8f44/src/debug/debug.h
[modify] https://crrev.com/7ab09b390ffabf79c9a306a9d5bfc44ed90f8f44/src/heap/heap.cc
[modify] https://crrev.com/7ab09b390ffabf79c9a306a9d5bfc44ed90f8f44/src/isolate.cc

Comment 86 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f0d69fc91345ea5ead9fbb6452e1a013e7deece1

commit f0d69fc91345ea5ead9fbb6452e1a013e7deece1
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Feb 01 12:56:59 2019

[test] Modernize value helpers

This CL changes the usage pattern from
FOR_XXX_VALUES(i) { Use(*i); }
to
FOR_XXX_VALUES(i) { Use(i); }
which is way more intuitive.

Note that the replacement in the uses was done via regular expression,
so it's purely mechanical. In two locations I removed unneeded braces
around the macro, because they confused clang-format.
I plan to do more cleanups (remove redundant assignments within the
FOR_XXX_VALUES body) in a follow-up CL.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I4329bfcf34e5b077d19b50f4204ceb3b4340fe61
Reviewed-on: https://chromium-review.googlesource.com/c/1449615
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59287}
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/codegen-tester.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-branch-combine.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-js-constant-cache.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-machine-operator-reducer.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-representation-change.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-run-load-store.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-run-machops.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/test-run-native-calls.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/compiler/value-helper.h
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/test-assembler-arm.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-c-wasm-entry.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm-64.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm-asmjs.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm-atomics.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm-atomics64.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm-interpreter.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm-simd.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-run-wasm.cc
[modify] https://crrev.com/f0d69fc91345ea5ead9fbb6452e1a013e7deece1/test/cctest/wasm/test-wasm-interpreter-entry.cc

Comment 87 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/30c1199f77e45b3ccfd350965dde7024826995d3

commit 30c1199f77e45b3ccfd350965dde7024826995d3
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Fri Feb 01 13:13:10 2019

[Cleanup] Delete deprecated RegisterDefaultTrapHandler API.

BUG=v8:8562

Change-Id: I66b729aeb306ecfbf92ee6e992c3abb6f854949c
Reviewed-on: https://chromium-review.googlesource.com/c/1449733
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59290}
[modify] https://crrev.com/30c1199f77e45b3ccfd350965dde7024826995d3/include/v8.h
[modify] https://crrev.com/30c1199f77e45b3ccfd350965dde7024826995d3/src/api.cc

Comment 88 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0b2fa277fb037ef75adaaf36273d74f9ca321824

commit 0b2fa277fb037ef75adaaf36273d74f9ca321824
Author: Simon Zünd <szuend@chromium.org>
Date: Fri Feb 01 13:36:47 2019

[cleanup] Remove usage of 'ReloadElements' from Array#sort

This CL is mostly a mechanical change. Loading either the receiver,
the backing store or the temp array from the sort state is pushed down
into each respective Load/Store builtin. This eliminates the need
for reloading the elements pointer after each compare function call.

R=jgruber@chromium.org, tebbi@chromium.org

Bug: v8:8562
Change-Id: I453e98635f9d891da58cf7b2a86c5c58f4a4069c
Reviewed-on: https://chromium-review.googlesource.com/c/1449613
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59291}
[modify] https://crrev.com/0b2fa277fb037ef75adaaf36273d74f9ca321824/third_party/v8/builtins/array-sort.tq

Comment 89 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7538d06576b48cf65d53f4ad1bcfdda34672e2

commit cc7538d06576b48cf65d53f4ad1bcfdda34672e2
Author: Dan Elphick <delphick@chromium.org>
Date: Fri Feb 01 13:41:47 2019

[cleanup] Fix uses of deprecated v8::Object::Set/Get

Replace uses of Get/Set with Context versions that return a
Maybe/MaybeLocal and check their return value mostly using
ToLocalChecked or Check.

Bug: v8:7283, v8:8562
Change-Id: Id8614f6e599cad628f3de8614d5a600d2148eb76
Reviewed-on: https://chromium-review.googlesource.com/c/1449676
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628313}
[modify] https://crrev.com/cc7538d06576b48cf65d53f4ad1bcfdda34672e2/content/renderer/pepper/v8_var_converter_unittest.cc
[modify] https://crrev.com/cc7538d06576b48cf65d53f4ad1bcfdda34672e2/content/renderer/v8_value_converter_impl.cc
[modify] https://crrev.com/cc7538d06576b48cf65d53f4ad1bcfdda34672e2/content/renderer/v8_value_converter_impl_unittest.cc

Comment 90 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e033d8e494795e52f9eb718d4256c680fbef30

commit 43e033d8e494795e52f9eb718d4256c680fbef30
Author: Andreas Haas <ahaas@chromium.org>
Date: Fri Feb 01 14:49:31 2019

[v8][cleanup] Remove uses of the deprecated IsNeuterable API

This is part of our cleanup effort to remove deprecated API from V8.

R=haraken@chromium.org

Bug: v8:8562 chromium:913887
Change-Id: I5fee15e15d1ff42754650779c543e5ee712b6896
Reviewed-on: https://chromium-review.googlesource.com/c/1449673
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628331}
[modify] https://crrev.com/43e033d8e494795e52f9eb718d4256c680fbef30/third_party/blink/renderer/core/typed_arrays/dom_array_buffer.cc

Comment 91 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/96315d1622d0c5e2b5e9773936373b90eaf14124

commit 96315d1622d0c5e2b5e9773936373b90eaf14124
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri Feb 01 14:51:34 2019

[api] Mark old method for tracing as soon deprecated

Users should switch to TracedGlobal and the newly added methods of
v8::EmbedderHeapTracer.

Bug: chromium:923361, v8:8562
Change-Id: I3e5ed5785a0a49c0b65c7b1d1d103e568dd3e938
Reviewed-on: https://chromium-review.googlesource.com/c/1445752
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59297}
[modify] https://crrev.com/96315d1622d0c5e2b5e9773936373b90eaf14124/include/v8.h
[modify] https://crrev.com/96315d1622d0c5e2b5e9773936373b90eaf14124/test/cctest/heap/test-embedder-tracing.cc

Comment 93 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2cbfbc2a1d81e5095ee35beaed9448ef054fd20f

commit 2cbfbc2a1d81e5095ee35beaed9448ef054fd20f
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Fri Feb 01 16:47:35 2019

[Cleanup] Delete deprecated ObjectTemplate::NewInstance() API

BUG=v8:7294,v8:8562

Change-Id: I1ed3b6d6a2fed2aee224e22ae8db5d76a52998a5
Reviewed-on: https://chromium-review.googlesource.com/c/1449731
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59301}
[modify] https://crrev.com/2cbfbc2a1d81e5095ee35beaed9448ef054fd20f/include/v8.h
[modify] https://crrev.com/2cbfbc2a1d81e5095ee35beaed9448ef054fd20f/src/api.cc

Comment 94 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/258bbaf2655d5687dcbf8ba8afa46215af61c62e

commit 258bbaf2655d5687dcbf8ba8afa46215af61c62e
Author: Dan Elphick <delphick@chromium.org>
Date: Fri Feb 01 17:37:35 2019

Fix deprecated V8 function use in GetOrCreateChromeObject

Fixes use of deprecated Object::Get/Set V8 functions in
content::GetOrCreateChromeObject by instead using the Context version
and checking the return values.

Bug: v8:7283, v8:8562
Change-Id: I16b147ec9f642a744b77516cf228fbd0a78f1bc3
Reviewed-on: https://chromium-review.googlesource.com/c/1447718
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628372}
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/chrome/renderer/sandbox_status_extension_android.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/chrome/renderer/searchbox/searchbox_extension.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/components/contextual_search/content/renderer/contextual_search_wrapper.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/content/public/renderer/chrome_object_extensions_utils.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/content/public/renderer/chrome_object_extensions_utils.h
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/content/renderer/gpu_benchmarking_extension.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/content/renderer/skia_benchmarking_extension.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/content/renderer/web_ui_extension.cc
[modify] https://crrev.com/258bbaf2655d5687dcbf8ba8afa46215af61c62e/docs/webui_explainer.md

Comment 95 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7eeb4a7f668f0b3ce2a1d8f83fa9f18844642d2

commit d7eeb4a7f668f0b3ce2a1d8f83fa9f18844642d2
Author: Dan Elphick <delphick@chromium.org>
Date: Fri Feb 01 17:55:56 2019

[cleanup] Fix uses deprecated v8 Object::Get in gin

Bug: v8:7283, v8:8562
Change-Id: I037bfb3818fdb9f92d5d9e0a8a71152ccdddade3
Reviewed-on: https://chromium-review.googlesource.com/c/1450255
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628380}
[modify] https://crrev.com/d7eeb4a7f668f0b3ce2a1d8f83fa9f18844642d2/gin/converter_unittest.cc
[modify] https://crrev.com/d7eeb4a7f668f0b3ce2a1d8f83fa9f18844642d2/gin/shell_runner_unittest.cc

Comment 97 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/83908b865b5f53d98c174e662fd7d4699e4ea655

commit 83908b865b5f53d98c174e662fd7d4699e4ea655
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Feb 04 09:18:58 2019

Reland "Extract JSObject class from objects.cc"

This is a reland of b8c821f4e276855e3c62d14d1e04263b562300d3

Fix: include src/string-stream.h for compile failure
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320

Original change's description:
> Extract JSObject class from objects.cc
>
> I extracted following class member functions to js-objects.cc
> * JSReceiver
> * JSObject
> * JSBoundFunction
> * JSFunction
> * JSGlobalObject
> * JSDate
> * JSMessageObject
>
> Declaration of all above class are in js-objects.h.
>
> I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite
> and ShouldConvertToSlowElements used in JSObject and JSArray
>
> This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux.
> And js-objects.cc takes 8.69s for compile.
>
> Bug: v8:7629
> Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f
> Reviewed-on: https://chromium-review.googlesource.com/c/1447916
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Marja Hölttä <marja@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59288}

Bug: v8:7629
Bug: v8:8562
Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5
Reviewed-on: https://chromium-review.googlesource.com/c/1449951
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59318}
[modify] https://crrev.com/83908b865b5f53d98c174e662fd7d4699e4ea655/BUILD.gn
[modify] https://crrev.com/83908b865b5f53d98c174e662fd7d4699e4ea655/src/objects.cc
[modify] https://crrev.com/83908b865b5f53d98c174e662fd7d4699e4ea655/src/objects/allocation-site-inl.h
[modify] https://crrev.com/83908b865b5f53d98c174e662fd7d4699e4ea655/src/objects/js-objects-inl.h
[add] https://crrev.com/83908b865b5f53d98c174e662fd7d4699e4ea655/src/objects/js-objects.cc

Comment 98 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc

commit bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Feb 04 09:44:18 2019

[isolate] Introduce SaveAndSwitchContext

The most common use of {SaveContext} is to allocate this object, then
immediately set the context of the isolate to another Context. Thus
introduce a second class called "SaveAndSwitchContext" which implements
exactly that.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I2fca1eadd909a7afe035316ded934624273f2e21
Reviewed-on: https://chromium-review.googlesource.com/c/1448319
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59323}
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/bootstrapper.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/d8.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/execution.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/heap/factory.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/interpreter/bytecode-generator.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/isolate.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/isolate.h
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/objects.cc
[modify] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/wasm/module-compiler.cc

Comment 99 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9023013f64c978ee8c7d1752f95d81893e3f1846

commit 9023013f64c978ee8c7d1752f95d81893e3f1846
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Feb 04 10:05:10 2019

Revert "Reland "Extract JSObject class from objects.cc""

This reverts commit 83908b865b5f53d98c174e662fd7d4699e4ea655.

Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/25074

Original change's description:
> Reland "Extract JSObject class from objects.cc"
> 
> This is a reland of b8c821f4e276855e3c62d14d1e04263b562300d3
> 
> Fix: include src/string-stream.h for compile failure
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320
> 
> Original change's description:
> > Extract JSObject class from objects.cc
> >
> > I extracted following class member functions to js-objects.cc
> > * JSReceiver
> > * JSObject
> > * JSBoundFunction
> > * JSFunction
> > * JSGlobalObject
> > * JSDate
> > * JSMessageObject
> >
> > Declaration of all above class are in js-objects.h.
> >
> > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite
> > and ShouldConvertToSlowElements used in JSObject and JSArray
> >
> > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux.
> > And js-objects.cc takes 8.69s for compile.
> >
> > Bug: v8:7629
> > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1447916
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> > Reviewed-by: Marja Hölttä <marja@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#59288}
> 
> Bug: v8:7629
> Bug: v8:8562
> Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5
> Reviewed-on: https://chromium-review.googlesource.com/c/1449951
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59318}

TBR=marja@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,tikuta@chromium.org

Change-Id: I3260edecb1434bbf9c25d89c9f9a8af02d106855
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7629, v8:8562
Reviewed-on: https://chromium-review.googlesource.com/c/1452096
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59324}
[modify] https://crrev.com/9023013f64c978ee8c7d1752f95d81893e3f1846/BUILD.gn
[modify] https://crrev.com/9023013f64c978ee8c7d1752f95d81893e3f1846/src/objects.cc
[modify] https://crrev.com/9023013f64c978ee8c7d1752f95d81893e3f1846/src/objects/allocation-site-inl.h
[modify] https://crrev.com/9023013f64c978ee8c7d1752f95d81893e3f1846/src/objects/js-objects-inl.h
[delete] https://crrev.com/bb2ee0468c74a91abdfa9710f2f2aab22c3fcadc/src/objects/js-objects.cc

Comment 100 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9

commit ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Feb 04 10:45:18 2019

Reland "[test] Check for illegal uses of mjsunit methods"

This is a reland of a9e93572d42663867fc62ef456b4fb1a92234c5a

Original change's description:
> [test] Check for illegal uses of mjsunit methods
> 
> The assertThrows and assertDoesNotThrow methods expect either a
> function to execute, or a string to eval. In several tests however we
> accidentally passed the *result* of the statement to be tested instead
> of the code.
> This CL adds check to catch such error early, and removes wrong uses.
> In most places, we do not need to use assertDoesNotThrow anyway,
> because exceptions are handled as test failures.
> 
> Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
> MjsUnitAssertionErrors correctly.
> 
> R=mathias@chromium.org
> 
> Bug: v8:8562
> Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
> Reviewed-on: https://chromium-review.googlesource.com/c/1439238
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59277}

Bug: v8:8562
Change-Id: I3b26935f7b35302d499266155273ea271bf8151d
Reviewed-on: https://chromium-review.googlesource.com/c/1449792
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59328}
[modify] https://crrev.com/ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9/test/mjsunit/mjsunit.js
[modify] https://crrev.com/ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9/test/mjsunit/regress/regress-3218530.js
[modify] https://crrev.com/ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9/test/mjsunit/regress/regress-687.js
[modify] https://crrev.com/ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9/test/mjsunit/regress/regress-crbug-715455.js
[modify] https://crrev.com/ac73e1d52bc5bf53de760e7f00c6d4db8d606ad9/test/mjsunit/wasm/errors.js

Comment 101 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d

commit bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Feb 04 10:53:56 2019

Reland "Reland "Extract JSObject class from objects.cc""

This is a reland of 83908b865b5f53d98c174e662fd7d4699e4ea655

Fix: check V8_INTL_SUPPORT macro in js-objects.cc

Original change's description:
> Reland "Extract JSObject class from objects.cc"
>
> This is a reland of b8c821f4e276855e3c62d14d1e04263b562300d3
>
> Fix: include src/string-stream.h for compile failure
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320
>
> Original change's description:
> > Extract JSObject class from objects.cc
> >
> > I extracted following class member functions to js-objects.cc
> > * JSReceiver
> > * JSObject
> > * JSBoundFunction
> > * JSFunction
> > * JSGlobalObject
> > * JSDate
> > * JSMessageObject
> >
> > Declaration of all above class are in js-objects.h.
> >
> > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite
> > and ShouldConvertToSlowElements used in JSObject and JSArray
> >
> > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux.
> > And js-objects.cc takes 8.69s for compile.
> >
> > Bug: v8:7629
> > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1447916
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> > Reviewed-by: Marja Hölttä <marja@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#59288}
>
> Bug: v8:7629
> Bug: v8:8562
> Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5
> Reviewed-on: https://chromium-review.googlesource.com/c/1449951
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59318}

Bug: v8:7629, v8:8562
Change-Id: If8870bd579d8597d08981a83492f60595e081a65
Reviewed-on: https://chromium-review.googlesource.com/c/1452097
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59329}
[modify] https://crrev.com/bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d/BUILD.gn
[modify] https://crrev.com/bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d/src/objects.cc
[modify] https://crrev.com/bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d/src/objects/allocation-site-inl.h
[modify] https://crrev.com/bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d/src/objects/js-objects-inl.h
[add] https://crrev.com/bddc6aa5562b1d67b7df6c1baeb181f6e1a0fa8d/src/objects/js-objects.cc

Comment 102 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6f5e8052847fc41df98a1e8f19211f399c6afc18

commit 6f5e8052847fc41df98a1e8f19211f399c6afc18
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Mon Feb 04 10:58:48 2019

[Cleanup] Delete deprecated FunctionTemplate::GetFunction API.

BUG=v8:7295,v8:8562

Change-Id: Ifa02ba233967ba38d4ff43576de77738001d076a
Reviewed-on: https://chromium-review.googlesource.com/c/1450115
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59330}
[modify] https://crrev.com/6f5e8052847fc41df98a1e8f19211f399c6afc18/include/v8.h
[modify] https://crrev.com/6f5e8052847fc41df98a1e8f19211f399c6afc18/src/api.cc

Comment 103 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/08c65e8838ad1ea61bfc3b3c4c054ac4598fc06c

commit 08c65e8838ad1ea61bfc3b3c4c054ac4598fc06c
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Feb 04 14:48:28 2019

[wasm] Store thread counts in int instead of size_t

The flag value and {Platform::NumberOfWorkerThreads()} are already int,
and we do not expect to spawn more than 2 billion threads any time soon.

R=titzer@chromium.org

Bug: v8:8562
Change-Id: I9c23ae1b5b9e9daab3fdb072bf98f48ea2b3f240
Reviewed-on: https://chromium-review.googlesource.com/c/1451887
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59343}
[modify] https://crrev.com/08c65e8838ad1ea61bfc3b3c4c054ac4598fc06c/src/wasm/module-compiler.cc

Comment 104 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf584d832f61dfd6f4735e2d1ebb5165441ab9b

commit 9cf584d832f61dfd6f4735e2d1ebb5165441ab9b
Author: Andreas Haas <ahaas@chromium.org>
Date: Mon Feb 04 16:45:50 2019

[v8][wasm] Replace use of deprecated V8::TryHandleSignal API

This CL also removes all uses of the SetFirstChanceHandler API of
BreakPad I marked as deprecated in https://crrev.com/c/1411776.

The tracking bug contains more information.

R=mark@chromium.org

Bug: chromium:921971, v8:8562
Change-Id: I395f5216f327b3353720ecc2091f0f65d766f880
Reviewed-on: https://chromium-review.googlesource.com/c/1411643
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628767}
[modify] https://crrev.com/9cf584d832f61dfd6f4735e2d1ebb5165441ab9b/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/9cf584d832f61dfd6f4735e2d1ebb5165441ab9b/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/9cf584d832f61dfd6f4735e2d1ebb5165441ab9b/components/crash/content/app/breakpad_linux.h
[modify] https://crrev.com/9cf584d832f61dfd6f4735e2d1ebb5165441ab9b/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/9cf584d832f61dfd6f4735e2d1ebb5165441ab9b/headless/lib/headless_content_main_delegate.cc

Comment 105 by mslekova@google.com, Feb 5

Blockedon: 8755

Comment 106 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f557ce54320c3e66b705efcd035aeb3d75ab6bcf

commit f557ce54320c3e66b705efcd035aeb3d75ab6bcf
Author: Simon Zünd <szuend@chromium.org>
Date: Tue Feb 05 10:56:58 2019

[cleanup] Replace hand-crafted accessors with generated ones

This CL introduces Torque classes with fields around TypedArrays so
CSA LoadObjectField accessors that are only used in Torque code
can be removed.

R=tebbi@chromium.org

Bug: v8:8562
Change-Id: Ie46dad5c25bd6ac03aacef8509e22f435896d127
Reviewed-on: https://chromium-review.googlesource.com/c/1451823
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59359}
[modify] https://crrev.com/f557ce54320c3e66b705efcd035aeb3d75ab6bcf/src/builtins/base.tq
[modify] https://crrev.com/f557ce54320c3e66b705efcd035aeb3d75ab6bcf/src/builtins/builtins-typed-array-gen.h
[modify] https://crrev.com/f557ce54320c3e66b705efcd035aeb3d75ab6bcf/src/builtins/data-view.tq
[modify] https://crrev.com/f557ce54320c3e66b705efcd035aeb3d75ab6bcf/src/code-stub-assembler.cc
[modify] https://crrev.com/f557ce54320c3e66b705efcd035aeb3d75ab6bcf/src/code-stub-assembler.h

Comment 107 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3efe2c5e26a21b25e3140b82b56aa599e75a4b8f

commit 3efe2c5e26a21b25e3140b82b56aa599e75a4b8f
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Feb 05 12:53:35 2019

Fix deprecated V8 function use in V8UnitTest

Fixes use of deprecated Object::Get/Set V8 functions by instead using
the Context version and checking the return values.

Bug: v8:7283, v8:8562
Change-Id: Idf2b5b596a431ad249d9bbcbf8f295537b2bab80
Reviewed-on: https://chromium-review.googlesource.com/c/1452177
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629121}
[modify] https://crrev.com/3efe2c5e26a21b25e3140b82b56aa599e75a4b8f/chrome/test/base/v8_unit_test.cc

Comment 108 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1479ac653cfd7d039f368cad7c7cee77e7bd9b3a

commit 1479ac653cfd7d039f368cad7c7cee77e7bd9b3a
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Feb 05 15:55:21 2019

Fix deprecated V8 function use in dom_distiller

Fixes use of deprecated Object::Get/Set V8 functions by instead using
the Context version and checking the return values.

Bug: v8:7283, v8:8562
Change-Id: I98481be4ddd15848df531ef6efcc85860b0362c4
Reviewed-on: https://chromium-review.googlesource.com/c/1454625
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629161}
[modify] https://crrev.com/1479ac653cfd7d039f368cad7c7cee77e7bd9b3a/components/dom_distiller/content/renderer/distiller_native_javascript.cc
[modify] https://crrev.com/1479ac653cfd7d039f368cad7c7cee77e7bd9b3a/components/dom_distiller/content/renderer/distiller_native_javascript.h

Comment 109 by bugdroid, Feb 5

Project Member

Comment 110 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a5c4a352adf46c9bff3bd1205114d31b3d6ee72

commit 2a5c4a352adf46c9bff3bd1205114d31b3d6ee72
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Feb 05 16:32:27 2019

Fix deprecated V8 function use in blink/renderer

Fix uses of deprecated Object::Get/Set V8 functions by instead using the
Context versions and checking the return values.

Bug: v8:7283, v8:8562
Change-Id: Ib404f83495ae5988050b9fd6e9722d8593b05f50
Reviewed-on: https://chromium-review.googlesource.com/c/1454490
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629166}
[modify] https://crrev.com/2a5c4a352adf46c9bff3bd1205114d31b3d6ee72/third_party/blink/renderer/controller/dev_tools_frontend_impl.cc
[modify] https://crrev.com/2a5c4a352adf46c9bff3bd1205114d31b3d6ee72/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/2a5c4a352adf46c9bff3bd1205114d31b3d6ee72/third_party/blink/renderer/modules/indexeddb/idb_test_helper.cc
[modify] https://crrev.com/2a5c4a352adf46c9bff3bd1205114d31b3d6ee72/third_party/blink/renderer/modules/payments/payment_response_test.cc

Comment 111 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9588e1957e87b9763c4080b2ff5ed3123277913

commit a9588e1957e87b9763c4080b2ff5ed3123277913
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Feb 05 21:13:37 2019

Fix deprecated V8 function use in content/public/test

Fix use of deprecated Object::Get V8 function by instead using the
Context version and checking the return value.

Bug: v8:7283, v8:8562
Change-Id: I5e778f2658ac4ce0482a8d45573e7f257f56349e
Reviewed-on: https://chromium-review.googlesource.com/c/1454548
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629310}
[modify] https://crrev.com/a9588e1957e87b9763c4080b2ff5ed3123277913/content/public/test/render_view_test.cc

Comment 112 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b276e30c487e4b03706dcb302c1336334deb3f24

commit b276e30c487e4b03706dcb302c1336334deb3f24
Author: Igor Sheludko <ishell@chromium.org>
Date: Wed Feb 06 13:45:21 2019

[snapshot][ptr-compr][cleanup] Write repeats as a prefix

... rather than as a suffix.

This avoids reading previous values which in turn will make things
simpler from the pointer compression point of view in a sense that
this is a step towards replacing UnalignedSlot with MaybeObjectSlot.

Bug: v8:8794, v8:8562
Change-Id: I9a9b4a01f73b8058074d337b7e9e9f75fa1c9de0
Reviewed-on: https://chromium-review.googlesource.com/c/1456037
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59402}
[modify] https://crrev.com/b276e30c487e4b03706dcb302c1336334deb3f24/src/snapshot/deserializer.cc
[modify] https://crrev.com/b276e30c487e4b03706dcb302c1336334deb3f24/src/snapshot/deserializer.h
[modify] https://crrev.com/b276e30c487e4b03706dcb302c1336334deb3f24/src/snapshot/serializer-common.h
[modify] https://crrev.com/b276e30c487e4b03706dcb302c1336334deb3f24/src/snapshot/serializer.cc
[modify] https://crrev.com/b276e30c487e4b03706dcb302c1336334deb3f24/src/snapshot/serializer.h

Comment 113 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/13f772476eb939f8b700323bfe4b4bff0b83b924

commit 13f772476eb939f8b700323bfe4b4bff0b83b924
Author: Igor Sheludko <ishell@chromium.org>
Date: Wed Feb 06 14:58:37 2019

[snapshot][cleanup] Simplify Deserializer::ReadObject()

Bug: v8:8794, v8:8562
Change-Id: I199b60150437c3a475a25c49c708058cd1371a1d
Reviewed-on: https://chromium-review.googlesource.com/c/1456038
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59410}
[modify] https://crrev.com/13f772476eb939f8b700323bfe4b4bff0b83b924/src/snapshot/deserializer.cc
[modify] https://crrev.com/13f772476eb939f8b700323bfe4b4bff0b83b924/src/snapshot/deserializer.h

Comment 114 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bb4fe197df505ff0f8e226a803a1a879d9ce2c59

commit bb4fe197df505ff0f8e226a803a1a879d9ce2c59
Author: Igor Sheludko <ishell@chromium.org>
Date: Wed Feb 06 15:26:05 2019

[snapshot][ptr-compr][cleanup] Don't read from slots during deserialization.

This drops Read() and Slot() methods from UnalignedSlot and simplifies
Deserializer::ReadDataCase() method.

Bug: v8:8794, v8:8562
Change-Id: I8a1f62e7b36fb91e379e38d91bcbf5728d1c5471
Reviewed-on: https://chromium-review.googlesource.com/c/1456099
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59413}
[modify] https://crrev.com/bb4fe197df505ff0f8e226a803a1a879d9ce2c59/src/snapshot/deserializer.cc

Comment 115 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f5e5d49533fb6bbbb5e8a3cdba7d105b1fb45af1

commit f5e5d49533fb6bbbb5e8a3cdba7d105b1fb45af1
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Wed Feb 06 15:32:44 2019

[ia32/x64] Remove unnecessary code flush in RelocInfo::Visit

Bug: v8:8562
Change-Id: I6f7dcaf888d0012fba2798613523c45d584753d4
Reviewed-on: https://chromium-review.googlesource.com/c/1456102
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59416}
[modify] https://crrev.com/f5e5d49533fb6bbbb5e8a3cdba7d105b1fb45af1/src/ia32/assembler-ia32-inl.h
[modify] https://crrev.com/f5e5d49533fb6bbbb5e8a3cdba7d105b1fb45af1/src/x64/assembler-x64-inl.h

Comment 116 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e3637a7c0cdcf9dff8e6fba687963f54340f3de9

commit e3637a7c0cdcf9dff8e6fba687963f54340f3de9
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Wed Feb 06 17:35:58 2019

[assembler] Move RelocInfo::Visit to reloc-info.h

This unifies the RelocInfo::Visit method across architectures.

Bug: v8:8562
Change-Id: I36fdfb2f456aebb4d69977bb84727c9b49b22f69
Reviewed-on: https://chromium-review.googlesource.com/c/1456106
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59423}
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/arm/assembler-arm-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/ia32/assembler-ia32-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/mips/assembler-mips-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/mips64/assembler-mips64-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/ppc/assembler-ppc-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/reloc-info.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/s390/assembler-s390-inl.h
[modify] https://crrev.com/e3637a7c0cdcf9dff8e6fba687963f54340f3de9/src/x64/assembler-x64-inl.h

Comment 117 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0c20a4c6aa61017226e367f300318b98e3a31529

commit 0c20a4c6aa61017226e367f300318b98e3a31529
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Thu Feb 07 12:37:06 2019

[cleanup] Move Code class out of objects.cc

Drive-by: Refactor FlushInstructionCache to its own header. This removes
dependencies of objects.cc and code.cc

Bug: v8:8562
Change-Id: If23f3b9d4f2068e08c61c0f4b070ecfe1b9a6cc0
Reviewed-on: https://chromium-review.googlesource.com/c/1456081
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59435}
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/BUILD.gn
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/arm/assembler-arm-inl.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/assembler.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/assembler.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/cpu-features.h
[add] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/flush-instruction-cache.cc
[add] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/flush-instruction-cache.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/ia32/assembler-ia32-inl.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/mips/assembler-mips.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/mips64/assembler-mips64.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/objects.cc
[add] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/objects/code.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/ppc/assembler-ppc-inl.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/reloc-info.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/s390/assembler-s390-inl.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/snapshot/startup-deserializer.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/v8.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/visitors.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/wasm/jump-table-assembler.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/wasm/wasm-serialization.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/src/x64/assembler-x64-inl.h
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/test/cctest/test-icache.cc
[modify] https://crrev.com/0c20a4c6aa61017226e367f300318b98e3a31529/test/common/assembler-tester.h

Comment 118 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a392280b4171a8b8849d2ff4e09cccd37f9559

commit 15a392280b4171a8b8849d2ff4e09cccd37f9559
Author: Dan Elphick <delphick@chromium.org>
Date: Fri Feb 08 10:26:26 2019

Fix deprecated BooleanValue call in chrome os code

Bug: v8:7279, v8:8562
Change-Id: I62bba21320a708bbb6e901077fba8c445f5ace44
Reviewed-on: https://chromium-review.googlesource.com/c/1458211
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630266}
[modify] https://crrev.com/15a392280b4171a8b8849d2ff4e09cccd37f9559/chrome/renderer/extensions/file_browser_handler_custom_bindings.cc

Comment 119 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c6d21691838833ed5b8ca4ac9f370850ad13999c

commit c6d21691838833ed5b8ca4ac9f370850ad13999c
Author: Dan Elphick <delphick@chromium.org>
Date: Fri Feb 08 11:33:07 2019

[api] Advance deprecation for Value::BooleanValue

Mark Context version of BooleanValue as V8_DEPRECATED.

Bug: v8:7279, v8:8562
Change-Id: I152f5080d92a940dadea9e8f2ed3f25338e6f099
Reviewed-on: https://chromium-review.googlesource.com/c/1458245
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59452}
[modify] https://crrev.com/c6d21691838833ed5b8ca4ac9f370850ad13999c/include/v8.h

Comment 120 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c9a9d825c8e2538951d3a06597835038db22271f

commit c9a9d825c8e2538951d3a06597835038db22271f
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri Feb 08 13:27:49 2019

[snapshot][cleanup] Remove skipping bytecodes

... as they are no longer needed.

Bug: v8:8794, v8:8562
Change-Id: Ib5d87fce9834839410b0dffce95b4a8ae4f946cc
Reviewed-on: https://chromium-review.googlesource.com/c/1460456
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59457}
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/code-serializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/code-serializer.h
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/deserializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/partial-serializer.h
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/read-only-serializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/read-only-serializer.h
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/roots-serializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/serializer-common.h
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/serializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/serializer.h
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/c9a9d825c8e2538951d3a06597835038db22271f/src/snapshot/startup-serializer.h

Comment 121 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9afefcbc052856e3fd81e0ffdab7512540818557

commit 9afefcbc052856e3fd81e0ffdab7512540818557
Author: Simon Zünd <szuend@chromium.org>
Date: Fri Feb 08 14:14:48 2019

[cleanup] Rename field offsets in StackFrameInfo

This CL renames field offsets from *Index to *Offset in the
StackFrameInfo class for consistency.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I9ccec3e6f924a4040d26dc677fdd1ec620cf0463
Reviewed-on: https://chromium-review.googlesource.com/c/1460937
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59460}
[modify] https://crrev.com/9afefcbc052856e3fd81e0ffdab7512540818557/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/9afefcbc052856e3fd81e0ffdab7512540818557/src/objects/stack-frame-info.h

Comment 122 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/60f8b7a894f9a403ad2eb310449e366b354c8c19

commit 60f8b7a894f9a403ad2eb310449e366b354c8c19
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri Feb 08 14:21:00 2019

[snapshot][cleanup] Remove WhereToPoint flag from bytecodes

... as it's no longer needed.

Bug: v8:8794, v8:8562
Change-Id: Ifbc4f5f5d34f24ff4ba8f32309e8a032268c12c0
Reviewed-on: https://chromium-review.googlesource.com/c/1460457
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59461}
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/code-serializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/code-serializer.h
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/deserializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/deserializer.h
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/partial-serializer.h
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/read-only-serializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/read-only-serializer.h
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/roots-serializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/serializer-common.h
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/serializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/serializer.h
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/60f8b7a894f9a403ad2eb310449e366b354c8c19/src/snapshot/startup-serializer.h

Comment 123 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/37e632b11969abb2dac0e61e58847965834350b1

commit 37e632b11969abb2dac0e61e58847965834350b1
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri Feb 08 14:40:49 2019

[snapshot][cleanup] Remove HowToCode flag from bytecodes

... as it's no longer needed.

Bug: v8:8794, v8:8562
Change-Id: Ia5149bab33af219e5cdc6909af4688e53f1409fa
Reviewed-on: https://chromium-review.googlesource.com/c/1460458
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59463}
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/code-serializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/code-serializer.h
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/deserializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/deserializer.h
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/partial-serializer.h
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/read-only-serializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/read-only-serializer.h
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/roots-serializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/serializer-common.h
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/serializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/serializer.h
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/37e632b11969abb2dac0e61e58847965834350b1/src/snapshot/startup-serializer.h

Comment 124 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/51f11f0f657cdf27222b6d521b45d63d4456b3d3

commit 51f11f0f657cdf27222b6d521b45d63d4456b3d3
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri Feb 08 18:18:28 2019

[snapshot][cleanup] Reassign bytecode values

... and update the list of unused bytecodes.

This CL also drops kInternalReferenceEncoded as all necessary details
are already encoded in RelocInfo.

Bug: v8:8794, v8:8562
Change-Id: Ia8aec1f4bcf9802fe15322bd6bb273218d8959fa
Reviewed-on: https://chromium-review.googlesource.com/c/1460459
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59471}
[modify] https://crrev.com/51f11f0f657cdf27222b6d521b45d63d4456b3d3/src/snapshot/deserializer.cc
[modify] https://crrev.com/51f11f0f657cdf27222b6d521b45d63d4456b3d3/src/snapshot/deserializer.h
[modify] https://crrev.com/51f11f0f657cdf27222b6d521b45d63d4456b3d3/src/snapshot/serializer-common.h
[modify] https://crrev.com/51f11f0f657cdf27222b6d521b45d63d4456b3d3/src/snapshot/serializer.cc

Comment 125 by bugdroid, Feb 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/455200e0098474e235716e40b6c842212e50a4b2

commit 455200e0098474e235716e40b6c842212e50a4b2
Author: Jakob Kummerow <jkummerow@chromium.org>
Date: Sat Feb 09 00:34:12 2019

[cleanup] Move some stuff out of objects-inl.h

HeapObject::SizeFromMap() was too large to get inlined anyway.
HeapObject::IsFoo() predicates should be implemented in foo-inl.h,
because that's what they depend on.
This patch also fixes up includes: dropping unnecessary ones from
object-inl.h, and adding them in other places that previously
relied on getting them transitively.

Bug: v8:8562
Change-Id: Id062bed67257d9dc1899f2d71f44cf69a1368c83
Reviewed-on: https://chromium-review.googlesource.com/c/1450778
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59478}
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/accessors.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/api-arguments-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/builtins/builtins-error.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/feedback-vector.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/field-index-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/field-index.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/concurrent-marking.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/factory-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/factory.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/heap.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/incremental-marking.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/mark-compact.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/scavenger.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/keys.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/layout-descriptor-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects-debug.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/code-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/descriptor-array-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/dictionary-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/hash-table-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/heap-object.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/js-collection-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/js-objects-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/js-objects.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/literal-objects-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/map-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/map.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/map.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/oddball-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/src/roots-inl.h
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/test/cctest/test-transitions.cc
[modify] https://crrev.com/455200e0098474e235716e40b6c842212e50a4b2/tools/gen-postmortem-metadata.py

Comment 126 by bugdroid, Feb 12 (4 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1eec85bb66f377debb05cc96a592e6b098a46e32

commit 1eec85bb66f377debb05cc96a592e6b098a46e32
Author: Maciej Goszczycki <goszczycki@google.com>
Date: Tue Feb 12 16:51:57 2019

[cleanup] Remove LoadAndUntagToWord32Root

It's unused and hinders separating read-only roots into a shared table.

Bug: v8:8562
Change-Id: I4a2889d9be5df877b2f9d11ce5146a091d864cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1466963
Reviewed-by: Dan Elphick <delphick@chromium.org>
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Cr-Commit-Position: refs/heads/master@{#59539}
[modify] https://crrev.com/1eec85bb66f377debb05cc96a592e6b098a46e32/src/builtins/base.tq
[modify] https://crrev.com/1eec85bb66f377debb05cc96a592e6b098a46e32/src/code-stub-assembler.cc
[modify] https://crrev.com/1eec85bb66f377debb05cc96a592e6b098a46e32/src/code-stub-assembler.h

Comment 127 by bugdroid, Feb 13 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0ce2f3d43b3b7ebeb0acd2fdf16b35fb360dda4c

commit 0ce2f3d43b3b7ebeb0acd2fdf16b35fb360dda4c
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Feb 13 14:10:18 2019

[wasm][test] Remove macros

This removes most macros from the function body decoder unittest. It
makes the {Validate} method (and the new {ExpectValidates} and
{ExpectFailure}) templates, to receive the code in different formats.

Drive-by: Rename "verify" to "validate".

R=titzer@chromium.org

Bug: v8:8562
Change-Id: I89e6125b52cf40a9539317bf16189208cd0592ab
Reviewed-on: https://chromium-review.googlesource.com/c/1458956
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59557}
[modify] https://crrev.com/0ce2f3d43b3b7ebeb0acd2fdf16b35fb360dda4c/test/unittests/wasm/function-body-decoder-unittest.cc

Comment 128 by bugdroid, Feb 13 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8bfefb2f032b597c5588349e7df4da07210281d8

commit 8bfefb2f032b597c5588349e7df4da07210281d8
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Feb 13 14:55:38 2019

[wasm][test] Clean up function body decoder unittest

This cleans up a few things after https://crrev.com/c/1458956.

R=titzer@chromium.org

Bug: v8:8562
Change-Id: I7904c195ee385f0aa8815447f440d8119601af3e
Reviewed-on: https://chromium-review.googlesource.com/c/1460467
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59567}
[modify] https://crrev.com/8bfefb2f032b597c5588349e7df4da07210281d8/test/unittests/wasm/function-body-decoder-unittest.cc

Comment 129 by bugdroid, Feb 13 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/685a20cac0860c83ef6d16db43c2a82619b9c9a6

commit 685a20cac0860c83ef6d16db43c2a82619b9c9a6
Author: Maciej Goszczycki <goszczycki@google.com>
Date: Wed Feb 13 17:41:38 2019

[cleanup] Move comment closer to code it describes

Bug: v8:8562
Change-Id: I7f65b4cd92bb08434afe3a18512223adaf47feec
Reviewed-on: https://chromium-review.googlesource.com/c/1470112
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59577}
[modify] https://crrev.com/685a20cac0860c83ef6d16db43c2a82619b9c9a6/BUILD.gn

Comment 130 by bugdroid, Feb 14 (2 days ago)

Project Member

Comment 131 by bugdroid, Feb 14 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4f69c46aa8798d88fcae638ba292d4c0f5d5017d

commit 4f69c46aa8798d88fcae638ba292d4c0f5d5017d
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Feb 14 16:52:03 2019

[wasm][test] Turn EXPECT_LENGTH macros into method

This removes another two macros and introduces a templatized function
instead.
Note that there is only one instantiation per input length, not per
input.

R=titzer@chromium.org

Bug: v8:8562
Change-Id: I47ad274e68d26b962cbd582e90995d30b1d09d39
Reviewed-on: https://chromium-review.googlesource.com/c/1460938
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59605}
[modify] https://crrev.com/4f69c46aa8798d88fcae638ba292d4c0f5d5017d/test/unittests/wasm/function-body-decoder-unittest.cc

Comment 132 by bugdroid, Feb 15 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc

commit 6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc
Author: Jakob Kummerow <jkummerow@chromium.org>
Date: Fri Feb 15 06:22:53 2019

[cleanup] #include heap-inl.h less often

This takes heap-inl.h out of the "Giant Include Cluster".
Naturally, that means adding a bunch of explicit includes
in a bunch of places that relied on transitively including
them before.
As of this patch, no header file outside src/heap/ includes
heap-inl.h.

Bug: v8:8562,v8:8499
Change-Id: I65fa763f90e66afc30d105b9277792721f05a6d4
Reviewed-on: https://chromium-review.googlesource.com/c/1459659
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59617}
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/BUILD.gn
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/api.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/arguments-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/assembler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/ast/ast.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/bootstrapper.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-arraybuffer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-boolean.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-collections-gen.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-microtask-queue-gen.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-object.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-promise.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-string-gen.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-string.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-symbol.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/builtins-trace.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/code-factory.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/code-reference.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/code-stub-assembler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/compiler-dispatcher/compiler-dispatcher.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/compiler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/compiler/compilation-dependencies.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/compiler/js-heap-broker.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/contexts-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/debug/debug.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/deoptimizer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/elements.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/external-reference.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/external-reference.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/feedback-vector-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/frames.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/global-handles.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/handles.cc
[add] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/hash-seed-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/array-buffer-tracker-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/code-stats.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/factory-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/factory.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/heap-controller.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/heap-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/heap-write-barrier-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/heap.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/heap.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/mark-compact-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/spaces-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/spaces.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/heap/spaces.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/ic/stub-cache.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/isolate-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/isolate.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/isolate.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/json-parser.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/log.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects-debug.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects-printer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/allocation-site-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/api-callbacks-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/bigint.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/cell-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/code-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/code.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/debug-objects-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/dictionary-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/embedder-data-array-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/embedder-data-array.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/embedder-data-slot-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/feedback-cell-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/fixed-array-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/foreign-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/free-space-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/hash-table-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/heap-number-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/heap-object-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/heap-object.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/js-array-buffer-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/js-collection-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/js-objects-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/js-objects.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/map-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/maybe-object-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/microtask-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/name-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/object-macros.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/oddball-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/ordered-hash-table-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/ordered-hash-table.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/property-array-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/property-cell-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/prototype-info-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/string-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/string.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/struct-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/objects/templates-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/parsing/parse-info.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/parsing/parser.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/parsing/parsing.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/parsing/preparse-data.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/parsing/preparser.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/parsing/rewriter.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/profiler/allocation-tracker.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/profiler/sampling-heap-profiler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/profiler/tick-sample.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/property-descriptor.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/regexp/jsregexp.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/regexp/regexp-parser.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/roots-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/roots.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/roots.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-array.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-collections.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-debug.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-forin.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-function.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-numbers.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-object.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-operators.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-proxy.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-regexp.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-scopes.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-strings.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-symbol.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/runtime/runtime-test.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/s390/macro-assembler-s390.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/code-serializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/deserializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/partial-deserializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/read-only-serializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/roots-serializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/serializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/string-builder.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/wasm/module-compiler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/wasm/module-instantiate.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/wasm/wasm-objects-inl.h
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/heap/test-alloc.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/heap/test-compaction.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/heap/test-embedder-tracing.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/heap/test-external-string-tracker.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/heap/test-weak-references.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/interpreter/interpreter-tester.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/interpreter/test-interpreter-intrinsics.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/interpreter/test-interpreter.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-api.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-compiler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-global-handles.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-mementos.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-parsing.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-regexp.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-roots.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-serialize.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-strings.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-unboxed-doubles.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-unwinder.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-weakmaps.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/test-weaksets.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/cctest/wasm/wasm-run-utils.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/mkgrokdump/mkgrokdump.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/background-compile-task-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/heap/heap-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/interpreter/bytecode-array-builder-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/interpreter/bytecode-array-iterator-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/interpreter/bytecode-array-random-iterator-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/interpreter/constant-array-builder-unittest.cc
[modify] https://crrev.com/6cac1382f43eb6be77eff43d581b9fd4b0e2b0bc/test/unittests/parser/ast-value-unittest.cc
Showing comments 33 - 132 of 132 Older

Sign in to add a comment