New issue
Advanced search Search tips

Issue 8556 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
HW: ----
NextAction: ----
OS: ----
Priority: ----
Type: Task



Sign in to add a comment

Define a way to test full list of locales / tz in the time importing new version of icu data

Project Member Reported by ftang@chromium.org, Dec 6

Issue description

Previously, we have some tests cause flakiness due to long execution time while we test a long list (700+) of locales and different combination and long list of tz. 
Due to the flakiness, we remove them from the normal test. But we still need a way to test them and only run it while we land new version of icu and/or icu data.

Some tests caused the problem
test/intl/regress-8413.js
test/intl/regress-8414.js

this bug track the development of such test framework.


 
Are they flaky or slow in *san bots?  I thought it's the latter (so slow that they time out).  Can't you just disable those tests in *san bots, then?  


It's only the *san bots so far where they've been slow enough to cause trouble. If they're indeed only slow on those platforms just disabling them across the board could be the right approach.

But I'm guessing that there are other places (e.g., arm simulator bots) where they might be slow as well. And given that they're not actually testing V8 behavior, but rather the existence of certain ICU data, I encouraged ftang to look for other approaches.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6355ca455969c1330799fd256a085b46230864d4

commit 6355ca455969c1330799fd256a085b46230864d4
Author: Frank Tang <ftang@chromium.org>
Date: Fri Dec 07 07:05:49 2018

[Intl] Remove flaky regress-8414.js

The removed tests should be later covered by v8:8556

Bug:  v8:5751 , v8:8556
Change-Id: Iea5450564ab4f85256f1aa76fb09d7e6704f9bd3
Reviewed-on: https://chromium-review.googlesource.com/c/1355634
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58082}
[delete] https://crrev.com/a6d2fe4009eaeb52860bcfa1610b72896af832a9/test/intl/regress-8414.js

Cc: ftang@chromium.org
 Issue 8448  has been merged into this issue.

Sign in to add a comment