New issue
Advanced search Search tips
Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
HW: ----
NextAction: ----
OS: ----
Priority: 3
Type: Task



Sign in to add a comment
link

Issue 8468: [Intl] Replace code uloc_ code w/ icu::Locale::(to|for)LanguageTag

Reported by ftang@chromium.org, Nov 16 Project Member

Issue description

ICU63 add icu::Locale::(to|for)LanguageTag
We should replace the current calling to the C version of uloc_ w/ them if it can simplified the code.
 

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7b744e3ae85f4725e343b97fefc9536444232b43

commit 7b744e3ae85f4725e343b97fefc9536444232b43
Author: Frank Tang <ftang@chromium.org>
Date: Sat Dec 15 01:11:49 2018

[Intl] Replace uloc_(to|for)Language w/ Locale API

Bug: v8:8468
Change-Id: Id2f8d165e5f29f429821b44def2512fe760c0a51
Reviewed-on: https://chromium-review.googlesource.com/c/1377989
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58260}
[modify] https://crrev.com/7b744e3ae85f4725e343b97fefc9536444232b43/src/objects/intl-objects.cc
[modify] https://crrev.com/7b744e3ae85f4725e343b97fefc9536444232b43/src/objects/js-date-time-format.cc
[modify] https://crrev.com/7b744e3ae85f4725e343b97fefc9536444232b43/src/objects/js-locale.cc

Comment 3 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/04041423e22cf0425575c23fe6b22459dd396c17

commit 04041423e22cf0425575c23fe6b22459dd396c17
Author: Frank Tang <ftang@chromium.org>
Date: Sat Dec 15 02:19:36 2018

Revert "[Intl] Replace uloc_(to|for)Language w/ Locale API"

This reverts commit 7b744e3ae85f4725e343b97fefc9536444232b43.

Reason for revert: Break V8 Linux64 ASAN

Original change's description:
> [Intl] Replace uloc_(to|for)Language w/ Locale API
> 
> Bug: v8:8468
> Change-Id: Id2f8d165e5f29f429821b44def2512fe760c0a51
> Reviewed-on: https://chromium-review.googlesource.com/c/1377989
> Reviewed-by: Jungshik Shin <jshin@chromium.org>
> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> Commit-Queue: Frank Tang <ftang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58260}

TBR=jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org

Change-Id: I5d6069245f468f7ca5d99f2973bd53524e2d4782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8468
Reviewed-on: https://chromium-review.googlesource.com/c/1378657
Reviewed-by: Frank Tang <ftang@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58261}
[modify] https://crrev.com/04041423e22cf0425575c23fe6b22459dd396c17/src/objects/intl-objects.cc
[modify] https://crrev.com/04041423e22cf0425575c23fe6b22459dd396c17/src/objects/js-date-time-format.cc
[modify] https://crrev.com/04041423e22cf0425575c23fe6b22459dd396c17/src/objects/js-locale.cc

Comment 4 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f97022cff7eab03d25510a707f128044861a2491

commit f97022cff7eab03d25510a707f128044861a2491
Author: Frank Tang <ftang@chromium.org>
Date: Mon Dec 17 22:01:14 2018

Reland "[Intl] Replace uloc_(to|for)Language w/ Locale API"

This is a reland of 7b744e3ae85f4725e343b97fefc9536444232b43

I cannot reproduce the problem in this reland CL. I think
the origin breakage is just due to test flakiness.
Try to reland it without changes

TBR=jshin@chromium.org

Original change's description:
> [Intl] Replace uloc_(to|for)Language w/ Locale API
>
> Bug: v8:8468
> Change-Id: Id2f8d165e5f29f429821b44def2512fe760c0a51
> Reviewed-on: https://chromium-review.googlesource.com/c/1377989
> Reviewed-by: Jungshik Shin <jshin@chromium.org>
> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> Commit-Queue: Frank Tang <ftang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58260}

Bug: v8:8468
Change-Id: I5f34d061d630d07f5c9da07f9adb1efa040d66d5
Reviewed-on: https://chromium-review.googlesource.com/c/1378658
Reviewed-by: Frank Tang <ftang@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58297}
[modify] https://crrev.com/f97022cff7eab03d25510a707f128044861a2491/src/objects/intl-objects.cc
[modify] https://crrev.com/f97022cff7eab03d25510a707f128044861a2491/src/objects/js-date-time-format.cc
[modify] https://crrev.com/f97022cff7eab03d25510a707f128044861a2491/src/objects/js-locale.cc

Comment 5 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a249aa9ce39a29799b2e90244b911e8e81fd8354

commit a249aa9ce39a29799b2e90244b911e8e81fd8354
Author: Frank Tang <ftang@chromium.org>
Date: Thu Dec 20 05:41:47 2018

[Intl] Change code to be idiomatic.

Follow up comments in
https://chromium-review.googlesource.com/c/v8/v8/+/1378658

Bug: v8:8468
Change-Id: I1bfcc305959e8230b08db034d99a2e6ac867775e
Reviewed-on: https://chromium-review.googlesource.com/c/1385166
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58384}
[modify] https://crrev.com/a249aa9ce39a29799b2e90244b911e8e81fd8354/src/objects/intl-objects.cc
[modify] https://crrev.com/a249aa9ce39a29799b2e90244b911e8e81fd8354/src/objects/js-date-time-format.cc

Comment 6 by ftang@chromium.org, Jan 27

Labels: -Type-Bug Type-Task
Summary: [Intl] Replace code uloc_ code w/ icu::Locale::(to|for)LanguageTag (was: Replace code uloc_ code w/ icu::Locale::(to|for)LanguageTag)

Sign in to add a comment