New issue
Advanced search Search tips

Issue 7782 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
HW: All
NextAction: ----
OS: All
Priority: 3
Type: FeatureRequest



Sign in to add a comment

Well-formed JSON.stringify

Project Member Reported by mathias@chromium.org, May 23 2018

Issue description

Components: Language
Labels: Priority-3
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/38feca55da245eaa8b9cb537428a551e359a0190

commit 38feca55da245eaa8b9cb537428a551e359a0190
Author: Mathias Bynens <mathias@chromium.org>
Date: Wed Oct 03 09:53:19 2018

[esnext] Add cctests for well-formed JSON.stringify

The proposal is currently at Stage 3 of the TC39 process.

Repository: https://github.com/tc39/proposal-well-formed-stringify

Bug:  v8:7782 
Change-Id: Ice2125ffd3dbc5381c81193eb64d460e0d5485cd
Reviewed-on: https://chromium-review.googlesource.com/c/1255728
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56349}
[modify] https://crrev.com/38feca55da245eaa8b9cb537428a551e359a0190/test/cctest/test-strings.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/77f917bafb527af9336ca89973abbac13ea48542

commit 77f917bafb527af9336ca89973abbac13ea48542
Author: Mathias Bynens <mathias@chromium.org>
Date: Wed Oct 03 19:55:30 2018

Stage well-formed JSON.stringify

The proposal is currently at Stage 3 of the TC39 process.

Repository: https://github.com/tc39/proposal-well-formed-stringify

Bug:  v8:7782 
Change-Id: Id46054ec6873ca2d1bc8113b8c82b58b1b8427d2
Reviewed-on: https://chromium-review.googlesource.com/c/1257921
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56357}
[modify] https://crrev.com/77f917bafb527af9336ca89973abbac13ea48542/src/flag-definitions.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f69bc879a434c147251b81e79f4bf9cf0b37fe77

commit f69bc879a434c147251b81e79f4bf9cf0b37fe77
Author: Mathias Bynens <mathias@chromium.org>
Date: Tue Oct 16 06:00:03 2018

Revert "Ship well-formed JSON.stringify ๐ŸŽ‰"

This reverts commit 0d91db0b32fa865e95bedb4facbf9c860f936409.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Ship well-formed JSON.stringify ๐ŸŽ‰
> 
> Proposal repository:
> https://github.com/tc39/proposal-global
> 
> Intent to ship:
> https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ
> 
> Bug:  v8:7782 
> Change-Id: Iaf790f134917796deac0e84cc931828934a6e589
> Reviewed-on: https://chromium-review.googlesource.com/c/1260122
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56650}

TBR=gsathya@chromium.org,mathias@chromium.org

Change-Id: Ie214a72a01fa81f754fd411808eb0bb748f89dbb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  v8:7782 
Reviewed-on: https://chromium-review.googlesource.com/c/1282563
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56663}
[modify] https://crrev.com/f69bc879a434c147251b81e79f4bf9cf0b37fe77/src/flag-definitions.h
[modify] https://crrev.com/f69bc879a434c147251b81e79f4bf9cf0b37fe77/test/mjsunit/json.js
[modify] https://crrev.com/f69bc879a434c147251b81e79f4bf9cf0b37fe77/test/webkit/resources/JSON-stringify.js
[modify] https://crrev.com/f69bc879a434c147251b81e79f4bf9cf0b37fe77/test/webkit/resources/json2-es5-compat.js
[modify] https://crrev.com/f69bc879a434c147251b81e79f4bf9cf0b37fe77/test/webkit/run-json-stringify-expected.txt

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55c6bb0fa45373ff6c20dfd572855abf221c862d

commit 55c6bb0fa45373ff6c20dfd572855abf221c862d
Author: Mathias Bynens <mathias@chromium.org>
Date: Tue Oct 16 08:52:39 2018

[tests] Prepare CSS.escape() tests for upcoming JSON.stringify() change

The well-formed JSON.stringify() proposal changes JSON.stringify() to
produce JavaScript/JSON-compatible escape sequences for any lone
surrogates in its input.

Because the test runner's `shouldBeEqualToString` uses `JSON.stringify`
before comparing strings, these tests would otherwise break when
shipping the `JSON.stringify()` change.

Bug:  v8:7782 
Change-Id: If6ace9c023be8997ed10c8f1dbc2dcaed18c4687
Reviewed-on: https://chromium-review.googlesource.com/c/1281965
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Philip Jรคgenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599922}
[modify] https://crrev.com/55c6bb0fa45373ff6c20dfd572855abf221c862d/third_party/WebKit/LayoutTests/css3/escape-dom-api-expected.txt
[modify] https://crrev.com/55c6bb0fa45373ff6c20dfd572855abf221c862d/third_party/WebKit/LayoutTests/css3/escape-dom-api.html

Status: Fixed (was: Started)

Sign in to add a comment