New issue
Advanced search Search tips
Starred by 8 users

Issue metadata

Status: Assigned
Owner:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: Bug


Sign in to add a comment
link

Issue 7777: Tracking bug: JIT-less V8

Reported by jgruber@chromium.org, May 22 2018 Project Member

Issue description

Design doc: goo.gl/kRnhVe
 

Comment 1 by jgruber@chromium.org, Sep 6

Blocking: -6666
Summary: Tracking bug: JIT-less V8 (was: Fix code printing wrt to embedded builtins)

Comment 2 by jgruber@chromium.org, Sep 6

Description: Show this description

Comment 4 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0112748741b710d339e78f0ef3c96b83e35b3ab1

commit 0112748741b710d339e78f0ef3c96b83e35b3ab1
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Tue Oct 16 10:48:07 2018

[ia32,root] Make JSEntryStub (almost) isolate independent

Bug:  v8:6666 , v8:7777
Change-Id: I842e61731a6df22f9bcdaa92cb6841af5c8ef796
Reviewed-on: https://chromium-review.googlesource.com/c/1280228
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56684}
[modify] https://crrev.com/0112748741b710d339e78f0ef3c96b83e35b3ab1/src/ia32/code-stubs-ia32.cc
[modify] https://crrev.com/0112748741b710d339e78f0ef3c96b83e35b3ab1/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/0112748741b710d339e78f0ef3c96b83e35b3ab1/src/ia32/macro-assembler-ia32.h

Comment 5 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f56195fc2b95d29add5380767dfd0ff4b374ef54

commit f56195fc2b95d29add5380767dfd0ff4b374ef54
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Tue Oct 16 11:20:41 2018

[ia32] Extend availability of root array in JSEntryStub

Change-Id: Ibc8a086c5761c732b454fbb6cc1e06abb9f5e90f
Bug: v8:7777
Reviewed-on: https://chromium-review.googlesource.com/c/1283032
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56690}
[modify] https://crrev.com/f56195fc2b95d29add5380767dfd0ff4b374ef54/src/ia32/code-stubs-ia32.cc

Comment 6 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/850c446aa550f362501add918798cfe3d996987d

commit 850c446aa550f362501add918798cfe3d996987d
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Nov 15 12:14:37 2018

[nojit] Add build- and runtime flags

This adds flags for the upcoming JIT-less V8.

Build-time: v8_enable_jitless_mode in gn.args
Runtime: --jitless command-line flag

The build-time flag is expected to be removed as the implementation
matures.

Bug: v8:7777
Change-Id: Ieea404a14c7859a66e18175d1740d73182db9b1b
Reviewed-on: https://chromium-review.googlesource.com/c/1335559
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57533}
[modify] https://crrev.com/850c446aa550f362501add918798cfe3d996987d/BUILD.gn
[modify] https://crrev.com/850c446aa550f362501add918798cfe3d996987d/src/flag-definitions.h

Comment 7 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6e5671e1cdd33f8f51b2afeab499881a83e52179

commit 6e5671e1cdd33f8f51b2afeab499881a83e52179
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Nov 16 09:36:05 2018

[nojit] Embed InterpreterEntryTrampoline

This marks the InterpreterEntryTrampoline as isolate-independent. With
this change, all builtins are now embedded.

Slight changes were needed to how we deopt into the trampoline. We now
store the entry address within the Interpreter class instead of
embedding the builtin code target.

Bug: v8:7777
Change-Id: If781bf6f06cb2efbab1369ece757f04c343a1b38
Reviewed-on: https://chromium-review.googlesource.com/c/1337734
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57563}
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/builtins.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/builtins.h
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/external-reference.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/external-reference.h
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/interpreter/interpreter.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/interpreter/interpreter.h
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/src/isolate.cc
[modify] https://crrev.com/6e5671e1cdd33f8f51b2afeab499881a83e52179/test/cctest/interpreter/test-interpreter.cc

Comment 8 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/33da71971f0cfb83d21e30a915a5817429d90e51

commit 33da71971f0cfb83d21e30a915a5817429d90e51
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Nov 19 08:32:55 2018

[nojit] Move several IC stubs to builtins

KeyedLoadSloppyArguments -> KeyedLoadIC_SloppyArguments
KeyedStoreSloppyArguments -> KeyedStoreIC_SloppyArguments
LoadIndexedIntercepter -> LoadIndexedInterceptorIC
StoreInArrayLiteralSlowStub -> StoreInArrayLiteralIC_Slow
StoreInterceptor -> StoreInterceptorIC
StoreSlowElementStub -> KeyedStoreIC_Slow

A few Store stubs were parameterized for the sole purpose of
determining the KeyedAccessStoreMode later on. These are now
implemented as a dedicated builtin for each store mode.

Bug: v8:7777
Change-Id: I743474b0e6c5d6ec2513bb9f8f3a93c5c0535927
Reviewed-on: https://chromium-review.googlesource.com/c/1339859
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57592}
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/builtins/builtins-definitions.h
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/builtins/builtins-handler-gen.cc
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/code-factory.cc
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/code-factory.h
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/code-stubs.cc
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/code-stubs.h
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/feedback-vector.cc
[modify] https://crrev.com/33da71971f0cfb83d21e30a915a5817429d90e51/src/ic/ic.cc

Comment 9 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218

commit ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Nov 19 09:25:12 2018

[nojit] Remove IsJSArray parameter from two stubs

In preparation for converting these stubs to builtins. This turns the
compile-time IsJSArray parameter into a runtime check.

Bug: v8:7777
Change-Id: Ief44e7cd77e772809e50618e55f51268e9ac8ad9
Reviewed-on: https://chromium-review.googlesource.com/c/1339868
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57594}
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/code-stub-assembler.cc
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/code-stub-assembler.h
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/code-stubs.cc
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/code-stubs.h
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/ic/handler-configuration.cc
[modify] https://crrev.com/ca34f4d0cc24e264dfc4e76e43c1a6b75ff2f218/src/ic/ic.cc

Comment 10 by bugdroid1@chromium.org, Nov 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/918b13781c3c34e1db461df269a78cf03a23e009

commit 918b13781c3c34e1db461df269a78cf03a23e009
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Nov 22 08:42:05 2018

[nojit] Remove elements kind parameter from two stubs

In preparation for converting these stubs to builtins. This turns
compile-time elements kind parameters into a runtime check, essentially
emitting all contained logic for each elements kinds and dispatching
at runtime.

Bug: v8:7777
Change-Id: I7a5c97ea2775e9f8ff469db6ab577de6c65c6bbe
Reviewed-on: https://chromium-review.googlesource.com/c/1340282
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57714}
[modify] https://crrev.com/918b13781c3c34e1db461df269a78cf03a23e009/src/code-stub-assembler.cc
[modify] https://crrev.com/918b13781c3c34e1db461df269a78cf03a23e009/src/code-stubs.cc
[modify] https://crrev.com/918b13781c3c34e1db461df269a78cf03a23e009/src/code-stubs.h
[modify] https://crrev.com/918b13781c3c34e1db461df269a78cf03a23e009/src/elements-kind.h
[modify] https://crrev.com/918b13781c3c34e1db461df269a78cf03a23e009/src/ic/handler-configuration.cc
[modify] https://crrev.com/918b13781c3c34e1db461df269a78cf03a23e009/src/ic/ic.cc

Comment 11 by bugdroid1@chromium.org, Nov 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ac96607bcdd055af454d44249538e25573dc5071

commit ac96607bcdd055af454d44249538e25573dc5071
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Nov 22 09:28:23 2018

[nojit] Move remaining IC stubs to builtins

This CL moves the two remaining IC stubs to builtins, generating a
dedicated builtin for each KeyedAccessStoreMode variant.

Bug: v8:7777
Change-Id: I540b3c3437adb94094771a19713e71ec8a349553
Reviewed-on: https://chromium-review.googlesource.com/c/1346095
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57719}
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/builtins/builtins-definitions.h
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/builtins/builtins-handler-gen.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/code-factory.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/code-factory.h
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/code-stubs.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/code-stubs.h
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/feedback-vector.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/heap/heap.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/ic/handler-configuration.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/src/ic/ic.cc
[modify] https://crrev.com/ac96607bcdd055af454d44249538e25573dc5071/test/cctest/test-heap-profiler.cc

Comment 12 by bugdroid1@chromium.org, Nov 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1f6d5a4362ef85ddba7e3e4f836b4559cdd7fb8a

commit 1f6d5a4362ef85ddba7e3e4f836b4559cdd7fb8a
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Nov 22 09:44:11 2018

Remove CodeStubAssembler from final binary

With the last remaining TF code stubs gone, c-s-a.{h,cc} is no longer
needed in the final binary.

Bug: v8:7777
Change-Id: I8573199401678758698df56e0cb680f125f06bdc
Reviewed-on: https://chromium-review.googlesource.com/c/1346329
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57721}
[modify] https://crrev.com/1f6d5a4362ef85ddba7e3e4f836b4559cdd7fb8a/BUILD.gn
[modify] https://crrev.com/1f6d5a4362ef85ddba7e3e4f836b4559cdd7fb8a/src/builtins/builtins-array.cc
[modify] https://crrev.com/1f6d5a4362ef85ddba7e3e4f836b4559cdd7fb8a/src/code-stubs.cc
[modify] https://crrev.com/1f6d5a4362ef85ddba7e3e4f836b4559cdd7fb8a/src/code-stubs.h

Comment 13 by bugdroid1@chromium.org, Nov 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f

commit 4a97d53301e46d9a6bfb32d2517424a6bc29ae7f
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Nov 26 13:58:43 2018

[nojit] Remove the ProfileEntryHookStub

The ProfileEntryHookStub is no longer used and can be removed.

Bug: v8:7777,  v8:8503 
Change-Id: I4ccd75d38cfee3e7963338d5d8213915db9be4a9
Reviewed-on: https://chromium-review.googlesource.com/c/1349191
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57823}
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/include/v8.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/api.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm/code-stubs-arm.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm64/assembler-arm64.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm64/code-stubs-arm64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/code-stubs.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/code-stubs.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/compiler/backend/mips/instruction-scheduler-mips.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/compiler/backend/mips64/instruction-scheduler-mips64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ia32/assembler-ia32.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ia32/code-stubs-ia32.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/isolate.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/isolate.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/mips/code-stubs-mips.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/mips64/code-stubs-mips64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ppc/code-stubs-ppc.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/ppc/macro-assembler-ppc.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/s390/code-stubs-s390.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/s390/macro-assembler-s390.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/s390/macro-assembler-s390.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/x64/assembler-x64.h
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/x64/code-stubs-x64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/4a97d53301e46d9a6bfb32d2517424a6bc29ae7f/src/x64/macro-assembler-x64.h

Comment 14 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5b343483f1f9e02f5533c55436dabce55dbef523

commit 5b343483f1f9e02f5533c55436dabce55dbef523
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Nov 30 14:29:13 2018

Remove remaining infrastructure for FunctionEntryHook

Bug:  v8:8503 , v8:7777
Change-Id: Iadf515cf4735d1046c7c14f44c02d5d5f95df87a
Reviewed-on: https://chromium-review.googlesource.com/c/1356512
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57969}
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/include/v8.h
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/arm/interface-descriptors-arm.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/arm64/interface-descriptors-arm64.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/ia32/interface-descriptors-ia32.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/interface-descriptors.h
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/mips/interface-descriptors-mips.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/mips64/interface-descriptors-mips64.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/ppc/interface-descriptors-ppc.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/s390/interface-descriptors-s390.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/src/x64/interface-descriptors-x64.cc
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/test/cctest/cctest.status
[modify] https://crrev.com/5b343483f1f9e02f5533c55436dabce55dbef523/test/cctest/test-api.cc

Comment 15 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c6b0e12e4e664d82cdbbfddca273546b82f98f5d

commit c6b0e12e4e664d82cdbbfddca273546b82f98f5d
Author: Jakob Gruber <jgruber@chromium.org>
Date: Tue Dec 04 08:38:03 2018

[nojit] Refactor CallApiCallback calling convention

This is the first (and major) step towards converting CallApiCallback
and CallApiGetter stubs into builtins.

The CallApiCallbackStub was parameterized with the number of arguments
passed on the stack. This CL converts the compile-time parameter into
an explicit runtime parameter, and removes all uses of the stub
parameter.

Drive-by: The implementation is now mostly consistent across platforms.
Drive-by: Refactor the calling convention to free up two registers
(kCallData and kHolder are now passed on the stack).

Bug: v8:7777
Change-Id: I212dccc2930de89c264a13755918c9fae7842f1f
Reviewed-on: https://chromium-review.googlesource.com/c/1354887
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58005}
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/arm/code-stubs-arm.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/arm/interface-descriptors-arm.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/arm64/code-stubs-arm64.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/arm64/interface-descriptors-arm64.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/ia32/code-stubs-ia32.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/ia32/interface-descriptors-ia32.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/ic/accessor-assembler.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/interface-descriptors.h
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/mips/code-stubs-mips.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/mips/constants-mips.h
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/mips/interface-descriptors-mips.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/mips64/code-stubs-mips64.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/mips64/interface-descriptors-mips64.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/x64/code-stubs-x64.cc
[modify] https://crrev.com/c6b0e12e4e664d82cdbbfddca273546b82f98f5d/src/x64/interface-descriptors-x64.cc

Comment 16 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cfdf6ff8476ef8d9c2f76d655301105056512fb6

commit cfdf6ff8476ef8d9c2f76d655301105056512fb6
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Dec 05 08:38:24 2018

[nojit] Migrate CallApi stubs to builtins

Bug: v8:7777
Change-Id: Iee3e03b0a3fea245408de4d675caa634a74aa188
Reviewed-on: https://chromium-review.googlesource.com/c/1357053
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58036}
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/arm/code-stubs-arm.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/arm64/code-stubs-arm64.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/builtins-definitions.h
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/code-factory.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/code-factory.h
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/code-stubs.h
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/ia32/code-stubs-ia32.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/ic/accessor-assembler.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/mips/code-stubs-mips.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/mips64/code-stubs-mips64.cc
[modify] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/x64/code-stubs-x64.cc

Comment 17 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bec0234f4bf608552778be097c671cf21780f1f6

commit bec0234f4bf608552778be097c671cf21780f1f6
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Dec 05 10:36:10 2018

[nojit] Migrate DirectCEntryStub to a builtin

Drive-by: Replace uses in CallApi* with a direct call now that they've
been converted to builtins themselves and are thus immovable.

Bug: v8:7777
Change-Id: I660b5788bdac4f5e45cc5c5677b86be17474cd83
Reviewed-on: https://chromium-review.googlesource.com/c/1361161
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58037}
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/BUILD.gn
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/arm/code-stubs-arm.cc
[delete] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/arm/code-stubs-arm.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/arm64/code-stubs-arm64.cc
[delete] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/arm64/code-stubs-arm64.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/builtins-definitions.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/code-stubs.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/mips/code-stubs-mips.cc
[delete] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/mips/code-stubs-mips.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/mips64/code-stubs-mips64.cc
[delete] https://crrev.com/cfdf6ff8476ef8d9c2f76d655301105056512fb6/src/mips64/code-stubs-mips64.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/bec0234f4bf608552778be097c671cf21780f1f6/src/regexp/mips64/regexp-macro-assembler-mips64.cc

Comment 19 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f7f18b0f1e0c278c0f346d187469f99371f657a2

commit f7f18b0f1e0c278c0f346d187469f99371f657a2
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Dec 06 09:44:32 2018

[nojit] Explicitly pass the root register value to JSEntry

In preparation for converting JSEntry into a builtin. The root register
used to be initialized by an embedded external reference, which is not
isolate-independent. Pass in its value explicitly instead.

Tbr: clemensh@chromium.org
Bug: v8:7777
Change-Id: If9d20cb193af175bd1cf58e5826bdf6f397869ad
Reviewed-on: https://chromium-review.googlesource.com/c/1363139
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58065}
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/arm/code-stubs-arm.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/arm/frame-constants-arm.h
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/arm64/code-stubs-arm64.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/arm64/frame-constants-arm64.h
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/execution.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/ia32/code-stubs-ia32.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/ia32/frame-constants-ia32.h
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/isolate.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/messages.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/mips/code-stubs-mips.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/mips/frame-constants-mips.h
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/mips64/code-stubs-mips64.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/mips64/frame-constants-mips64.h
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/wasm/wasm-interpreter.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/x64/code-stubs-x64.cc
[modify] https://crrev.com/f7f18b0f1e0c278c0f346d187469f99371f657a2/src/x64/frame-constants-x64.h

Comment 20 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d8b59fc60de08219cf2982f42809a8bb3643fd09

commit d8b59fc60de08219cf2982f42809a8bb3643fd09
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Dec 06 11:37:08 2018

[nojit] Fix debug-evaluate failure on noembed builds

Fixes https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noembed%20-%20debug/781.
Failing since https://crrev.com/c/1360630.

Tbr: yangguo@chromium.org
Bug: v8:7777
Change-Id: Ia9adfa9340087dfcd74c966c40a54176081f6933
Reviewed-on: https://chromium-review.googlesource.com/c/1365276
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58069}
[modify] https://crrev.com/d8b59fc60de08219cf2982f42809a8bb3643fd09/src/debug/debug-evaluate.cc

Comment 21 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b89d4249c0955337d2bd55cc304905fc43a3a2f7

commit b89d4249c0955337d2bd55cc304905fc43a3a2f7
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 07 10:16:06 2018

[nojit] Migrate JSEntry variants to builtins

This migrates the JSEntryStub to three dedicated builtins:

JSEntry
JSConstructEntry
JSRunMicrotasksEntry

Drive-by: Tweaks to make the code isolate-independent (e.g. using the
correct macro assembler method to load and store external references
through the kRootRegister).
Drive-by: The context slot on x64/ia32 must be set up after
kRootRegister is initialized, so we first reserve the slot and later
load its value.
Drive-by: Update all remaining comments referencing JSEntryStub.

Bug: v8:7777
Change-Id: Ie3ba17ffb3bde6f18ec1d26d778b258719b2d4ef
Reviewed-on: https://chromium-review.googlesource.com/c/1365275
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58088}
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/BUILD.gn
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/api.cc
[delete] https://crrev.com/988269d5ec2169a15580c0592bf0d4311256a955/src/arm/code-stubs-arm.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/arm/macro-assembler-arm.cc
[delete] https://crrev.com/988269d5ec2169a15580c0592bf0d4311256a955/src/arm64/code-stubs-arm64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/builtins-definitions.h
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/builtins.h
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/code-stubs.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/code-stubs.h
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/execution.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/frames.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/heap/heap.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/heap/heap.h
[delete] https://crrev.com/988269d5ec2169a15580c0592bf0d4311256a955/src/ia32/code-stubs-ia32.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/isolate.cc
[delete] https://crrev.com/988269d5ec2169a15580c0592bf0d4311256a955/src/mips/code-stubs-mips.cc
[delete] https://crrev.com/988269d5ec2169a15580c0592bf0d4311256a955/src/mips64/code-stubs-mips64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/roots.h
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/unwinder.cc
[delete] https://crrev.com/988269d5ec2169a15580c0592bf0d4311256a955/src/x64/code-stubs-x64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/test/cctest/test-api.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/test/cctest/test-assembler-arm.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/test/cctest/test-code-stubs.cc
[modify] https://crrev.com/b89d4249c0955337d2bd55cc304905fc43a3a2f7/test/cctest/test-unwinder.cc

Comment 22 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f849396c3a56dd088baa89045200a5e6f7437fcf

commit f849396c3a56dd088baa89045200a5e6f7437fcf
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 07 13:41:21 2018

[nojit] Remove code stubs

All stubs have been migrated to builtins. This CL removes most related
code.

Bug: v8:7777,  v8:5784 
Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad
Reviewed-on: https://chromium-review.googlesource.com/c/1365284
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58093}
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/BUILD.gn
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/api.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm/assembler-arm.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm/assembler-arm.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm64/assembler-arm64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm64/assembler-arm64.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/assembler.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/assembler.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ast/ast.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/bootstrapper.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/code-factory.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/code-factory.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/code-stub-assembler.h
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/src/code-stubs-utils.h
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/src/code-stubs.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/src/code-stubs.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/backend/code-generator-impl.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/code-assembler.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/code-assembler.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/graph-visualizer.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/linkage.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/pipeline.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/compiler/pipeline.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/counters.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/debug/debug.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/disassembler.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/feedback-vector.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/flag-definitions.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/globals.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/factory.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/factory.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/heap-inl.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/heap.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/heap.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/incremental-marking.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/mark-compact.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/object-stats.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/object-stats.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ia32/assembler-ia32.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ia32/assembler-ia32.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ic/accessor-assembler.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/ic/call-optimization.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/interpreter/bytecode-flags.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/interpreter/bytecode-generator.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/interpreter/interpreter-generator.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/isolate.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/log.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/macro-assembler.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips/assembler-mips.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips/assembler-mips.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips64/assembler-mips64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips64/assembler-mips64.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/objects-debug.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/objects.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/objects/code-inl.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/objects/code.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/optimized-compilation-info.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/profiler/heap-snapshot-generator.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/reloc-info.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/roots.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/runtime-profiler.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/runtime/runtime-array.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/snapshot/code-serializer.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/snapshot/code-serializer.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/snapshot/startup-deserializer.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/x64/assembler-x64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/x64/assembler-x64.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/BUILD.gn
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/cctest.status
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/compiler/code-assembler-tester.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/compiler/test-linkage.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/compiler/test-run-stubs.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/test-api.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs-arm.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs-arm64.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs-ia32.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs-mips.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs-mips64.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs-x64.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs.cc
[delete] https://crrev.com/a3496f4afbf8122b89e26df2a2c626b3dbfe204c/test/cctest/test-code-stubs.h
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/test-log-stack-tracer.cc
[modify] https://crrev.com/f849396c3a56dd088baa89045200a5e6f7437fcf/test/cctest/wasm/wasm-run-utils.h

Comment 23 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/05100848ba83b8ad44f4fd5aaf8615aba2dba20f

commit 05100848ba83b8ad44f4fd5aaf8615aba2dba20f
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 07 13:54:22 2018

Revert "[nojit] Remove code stubs"

This reverts commit f849396c3a56dd088baa89045200a5e6f7437fcf.

Reason for revert: arm64: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/24229

Original change's description:
> [nojit] Remove code stubs
> 
> All stubs have been migrated to builtins. This CL removes most related
> code.
> 
> Bug: v8:7777,  v8:5784 
> Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad
> Reviewed-on: https://chromium-review.googlesource.com/c/1365284
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58093}

TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,jgruber@chromium.org,bmeurer@chromium.org

Change-Id: I52c3abd3f4e5872fe26ed7e527a58b118e02b387
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7777,  v8:5784 
Reviewed-on: https://chromium-review.googlesource.com/c/1367804
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58095}
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/BUILD.gn
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/api.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm/assembler-arm.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm/assembler-arm.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm64/assembler-arm64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm64/assembler-arm64.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/assembler.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/assembler.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ast/ast.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/bootstrapper.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/code-factory.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/code-factory.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/code-stub-assembler.h
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/code-stubs-utils.h
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/code-stubs.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/code-stubs.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/backend/code-generator-impl.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/code-assembler.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/code-assembler.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/graph-visualizer.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/linkage.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/pipeline.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/compiler/pipeline.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/counters.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/debug/debug.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/disassembler.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/feedback-vector.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/flag-definitions.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/globals.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/factory.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/factory.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/heap-inl.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/heap.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/heap.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/incremental-marking.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/mark-compact.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/object-stats.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/object-stats.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ia32/assembler-ia32.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ia32/assembler-ia32.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ic/accessor-assembler.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/ic/call-optimization.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/interpreter/bytecode-flags.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/interpreter/bytecode-generator.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/interpreter/interpreter-generator.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/isolate.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/log.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/macro-assembler.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips/assembler-mips.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips/assembler-mips.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips64/assembler-mips64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips64/assembler-mips64.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/objects-debug.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/objects.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/objects/code-inl.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/objects/code.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/optimized-compilation-info.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/profiler/heap-snapshot-generator.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/reloc-info.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/roots.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/runtime-profiler.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/runtime/runtime-array.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/snapshot/code-serializer.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/snapshot/code-serializer.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/snapshot/startup-deserializer.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/x64/assembler-x64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/x64/assembler-x64.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/BUILD.gn
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/cctest.status
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/compiler/code-assembler-tester.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/compiler/test-linkage.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/compiler/test-run-stubs.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-api.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs-arm.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs-arm64.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs-ia32.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs-mips.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs-mips64.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs-x64.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs.cc
[add] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-code-stubs.h
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/test-log-stack-tracer.cc
[modify] https://crrev.com/05100848ba83b8ad44f4fd5aaf8615aba2dba20f/test/cctest/wasm/wasm-run-utils.h

Comment 24 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/24e766168b60449c93ac61fe8f4e8b49a19636c0

commit 24e766168b60449c93ac61fe8f4e8b49a19636c0
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 07 15:46:17 2018

Reland "[nojit] Remove code stubs"

This is a reland of f849396c3a56dd088baa89045200a5e6f7437fcf

Original change's description:
> [nojit] Remove code stubs
>
> All stubs have been migrated to builtins. This CL removes most related
> code.
>
> Bug: v8:7777,  v8:5784 
> Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad
> Reviewed-on: https://chromium-review.googlesource.com/c/1365284
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58093}

Tbr: mstarzinger@chromium.org,yangguo@chromium.org,jkummerow@chromium.org,bmeurer@chromium.org
Bug: v8:7777,  v8:5784 
Change-Id: I005ee2a820d49a75a90481d262a310e4ccfd1391
Reviewed-on: https://chromium-review.googlesource.com/c/1367746
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58101}
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/BUILD.gn
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/api.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm/assembler-arm.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm/assembler-arm.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm64/assembler-arm64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm64/assembler-arm64.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/assembler.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/assembler.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ast/ast.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/bootstrapper.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/builtins/setup-builtins-internal.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/code-factory.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/code-factory.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/code-stub-assembler.h
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/src/code-stubs-utils.h
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/src/code-stubs.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/src/code-stubs.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/backend/code-generator-impl.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/code-assembler.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/code-assembler.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/graph-visualizer.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/linkage.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/pipeline.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/compiler/pipeline.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/counters.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/debug/debug.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/disassembler.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/feedback-vector.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/flag-definitions.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/globals.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/factory.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/factory.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/heap-inl.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/heap.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/heap.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/incremental-marking.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/mark-compact.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/object-stats.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/object-stats.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ia32/assembler-ia32.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ia32/assembler-ia32.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ic/accessor-assembler.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/ic/call-optimization.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/interpreter/bytecode-flags.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/interpreter/bytecode-generator.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/interpreter/interpreter-generator.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/isolate.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/log.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/macro-assembler.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips/assembler-mips.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips/assembler-mips.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips64/assembler-mips64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips64/assembler-mips64.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/objects-debug.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/objects.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/objects/code-inl.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/objects/code.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/optimized-compilation-info.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/profiler/heap-snapshot-generator.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/reloc-info.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/roots.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/runtime-profiler.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/runtime/runtime-array.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/snapshot/code-serializer.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/snapshot/code-serializer.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/snapshot/startup-deserializer.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/x64/assembler-x64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/x64/assembler-x64.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/BUILD.gn
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/cctest.status
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/compiler/code-assembler-tester.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/compiler/test-linkage.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/compiler/test-run-stubs.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/test-api.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs-arm.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs-arm64.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs-ia32.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs-mips.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs-mips64.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs-x64.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs.cc
[delete] https://crrev.com/c99604d98c84a3ae61045d44c9043f1f24f553b8/test/cctest/test-code-stubs.h
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/test-log-stack-tracer.cc
[modify] https://crrev.com/24e766168b60449c93ac61fe8f4e8b49a19636c0/test/cctest/wasm/wasm-run-utils.h

Comment 25 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/302f187b8b672585101108ad5a74b5161203e028

commit 302f187b8b672585101108ad5a74b5161203e028
Author: Jakob Gruber <jgruber@chromium.org>
Date: Tue Dec 11 09:58:34 2018

[nojit] Remaining cleanups related to CodeStub removal

This:

- documents removal of Code's stub key field.
- removes SerializedCodeData's CodeStubKeys field.
- removes masm's custom self-reference marker mechanism.

Bug: v8:7777
Change-Id: Ie5c51bc895e508acdeb3994cf5558a2cf4c21540
Reviewed-on: https://chromium-review.googlesource.com/c/1367744
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58145}
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/builtins/constants-table-builder.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/objects/code-inl.h
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/objects/code.h
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/s390/macro-assembler-s390.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/snapshot/code-serializer.cc
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/snapshot/code-serializer.h
[modify] https://crrev.com/302f187b8b672585101108ad5a74b5161203e028/src/x64/macro-assembler-x64.cc

Comment 26 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6

commit 2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6
Author: Alexander Timokhin <atimoxin@yandex-team.ru>
Date: Wed Dec 12 18:04:55 2018

Don't use |v8_initializers| code in |v8_base|

Removing |CodeStubAssembler| from |v8_base| source list (see
https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to
linkage problems with some build configurations because it was explicitly
and implicitly included in |v8_base| code.

This CL decouple this code and fixes problems.

Bug: v8:7777
Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189
Reviewed-on: https://chromium-review.googlesource.com/c/1372067
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58200}
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/BUILD.gn
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/builtins/builtins-date.cc
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/builtins/builtins-object.cc
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/builtins/builtins-promise-gen.cc
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/builtins/builtins-promise-gen.h
[add] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/builtins/builtins-promise.h
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/isolate.cc
[modify] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/test/cctest/test-code-stub-assembler.cc

Comment 27 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7975e215f7079eef51a0ce484518e463a3741e4e

commit 7975e215f7079eef51a0ce484518e463a3741e4e
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Dec 12 18:26:38 2018

Revert "Don't use |v8_initializers| code in |v8_base|"

This reverts commit 2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6.

Reason for revert: Missing explicit include in cc file:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Presubmit/986

Original change's description:
> Don't use |v8_initializers| code in |v8_base|
> 
> Removing |CodeStubAssembler| from |v8_base| source list (see
> https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to
> linkage problems with some build configurations because it was explicitly
> and implicitly included in |v8_base| code.
> 
> This CL decouple this code and fixes problems.
> 
> Bug: v8:7777
> Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189
> Reviewed-on: https://chromium-review.googlesource.com/c/1372067
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58200}

TBR=jkummerow@chromium.org,jgruber@chromium.org,bmeurer@chromium.org,atimoxin@yandex-team.ru

Change-Id: I3e41fb5f8a9db6a78c56546a08e55610885d312b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7777
Reviewed-on: https://chromium-review.googlesource.com/c/1374292
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58201}
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/BUILD.gn
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/src/builtins/builtins-date.cc
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/src/builtins/builtins-object.cc
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/src/builtins/builtins-promise-gen.cc
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/src/builtins/builtins-promise-gen.h
[delete] https://crrev.com/2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6/src/builtins/builtins-promise.h
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/src/isolate.cc
[modify] https://crrev.com/7975e215f7079eef51a0ce484518e463a3741e4e/test/cctest/test-code-stub-assembler.cc

Comment 28 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/014eb820f52ff9504a30ae88e0acf6ac36418d4a

commit 014eb820f52ff9504a30ae88e0acf6ac36418d4a
Author: Alexander Timokhin <atimoxin@yandex-team.ru>
Date: Thu Dec 13 10:48:44 2018

Reland "Don't use |v8_initializers| code in |v8_base|"

This is a reland of 2e36e9ea1ef3e332bc9b2d620c6d6ceb054f58a6

Was reverted because of v8_presubmit.py issue in
https://chromium-review.googlesource.com/c/v8/v8/+/1374292

Original change's description:
> Don't use |v8_initializers| code in |v8_base|
>
> Removing |CodeStubAssembler| from |v8_base| source list (see
> https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to
> linkage problems with some build configurations because it was explicitly
> and implicitly included in |v8_base| code.
>
> This CL decouple this code and fixes problems.
>
> Bug: v8:7777
> Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189
> Reviewed-on: https://chromium-review.googlesource.com/c/1372067
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58200}

Bug: v8:7777
Change-Id: Iaa00e73c7dbd8c413fbf15a17709aa12eda9a706
Reviewed-on: https://chromium-review.googlesource.com/c/1375654
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58209}
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/BUILD.gn
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/builtins/builtins-date.cc
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/builtins/builtins-object.cc
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/builtins/builtins-promise-gen.cc
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/builtins/builtins-promise-gen.h
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/builtins/builtins-promise.cc
[add] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/builtins/builtins-promise.h
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/src/isolate.cc
[modify] https://crrev.com/014eb820f52ff9504a30ae88e0acf6ac36418d4a/test/cctest/test-code-stub-assembler.cc

Comment 29 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5e2fda250c8648be4f4d9e64c0220c726aec3f90

commit 5e2fda250c8648be4f4d9e64c0220c726aec3f90
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 14 15:43:46 2018

[nojit] Add a builtins entry table to IsolateData

In preparation for upcoming work on Torque function pointers.

This table will be used to look up the entry address in order to call
there directly without going through the (on-heap) trampoline.

Bug: v8:7777
Change-Id: If713430c843e85371a5aaef8a3bfb5da9e0ea903
Reviewed-on: https://chromium-review.googlesource.com/c/1378172
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58245}
[modify] https://crrev.com/5e2fda250c8648be4f4d9e64c0220c726aec3f90/src/builtins/builtins.cc
[modify] https://crrev.com/5e2fda250c8648be4f4d9e64c0220c726aec3f90/src/builtins/builtins.h
[modify] https://crrev.com/5e2fda250c8648be4f4d9e64c0220c726aec3f90/src/heap/heap.cc
[modify] https://crrev.com/5e2fda250c8648be4f4d9e64c0220c726aec3f90/src/isolate-data.h
[modify] https://crrev.com/5e2fda250c8648be4f4d9e64c0220c726aec3f90/src/isolate.cc
[modify] https://crrev.com/5e2fda250c8648be4f4d9e64c0220c726aec3f90/src/isolate.h

Comment 30 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f323a5f415316ced84937e7625a056d9d2cf0db7

commit f323a5f415316ced84937e7625a056d9d2cf0db7
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Dec 17 14:03:22 2018

[nojit] Add a kCallBuiltinPointer call kind

Currently, Torque's builtin pointers store a Code target underneath and
callsites generate a kArchCallCodeObject opcode. When embedded builtins
are enabled, the call thus first calls the on-heap trampoline, which
finally jumps to the target off-heap builtin code.

This will no longer be possible in jitless mode, since on-heap code must
not be executable.

As a step towards changing the way builtin pointers are called
(function pointers will hold the builtin index as a Smi, and callsites
look up the off-heap target address and jump there), this CL adds a
dedicated opcode for builtin pointer calls to the compiler pipeline.

The calling mechanism itself is unchanged, changes there will happen
in a follow-up.

Drive-by: rename 'FunctionPointer' in torque/ to 'BuiltinPointer'.

Bug: v8:7777
Change-Id: Ic999a1cd7c3172425dd4a1513ae2f50c774faddb
Reviewed-on: https://chromium-review.googlesource.com/c/1378175
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58281}
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/arm64/code-generator-arm64.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/ia32/code-generator-ia32.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/instruction-codes.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/instruction-scheduler.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/mips/code-generator-mips.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/mips64/code-generator-mips64.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/code-assembler.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/code-assembler.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/linkage.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/compiler/linkage.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/globals.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/interpreter/interpreter-assembler.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/interpreter/interpreter-intrinsics-generator.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/csa-generator.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/declarations.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/declarations.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/implementation-visitor.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/instructions.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/instructions.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/type-oracle.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/types.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/torque/types.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/turbo-assembler.h
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/f323a5f415316ced84937e7625a056d9d2cf0db7/src/x64/macro-assembler-x64.h

Comment 31 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fa3cbf60d50466685964b36ff95b3599db5188a4

commit fa3cbf60d50466685964b36ff95b3599db5188a4
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Dec 17 15:35:59 2018

[nojit] Change builtin pointers to use Smis underneath

This changes Torque's builtin pointers to use a Smi representation
underneath instead of storing the Code target object. Callsites look
up the target entry point through IsolateData::builtin_entry_table.

The notable effect of this CL is that builtin pointer calls no longer
call any on-heap Code.

Bug: v8:7777
Change-Id: Ibf6c749dd46cae7aba51494b09921229dd436f63
Reviewed-on: https://chromium-review.googlesource.com/c/1379880
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58286}
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/builtins/base.tq
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/compiler/code-assembler.h
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/isolate-data.h
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/torque/csa-generator.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/torque/type-oracle.h
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/torque/types.h
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/fa3cbf60d50466685964b36ff95b3599db5188a4/test/torque/test-torque.tq

Comment 32 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9abc7dae295976985217b1daa16fc091c8a1d935

commit 9abc7dae295976985217b1daa16fc091c8a1d935
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Dec 17 16:34:49 2018

Rename StubCallMode::kCallOnHeapBuiltin

The kCallOnHeapBuiltin name has gotten very confusing now
that builtins are actually off the heap (and the generated code will
directly call off-heap).

Bug: v8:7777
Change-Id: Ie14069eee2fc11ef9aec64868c50832f6138ae8f
Reviewed-on: https://chromium-review.googlesource.com/c/1379883
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58291}
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/compiler/code-assembler.cc
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/compiler/code-assembler.h
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/compiler/linkage.cc
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/compiler/linkage.h
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/globals.h
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/interpreter/interpreter-assembler.cc
[modify] https://crrev.com/9abc7dae295976985217b1daa16fc091c8a1d935/src/interpreter/interpreter-intrinsics-generator.cc

Comment 33 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5308f83d6bff3e83bceb9e2b3cb81730aeea613c

commit 5308f83d6bff3e83bceb9e2b3cb81730aeea613c
Author: Jakob Gruber <jgruber@chromium.org>
Date: Tue Dec 18 14:47:15 2018

[nojit] Skip on-heap trampoline in Invoke

This skips one level of indirection by calling the off-heap entry
point directly instead of going through the on-heap Code trampoline.

Bug: v8:7777
Change-Id: If667ea6cd6138ab1c12aa861ef441109008e4fba
Reviewed-on: https://chromium-review.googlesource.com/c/1382459
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58324}
[modify] https://crrev.com/5308f83d6bff3e83bceb9e2b3cb81730aeea613c/src/execution.cc

Comment 34 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e9a0e0e593881cea1cdd6ae4b9bc4104350470da

commit e9a0e0e593881cea1cdd6ae4b9bc4104350470da
Author: Jakob Gruber <jgruber@chromium.org>
Date: Tue Dec 18 15:24:36 2018

[nojit,x64] Tweak builtin pointer call sequence for pointer compression

This is to fix the pointer compression bot, which tests only x64.
Other 64-bit architectures will need similar work in the future.

On x64 with pointer compression, smi-untagging can be folded into the
Operand calculation since the left-shift for multiplying by
kSystemPointerSize is greater than the right-shift for untagging.

Bug: v8:7777
Change-Id: I5c46e9d3f51580341cfc3c12a7e32d17cf0b63ee
Reviewed-on: https://chromium-review.googlesource.com/c/1381452
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58328}
[modify] https://crrev.com/e9a0e0e593881cea1cdd6ae4b9bc4104350470da/src/x64/macro-assembler-x64.cc

Comment 35 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/71180e544747b2bd31b93f82ff2b15ab6d8788bd

commit 71180e544747b2bd31b93f82ff2b15ab6d8788bd
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Dec 20 11:31:47 2018

Don't embed CompileLazyDeoptimizedCode

This changes the CompileLazyDeoptimizedCode call to use the standard
builtin calling sequence, which (for optimized code) creates an
inlined off-heap trampoline instead of embedding a CODE_TARGET.

Drive-by: Add missing conditional jump handling to masm::Jump. It was
missing only for the case of inlined trampolines.

Bug: v8:7777
Change-Id: Id79a10ba99fd97c1b3351774b9ecf5adf10ee6d4
Reviewed-on: https://chromium-review.googlesource.com/c/1382460
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58389}
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/compiler/backend/arm64/code-generator-arm64.cc
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/compiler/backend/ia32/code-generator-ia32.cc
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/compiler/backend/mips/code-generator-mips.cc
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/compiler/backend/mips64/code-generator-mips64.cc
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/71180e544747b2bd31b93f82ff2b15ab6d8788bd/src/x64/macro-assembler-x64.cc

Comment 36 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/84450a2239672109bcf537d6740b8babda521567

commit 84450a2239672109bcf537d6740b8babda521567
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 21 12:55:09 2018

[nojit] Define V8_JITLESS_MODE in V8 Lite builds

This defines V8_JITLESS_MODE if the v8_enable_lite_mode build-time
option is enabled. Jitless mode will thus be tested by existing lite
bots.

The build-time option for jitless mode will only be needed temporarily
and is expected to be removed again in the near future.

Bug: v8:7777
Change-Id: I556ba5069dbd0810a6d7376601d8f7d498fef8c9
Reviewed-on: https://chromium-review.googlesource.com/c/1387499
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58433}
[modify] https://crrev.com/84450a2239672109bcf537d6740b8babda521567/BUILD.gn

Comment 37 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ccc068d5fd75b639a3f0c7c92623a191e9af861e

commit ccc068d5fd75b639a3f0c7c92623a191e9af861e
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Dec 21 14:43:16 2018

[nojit] Skip the on-heap trampoline for builtin calls

This CL does two things:

1. It introduces Call/JumpCodeObject as the bottleneck for all calls
   to non-heap-constant Code objects; and
2. it dispatches directly to the off-heap entry point for all embedded
   code.

Codegen at runtime remains unchanged to preserve the shorter,
branch-less calling sequence.

Bug: v8:7777
Change-Id: I15fdcb51625209904c6a56737f085a23219319b9
Reviewed-on: https://chromium-review.googlesource.com/c/1382461
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58440}
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/arm/macro-assembler-arm.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/compiler/backend/arm64/code-generator-arm64.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/compiler/backend/ia32/code-generator-ia32.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/ia32/macro-assembler-ia32.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/mips/macro-assembler-mips.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/turbo-assembler.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/ccc068d5fd75b639a3f0c7c92623a191e9af861e/test/cctest/wasm/test-wasm-import-wrapper-cache.cc

Comment 38 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0ae25272c60020146965011d2c05517614d5a5ac

commit 0ae25272c60020146965011d2c05517614d5a5ac
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Dec 24 08:47:41 2018

[nojit] Fix noembed bot failures

noembed bots have started failing since https://crrev.com/c/1382461.

The reason was that inline_offheap_trampolines option was set to true
even in noembed builds, and the assembler tried to inline trampolines
to non-existent embedded builtins.

Tbr: sigurds@chromium.org
Bug: v8:7777
Change-Id: I483dd8b77269b8684e57f8da6e659a9648b1657b
Reviewed-on: https://chromium-review.googlesource.com/c/1390117
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58458}
[modify] https://crrev.com/0ae25272c60020146965011d2c05517614d5a5ac/src/assembler.cc

Comment 39 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f2411cf2b92d922ee942cbbffa8c23303309d43b

commit f2411cf2b92d922ee942cbbffa8c23303309d43b
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Dec 24 09:48:55 2018

[nojit] Disable embed tests on noembed builds

These test off-heap builtin call sequences and don't make sense in
noembed builds.

Tbr: sigurds@chromium.org
Bug: v8:7777
Change-Id: I2795257e33b6ad87958d08f0845b75a7e88988f2
Reviewed-on: https://chromium-review.googlesource.com/c/1390120
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58461}
[modify] https://crrev.com/f2411cf2b92d922ee942cbbffa8c23303309d43b/test/cctest/test-code-stub-assembler.cc

Comment 40 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4af9ec6a9deb0747b84c92c220d6621d5497999d

commit 4af9ec6a9deb0747b84c92c220d6621d5497999d
Author: Junliang Yan <jyan@ca.ibm.com>
Date: Wed Jan 02 20:08:17 2019

PPC/s390: Reland "[nojit] Remove code stubs"

Port 24e766168b60449c93ac61fe8f4e8b49a19636c0

Original Commit Message:

    This is a reland of f849396c3a56dd088baa89045200a5e6f7437fcf

    Original change's description:
    > [nojit] Remove code stubs
    >
    > All stubs have been migrated to builtins. This CL removes most related
    > code.
    >
    > Bug: v8:7777,  v8:5784 
    > Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad
    > Reviewed-on: https://chromium-review.googlesource.com/c/1365284
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58093}

R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: Ie05463245c24975804a8bb7ffdf902c70e042127
Reviewed-on: https://chromium-review.googlesource.com/c/1393302
Reviewed-by: Joran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#58504}
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/ppc/assembler-ppc.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/ppc/assembler-ppc.h
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/ppc/macro-assembler-ppc.h
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/regexp/ppc/regexp-macro-assembler-ppc.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/regexp/s390/regexp-macro-assembler-s390.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/s390/assembler-s390.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/s390/assembler-s390.h
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/s390/macro-assembler-s390.cc
[modify] https://crrev.com/4af9ec6a9deb0747b84c92c220d6621d5497999d/src/s390/macro-assembler-s390.h

Comment 41 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/566a885d4a0d5df72614317ff1be013f072bd514

commit 566a885d4a0d5df72614317ff1be013f072bd514
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Jan 10 10:55:48 2019

[nojit] Don't allocate executable memory in jitless mode

This CL disables RX (read and execute) permissions for Code memory
when in jitless mode. All memory that was previously allocated RX
is now read-only.

Bug: v8:7777
Cq-Include-Trybots: luci.v8.try:v8_linux_arm_lite_rel_ng
Change-Id: I52d6ed785d244ec33168a02293c5506d26f36fe8
Reviewed-on: https://chromium-review.googlesource.com/c/1390122
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58692}
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/src/flag-definitions.h
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/src/heap/heap-inl.h
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/src/heap/heap.cc
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/src/heap/spaces.cc
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/src/heap/spaces.h
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/src/x64/codegen-x64.cc
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/cctest/cctest.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/debugger/debugger.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/fuzzer/fuzzer.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/inspector/inspector.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/message/message.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/mjsunit/mjsunit.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/mkgrokdump/mkgrokdump.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/unittests/unittests.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/wasm-js/wasm-js.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/test/wasm-spec-tests/wasm-spec-tests.status
[modify] https://crrev.com/566a885d4a0d5df72614317ff1be013f072bd514/tools/v8_presubmit.py

Comment 42 by jgruber@chromium.org, Jan 11

Blockedon: 8675

Comment 43 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a

commit f3a23accadbd46e0b1d7141ef4a9b31b9c41656a
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Jan 11 12:45:38 2019

Remove fast_sqrt generated code

As far as I can tell these were unused; their only callers were arm
and ppc simulators, but codegen explicitly returned nullptr if in a
simulator build, falling back to std::sqrt.

There's more potential cleanup to be done here for other functions
defined in codegen-*.cc files.

Tbr: clemensh@chromium.org
Bug: v8:7777,  v8:8675 
Change-Id: I4b9d6062c6724a810ab094d09e3cd04a0b733d9b
Reviewed-on: https://chromium-review.googlesource.com/c/1405851
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58740}
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/BUILD.gn
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/arm/codegen-arm.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/arm/simulator-arm.cc
[delete] https://crrev.com/f451d6ce77a5c70bc59af0b16bff52b38939b99c/src/arm64/codegen-arm64.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/arm64/simulator-arm64.cc
[delete] https://crrev.com/f451d6ce77a5c70bc59af0b16bff52b38939b99c/src/codegen.cc
[delete] https://crrev.com/f451d6ce77a5c70bc59af0b16bff52b38939b99c/src/codegen.h
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/external-reference.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/ia32/codegen-ia32.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/mips/codegen-mips.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/mips/simulator-mips.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/mips64/codegen-mips64.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/mips64/simulator-mips64.cc
[delete] https://crrev.com/f451d6ce77a5c70bc59af0b16bff52b38939b99c/src/ppc/codegen-ppc.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/ppc/simulator-ppc.cc
[delete] https://crrev.com/f451d6ce77a5c70bc59af0b16bff52b38939b99c/src/s390/codegen-s390.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/s390/simulator-s390.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/src/wasm/wasm-code-manager.cc
[delete] https://crrev.com/f451d6ce77a5c70bc59af0b16bff52b38939b99c/src/x64/codegen-x64.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/cctest/compiler/test-machine-operator-reducer.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/cctest/compiler/test-multiple-return.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/cctest/compiler/test-run-load-store.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/cctest/compiler/test-run-machops.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/cctest/compiler/test-run-native-calls.cc
[modify] https://crrev.com/f3a23accadbd46e0b1d7141ef4a9b31b9c41656a/test/unittests/compiler/typer-unittest.cc

Comment 44 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a9f186bde6f13a38de26c0268563844fa157636

commit 4a9f186bde6f13a38de26c0268563844fa157636
Author: Jakob Gruber <jgruber@chromium.org>
Date: Fri Jan 11 14:35:33 2019

[ia32] Remove custom MemMove function

It isn't clear whether our custom generated MemMove function provides
any benefits over std::memmove. This is an attempt to remove it. If
bots seem unhappy we can revert.

Bug: v8:7777, v8:8675 
Change-Id: I7f1a6e3050b6e635618593c04f7d51e448426ee2
Reviewed-on: https://chromium-review.googlesource.com/c/1405854
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58748}
[modify] https://crrev.com/4a9f186bde6f13a38de26c0268563844fa157636/BUILD.gn
[delete] https://crrev.com/5708a86520061efbaefb51c176707828b7ac8f5b/src/ia32/codegen-ia32.cc
[modify] https://crrev.com/4a9f186bde6f13a38de26c0268563844fa157636/src/memcopy.cc
[modify] https://crrev.com/4a9f186bde6f13a38de26c0268563844fa157636/src/memcopy.h

Comment 45 by jgruber@chromium.org, Jan 11

Blockedon: 8678

Comment 46 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9eb278b829a5c5072f553864e1bbea4ac7f40c0e

commit 9eb278b829a5c5072f553864e1bbea4ac7f40c0e
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Jan 14 09:07:51 2019

Revert "[ia32] Remove custom MemMove function"

This reverts commit 4a9f186bde6f13a38de26c0268563844fa157636.

Reason for revert: Regresses microbenchmarks.  https://crbug.com/v8/8675#c5 

Original change's description:
> [ia32] Remove custom MemMove function
> 
> It isn't clear whether our custom generated MemMove function provides
> any benefits over std::memmove. This is an attempt to remove it. If
> bots seem unhappy we can revert.
> 
> Bug: v8:7777, v8:8675 
> Change-Id: I7f1a6e3050b6e635618593c04f7d51e448426ee2
> Reviewed-on: https://chromium-review.googlesource.com/c/1405854
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58748}

TBR=jkummerow@chromium.org,jgruber@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7777,  v8:8675 
Change-Id: Ia4ad37070f433f76b1158e90835162aefe38abdd
Reviewed-on: https://chromium-review.googlesource.com/c/1407063
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58766}
[modify] https://crrev.com/9eb278b829a5c5072f553864e1bbea4ac7f40c0e/BUILD.gn
[add] https://crrev.com/9eb278b829a5c5072f553864e1bbea4ac7f40c0e/src/ia32/codegen-ia32.cc
[modify] https://crrev.com/9eb278b829a5c5072f553864e1bbea4ac7f40c0e/src/memcopy.cc
[modify] https://crrev.com/9eb278b829a5c5072f553864e1bbea4ac7f40c0e/src/memcopy.h

Comment 47 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b00ef713703f75369f66dbf0eec42e57e31cded0

commit b00ef713703f75369f66dbf0eec42e57e31cded0
Author: Jakob Gruber <jgruber@chromium.org>
Date: Tue Jan 15 11:20:19 2019

[nojit] Add a few flag implications based on --jitless

--jitless -> --no-opt
          -> --no-validate-asm
          -> --wasm-interpret-all -> --no-asm-wasm-lazy-compilation
                                  -> --no-wasm-lazy-compilation

Note that wasm still isn't supported in jitless mode since it generates
code at runtime even with --wasm-interpret-all.

Drive-by: Fail early when trying to compile irregexp code in jitless
mode.

Cq-Include-Trybots: luci.v8.try:v8_linux_arm_lite_rel_ng
Bug: v8:7777
Change-Id: I7f0421f71efeaaeb030ed9ec268d12a659667acf
Reviewed-on: https://chromium-review.googlesource.com/c/1406677
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58820}
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/src/flag-definitions.h
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/src/regexp/jsregexp.cc
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/test/cctest/test-flags.cc
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/test/debugger/debugger.status
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/test/fuzzer/fuzzer.status
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/test/inspector/inspector.status
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/test/message/message.status
[modify] https://crrev.com/b00ef713703f75369f66dbf0eec42e57e31cded0/test/mjsunit/mjsunit.status

Comment 48 by jgruber@chromium.org, Jan 23

Blockedon: 8724

Comment 49 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7e616f2b6e043c6e6c55e920166309be3e449c28

commit 7e616f2b6e043c6e6c55e920166309be3e449c28
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Jan 23 16:06:31 2019

[nojit] Ship the regexp interpreter unconditionally

For jitless mode, we must be able to switch between the native regexp
engine and interpreted regexps at runtime since --jitless is itself a
runtime flag.

This CL unconditionally compiles in the regexp interpreter in all
builds. It can be toggled through the --regexp-interpret-all flag.

Bug: v8:7777,  v8:8678 
Change-Id: Iadd21a152de7c07586d5af32bee5fdf9931f1a01
Reviewed-on: https://chromium-review.googlesource.com/c/1408929
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59041}
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/external-reference.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/external-reference.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/flag-definitions.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/objects/js-regexp-inl.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm/regexp-macro-assembler-arm.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm64/regexp-macro-assembler-arm64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/bytecodes-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ia32/regexp-macro-assembler-ia32.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ia32/regexp-macro-assembler-ia32.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/interpreter-irregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/interpreter-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/jsregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/jsregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips/regexp-macro-assembler-mips.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips64/regexp-macro-assembler-mips64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ppc/regexp-macro-assembler-ppc.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ppc/regexp-macro-assembler-ppc.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp-inl.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/s390/regexp-macro-assembler-s390.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/s390/regexp-macro-assembler-s390.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/x64/regexp-macro-assembler-x64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/cctest.status
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-api.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-regexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-serialize.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-thread-termination.cc

Comment 50 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7e616f2b6e043c6e6c55e920166309be3e449c28

commit 7e616f2b6e043c6e6c55e920166309be3e449c28
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Jan 23 16:06:31 2019

[nojit] Ship the regexp interpreter unconditionally

For jitless mode, we must be able to switch between the native regexp
engine and interpreted regexps at runtime since --jitless is itself a
runtime flag.

This CL unconditionally compiles in the regexp interpreter in all
builds. It can be toggled through the --regexp-interpret-all flag.

Bug: v8:7777,  v8:8678 
Change-Id: Iadd21a152de7c07586d5af32bee5fdf9931f1a01
Reviewed-on: https://chromium-review.googlesource.com/c/1408929
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59041}
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/external-reference.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/external-reference.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/flag-definitions.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/objects/js-regexp-inl.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm/regexp-macro-assembler-arm.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm64/regexp-macro-assembler-arm64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/bytecodes-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ia32/regexp-macro-assembler-ia32.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ia32/regexp-macro-assembler-ia32.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/interpreter-irregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/interpreter-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/jsregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/jsregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips/regexp-macro-assembler-mips.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips64/regexp-macro-assembler-mips64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ppc/regexp-macro-assembler-ppc.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ppc/regexp-macro-assembler-ppc.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp-inl.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/s390/regexp-macro-assembler-s390.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/s390/regexp-macro-assembler-s390.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/x64/regexp-macro-assembler-x64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/cctest.status
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-api.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-regexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-serialize.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-thread-termination.cc

Comment 51 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7e616f2b6e043c6e6c55e920166309be3e449c28

commit 7e616f2b6e043c6e6c55e920166309be3e449c28
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Jan 23 16:06:31 2019

[nojit] Ship the regexp interpreter unconditionally

For jitless mode, we must be able to switch between the native regexp
engine and interpreted regexps at runtime since --jitless is itself a
runtime flag.

This CL unconditionally compiles in the regexp interpreter in all
builds. It can be toggled through the --regexp-interpret-all flag.

Bug: v8:7777,  v8:8678 
Change-Id: Iadd21a152de7c07586d5af32bee5fdf9931f1a01
Reviewed-on: https://chromium-review.googlesource.com/c/1408929
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59041}
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/external-reference.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/external-reference.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/flag-definitions.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/objects/js-regexp-inl.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm/regexp-macro-assembler-arm.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm/regexp-macro-assembler-arm.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/arm64/regexp-macro-assembler-arm64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/bytecodes-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ia32/regexp-macro-assembler-ia32.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ia32/regexp-macro-assembler-ia32.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/interpreter-irregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/interpreter-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/jsregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/jsregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips/regexp-macro-assembler-mips.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips/regexp-macro-assembler-mips.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips64/regexp-macro-assembler-mips64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/mips64/regexp-macro-assembler-mips64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ppc/regexp-macro-assembler-ppc.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/ppc/regexp-macro-assembler-ppc.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp-inl.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler-irregexp.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/regexp-macro-assembler.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/s390/regexp-macro-assembler-s390.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/s390/regexp-macro-assembler-s390.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/x64/regexp-macro-assembler-x64.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/src/regexp/x64/regexp-macro-assembler-x64.h
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/cctest.status
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-api.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-regexp.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-serialize.cc
[modify] https://crrev.com/7e616f2b6e043c6e6c55e920166309be3e449c28/test/cctest/test-thread-termination.cc

Comment 52 by jgruber@chromium.org, Feb 1

Blockedon: 8776

Comment 53 by machenb...@chromium.org, Feb 1

Blockedon: 8778

Comment 54 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0befa6d4c38e2871756daaf1735bc27c47328b9d

commit 0befa6d4c38e2871756daaf1735bc27c47328b9d
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Feb 04 08:42:28 2019

[nojit] Check that --jitless is disabled when creating wasm code

Drive-by: Amend wasm test skips for lite mode.

Bug: v8:7777
Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7
Reviewed-on: https://chromium-review.googlesource.com/c/1449616
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59314}
[modify] https://crrev.com/0befa6d4c38e2871756daaf1735bc27c47328b9d/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/0befa6d4c38e2871756daaf1735bc27c47328b9d/test/cctest/cctest.status

Comment 55 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6045f983f29a8a055f1e278af4190eb0c4bad1d1

commit 6045f983f29a8a055f1e278af4190eb0c4bad1d1
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Feb 04 09:02:53 2019

Revert "[nojit] Check that --jitless is disabled when creating wasm code"

This reverts commit 0befa6d4c38e2871756daaf1735bc27c47328b9d.

Reason for revert: Fails in lite mode: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/2177

Original change's description:
> [nojit] Check that --jitless is disabled when creating wasm code
> 
> Drive-by: Amend wasm test skips for lite mode.
> 
> Bug: v8:7777
> Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7
> Reviewed-on: https://chromium-review.googlesource.com/c/1449616
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59314}

TBR=mstarzinger@chromium.org,jgruber@chromium.org

Change-Id: Id0d43fe4b03a2992acd980fd9fa4ef114d4b6aa2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7777
Reviewed-on: https://chromium-review.googlesource.com/c/1451877
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59317}
[modify] https://crrev.com/6045f983f29a8a055f1e278af4190eb0c4bad1d1/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/6045f983f29a8a055f1e278af4190eb0c4bad1d1/test/cctest/cctest.status

Comment 56 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365

commit 8de3a2ca441bbcecdbdcb472d55b3a4df1f97365
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Feb 04 10:20:08 2019

Reland "[nojit] Check that --jitless is disabled when creating wasm code"

This is a reland of 0befa6d4c38e2871756daaf1735bc27c47328b9d

Original change's description:
> [nojit] Check that --jitless is disabled when creating wasm code
>
> Drive-by: Amend wasm test skips for lite mode.
>
> Bug: v8:7777
> Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7
> Reviewed-on: https://chromium-review.googlesource.com/c/1449616
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59314}

Tbr: mstarzinger@chromium.org
Bug: v8:7777
Change-Id: I0a076b36bb2e69b612df89b0f35067f299f27a7e
Reviewed-on: https://chromium-review.googlesource.com/c/1451819
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59325}
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/test/cctest/cctest.status
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/test/debugger/debugger.status
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/test/fuzzer/fuzzer.status
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/test/message/message.status
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/test/mjsunit/mjsunit.status
[modify] https://crrev.com/8de3a2ca441bbcecdbdcb472d55b3a4df1f97365/test/unittests/unittests.status

Comment 57 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/81a62c8cb63915117e44245ea1b3fb21ab4fba9a

commit 81a62c8cb63915117e44245ea1b3fb21ab4fba9a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Feb 04 15:15:12 2019

[jitless] Skip crashing tests on native arm

TBR=jgruber@chromium.org
NOTRY=true

Bug: v8:7777
Change-Id: I5006aee897fe0d0705e7265e714ec200e13370b1
Reviewed-on: https://chromium-review.googlesource.com/c/1451890
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59345}
[modify] https://crrev.com/81a62c8cb63915117e44245ea1b3fb21ab4fba9a/test/cctest/cctest.status

Comment 58 by machenb...@chromium.org, Feb 6

Blockedon: 8789

Comment 59 by jgruber@chromium.org, Feb 7

Blockedon: 8802

Comment 60 by jgruber@chromium.org, Feb 12

Blockedon: chromium:931068

Comment 61 by jgruber@chromium.org, Feb 12

Blocking: chromium:931185

Comment 62 by jgruber@chromium.org, Feb 12

Blockedon: chromium:931228

Comment 63 by bugdroid, Feb 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c79a63e634c0e0bd66c225cd0ff109a47b378c7f

commit c79a63e634c0e0bd66c225cd0ff109a47b378c7f
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Feb 13 14:26:54 2019

[nojit] Don't expose wasm in jitless mode

Wasm currently still creates executable memory even in
interpreter-only mode, and is thus unsupported in jitless mode. This
hides wasm completely, which will help e.g. fuzzers that attempt to
run wasm code (and currently crash on the CHECK in AddOwnedCode).

Bug: v8:7777, chromium:931068 
Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8
Reviewed-on: https://chromium-review.googlesource.com/c/1470124
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59561}
[modify] https://crrev.com/c79a63e634c0e0bd66c225cd0ff109a47b378c7f/src/flag-definitions.h
[modify] https://crrev.com/c79a63e634c0e0bd66c225cd0ff109a47b378c7f/test/cctest/cctest.status
[modify] https://crrev.com/c79a63e634c0e0bd66c225cd0ff109a47b378c7f/test/mjsunit/mjsunit.status

Comment 64 by bugdroid, Feb 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8a173c6ff41066ee024f5eb3a5dad007b340a9c3

commit 8a173c6ff41066ee024f5eb3a5dad007b340a9c3
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Feb 13 15:39:12 2019

Revert "[nojit] Don't expose wasm in jitless mode"

This reverts commit c79a63e634c0e0bd66c225cd0ff109a47b378c7f.

Reason for revert: Needs addtl test skips: https://chromium-review.googlesource.com/c/1470124

Original change's description:
> [nojit] Don't expose wasm in jitless mode
> 
> Wasm currently still creates executable memory even in
> interpreter-only mode, and is thus unsupported in jitless mode. This
> hides wasm completely, which will help e.g. fuzzers that attempt to
> run wasm code (and currently crash on the CHECK in AddOwnedCode).
> 
> Bug: v8:7777, chromium:931068 
> Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8
> Reviewed-on: https://chromium-review.googlesource.com/c/1470124
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59561}

TBR=mstarzinger@chromium.org,jgruber@chromium.org

Change-Id: Ic242db3efe73ef362e0f0c3efde90682db6de4a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7777,  chromium:931068 
Reviewed-on: https://chromium-review.googlesource.com/c/1470131
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59570}
[modify] https://crrev.com/8a173c6ff41066ee024f5eb3a5dad007b340a9c3/src/flag-definitions.h
[modify] https://crrev.com/8a173c6ff41066ee024f5eb3a5dad007b340a9c3/test/cctest/cctest.status
[modify] https://crrev.com/8a173c6ff41066ee024f5eb3a5dad007b340a9c3/test/mjsunit/mjsunit.status

Comment 65 by bugdroid, Feb 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/10f0d8c14310cca86c1a2f4718e4dabf6e52356f

commit 10f0d8c14310cca86c1a2f4718e4dabf6e52356f
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Feb 13 16:24:04 2019

Reland "[nojit] Don't expose wasm in jitless mode"

This is a reland of c79a63e634c0e0bd66c225cd0ff109a47b378c7f

Original change's description:
> [nojit] Don't expose wasm in jitless mode
>
> Wasm currently still creates executable memory even in
> interpreter-only mode, and is thus unsupported in jitless mode. This
> hides wasm completely, which will help e.g. fuzzers that attempt to
> run wasm code (and currently crash on the CHECK in AddOwnedCode).
>
> Bug: v8:7777, chromium:931068 
> Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8
> Reviewed-on: https://chromium-review.googlesource.com/c/1470124
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59561}

Tbr: mstarzinger@chromium.org
Bug: v8:7777,  chromium:931068 
Change-Id: I535c3f598c90cd5c4072a73544cc33c5bf5460c1
Reviewed-on: https://chromium-review.googlesource.com/c/1470132
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59571}
[modify] https://crrev.com/10f0d8c14310cca86c1a2f4718e4dabf6e52356f/src/flag-definitions.h
[modify] https://crrev.com/10f0d8c14310cca86c1a2f4718e4dabf6e52356f/test/cctest/cctest.status
[modify] https://crrev.com/10f0d8c14310cca86c1a2f4718e4dabf6e52356f/test/mjsunit/mjsunit.status
[modify] https://crrev.com/10f0d8c14310cca86c1a2f4718e4dabf6e52356f/test/unittests/unittests.status

Comment 66 by bugdroid, Feb 18 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f7f850cb8555a908cc0e7dd4627fbad7073d6b80

commit f7f850cb8555a908cc0e7dd4627fbad7073d6b80
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Feb 18 11:07:57 2019

[nojit] Expose wasm in jitless mode for correctness fuzzers

Correctness fuzzers need the global object to have a consistent shape
across build configs.

Bug:  chromium:932877 ,chromium:932656,v8:7777
Change-Id: Id4e1251e50965b822bc4ef36c5ae2777864273d5
Reviewed-on: https://chromium-review.googlesource.com/c/1475768
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59654}
[modify] https://crrev.com/f7f850cb8555a908cc0e7dd4627fbad7073d6b80/src/flag-definitions.h
[modify] https://crrev.com/f7f850cb8555a908cc0e7dd4627fbad7073d6b80/src/v8.cc

Comment 67 by bugdroid, Feb 21 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9b5fe7b26d3857229f5192c2f8abf113f6ccd24d

commit 9b5fe7b26d3857229f5192c2f8abf113f6ccd24d
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Feb 21 13:26:47 2019

DCHECK_IMPLIES(FLAG_jitless, FLAG_embedded_builtins);

Bug: v8:7777
Change-Id: I0227ee37018e718014b8a8fbdba93e82a2209ae0
Reviewed-on: https://chromium-review.googlesource.com/c/1480372
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59761}
[modify] https://crrev.com/9b5fe7b26d3857229f5192c2f8abf113f6ccd24d/src/isolate.cc

Comment 68 by jgruber@chromium.org, Feb 21 (2 days ago)

Blockedon: 8886

Comment 69 by jgruber@chromium.org, Feb 21 (2 days ago)

Blockedon: 8888

Comment 70 by bugdroid, Feb 21 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/285519582be28caf73c8688934b4813cbdf64761

commit 285519582be28caf73c8688934b4813cbdf64761
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Feb 21 14:33:37 2019

Extend error messages for blob or isolate verification failures

Bug: v8:7777
Change-Id: I781ac51ba740655c644e19388c6cadad7267b18c
Reviewed-on: https://chromium-review.googlesource.com/c/1478209
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59765}
[modify] https://crrev.com/285519582be28caf73c8688934b4813cbdf64761/src/isolate.cc

Comment 71 by jgruber@chromium.org, Feb 21 (2 days ago)

Blockedon: 8889

Sign in to add a comment