New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
HW: All
NextAction: ----
OS: All
Priority: 2
Type: Bug

Blocked on:
issue 5751

Blocking:
issue 7411
issue 5505



Sign in to add a comment
link

Issue 7624: Remove js natives

Reported by szuend@google.com, Apr 5 2018 Project Member

Issue description

Tracking bug for removal of remaining JS natives

array.js
intl.js
prologue.js
typedarray.js
debug/debug.js
debug/liveedit.js
debug/mirrors.js

Design doc: https://docs.google.com/document/d/10FU7W-pptBMwa9RjHg3CdwISKuIug1ilDBQd4QTk-vQ/edit#heading=h.c10w3san2p7e
 

Comment 2 by jgruber@chromium.org, Apr 6 2018

Cc: bmeu...@chromium.org szuend@google.com yangguo@chromium.org
Components: Runtime
Labels: HelpWanted HW-All OS-All Priority-2
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by bugdroid1@chromium.org, Apr 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c6cb81a884d003f8e7579c7b00419f82628f4fc8

commit c6cb81a884d003f8e7579c7b00419f82628f4fc8
Author: Simon Zünd <szuend@google.com>
Date: Mon Apr 09 08:10:55 2018

Adds CSA builtin for abstract TypedArray constructor.

Also removes the JS constructor.

R=jgruber@chromium.org

Bug: v8:7624
Change-Id: I33493ab2fafb35f95fb1822d46d3f249568c0a56
Reviewed-on: https://chromium-review.googlesource.com/999534
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52469}
[modify] https://crrev.com/c6cb81a884d003f8e7579c7b00419f82628f4fc8/src/bootstrapper.cc
[modify] https://crrev.com/c6cb81a884d003f8e7579c7b00419f82628f4fc8/src/builtins/builtins-definitions.h
[modify] https://crrev.com/c6cb81a884d003f8e7579c7b00419f82628f4fc8/src/builtins/builtins-typedarray-gen.cc
[modify] https://crrev.com/c6cb81a884d003f8e7579c7b00419f82628f4fc8/src/js/typedarray.js

Comment 4 by bugdroid1@chromium.org, Apr 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3953955aabfc444d87795a781dae84e40b800208

commit 3953955aabfc444d87795a781dae84e40b800208
Author: Simon Zünd <szuend@google.com>
Date: Wed Apr 11 09:02:39 2018

Extend the existing TypedArray.sort benchmark.

Benchmark now sorts every element type of TypedArray and groups the
benchmarks by integer and floating point types. Also adding a sort
benchmark that uses multiple custom compare functions.

R=petermarshall@chromium.org

Bug: v8:7624
Change-Id: Id0f44adf78398c99a17fe3edb6ee5d7fccc4d99b
Reviewed-on: https://chromium-review.googlesource.com/1000774
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52541}
[modify] https://crrev.com/3953955aabfc444d87795a781dae84e40b800208/test/js-perf-test/JSTests.json
[add] https://crrev.com/3953955aabfc444d87795a781dae84e40b800208/test/js-perf-test/TypedArrays/sort-cmpfn-float.js
[add] https://crrev.com/3953955aabfc444d87795a781dae84e40b800208/test/js-perf-test/TypedArrays/sort-cmpfn-int.js
[add] https://crrev.com/3953955aabfc444d87795a781dae84e40b800208/test/js-perf-test/TypedArrays/sort-float.js
[add] https://crrev.com/3953955aabfc444d87795a781dae84e40b800208/test/js-perf-test/TypedArrays/sort-int.js
[modify] https://crrev.com/3953955aabfc444d87795a781dae84e40b800208/test/js-perf-test/TypedArrays/sort.js

Comment 5 by gsat...@chromium.org, Jun 10 2018

Blockedon: 5751

Comment 6 by bugdroid1@chromium.org, Jul 6 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d4475252978a72dff9fa3163d2fb4657c718c00c

commit d4475252978a72dff9fa3163d2fb4657c718c00c
Author: Simon Zünd <szuend@google.com>
Date: Fri Jul 06 08:50:20 2018

[array] Move Array.p.push fall-back from JS to C++

This CL extends the existing ArrayPush C++ builtin with a generic
slow-path that replaces the JavaScript fall-back.

Bug: v8:7624
Change-Id: I1e8431601e8a872f3c5afba5d486f37fd5781d60
Reviewed-on: https://chromium-review.googlesource.com/1126922
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#54282}
[modify] https://crrev.com/d4475252978a72dff9fa3163d2fb4657c718c00c/src/builtins/builtins-array.cc
[modify] https://crrev.com/d4475252978a72dff9fa3163d2fb4657c718c00c/src/contexts.h
[modify] https://crrev.com/d4475252978a72dff9fa3163d2fb4657c718c00c/src/js/array.js
[modify] https://crrev.com/d4475252978a72dff9fa3163d2fb4657c718c00c/src/objects/js-array.h

Comment 7 by bugdroid1@chromium.org, Jul 6 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/575e582edce8071d19ff74c7c5b3714d9608c1c0

commit 575e582edce8071d19ff74c7c5b3714d9608c1c0
Author: Simon Zünd <szuend@google.com>
Date: Fri Jul 06 09:39:51 2018

[array] Move Array.p.pop fall-back from JS to C++

This CL extends the existing ArrayPop C++ builtin with a generic
slow-path that replaces the JavaScript fallback.

R=cbruni@chromium.org, jgruber@chromium.org

Bug: v8:7624
Change-Id: Ie3ce5379e5c65df67cbc4d956390a8701345ea3c
Reviewed-on: https://chromium-review.googlesource.com/1127162
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54284}
[modify] https://crrev.com/575e582edce8071d19ff74c7c5b3714d9608c1c0/src/builtins/builtins-array.cc
[modify] https://crrev.com/575e582edce8071d19ff74c7c5b3714d9608c1c0/src/contexts.h
[modify] https://crrev.com/575e582edce8071d19ff74c7c5b3714d9608c1c0/src/js/array.js

Comment 8 by jgruber@chromium.org, Jul 6 2018

Cc: peter.wm...@gmail.com gsat...@chromium.org
debug/*.js is gone, only 

array.js
intl.js
typedarray.js

remain. Adding Sathya for intl.js and Peter for array.js.

Comment 9 by jgruber@chromium.org, Jul 6 2018

Blocking: 5505

Comment 10 by bugdroid1@chromium.org, Jul 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/eeb583d8b89f954efd94ab884b4207187e5b9cc7

commit eeb583d8b89f954efd94ab884b4207187e5b9cc7
Author: Simon Zünd <szuend@google.com>
Date: Wed Jul 18 14:06:24 2018

[array] Move Array.p.fill to C++

This CL moves Array.p.fill from JavaScript to a C++ builtin. It has
a generic slow-path and fast-paths implemented via ElementsAccessor in
elements.cc.

R=cbruni@chromium.org

Bug: v8:7624
Change-Id: I8820e1195d2cd9b41c254058923ad9875aab067c
Reviewed-on: https://chromium-review.googlesource.com/1131130
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54522}
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/bootstrapper.cc
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/builtins/builtins-array.cc
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/builtins/builtins-definitions.h
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/debug/debug-evaluate.cc
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/elements.cc
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/js/array.js
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/src/objects.h
[add] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/test/mjsunit/es6/array-fill-receiver.js
[modify] https://crrev.com/eeb583d8b89f954efd94ab884b4207187e5b9cc7/test/mjsunit/es6/array-fill.js

Comment 11 by jgruber@chromium.org, Jul 24 2018

Cc: ftang@chromium.org bstell@chromium.org
cc ftang@ and bstell@ for intl.js.

Comment 12 by jgruber@chromium.org, Jul 26 2018

Description: Show this description

Comment 13 by bugdroid1@chromium.org, Aug 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ce206503bcc9a7fc55f9a42b4da82500fb1cff2c

commit ce206503bcc9a7fc55f9a42b4da82500fb1cff2c
Author: Simon Zünd <szuend@google.com>
Date: Wed Aug 08 15:05:16 2018

[array] Add basic js-perf benchmarks for Array.p.copyWithin

This CL adds basic JS benchmarks for Array.p.copyWithin to get some
feedback for the upcoming Torque implementation.

R=jgruber@chromium.org

Bug: v8:7624
Change-Id: Ic193a2b576d5fb7ac9f39db0379cece9144f979f
Reviewed-on: https://chromium-review.googlesource.com/1167289
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#54984}
[add] https://crrev.com/ce206503bcc9a7fc55f9a42b4da82500fb1cff2c/test/js-perf-test/Array/copy-within.js
[modify] https://crrev.com/ce206503bcc9a7fc55f9a42b4da82500fb1cff2c/test/js-perf-test/Array/run.js
[modify] https://crrev.com/ce206503bcc9a7fc55f9a42b4da82500fb1cff2c/test/js-perf-test/JSTests.json

Comment 14 by bugdroid1@chromium.org, Aug 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c112c962c42eb71d9c9e0e2b849dca648e99a3ab

commit c112c962c42eb71d9c9e0e2b849dca648e99a3ab
Author: Simon Zünd <szuend@google.com>
Date: Thu Aug 09 07:53:42 2018

[array] Move Array.p.copyWithin to Torque

This CL adds a baseline Torque implementation without fast-paths for
Array.p.copyWithin. The JS version in array.js is removed.

R=cbruni@chromium.org, jgruber@chromium.org

Bug: v8:7624
Change-Id: Ie53047883a65dd9310ea8f8d0edb440f431044ea
Reviewed-on: https://chromium-review.googlesource.com/1165223
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#55000}
[modify] https://crrev.com/c112c962c42eb71d9c9e0e2b849dca648e99a3ab/BUILD.gn
[modify] https://crrev.com/c112c962c42eb71d9c9e0e2b849dca648e99a3ab/src/bootstrapper.cc
[add] https://crrev.com/c112c962c42eb71d9c9e0e2b849dca648e99a3ab/src/builtins/array-copywithin.tq
[modify] https://crrev.com/c112c962c42eb71d9c9e0e2b849dca648e99a3ab/src/js/array.js

Comment 15 by bugdroid1@chromium.org, Aug 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5a3893958a8211722b01f6b5bbfdd4498a45ff57

commit 5a3893958a8211722b01f6b5bbfdd4498a45ff57
Author: Simon Zünd <szuend@google.com>
Date: Thu Aug 09 08:45:39 2018

[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort

This CL changes the sorting algorithm used in Array.p.sort from
QuickSort to TimSort (implemented in Torque).

Detailed performance results can be found here: https://goo.gl/4E733J

To save on code space, fast-paths are implemented as sets of
function pointers instead of specializing generics.

R=cbruni@chromium.org, jgruber@chromium.org

Bug:  v8:7382 , v8:7624
Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de
Reviewed-on: https://chromium-review.googlesource.com/1151199
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55003}
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/.gitignore
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/BUILD.gn
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/bootstrapper.cc
[delete] https://crrev.com/32e4540b4116c4270da5e1474b90d228d924c0aa/src/builtins/array-sort.tq
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/builtins/base.tq
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/code-stub-assembler.h
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/debug/debug-evaluate.cc
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/src/js/array.js
[modify] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/test/message/fail/non-alphanum.out
[add] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/third_party/v8/builtins/LICENSE
[add] https://crrev.com/5a3893958a8211722b01f6b5bbfdd4498a45ff57/third_party/v8/builtins/array-sort.tq

Comment 16 by bugdroid1@chromium.org, Aug 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f4ca3fc56eba8e536b835d47e280079e067288f0

commit f4ca3fc56eba8e536b835d47e280079e067288f0
Author: Simon Zünd <szuend@google.com>
Date: Fri Aug 10 09:02:52 2018

[array] Prepare Array.p.shift for removal of the JavaScript fall-back

This CL changes the ArrayPrototypeShift builtin to a CSA macro which
is used in a newly created Torque builtin.

This is in preparation for removing the JavaScript fall-back, which
will be replaced by a baseline Torque implementation.

R=cbruni@chromium.org, jgruber@chromium.org

Bug: v8:7624
Change-Id: I9b7898beea2802cc02d394e040a1e500387cf108
Reviewed-on: https://chromium-review.googlesource.com/1169172
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#55036}
[modify] https://crrev.com/f4ca3fc56eba8e536b835d47e280079e067288f0/BUILD.gn
[add] https://crrev.com/f4ca3fc56eba8e536b835d47e280079e067288f0/src/builtins/array-shift.tq
[modify] https://crrev.com/f4ca3fc56eba8e536b835d47e280079e067288f0/src/builtins/base.tq
[modify] https://crrev.com/f4ca3fc56eba8e536b835d47e280079e067288f0/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/f4ca3fc56eba8e536b835d47e280079e067288f0/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/f4ca3fc56eba8e536b835d47e280079e067288f0/src/builtins/builtins-definitions.h

Comment 17 by bugdroid1@chromium.org, Aug 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71

commit adac1c2ac0d1c2ee110b162b1815aafe4bf71d71
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Aug 14 10:05:48 2018

Revert "[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort"

This reverts commit 5a3893958a8211722b01f6b5bbfdd4498a45ff57.

Reason for revert: Breaks some chromium tests. Not your fault, but it's blocking the roll so we have to fix those first -- then you can reland without changes: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/21727

Original change's description:
> [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort
> 
> This CL changes the sorting algorithm used in Array.p.sort from
> QuickSort to TimSort (implemented in Torque).
> 
> Detailed performance results can be found here: https://goo.gl/4E733J
> 
> To save on code space, fast-paths are implemented as sets of
> function pointers instead of specializing generics.
> 
> R=​cbruni@chromium.org, jgruber@chromium.org
> 
> Bug:  v8:7382 , v8:7624
> Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de
> Reviewed-on: https://chromium-review.googlesource.com/1151199
> Commit-Queue: Simon Zünd <szuend@google.com>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55003}

TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  v8:7382 , v8:7624
Change-Id: Id4002d8080648c418639d35e7b82487fa43f463d
Reviewed-on: https://chromium-review.googlesource.com/1174231
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55114}
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/BUILD.gn
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/src/bootstrapper.cc
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/src/builtins/base.tq
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/src/code-stub-assembler.h
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/src/debug/debug-evaluate.cc
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/src/js/array.js
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/test/message/fail/non-alphanum.out
[delete] https://crrev.com/666c8b87f34bf98a07738c51d7750baa6c8473a9/third_party/v8/builtins/LICENSE
[modify] https://crrev.com/adac1c2ac0d1c2ee110b162b1815aafe4bf71d71/third_party/v8/builtins/array-sort.tq

Comment 18 by bugdroid1@chromium.org, Aug 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18

commit 9e48a24fd9b88712e4ec591c8b1fd40dc6381f18
Author: Simon Zünd <szuend@google.com>
Date: Thu Aug 23 07:33:33 2018

Reland "[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort"

The CL was reverted because it broke some tests in ChromeOS.

> [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort
>
> This CL changes the sorting algorithm used in Array.p.sort from
> QuickSort to TimSort (implemented in Torque).
>
> Detailed performance results can be found here: https://goo.gl/4E733J
>
> To save on code space, fast-paths are implemented as sets of
> function pointers instead of specializing generics.
>
> R=cbruni@chromium.org, jgruber@chromium.org
>
> Bug:  v8:7382 , v8:7624
> Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de
> Reviewed-on: https://chromium-review.googlesource.com/1151199
> Commit-Queue: Simon Zünd <szuend@google.com>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55003}

Bug:  v8:7382 , v8:7624
Change-Id: Ic7a3230f3708177774b0760f08b7659d83ec5505
Reviewed-on: https://chromium-review.googlesource.com/1184901
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55325}
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/BUILD.gn
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/bootstrapper.cc
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/builtins/base.tq
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/code-stub-assembler.h
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/debug/debug-evaluate.cc
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/src/js/array.js
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/test/message/fail/non-alphanum.out
[add] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/third_party/v8/builtins/LICENSE
[modify] https://crrev.com/9e48a24fd9b88712e4ec591c8b1fd40dc6381f18/third_party/v8/builtins/array-sort.tq

Comment 19 by bugdroid1@chromium.org, Aug 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/28afdca68349b3ae7584732ba4eea0743b33d794

commit 28afdca68349b3ae7584732ba4eea0743b33d794
Author: Simon Zünd <szuend@google.com>
Date: Thu Aug 23 11:34:07 2018

Revert "[array] Prepare Array.p.shift for removal of the JavaScript fall-back"

This reverts commit f4ca3fc56eba8e536b835d47e280079e067288f0.

Reason for revert: Since TF (js-call-reducer) calls into the C++ builtin, it is easier (cleaner for now) to implement the baseline version in C++ instead of Torque.

Original change's description:
> [array] Prepare Array.p.shift for removal of the JavaScript fall-back
> 
> This CL changes the ArrayPrototypeShift builtin to a CSA macro which
> is used in a newly created Torque builtin.
> 
> This is in preparation for removing the JavaScript fall-back, which
> will be replaced by a baseline Torque implementation.
> 
> R=​cbruni@chromium.org, jgruber@chromium.org
> 
> Bug: v8:7624
> Change-Id: I9b7898beea2802cc02d394e040a1e500387cf108
> Reviewed-on: https://chromium-review.googlesource.com/1169172
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Simon Zünd <szuend@google.com>
> Cr-Commit-Position: refs/heads/master@{#55036}

TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7624
Change-Id: I4929eefaa90ff8681bc8ae20e3ea3fe84ee7f1e8
Reviewed-on: https://chromium-review.googlesource.com/1186342
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#55345}
[modify] https://crrev.com/28afdca68349b3ae7584732ba4eea0743b33d794/BUILD.gn
[delete] https://crrev.com/44180f55af91dff2526f176becb6bad5c1d9fb36/src/builtins/array-shift.tq
[modify] https://crrev.com/28afdca68349b3ae7584732ba4eea0743b33d794/src/builtins/base.tq
[modify] https://crrev.com/28afdca68349b3ae7584732ba4eea0743b33d794/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/28afdca68349b3ae7584732ba4eea0743b33d794/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/28afdca68349b3ae7584732ba4eea0743b33d794/src/builtins/builtins-definitions.h

Comment 20 by bugdroid1@chromium.org, Aug 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f

commit 8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f
Author: Maya Lekova <mslekova@chromium.org>
Date: Thu Aug 23 13:08:13 2018

Revert "Reland "[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort""

This reverts commit 9e48a24fd9b88712e4ec591c8b1fd40dc6381f18.

Reason for revert: Possibly breaking the V8-Blink Mac bot - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Mac/15097

Original change's description:
> Reland "[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort"
> 
> The CL was reverted because it broke some tests in ChromeOS.
> 
> > [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort
> >
> > This CL changes the sorting algorithm used in Array.p.sort from
> > QuickSort to TimSort (implemented in Torque).
> >
> > Detailed performance results can be found here: https://goo.gl/4E733J
> >
> > To save on code space, fast-paths are implemented as sets of
> > function pointers instead of specializing generics.
> >
> > R=cbruni@chromium.org, jgruber@chromium.org
> >
> > Bug:  v8:7382 , v8:7624
> > Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de
> > Reviewed-on: https://chromium-review.googlesource.com/1151199
> > Commit-Queue: Simon Zünd <szuend@google.com>
> > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#55003}
> 
> Bug:  v8:7382 , v8:7624
> Change-Id: Ic7a3230f3708177774b0760f08b7659d83ec5505
> Reviewed-on: https://chromium-review.googlesource.com/1184901
> Commit-Queue: Simon Zünd <szuend@google.com>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55325}

TBR=jgruber@chromium.org,szuend@google.com

Change-Id: Ie7e2af57a6480aa0504ba21ec98ee825d7ac74fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  v8:7382 , v8:7624
Reviewed-on: https://chromium-review.googlesource.com/1186601
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55355}
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/BUILD.gn
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/bootstrapper.cc
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/builtins/base.tq
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/code-stub-assembler.h
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/debug/debug-evaluate.cc
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/src/js/array.js
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/test/message/fail/non-alphanum.out
[delete] https://crrev.com/027074fd78c736afc8ec81e7b6f597c00c64017d/third_party/v8/builtins/LICENSE
[modify] https://crrev.com/8e43b9c01d60ddb5e58ec8de9d34616ea1bb905f/third_party/v8/builtins/array-sort.tq

Comment 21 by bugdroid1@chromium.org, Aug 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fa11e2ac0380948a2f57963e6651402c3ca07d04

commit fa11e2ac0380948a2f57963e6651402c3ca07d04
Author: Simon Zünd <szuend@google.com>
Date: Thu Aug 23 15:43:29 2018

Reland ^2 "[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort"

This is a reland of 9e48a24fd9b88712e4ec591c8b1fd40dc6381f18

Original change's description:
> Reland "[array] Move Array.p.sort to Torque and use TimSort instead of QuickSort"
>
> The CL was reverted because it broke some tests in ChromeOS.
>
> > [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort
> >
> > This CL changes the sorting algorithm used in Array.p.sort from
> > QuickSort to TimSort (implemented in Torque).
> >
> > Detailed performance results can be found here: https://goo.gl/4E733J
> >
> > To save on code space, fast-paths are implemented as sets of
> > function pointers instead of specializing generics.
> >
> > R=cbruni@chromium.org, jgruber@chromium.org
> >
> > Bug:  v8:7382 , v8:7624
> > Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de
> > Reviewed-on: https://chromium-review.googlesource.com/1151199
> > Commit-Queue: Simon Zünd <szuend@google.com>
> > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#55003}
>
> Bug:  v8:7382 , v8:7624
> Change-Id: Ic7a3230f3708177774b0760f08b7659d83ec5505
> Reviewed-on: https://chromium-review.googlesource.com/1184901
> Commit-Queue: Simon Zünd <szuend@google.com>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55325}

Bug:  v8:7382 , v8:7624
Change-Id: I297611f45c09967e0f6961156b0c9ebdebc7053f
Reviewed-on: https://chromium-review.googlesource.com/1186801
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55360}
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/BUILD.gn
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/bootstrapper.cc
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/builtins/base.tq
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/code-stub-assembler.h
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/debug/debug-evaluate.cc
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/src/js/array.js
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/test/message/fail/non-alphanum.out
[add] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/third_party/v8/builtins/LICENSE
[modify] https://crrev.com/fa11e2ac0380948a2f57963e6651402c3ca07d04/third_party/v8/builtins/array-sort.tq

Comment 22 by bugdroid1@chromium.org, Aug 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/837fec91a456da3fe6faee53ee8e2894743633b6

commit 837fec91a456da3fe6faee53ee8e2894743633b6
Author: Simon Zünd <szuend@google.com>
Date: Fri Aug 24 05:57:20 2018

[array] Replace JS Array.p.reverse with a Torque implementation

This CL adds a baseline implementation for Array.p.reverse in Torque,
as well as fastpaths for PACKED elements kinds.

Support for sparse JSArrays was removed.

R=jgruber@chromium.org, petermarshall@chromium.org

Bug: v8:7624
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I12900fbbb44746f1c5d36b78be826e14b88b4f69
Reviewed-on: https://chromium-review.googlesource.com/1185600
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55369}
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/BUILD.gn
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/src/bootstrapper.cc
[add] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/src/builtins/array-reverse.tq
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/src/builtins/array.tq
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/src/debug/debug-evaluate.cc
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/src/js/array.js
[add] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/test/mjsunit/array-reverse.js
[delete] https://crrev.com/8093b4f313c1d8c043820b5ca10c71afa98e6097/test/mjsunit/regress/regress-685.js
[delete] https://crrev.com/8093b4f313c1d8c043820b5ca10c71afa98e6097/test/mjsunit/sparse-array-reverse.js
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/test/test262/test262.status
[modify] https://crrev.com/837fec91a456da3fe6faee53ee8e2894743633b6/third_party/v8/builtins/array-sort.tq

Comment 23 by bugdroid1@chromium.org, Aug 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a4f5c6962ad52882335eeae76f2dd9138c6edb9c

commit a4f5c6962ad52882335eeae76f2dd9138c6edb9c
Author: Simon Zünd <szuend@google.com>
Date: Tue Aug 28 12:02:32 2018

[array] Move Array.p.lastIndexOf from JS to Torque

This CL re-implements Array.p.lastIndexOf in Torque. The implementation
consists of a generic baseline path and a fast-path for JSArrays with fast
ElementsKinds.

Sparse support for JSArrays was removed.

Bug: v8:7624
Change-Id: I6ae877aaf99fa97a91763b3d60a0ee05623ab085
Reviewed-on: https://chromium-review.googlesource.com/1190345
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55451}
[modify] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/BUILD.gn
[modify] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/src/bootstrapper.cc
[add] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/src/builtins/array-lastindexof.tq
[modify] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/src/builtins/base.tq
[modify] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/src/debug/debug-evaluate.cc
[modify] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/src/js/array.js
[modify] https://crrev.com/a4f5c6962ad52882335eeae76f2dd9138c6edb9c/test/cctest/test-serialize.cc

Comment 24 by bugdroid1@chromium.org, Sep 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a45a20e4460674f4c8a7024ea047ed29f295ddf1

commit a45a20e4460674f4c8a7024ea047ed29f295ddf1
Author: Simon Zünd <szuend@google.com>
Date: Mon Sep 03 06:10:11 2018

[array] Move fall-back for Array.p.shift to C++

This CL replaces the JavaScript fall-back for Array.p.shift with a
baseline C++ implementation.

R=jgruber@chromium.org

Bug: v8:7624
Change-Id: Ib55e04e18e4e69089fc541636d3cad7fcb4c7245
Reviewed-on: https://chromium-review.googlesource.com/1186327
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55576}
[modify] https://crrev.com/a45a20e4460674f4c8a7024ea047ed29f295ddf1/src/builtins/builtins-array.cc
[modify] https://crrev.com/a45a20e4460674f4c8a7024ea047ed29f295ddf1/src/contexts.h
[modify] https://crrev.com/a45a20e4460674f4c8a7024ea047ed29f295ddf1/src/js/array.js
[modify] https://crrev.com/a45a20e4460674f4c8a7024ea047ed29f295ddf1/test/mjsunit/array-functions-prototype-misc.js

Comment 25 by bugdroid1@chromium.org, Sep 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cfe7115690758c9b6d92de705a6036c8fd753b37

commit cfe7115690758c9b6d92de705a6036c8fd753b37
Author: Simon Zünd <szuend@google.com>
Date: Thu Sep 06 07:09:05 2018

[array] Move Array.p.unshift fall-back to Torque

This CL implements a generic baseline version of Array.p.unshift
in Torque, enabling us to remove the JS fall-back.

The elements-accessor fast-path is still used, but the check whether
to use it is also moved to Torque.

Support for sparse JSArrays is removed.

Drive-by change: Small refactoring in builtins-array that will
get extended to other array builtins in a follow-up CL.

R=cbruni@chromium.org, jgruber@chromium.org

Bug: v8:7624
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I7b23ce15e7b922eb333f61a408050dedec77c95a
Reviewed-on: https://chromium-review.googlesource.com/1189902
Commit-Queue: Simon Zünd <szuend@google.com>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55670}
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/BUILD.gn
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/bootstrapper.cc
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/builtins/array-reverse.tq
[add] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/builtins/array-unshift.tq
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/builtins/array.tq
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/builtins/base.tq
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/builtins/builtins-array.cc
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/code-stub-assembler.h
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/contexts.h
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/debug/debug-evaluate.cc
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/src/js/array.js
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/test/mjsunit/array-functions-prototype-misc.js
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/test/mjsunit/array-unshift.js
[delete] https://crrev.com/dd5ea32af3566471866940c4549c667284a7c816/test/mjsunit/regress/regress-splice-large-index.js
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/test/mozilla/mozilla.status
[modify] https://crrev.com/cfe7115690758c9b6d92de705a6036c8fd753b37/test/test262/test262.status

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f7be7ae09687d018afd2499c376375ef8b251df5

commit f7be7ae09687d018afd2499c376375ef8b251df5
Author: Jakob Gruber <jgruber@chromium.org>
Date: Mon Nov 12 14:46:04 2018

Clean out dead code and remove IS_VAR support

This removes unused code (macros.py, runtime functions). As IS_VAR is
now unused we can remove support from the parser.

Bug: v8:7624
Change-Id: Ia1c5e23f4c2caa85310d3f9a557218fc52d200f2
Reviewed-on: https://chromium-review.googlesource.com/c/1329696
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57434}
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/ic/ic.cc
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/js/macros.py
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/message-template.h
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/parsing/parser.cc
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/runtime/runtime-array.cc
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/runtime/runtime-internal.cc
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/runtime/runtime-promise.cc
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/runtime/runtime-test.cc
[modify] https://crrev.com/f7be7ae09687d018afd2499c376375ef8b251df5/src/runtime/runtime.h
[delete] https://crrev.com/2ecdbd24fb1fe04b5775655f555783b65a3cf225/test/message/fail/isvar.js
[delete] https://crrev.com/2ecdbd24fb1fe04b5775655f555783b65a3cf225/test/message/fail/isvar.out

Comment 28 by bugdroid1@chromium.org, Nov 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0ef1a8afe6c70224ba55d2c241b787a239fe39e2

commit 0ef1a8afe6c70224ba55d2c241b787a239fe39e2
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Thu Nov 22 08:17:29 2018

[builtins] Use Torque exception handling for Array.p.join

Initial port of Array.p.join came before Torque had exception
handling.  This small cleanup also simplifies a future CL
porting TypedArray.p.join.

Bug: v8:7624
Change-Id: I74f3880ee6e87917bc87e41d94be1a83b039384b
Reviewed-on: https://chromium-review.googlesource.com/c/1347514
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Commit-Position: refs/heads/master@{#57712}
[modify] https://crrev.com/0ef1a8afe6c70224ba55d2c241b787a239fe39e2/src/builtins/array-join.tq
[modify] https://crrev.com/0ef1a8afe6c70224ba55d2c241b787a239fe39e2/src/builtins/builtins-array-gen.h

Comment 29 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f8f742700fcc607d4ab93400954dfaa311db3660

commit f8f742700fcc607d4ab93400954dfaa311db3660
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Tue Dec 11 16:06:48 2018

[js-perf-test] Add TypedArray#join micro-benchmarks

This patch adds micro-benchmarks for TypedArray#join with and without a separator.
The benchmark can be used to measure any TypedArray#join optimizations we implement in the future.

Test:

  tools/run_perf.py --binary-override-path=out/x64.release/d8 \
    --filter JSTests/TypedArrays/Join \
    test/js-perf-test/JSTests.json

Bug: v8:7624
Change-Id: I526af50da0eff400d21b807ba30a9de2c3d87476
Reviewed-on: https://chromium-review.googlesource.com/c/1369333
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Commit-Position: refs/heads/master@{#58163}
[modify] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/JSTests.json
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/base.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join-bigint.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join-float.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join-int.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join-sep-bigint.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join-sep-float.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join-sep-int.js
[add] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/join.js
[modify] https://crrev.com/f8f742700fcc607d4ab93400954dfaa311db3660/test/js-perf-test/TypedArrays/sort.js

Comment 30 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d1c15973d32287e3cb54afbab57a1cc334ab81f2

commit d1c15973d32287e3cb54afbab57a1cc334ab81f2
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Tue Dec 11 17:52:33 2018

[builtins] Port TypedArray join, toString, and toLocaleString to Torque.

Micro-benchmarks show speed improvements across the various types:

TypedArrays-JoinBigIntTypes                7246   8297  14.50%
TypedArrays-JoinBigIntTypes                7194   8637  20.06%
TypedArrays-JoinBigIntTypes                7258   8586  18.30%
TypedArrays-JoinFloatTypes                24461  28628  17.04%
TypedArrays-JoinFloatTypes                24523  29647  20.89%
TypedArrays-JoinFloatTypes                24419  29327  20.10%
TypedArrays-JoinIntTypes                  23378  33928  45.13%
TypedArrays-JoinIntTypes                  23333  34034  45.86%
TypedArrays-JoinIntTypes                  21653  34000  57.02%
TypedArrays-JoinWithSeparatorBigIntTypes   6620   7339  10.86%
TypedArrays-JoinWithSeparatorBigIntTypes   6566   7579  15.43%
TypedArrays-JoinWithSeparatorBigIntTypes   6631   7481  12.82%
TypedArrays-JoinWithSeparatorFloatTypes   18695  19670   5.22%
TypedArrays-JoinWithSeparatorFloatTypes   18518  20088   8.48%
TypedArrays-JoinWithSeparatorFloatTypes   18482  20193   9.26%
TypedArrays-JoinWithSeparatorIntTypes     17849  21482  20.35%
TypedArrays-JoinWithSeparatorIntTypes     17831  21578  21.01%
TypedArrays-JoinWithSeparatorIntTypes     17937  21578  20.30%

Drive-by: Removed unused CSA helper InternalArrayCreate.

Bug: v8:7624
Change-Id: I8e63815982439cfd2267417d03cd2b71b4b7a812
Reviewed-on: https://chromium-review.googlesource.com/c/1369330
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58167}
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/BUILD.gn
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/src/bootstrapper.cc
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/src/builtins/array-join.tq
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/src/builtins/base.tq
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/src/code-stub-assembler.cc
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/src/code-stub-assembler.h
[delete] https://crrev.com/9b4f14de51de67116facc36d3636cbcc53cc43e7/src/js/array.js
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/src/js/prologue.js
[delete] https://crrev.com/9b4f14de51de67116facc36d3636cbcc53cc43e7/src/js/typedarray.js
[modify] https://crrev.com/d1c15973d32287e3cb54afbab57a1cc334ab81f2/test/cctest/test-debug.cc

Comment 31 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31

commit 640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Wed Dec 12 16:13:41 2018

[builtins] Remove InternalArray and reduce InternalPackedArray constructors.

InternalPackedArray now only has one constructor variant that expects no
arguments (Chrome's only usage of InternalPackedArray). As such, these TFC
builtins are no longer used and were removed:
- InternalArrayNoArgumentConstructor_Holey
- InternalArraySingleArgumentConstructor_Packed
- InternalArraySingleArgumentConstructor_Holey

On x64.release, this reduces builtins size by ~1.2KB.

Bug: v8:7624
Change-Id: I7316608dc02b1e09e9e414ee1aeb1fb08410c6f6
Reviewed-on: https://chromium-review.googlesource.com/c/1372772
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58193}
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/bailout-reason.h
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/bootstrapper.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/builtins-definitions.h
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/code-factory.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/code-factory.h
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/contexts.h
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/src/js/prologue.js
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/640d3adf5f87b73ef1b8dd6ba2f3fbd4c065ab31/test/cctest/test-extra.js

Comment 32 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0091fbe8d72f448452564759ddd49ff4c69fc44f

commit 0091fbe8d72f448452564759ddd49ff4c69fc44f
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Fri Dec 14 13:28:59 2018

[builtins] Move InternalPackedArray initialization into bootstrapper.

Incremental step towards the removal of JS Natives.  This CL Moves
the initialization of InternalPackedArray functions and prototype out
of prologue.js and into bootstrapper.

Bug: v8:7624
Change-Id: I7a2a1afbd1721ddc9bc9ac677c03f0817e4f1418
Reviewed-on: https://chromium-review.googlesource.com/c/1374995
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Commit-Position: refs/heads/master@{#58240}
[modify] https://crrev.com/0091fbe8d72f448452564759ddd49ff4c69fc44f/src/bootstrapper.cc
[modify] https://crrev.com/0091fbe8d72f448452564759ddd49ff4c69fc44f/src/js/prologue.js

Comment 33 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/93e5db5f610c831f86b2d9df60071aca2b82fe39

commit 93e5db5f610c831f86b2d9df60071aca2b82fe39
Author: Jakob Gruber <jgruber@chromium.org>
Date: Thu Dec 20 11:54:27 2018

Remove the js minifier

V8 is almost completely JS-free. There's no need to ship the minifier
any more.

Bug: v8:7624, v8:5505 , v8:4240 , v8:4235 , v8:4188 , v8:1557 
Change-Id: Iee15bf68c66bac27a67fe70e10b1edd4dcef89d1
Reviewed-on: https://chromium-review.googlesource.com/c/1386146
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58392}
[modify] https://crrev.com/93e5db5f610c831f86b2d9df60071aca2b82fe39/BUILD.gn
[modify] https://crrev.com/93e5db5f610c831f86b2d9df60071aca2b82fe39/test/cctest/BUILD.gn
[modify] https://crrev.com/93e5db5f610c831f86b2d9df60071aca2b82fe39/tools/js2c.py
[delete] https://crrev.com/b29c0459c35dccb96e51cff909714340766836b7/tools/jsmin.py
[modify] https://crrev.com/93e5db5f610c831f86b2d9df60071aca2b82fe39/tools/v8_presubmit.py

Comment 34 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/66d26a359fbcda22fe77d73b273ac9c7245f2bba

commit 66d26a359fbcda22fe77d73b273ac9c7245f2bba
Author: Adam Klein <adamk@chromium.org>
Date: Thu Dec 20 20:24:33 2018

[js] Move remaining Array setup code from prologue.js to bootstrapper

Also remove ImportNow() and helper runtime functions and Context methods
that are now unused.

Bug: v8:7624
Change-Id: I109b112d2147240e72eb0ed6112a267057de59cb
Reviewed-on: https://chromium-review.googlesource.com/c/1385224
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58415}
[modify] https://crrev.com/66d26a359fbcda22fe77d73b273ac9c7245f2bba/src/bootstrapper.cc
[modify] https://crrev.com/66d26a359fbcda22fe77d73b273ac9c7245f2bba/src/contexts.cc
[modify] https://crrev.com/66d26a359fbcda22fe77d73b273ac9c7245f2bba/src/contexts.h
[modify] https://crrev.com/66d26a359fbcda22fe77d73b273ac9c7245f2bba/src/js/prologue.js
[modify] https://crrev.com/66d26a359fbcda22fe77d73b273ac9c7245f2bba/src/runtime/runtime-internal.cc
[modify] https://crrev.com/66d26a359fbcda22fe77d73b273ac9c7245f2bba/src/runtime/runtime.h

Comment 35 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/43fff3d7b1188cb9bc533a9431efc44af056d86a

commit 43fff3d7b1188cb9bc533a9431efc44af056d86a
Author: Adam Klein <adamk@chromium.org>
Date: Fri Dec 21 16:56:12 2018

[runtime] Remove %AddNamedProperty and %AddElement

%AddNamedProperty was only used by regression tests, and is easily
replaced by Object.defineProperty (or deleted, in the case of a
cctest that was designed to test it directly).

%AddElement was unused (probably due to the death of array.js).

Bug: v8:7624
Change-Id: Icc17fd7a7419aa649275414a351f176f104040e2
Reviewed-on: https://chromium-review.googlesource.com/c/1387990
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58448}
[modify] https://crrev.com/43fff3d7b1188cb9bc533a9431efc44af056d86a/src/runtime/runtime-object.cc
[modify] https://crrev.com/43fff3d7b1188cb9bc533a9431efc44af056d86a/src/runtime/runtime.h
[modify] https://crrev.com/43fff3d7b1188cb9bc533a9431efc44af056d86a/test/cctest/test-api.cc
[modify] https://crrev.com/43fff3d7b1188cb9bc533a9431efc44af056d86a/test/mjsunit/regress/regress-1199637.js
[modify] https://crrev.com/43fff3d7b1188cb9bc533a9431efc44af056d86a/test/mjsunit/regress/regress-334.js
[modify] https://crrev.com/43fff3d7b1188cb9bc533a9431efc44af056d86a/test/mjsunit/regress/regress-cntl-descriptors-enum.js

Comment 36 by bugdroid1@chromium.org, Jan 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/263dce9b578c0809594cc8b2b94ae9b0ba982796

commit 263dce9b578c0809594cc8b2b94ae9b0ba982796
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Mon Jan 07 11:57:46 2019

[js] Remove CORE JS Natives (prologue.js), port extra utils to C++/Torque

- Removes the last `CORE` JS native script: `prologue.js`.
- Removes build step and bootstrapping associated with building/loading `CORE` JS natives.
- Removes `natives_utils_object` from context.
- Deprecates `--expose-natives-as` flag.
- Ports extra utils functions to C++ (`uncurryThis`) or Torque
  (`createPrivateSymbol`, `markPromiseAsHandled`, and `promiseState`).
- Move extra utils constants initialization into bootstrapper
  (`kPROMISE_PENDING`, `kPROMISE_FULFILLED`, `kPROMISE_REJECTED`).
- Removes unused extra utils functions `log` and `logStackTrace`.

Drive-by: Added test coverage for Array#includes being an unscopeable.

Bug: v8:7624
Change-Id: I5d983f8d11b76cb4dd3c2c67592ce1dc88364cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1381672
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Commit-Position: refs/heads/master@{#58577}
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/BUILD.gn
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/bootstrapper.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/bootstrapper.h
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/builtins/builtins-definitions.h
[add] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/builtins/builtins-extras-utils.cc
[add] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/builtins/extras-utils.tq
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/contexts.h
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/flag-definitions.h
[delete] https://crrev.com/2a9a60a5b57c559cb7830abdd7be4c01e382ac56/src/js/prologue.js
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/runtime/runtime-internal.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/runtime/runtime.h
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/snapshot/natives-common.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/snapshot/natives-external.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/src/snapshot/natives.h
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/test/cctest/test-api.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/test/cctest/test-debug.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/test/cctest/test-extra.js
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/test/cctest/test-flags.cc
[modify] https://crrev.com/263dce9b578c0809594cc8b2b94ae9b0ba982796/test/mjsunit/es6/unscopables.js
[delete] https://crrev.com/2a9a60a5b57c559cb7830abdd7be4c01e382ac56/test/mjsunit/regress/regress-408036.js

Comment 37 by bugdroid1@chromium.org, Jan 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/400fe0690fb8e7f39ccab65439f25dd33b392850

commit 400fe0690fb8e7f39ccab65439f25dd33b392850
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Mon Jan 07 14:43:41 2019

[js] Remove Experimental Extras JS Natives

- Removes build step and bootstrapping associated with building/loading `EXPERIMENTAL_EXTRAS` JS natives.
- Removes `--experimental-extras` flag

Bug: v8:7624
Change-Id: I4c45fe70da42847545037d63e9f1da77f5957f8b
Reviewed-on: https://chromium-review.googlesource.com/c/1397906
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Commit-Position: refs/heads/master@{#58590}
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/BUILD.gn
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/src/bootstrapper.cc
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/src/flag-definitions.h
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/src/snapshot/natives-common.cc
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/src/snapshot/natives-external.cc
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/src/snapshot/natives.h
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/test/cctest/test-api.cc
[delete] https://crrev.com/426312c88e6f6630310ad8a2834a209e2fdca087/test/cctest/test-experimental-extra.js
[modify] https://crrev.com/400fe0690fb8e7f39ccab65439f25dd33b392850/tools/js2c.py

Comment 38 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7164251aecf2901d8083654d973213188c217a5a

commit 7164251aecf2901d8083654d973213188c217a5a
Author: peterwmwong <peter.wm.wong@gmail.com>
Date: Tue Jan 08 13:26:02 2019

[js] Remove macros.py and simplify js2c.py

- Remove macros.py
- Inlines macros into d8.js
- Remove dead code (macros and message templates)
  from js2c.py
- Remove empty src/js directory

Bug: v8:7624
Change-Id: I8dfb69f2f8cb3746b67de816ffc8eb305cbcdee6
Reviewed-on: https://chromium-review.googlesource.com/c/1400150
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58631}
[modify] https://crrev.com/7164251aecf2901d8083654d973213188c217a5a/BUILD.gn
[modify] https://crrev.com/7164251aecf2901d8083654d973213188c217a5a/src/d8.js
[delete] https://crrev.com/ac2fb66b65053d1cac5d1bb430261979f4017f60/src/js/OWNERS
[delete] https://crrev.com/ac2fb66b65053d1cac5d1bb430261979f4017f60/src/js/macros.py
[modify] https://crrev.com/7164251aecf2901d8083654d973213188c217a5a/tools/js2c.py

Comment 40 by jgruber@chromium.org, Feb 1

Blocking: 7411

Comment 41 by bugdroid, Feb 19 (4 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/29e7c165a4782d087b6e9ebcdb7cb956d03d282f

commit 29e7c165a4782d087b6e9ebcdb7cb956d03d282f
Author: Jakob Gruber <jgruber@chromium.org>
Date: Tue Feb 19 14:21:31 2019

[regexp] Remove internal match and replace methods

These are no longer needed now that JS builtins have been fully
removed.

The internal match usage in assert.js has been replaced by a custom
miniparser. The internal replace use in various string builtins was
replaced by manual global string replacement in a runtime function.

Bug:  v8:8842 ,v8:7624
Change-Id: Ieb49c694662a13e84fd9fd2fe5d0412b8e0574da
Reviewed-on: https://chromium-review.googlesource.com/c/1473030
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Peter Wong <peter.wm.wong@gmail.com>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59689}
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/bootstrapper.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/builtins/builtins-definitions.h
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/builtins/builtins-string-gen.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/contexts.h
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/debug/debug-evaluate.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/regexp/jsregexp.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/runtime/runtime-regexp.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/runtime/runtime-strings.cc
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/src/runtime/runtime.h
[modify] https://crrev.com/29e7c165a4782d087b6e9ebcdb7cb956d03d282f/test/intl/assert.js

Sign in to add a comment