New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: WorkingAsIntended
Owner: ----
Closed: Mar 2018
Cc:
Components:
HW: ----
NextAction: ----
OS: ----
Priority: 3
Type: FeatureRequest



Sign in to add a comment
link

Issue 7546: Feature Request: MaybeLocal<Module> and MaybeLocal<Script> on ScriptOrModule

Reported by g...@gopositron.com, Mar 11 2018

Issue description

It would be very nice if ScriptOrModule had a MaybeLocal<Script> and MaybeLocal<Module> on it.

In Node.js I'm working on making dynamic import work for vm.Module but it is currently blocked by only having the referrer url without a reference to the actual v8::Module instance. We can't keep any sort of maps from url to module instance because vm module instances aren't required to have unique urls.
 

Comment 1 by adamk@chromium.org, Mar 12 2018

Cc: neis@chromium.org gsat...@chromium.org
Components: API
Labels: -Type-Bug Priority-3 Type-FeatureRequest
Status: Available (was: Untriaged)

Comment 2 by g...@gopositron.com, Mar 13 2018

another option could be having the ScriptOrModule host defined options be a not primitive array but i imagine there's already a good reason for it being a primitive array

Comment 3 by gsat...@chromium.org, Mar 13 2018

Cc: bradley....@gmail.com
See here for previous discussion with bradley about Node's API requirements: https://bugs.chromium.org/p/v8/issues/detail?id=6658

Comment 4 by gsat...@chromium.org, Mar 13 2018

Labels: Hotlist-NodeJS

Comment 5 by g...@gopositron.com, Mar 13 2018

it appears I can work with this by passing around modules identity hashes
in the host defined options.

thanks,
-gus

Comment 6 by gsat...@chromium.org, Mar 13 2018

Status: WorkingAsIntended (was: Available)

Sign in to add a comment