New issue
Advanced search Search tips

Issue 6889 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: FeatureRequest



Sign in to add a comment

ESNext: Implement optional catch binding

Project Member Reported by gsat...@chromium.org, Oct 5 2017

Issue description

Kevin, are you planning on re landing your CL soon? If not, I'm happy to take over.

I'd like to get this in for Chrome 64.
Cc: mathias@chromium.org

Comment 4 by bak...@gmail.com, Oct 17 2017

@gsathya Feel free. I spent a day trying and failing to get a reproduction of the failing test and wasn't able to (though @adamk was), and haven't yet been able to dedicate the time to trying again.

Alternatively, @machenbach suggested just disabling the test. I was hoping to be able to reproduce it myself so I could confirm it really wasn't related before going that route, but it might not be worth the trouble.
Cc: -gsat...@chromium.org
Owner: gsat...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/779c0808957b22f5063ef899527dbcac45e77ba3

commit 779c0808957b22f5063ef899527dbcac45e77ba3
Author: Sathya Gunasekaran <gsathya@chromium.org>
Date: Mon Jan 08 18:09:34 2018

[ESNext] Implement optional catch binding

This is just a rebased version of
https://chromium-review.googlesource.com/c/v8/v8/+/571453 with
no functional changes

Bug:  v8:6889 
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: Ia082cc09ca527505b288ac88e68e0b74eae94765
Reviewed-on: https://chromium-review.googlesource.com/849423
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50417}
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/ast/prettyprinter.cc
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/bootstrapper.cc
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/flag-definitions.h
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/interpreter/bytecode-generator.cc
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/parsing/expression-scope-reparenter.cc
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/parsing/parser-base.h
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/parsing/parser.cc
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/src/parsing/parser.h
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/interpreter/bytecode_expectations/AsyncGenerators.golden
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/interpreter/bytecode_expectations/ForOf.golden
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/interpreter/bytecode_expectations/ForOfLoop.golden
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/interpreter/bytecode_expectations/Generators.golden
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/test-parsing.cc
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/cctest/test-serialize.cc
[add] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/mjsunit/harmony/optional-catch-binding-breaks.js
[add] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/mjsunit/harmony/optional-catch-binding.js
[modify] https://crrev.com/779c0808957b22f5063ef899527dbcac45e77ba3/test/test262/testcfg.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7f019bb282700e1dc871a5cf1a0f9f40656652f4

commit 7f019bb282700e1dc871a5cf1a0f9f40656652f4
Author: Sathya Gunasekaran <gsathya@chromium.org>
Date: Tue Jan 09 19:40:20 2018

[ESNext] Stage optional catch binding

Bug:  v8:6889 
Change-Id: Ia14a51f4d71059669e62a831c4f3c4d3e60003f1
Reviewed-on: https://chromium-review.googlesource.com/857881
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50464}
[modify] https://crrev.com/7f019bb282700e1dc871a5cf1a0f9f40656652f4/src/flag-definitions.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/66caee74e0b4fad76923877aeca5a0b7aead81e0

commit 66caee74e0b4fad76923877aeca5a0b7aead81e0
Author: Sathya Gunasekaran <gsathya@chromium.org>
Date: Fri Jan 19 00:35:16 2018

[ESNext] Ship optional catch binding

Bug:  v8:6889 
Change-Id: Id79989b5ea65fa4a622205769e961a6e200641b7
Reviewed-on: https://chromium-review.googlesource.com/874996
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50700}
[modify] https://crrev.com/66caee74e0b4fad76923877aeca5a0b7aead81e0/src/flag-definitions.h
[modify] https://crrev.com/66caee74e0b4fad76923877aeca5a0b7aead81e0/test/webkit/fast/js/parser-syntax-check-expected.txt
[modify] https://crrev.com/66caee74e0b4fad76923877aeca5a0b7aead81e0/test/webkit/fast/js/parser-syntax-check.js

Status: Fixed (was: Assigned)
This is shipping in Chrome 66. 
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 5

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0a237ffe5bbda09c5825b133e7222ef596247148

commit 0a237ffe5bbda09c5825b133e7222ef596247148
Author: Mathias Bynens <mathias@chromium.org>
Date: Tue Jun 05 16:24:20 2018

Remove always-true --harmony-optional-catch-binding runtime flag

It was shipped in Chrome 66.

Bug:  v8:6889 
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I6333ee20ab913b281674b911d525d2851f4694c9
Reviewed-on: https://chromium-review.googlesource.com/1086928
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53527}
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/src/bootstrapper.cc
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/src/flag-definitions.h
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/src/parsing/parser-base.h
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/src/parsing/parser.cc
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/src/parsing/parser.h
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/test/cctest/test-parsing.cc
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/test/mjsunit/harmony/optional-catch-binding-breaks.js
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/test/mjsunit/harmony/optional-catch-binding.js
[modify] https://crrev.com/0a237ffe5bbda09c5825b133e7222ef596247148/test/test262/testcfg.py

Sign in to add a comment