New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
HW: All
NextAction: ----
OS: All
Priority: ----
Type: FeatureRequest



Sign in to add a comment
link

Issue 6172: Tracking Bug: RegExp dotAll flag

Reported by jgruber@chromium.org, Mar 29 2017 Project Member

Issue description

Tracking bug for the dotAll flag in regular expressions.

Spec proposal: https://github.com/mathiasbynens/es-regexp-dotall-flag
Spec proposal text: https://mathiasbynens.github.io/es-regexp-dotall-flag/

Spec draft: https://tc39.github.io/proposal-regexp-dotall-flag/
 

Comment 1 by adamk@chromium.org, Mar 29 2017

Cc: adamk@chromium.org
Components: Language

Comment 2 by bugdroid1@chromium.org, Mar 31 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cec39ad1ade5b38a7b203e9cc64cca867196f33a

commit cec39ad1ade5b38a7b203e9cc64cca867196f33a
Author: jgruber <jgruber@chromium.org>
Date: Fri Mar 31 09:20:13 2017

[regexp] Add support for dotAll flag

The dotAll flag changes behavior of the dot '.' character to match every
possible single character instead of excluding certain line terminators.

The implementation is staged behind --harmony-regexp-dotall.

Spec proposal: https://github.com/mathiasbynens/es-regexp-dotall-flag

BUG= v8:6172 

Review-Url: https://codereview.chromium.org/2780173002
Cr-Commit-Position: refs/heads/master@{#44295}

[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/include/v8.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/assembler.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/assembler.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/bootstrapper.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/builtins/builtins-definitions.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/builtins/builtins-regexp-gen.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/external-reference-table.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/flag-definitions.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/heap-symbols.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/objects.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/objects.h
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/parsing/scanner.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/regexp/regexp-parser.cc
[modify] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/src/regexp/regexp-parser.h
[add] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/test/mjsunit/harmony/regexp-dotall-disabled.js
[add] https://crrev.com/cec39ad1ade5b38a7b203e9cc64cca867196f33a/test/mjsunit/harmony/regexp-dotall.js

Comment 3 by jgruber@chromium.org, Apr 3 2017

Status: Fixed (was: Assigned)
Summary: Tracking Bug: RegExp dotAll flag (was: RegExp dotAll flag)

Comment 4 by bugdroid1@chromium.org, Apr 3 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/32d4d8e93dda9f8aa069dd5f3f88ba09462ba89d

commit 32d4d8e93dda9f8aa069dd5f3f88ba09462ba89d
Author: jgruber <jgruber@chromium.org>
Date: Mon Apr 03 14:36:46 2017

[regexp] Fix check for FLAG_harmony_regexp_dotall

Bool flags can be as small as one byte, so testing an IntPtr-sized value
is incorrect.

BUG= v8:6172 

Review-Url: https://codereview.chromium.org/2792963002
Cr-Commit-Position: refs/heads/master@{#44343}

[modify] https://crrev.com/32d4d8e93dda9f8aa069dd5f3f88ba09462ba89d/src/builtins/builtins-regexp-gen.cc

Comment 6 by bugdroid1@chromium.org, Jul 28 2017

Project Member

Comment 7 by yangguo@chromium.org, Aug 28 2017

Description: Show this description

Comment 8 by bugdroid1@chromium.org, Nov 17 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d42534d441a75405d8dcf50a1383485b3c135faf

commit d42534d441a75405d8dcf50a1383485b3c135faf
Author: Adam Klein <adamk@chromium.org>
Date: Fri Nov 17 16:47:19 2017

Remove always-on flags for RegExp dotAll and lookbehind

Both of these features were shipped in Chrome 62.

Bug:  v8:4545 ,  v8:6172 
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Ie00dcbeded7517a15696d4a78fcfbbf162919923
Reviewed-on: https://chromium-review.googlesource.com/775601
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49453}
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/assembler.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/assembler.h
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/bootstrapper.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/builtins/builtins-regexp-gen.h
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/external-reference-table.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/flag-definitions.h
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/objects.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/objects/js-regexp.h
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/parsing/scanner.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/regexp/regexp-parser.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/src/value-serializer.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/cctest/test-regexp.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/fuzzer/regexp.cc
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/es6/unicode-character-ranges.js
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/es6/unicode-regexp-backrefs.js
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/es6/unicode-regexp-last-index.js
[rename] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/es9/regexp-lookbehind.js
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/harmony/regexp-named-captures.js
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/regexp-modifiers-dotall.js
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/mjsunit/regress/regress-crbug-570241.js
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/test262/testcfg.py
[modify] https://crrev.com/d42534d441a75405d8dcf50a1383485b3c135faf/test/unittests/value-serializer-unittest.cc

Sign in to add a comment