New issue
Advanced search Search tips

Issue 5547 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: Bug

Blocking:
issue 1569



Sign in to add a comment

Stores of module exports need to check for the hole

Project Member Reported by adamk@chromium.org, Oct 19 2016

Issue description

This currently prints "hello world", but should throw:

x = "hello world";
print(x);
export let x = 42;
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cadfe092a25fd052294a45a2c5aabe34b475f534

commit cadfe092a25fd052294a45a2c5aabe34b475f534
Author: neis <neis@chromium.org>
Date: Fri Oct 21 14:23:58 2016

[modules] Fix bugs in assignments to exported variables.

- Add hole check if needed.
- Preserve the accumulator so that the result is the rhs.

R=adamk@chromium.org
BUG= v8:1569 , v8:5547 

Review-Url: https://chromiumcodereview.appspot.com/2438653003
Cr-Commit-Position: refs/heads/master@{#40510}

[modify] https://crrev.com/cadfe092a25fd052294a45a2c5aabe34b475f534/src/interpreter/bytecode-generator.cc
[modify] https://crrev.com/cadfe092a25fd052294a45a2c5aabe34b475f534/test/mjsunit/modules-init3.js
[modify] https://crrev.com/cadfe092a25fd052294a45a2c5aabe34b475f534/test/mjsunit/modules-skip-init3.js

Comment 2 by neis@chromium.org, Oct 21 2016

Status: Fixed (was: Assigned)
Labels: Priority-2

Sign in to add a comment