Project: v8 Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 1 user
Status: Fixed
Owner:
Closed: Jul 2016
Cc:
HW: ----
OS: ----
Priority: 2
Type: Bug



Sign in to add a comment
Replace ObjectProtoToString with TurboFan codestub
Project Member Reported by fran...@chromium.org, Jul 1 2016 Back to list
Speedup ObjectProtoToString with TurboFan codestub. 
 
Comment 1 by adamk@chromium.org, Jul 1 2016
Cc: adamk@chromium.org
Curious what's driving this particular work. Is it to improve Speedometer score?
It's actually one of the top used builtins, and fairly straightforward to make faster.
Project Member Comment 3 by bugdroid1@chromium.org, Jul 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3a1296a20e9bd8a4494c453ece5e276314dfe256

commit 3a1296a20e9bd8a4494c453ece5e276314dfe256
Author: franzih <franzih@chromium.org>
Date: Mon Jul 18 10:02:31 2016

[builtins] Object.prototype.toString() as TurboFan stub.

For angular.js on Speedometer, this results in 8.96%
speed up, i.e., the tests take on average 762ms
with this patch, 837ms without.

BUG=  v8:5175 

Review-Url: https://codereview.chromium.org/2134803002
Cr-Commit-Position: refs/heads/master@{#37827}

[modify] https://crrev.com/3a1296a20e9bd8a4494c453ece5e276314dfe256/src/bootstrapper.cc
[modify] https://crrev.com/3a1296a20e9bd8a4494c453ece5e276314dfe256/src/builtins/builtins.cc
[modify] https://crrev.com/3a1296a20e9bd8a4494c453ece5e276314dfe256/src/builtins/builtins.h

Status: Fixed
Labels: Priority-2
Sign in to add a comment