New issue
Advanced search Search tips

Issue 5045 link

Starred by 8 users

Issue metadata

Status: Fixed
Closed: May 2017
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: Bug

issue 1569

Sign in to add a comment

HTML comments are enabled in module code (violating spec)

Reported by, May 25 2016

Issue description

Version: bb8b2b9b029c1faced71321516a571d7e8992e0c (Mon May 23 11:39:25 2016 -0700)
OS: Ubuntu Linux
Architecture: x64

ES2015 section B.1.3 ("HTML-like Comments") reads:

> The syntax and semantics of 11.4 is extended as follows except that this
> extension is not allowed when parsing source code using the goal symbol
> Module

Tests for this recently landed in Test262:

- the "Hotlist-test262" label may be appropriate here.

Comment 1 by, May 25 2016

Components: Language
Labels: Hotlist-test262
Status: Available (was: Untriaged)
Thanks for the report.
Labels: SpecViolation-ReadyToFix

Comment 3 by, Jun 28 2016

I am currently working on a patch for this [1], although (as noted in the conversation on that code review page), the solution is temporarily blocked by an architectural change [2] (also now "in progress").


Comment 5 by, Oct 10 2016

 Issue 5485  has been merged into this issue.

Comment 6 by, Oct 10 2016

Blocking: 1569
Labels: Priority-2
Status: Started (was: Available)
Project Member

Comment 9 by, May 4 2017

The following revision refers to this bug:

commit 0015bbb5e115f072b5edcc834d59f7958d1e2cc8
Author: Sathya Gunasekaran <>
Date: Thu May 04 18:42:12 2017

[modules] Disallow HTML comments in modules

Bug:  v8:5045 
Change-Id: I1d8b6be8a65595dc357c4f721b1a03425e025e6e
Commit-Queue: Sathya Gunasekaran <>
Reviewed-by: Daniel Ehrenberg <>
Reviewed-by: Daniel Vogelheim <>
Cr-Commit-Position: refs/heads/master@{#45107}

Status: Fixed (was: Started)

Sign in to add a comment