New issue
Advanced search Search tips

Issue 5045 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: Bug

Blocking:
issue 1569



Sign in to add a comment

HTML comments are enabled in module code (violating spec)

Reported by m...@mikepennisi.com, May 25 2016

Issue description

Version: bb8b2b9b029c1faced71321516a571d7e8992e0c (Mon May 23 11:39:25 2016 -0700)
OS: Ubuntu Linux
Architecture: x64

ES2015 section B.1.3 ("HTML-like Comments") reads:

> The syntax and semantics of 11.4 is extended as follows except that this
> extension is not allowed when parsing source code using the goal symbol
> Module

http://www.ecma-international.org/ecma-262/6.0/#sec-html-like-comments

Tests for this recently landed in Test262:

- https://github.com/tc39/test262/blob/56b988883e3e1819cdc98b21c125be4c80f2bc24/test/language/module-code/comment-multi-line-html-close.js
- https://github.com/tc39/test262/blob/56b988883e3e1819cdc98b21c125be4c80f2bc24/test/language/module-code/comment-single-line-html-close.js
- https://github.com/tc39/test262/blob/56b988883e3e1819cdc98b21c125be4c80f2bc24/test/language/module-code/comment-single-line-html-open.js

...so the "Hotlist-test262" label may be appropriate here.
 

Comment 1 by adamk@chromium.org, May 25 2016

Components: Language
Labels: Hotlist-test262
Status: Available (was: Untriaged)
Thanks for the report.
Labels: SpecViolation-ReadyToFix

Comment 3 by neis@chromium.org, Jun 28 2016

Cc: neis@chromium.org
I am currently working on a patch for this [1], although (as noted in the conversation on that code review page), the solution is temporarily blocked by an architectural change [2] (also now "in progress").

[1] https://codereview.chromium.org/2009963002/
[2] https://codereview.chromium.org/2065453002/

Comment 5 by adamk@chromium.org, Oct 10 2016

Cc: adamk@chromium.org
 Issue 5485  has been merged into this issue.

Comment 6 by adamk@chromium.org, Oct 10 2016

Blocking: 1569
Labels: Priority-2
Owner: gsat...@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0015bbb5e115f072b5edcc834d59f7958d1e2cc8

commit 0015bbb5e115f072b5edcc834d59f7958d1e2cc8
Author: Sathya Gunasekaran <gsathya@chromium.org>
Date: Thu May 04 18:42:12 2017

[modules] Disallow HTML comments in modules

Bug:  v8:5045 
Change-Id: I1d8b6be8a65595dc357c4f721b1a03425e025e6e
Reviewed-on: https://chromium-review.googlesource.com/463811
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45107}
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/src/messages.h
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/src/parsing/parser.cc
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/src/parsing/scanner.cc
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/src/parsing/scanner.h
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/test/cctest/parsing/test-scanner.cc
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/test/cctest/test-parsing.cc
[add] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/test/test262/local-tests/test/language/module-code/comment-single-line-html-close-comment-before-function.js
[add] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/test/test262/local-tests/test/language/module-code/comment-single-line-html-close-comment-newline-before-function.js
[modify] https://crrev.com/0015bbb5e115f072b5edcc834d59f7958d1e2cc8/test/test262/test262.status

Status: Fixed (was: Started)

Sign in to add a comment