Project: v8 Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 4743 Implement unicode regexp property class
Starred by 4 users Project Member Reported by yangguo@chromium.org, Feb 9 2016 Back to list
Status: Assigned
Owner:
Cc:
HW: ----
OS: ----
Priority: 2
Type: FeatureRequest



Sign in to add a comment
This is currently stage0, but that doesn't prohibit us from experimenting, right? Property classes have the syntax:
/\p{<property alias>}/u
or negated
/\P{<property alias>}/u
and only work in combination with the unicode flag.

It's not entirely clear what <property alias> can be. It should work for character categories:
http://www.fileformat.info/info/unicode/category/index.htm

 
Labels: -Type-Bug Type-FeatureRequest
Project Member Comment 2 by bugdroid1@chromium.org, Feb 10 2016
Project Member Comment 4 by bugdroid1@chromium.org, Mar 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89

commit 7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89
Author: yangguo <yangguo@chromium.org>
Date: Mon Mar 07 18:11:55 2016

Revert of [regexp] extend property classes by script category. (patchset #1 id:1 of https://codereview.chromium.org/1774513002/ )

Reason for revert:
wrong noi18n expectations

Original issue's description:
> [regexp] extend property classes by script category.
>
> R=littledan@chromium.org
> BUG=v8:4743
> LOG=N
>
> Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
> Cr-Commit-Position: refs/heads/master@{#34553}

TBR=littledan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4743

Review URL: https://codereview.chromium.org/1772563003

Cr-Commit-Position: refs/heads/master@{#34554}

[modify] https://crrev.com/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89/src/char-predicates-inl.h
[modify] https://crrev.com/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89/src/char-predicates.h
[modify] https://crrev.com/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89/src/regexp/regexp-parser.cc
[delete] https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655/test/mjsunit/harmony/regexp-property-script-category.js
[rename] https://crrev.com/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89/test/mjsunit/harmony/unicode-regexp-property-class.js

Project Member Comment 6 by bugdroid1@chromium.org, Mar 9 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/48f9c161840a5c47c72098f66f03cf763736f62b

commit 48f9c161840a5c47c72098f66f03cf763736f62b
Author: yangguo <yangguo@chromium.org>
Date: Wed Mar 09 19:05:02 2016

[regexp] allow loose matching for property names.

As described in unicode database file PropertyValueAliases.txt

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Review URL: https://codereview.chromium.org/1776953002

Cr-Commit-Position: refs/heads/master@{#34638}

[modify] https://crrev.com/48f9c161840a5c47c72098f66f03cf763736f62b/src/char-predicates-inl.h
[modify] https://crrev.com/48f9c161840a5c47c72098f66f03cf763736f62b/src/char-predicates.h
[modify] https://crrev.com/48f9c161840a5c47c72098f66f03cf763736f62b/src/regexp/regexp-parser.cc
[modify] https://crrev.com/48f9c161840a5c47c72098f66f03cf763736f62b/test/mjsunit/harmony/regexp-property-general-category.js

Comment 10 by math...@qiwi.be, May 20 2016
Cc: math...@qiwi.be
Comment 11 Deleted
Comment 12 by math...@qiwi.be, Jun 11 2016
There is now a formal proposal to add this functionality to the language: https://github.com/mathiasbynens/es-regexp-unicode-property-escapes
Comment 13 by phistuck@gmail.com, Jun 11 2016
Cool! Add it to the stage 0 list?
https://github.com/tc39/proposals/blob/master/stage-0-proposals.md
Project Member Comment 15 by bugdroid1@chromium.org, Jun 14 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37

commit 3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37
Author: yangguo <yangguo@chromium.org>
Date: Tue Jun 14 13:58:53 2016

Revert of [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. (patchset #3 id:40001 of https://codereview.chromium.org/2059113002/ )

Reason for revert:
compile failure

Original issue's description:
> [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}.
>
> R=littledan@chromium.org, mathias@qiwi.be
> BUG=v8:4743
>
> Committed: https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4
> Cr-Commit-Position: refs/heads/master@{#36969}

TBR=littledan@chromium.org,mathias@qiwi.be
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4743

Review-Url: https://codereview.chromium.org/2065083002
Cr-Commit-Position: refs/heads/master@{#36970}

[modify] https://crrev.com/3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37/src/regexp/regexp-parser.cc
[modify] https://crrev.com/3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37/src/regexp/regexp-parser.h
[modify] https://crrev.com/3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37/test/mjsunit/harmony/regexp-property-general-category.js
[delete] https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4/test/mjsunit/harmony/regexp-property-lu-ui.js
[delete] https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4/test/mjsunit/harmony/regexp-property-special.js

Project Member Comment 17 by bugdroid1@chromium.org, Nov 18
Comment 18 by hablich@chromium.org, Mar 23 (4 days ago)
Labels: Priority-2
Sign in to add a comment