Issue 4552 link

Starred by 2 users

Issue metadata

Status:	Assigned
Owner:	littledan@chromium.org
Cc:	adamk@chromium.org gsat...@chromium.org
Components:	Language
HW:	----
NextAction:	----
OS:	----
Priority:	2
Type:	Bug
Harmony

Back to list

TypedArray constructor should not use iterator for typed arrays

Reported by zloir...@gmail.com, Nov 17 2015

Issue description

```
var a = new Uint8Array([1, 2, 3, 4]);
a[Symbol.iterator] = _ => [4, 3, 2, 1][Symbol.iterator]();
new Uint8Array(a); // => [4, 3, 2, 1], should be [1, 2, 3, 4]
```
http://www.ecma-international.org/ecma-262/6.0/#sec-%typedarray%-object
http://www.ecma-international.org/ecma-262/6.0/#sec-%typedarray%-typedarray

Comment 1 by zloir...@gmail.com, Nov 17 2015

new Uint8Array(null) -> TypeError, should be []
new Uint8Array() -> [], should be TypeError
new Uint8Array(undefined) -> [], should be TypeError
new Uint8Array(1.5) -> [0], should be RangeError
...

Comment 2 by hablich@chromium.org, Nov 18 2015

Cc: rossberg@chromium.org adamk@chromium.org dehrenberg@chromium.org
Labels: Type-Bug Harmony Priority-Medium Area-Language
Status: Available

Comment 3 by rossberg@chromium.org, Nov 18 2015

Owner: littledan@chromium.org

Comment 4 by littledan@chromium.org, Feb 24 2016

Status: Assigned (was: Available)

This should definitely be addressed, but I'm worried about the web compat implications. These are being discussed upstream at https://github.com/tc39/ecma262/issues/265 but they have not been brought to discussion in TC39 committee time. I think we can make some improvements without risking compat, but it will be tricky to figure out what exactly to do and what not to do.

Comment 5 by littledan@chromium.org, Feb 24 2016

core.js rolled back part of this change due to compat issues: https://github.com/karma-runner/karma/issues/1768

Comment 6 by zloir...@gmail.com, Feb 24 2016

FF already has a correct length validation here + it can be fixed on NodeJS side only for Buffer, so I don't think it can be reverted from the spec.

Comment 7 by hablich@chromium.org, Mar 23 2017

Labels: Priority-2

Comment 8 by adamk@chromium.org, Dec 19 2017

Cc: -dehrenberg@chromium.org -rossberg@chromium.org

Did this get resolved on the spec side?

►